Commit Graph

11042 Commits

Author SHA1 Message Date
MDW
e64e57716c Fix fatal (PHP8.X) type issue with abs, and amend dol_eval return type
# Fix fatal (PHP8.X) type issue with abs, and amend dol_eval return type

I got the following message:
`Fatal error: Uncaught TypeError: abs(): Argument #1 ($num) must be of type int|float, string given in D:\mdeweerd\workspace\dolibarr\htdocs\projet\list.php on line 233`

I examined the phan report and there was no mention of this because dol_eval was
said to return mixed.

In order to detect such cases, I amended the dol_eval return type to ensure to find
most of the locations where a cast is needed.
2024-04-02 22:52:52 +02:00
Laurent Destailleur
c6cef436dc Fix warning 2024-04-02 20:59:20 +02:00
MDW
146b735269 New: dol_get_object_properties to get real and magic props
# New: dol_get_object_properties to get real and magic props

This method will get an array with real and magic properties
from an object (if $properties is provided).
2024-04-02 11:25:18 +02:00
Laurent Destailleur
e3037794aa Look and feel v20 2024-04-01 15:04:20 +02:00
Laurent Destailleur
8ed9866433 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-31 19:26:54 +02:00
Laurent Destailleur
2ed6ae0799 Fix #29031 Fix #29059 2024-03-31 19:15:41 +02:00
Laurent Destailleur
49af1da76c Fix #29031 Fix #29059 2024-03-31 19:14:02 +02:00
Laurent Destailleur
47297d07fd Merge pull request #29135 from mikko80/patch-1
NEW Invoice PDF If bank account is empty, not print "Bank" and "Account"
2024-03-31 14:02:20 +02:00
Laurent Destailleur
21bedea607 Merge pull request #29143 from mdeweerd/fix/phpstan4
Fix Multiple fixes inspired by phpstan level 5 and phan
2024-03-31 13:56:24 +02:00
MDW
a0ce1514c1 Improve phpdoc typing 2024-03-31 03:02:03 +02:00
MDW
3a84e10b09 Should compare to constant IMAGETYPE_PNG, not to string 2024-03-31 01:08:36 +01:00
MDW
aad8c3d3d2 Improve phpdoc for make_substitutions 2024-03-31 01:03:32 +01:00
MDW
13043be5c5 Improve phpdoc typing 2024-03-31 01:03:31 +01:00
Laurent Destailleur
5c72441cc2 Merge pull request #29133 from mdeweerd/fix/related/fournisseur.facture
Fix phan notices related to fournisseur.facture.class.php
2024-03-30 23:46:01 +01:00
Laurent Destailleur
56105667e7 Merge pull request #29128 from mdeweerd/fix/stan
Fix PHPdoc typing (to fix php stan notices)
2024-03-30 20:01:48 +01:00
Laurent Destailleur
bf5dff67ee Merge pull request #29139 from mdeweerd/fix/related/html.form
Fix phan notices related to Html Form
2024-03-30 19:53:25 +01:00
MDW
94796d90b8 Improve phpdoc typing ajax_autocompleter 2024-03-30 18:03:10 +01:00
Mikko Virtanen
fd53a90153 Update pdf.lib.php 2024-03-30 13:46:22 +02:00
Mikko Virtanen
0f661175be Update pdf.lib.php
If bank account is empty, not print "Bank" and "Account"
2024-03-30 13:29:40 +02:00
Laurent Destailleur
3d28163c2e Fix create dir if dir does not exist 2024-03-30 03:33:36 +01:00
MDW
9afe7dba59 Fix phan notices related to fournisseur.facture.class.php
# Fix phan notices related to fournisseur.facture.class.php

This fixes deprecations and phpdoc.
2024-03-29 23:48:40 +01:00
MDW
9e892f4367 Improve dol_clone typing by using phpdoc template 2024-03-29 18:26:46 +01:00
Laurent Destailleur
ba7db18389 Merge pull request #29096 from altairis-noe/element_properties
NEW: consider document lines in element properties
2024-03-29 14:37:26 +01:00
Laurent Destailleur
3e8c3edd6d Clean code from _GET 2024-03-28 17:10:22 +01:00
Laurent Destailleur
7ba40287ca Merge pull request #29009 from lamrani002/fixInDictMB
Fix condition in  createDictionary for modulebuilder
2024-03-28 15:12:07 +01:00
Laurent Destailleur
787b1a1c83 Merge branch 'develop' into fix/filebyfile 2024-03-28 14:23:54 +01:00
Laurent Destailleur
a7e33e6573 Merge pull request #29047 from mdeweerd/fix/PhanPluginUnknownObjectMethodCall1
Fixes for PhanPluginUnknownObjectMethodCall
2024-03-28 14:20:57 +01:00
Laurent Destailleur
54501bccc3 Merge pull request #29066 from mdeweerd/fix/dol_get_fiche_head
Fix arguments to dol_get_fiche_head and dol_get_fiche_end
2024-03-28 14:16:45 +01:00
Laurent Destailleur
1d125bf9fa Merge pull request #29065 from mdeweerd/fix/dol_print_error
Fix arguments to dol_print_error
2024-03-28 13:35:44 +01:00
Laurent Destailleur
6c15816e5c Merge pull request #29093 from mdeweerd/fix/facture/card
Fix phan noticies for compta/facture/card.php
2024-03-28 12:06:32 +01:00
Laurent Destailleur
a2ec7400eb Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-03-28 10:55:44 +01:00
Noé Cendrier
2ab704d630 whoops 2024-03-28 10:36:49 +01:00
Noé Cendrier
bcd99c1365 NEW: consider document lines in element properties 2024-03-28 09:19:46 +01:00
MDW
7d90a572e9 Fix phan notice with cast 2024-03-28 02:13:38 +01:00
MDW
d885b2d459 Fix arguments to dol_print_error 2024-03-27 10:23:42 +01:00
MDW
bf6cd79494 Improve typing for member_prepare_head() return value 2024-03-27 10:22:51 +01:00
MDW
f41d21407f Fix typing for $links arg in dol_fiche_head() 2024-03-27 10:18:45 +01:00
MDW
ceeaf8b534 Be less restrictive on links index (for phpstan) 2024-03-27 10:18:44 +01:00
MDW
a30bf48e16 Improve phpdoc typing 2024-03-27 10:18:40 +01:00
MDW
d765e847a7 Allow empty array for dol_print_date() return 2024-03-27 10:18:38 +01:00
MDW
e2b0295308 Adjust to real typings 2024-03-27 10:18:34 +01:00
MDW
37515f1154 Adjust to real typings 2024-03-27 10:18:33 +01:00
MDW
cfe66e2f60 Improve typing, init var, suppress notification 2024-03-27 10:18:21 +01:00
MDW
7c660d3392 PHPdoc improvement: dol_print_error_email, price 2024-03-27 10:18:20 +01:00
MDW
974ecf82fe Fix get_class on potential null 2024-03-27 10:18:18 +01:00
MDW
c76baf1e10 Fix typing, inits, ignore some phan's, fix caching reuse 2024-03-27 10:18:16 +01:00
MDW
2cbd57654a Improve PHPdoc for getEntity/setEntity 2024-03-27 10:17:26 +01:00
Regis Houssin
08aed338c1 FIX phan phan la tulip 2024-03-26 22:35:21 +01:00
Laurent Destailleur
caf6367a4e NEW Add the process and user ID into log 2024-03-26 14:14:11 +01:00
Laurent Destailleur
4efa503400 NEW Accept the __NOW__ and __USER_ID__key into filters 2024-03-25 23:53:28 +01:00