Commit Graph

252 Commits

Author SHA1 Message Date
Frédéric France
1ab4e57ab9 fix phan and phpstan 2024-12-17 20:32:52 +01:00
Frédéric France
6f2611cf74 fix phan 2024-12-17 18:36:52 +01:00
Frédéric France
0299cb8296 clean phan baseline 2024-12-16 20:48:30 +01:00
MDW
d48a2e907f Qual: Fix phan notices (mostly in box files)
# Qual: Fix phan notices (mostly in box files)

Fix several phan notices reported in box files and a few extra cases.
2024-12-04 23:41:04 +01:00
MDW
7304048afb Qual: Fix phan notices (#31996)
# Qual: Fix phan notices

Fix phan notices up to htdocs\core\ajax\selectsearchbox.php.
2024-11-19 03:07:18 +01:00
MDW
3685032671 Qual: Fix phan notices (#31990) 2024-11-19 00:09:38 +01:00
MDW
58fa1ac626 Qual: Fix phan notices (#31962) 2024-11-18 15:40:54 +01:00
MDW
78fde76f61 Qual: Fix some phan notices (#31948) 2024-11-16 17:59:26 +01:00
MDW
5d9565f32a Qual: Update phan baseline (#31808) 2024-11-14 01:28:40 +01:00
Laurent Destailleur
714dc0c4b3 Try to exclude phan 2024-11-14 00:06:45 +01:00
Laurent Destailleur
4415246d46 Exclude dir for phan 2024-11-14 00:03:31 +01:00
MDW
56dc321665 Qual: Fix phan notices (in order of appearance) (#31768)
* Qual: Fix phan notices (in order of appearance)

* Qual: Fix phan notices (in order of appearance)/2
2024-11-12 00:35:14 +01:00
MDW
9ec4618199 Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
MDW
67d932e7de Qual: Fix phpdoc for *ArrayMethod* args/return values (non api_) (#31719) 2024-11-08 14:43:12 +01:00
MDW
278d301f32 Qual: Fix phan/phpstan notices in class files (part 6) (#31634)
* Qual: Fix notices for paymentdonation...workstationusergroup.class

* Qual: Fix PhanPluginRedundantReturnComment, update baseline

* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
MDW
178d748cad Qual: Fix phan/phpstan notices in class files (part 5) (#31617)
* Qual: fix commonstickergen..don.class

* Fix notifications for pdf_paiement...cronjob.class

* Qual: Fix notifications for emailcollector..price_parser.class

* Ensure that NULL is used in the database when fk's are 0/empty

* Fix notifications for pdf_paiement...cronjob.class

* Cope with updated phpstan, and make fk_origin_stock int in multiple locations
2024-11-06 20:15:15 +01:00
MDW
e7539f2e19 Qual: Fix notices in .lib.php files (#31672)
* Qual: Fix notices in .lib.php files

* Update wrapper.php

* Update availabilities_card.php

* Update index.php

* Update document.controller.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 12:32:13 +01:00
MDW
f4ff437026 Qual: Fix phan/phpstan notices in class files (part 4) (#31598)
* Qual: Fix phan notices for DolibarrModules.class

* Qual: Fix notices for classes actioncomm..task.class.php

* fixup! Qual: Fix notices for classes actioncomm..task.class.php

* Qual: Fix new notices blocking PR
2024-10-30 21:33:30 +01:00
MDW
b91c99b18a Qual: Fix phan/phpstan notices in class files (part 3) (#31578)
* fix phpstan in conf class (#31630)

* fix phpstan

* fix phan

* Fix merge

* Qual: Avoid notification with typing hint

* Qual: Fix notices link.class

* Qual: Fix notices link..socialneetworkmanager.class and DoliDb->DoliDB

* Qual: Fix notices for link..utils.class

* Qual: Fix notices for db classes

* Update translate.class.php

* Update translate.class.php

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-29 22:44:47 +01:00
MDW
67e9eaff46 Qual: Fix phan/phpstan notices in class files (part 2) (#31523)
* Qual: Fix phan notices in class files (part 2)

* Qual: Fix phan notices doleditor...events.class

* Qual: Fix phan notices defaultvalues...formprojet.class

* Qual: Fix notices formsetup...formwebsite.class

* Qual: Fix phan notices in class files (part 2)

* Qual: Fix phan notices doleditor...events.class

* Qual: Fix phan notices defaultvalues...formprojet.class

* Qual: Fix notices formsetup...formwebsite.class
2024-10-26 18:24:40 +02:00
MDW
0ac595364b Qual: Fix phan/phpstan notices in class files (part 1) (#31501)
* Ignore phpstan configuration for spelling

* Qual: Fix phan notices in class files
2024-10-25 21:00:02 +02:00
MDW
acda13eddf Qual: Fix phan/stan notices for facture-rec.class (#31489)
* Qual: Fix phan/stan notices for facture-rec.class

* Update fournisseur.facture-rec.class.php

* Update fournisseur.facture.class.php

* Update fournisseur.facture-rec.class.php

* Update fournisseur.facture-rec.class.php

* Update fournisseur.facture-rec.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-25 17:11:39 +02:00
MDW
fcd680d300 Qual: Fix phan & phpstan notices (#31496)
# Qual: Fix phan & phpstan notices

Fix multiple phan & phpstan notices
2024-10-25 14:20:55 +02:00
MDW
28e78d6cb4 Qual: Fix phan/stan notices for conferenceorbooth, facture-re, productcustomerprice (#31541) 2024-10-25 14:18:17 +02:00
MDW
f3dc9a9e45 Qual: fix phan notices in interface_50_modAgenda_ActionsAuto.class (#31478)
# Qual: fix phan notices in interface_50_modAgenda_ActionsAuto.class

Fix several notices in interface_50_modAgenda_ActionsAuto.class with typing hints.
2024-10-24 01:32:10 +02:00
MDW
76d801dcb3 Qual: Fix phan by adding typing hints, fix arguments (#31466)
* Do not analyze custom

* Update baseline, ignore everything in custom

* Qual: Fix notices in files related to ticket class

* Qual: Add typing hints to tpl files + other 'fixes'

* Qual: fix typing issu gy typing intermediate variable
2024-10-20 01:57:12 +02:00
MDW
fb3972b702 Qual: Fix phan notices in some payment/strip related classes (#31453)
* fix concat

* fix overwrite

* Clean code

* Do not analyze custom

* Update baseline, ignore everything in custom

* Qual: Fix notices in files related to ticket class

* Qual: Fix companybankaccount.class

* Fix phan/phpstan notices

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Frédéric FRANCE <frederic.france@free.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-20 00:32:01 +02:00
MDW
11c43e8c63 Fix: ticket.class phan/phpstan notices (#31448)
* Qual: Fix ticket.class notices

* Do not analyze custom

* Fix: Correct reference to cache (+phpdoc)

* Update baseline, ignore everything in custom

* Qual: Fix notices in files related to ticket class
2024-10-19 01:21:41 +02:00
MDW
cee4535975 Qual: Fix phan notices in admin.lib and tax.lib + related (#31414)
* Qual: Fix admin.lib phpstan/phan notices

* Qual: Fix some argument types in Societe methods

* Fixup phpdoc

* Qual: Improve typing for static analysis

* Qual: Improve typing for static analysis

* Fix tax typing

* Qual: further phan/phpstan notice fixes in dol_generic_project_odt

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-17 03:08:38 +02:00
MDW
8a9f86e109 Qual: Suppress PhanTypeSuspiciousNonTraversableForeach (#31382)
# Qual: Ignore PhanTypeSuspiciousNonTraversableForeach

PhanTypeSuspiciousNonTraversableForeach reports on the use of
`foreach ($object as $key => value)` which is valid accross
tested php versions (at least since PHP7.0).

So suppressing this notice.
2024-10-17 01:54:19 +02:00
MDW
9677a370e9 Qual: Nullable mysoc hint (#31393)
* Qual: Nullable mysoc hint

# Qual: Nullable mysoc hint

$mysoc can be nullable resulting in issues (#31387) so
it is best to detect these cases with static analysis

* Prevent null assignment
2024-10-17 01:44:54 +02:00
MDW
cad13e85e3 Qual: Fix smtps.class (#31403)
# Qual: Fix smtps.class

Fix most phan notices in smtps.class
2024-10-15 15:49:41 +02:00
MDW
0524358377 Qual: Fix phan notices in dolgraph class (#31399)
# Qual: Fix phan notices in dolgraph class

This fixes most notices in the dolgraph class.
2024-10-15 15:46:19 +02:00
MDW
53cfbc35be Qual: Fix several phan & stan notices (#31308)
* Qual: Fix several phan & stan notices

# Qual: Fix several phan & stan notices

Several fixes in files while fixing UnknownClass notices

* Qual: Update prepare_head PHPDoc return types

# Qual: Update prepare_head PHPDoc return types

Provide detailed array return types for prepare_head functions.

* Fix new phan notice

* Better loadLangs typing and fix call to loadLangs

* Fix new issues (stats)

* Other fixes of new issues

* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
MDW
8609df383a Qual: fix phan notices (#31368)
* Qual: fix phan notices

# Qual: fix phan notices

Fix phan/phpstan notices, mostly in html,formmail

* Ignore phpstan exception
2024-10-14 00:36:42 +02:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
MDW
c9690393bc Fix undefined global varialbe user/card.php (#31353)
# Fix undefined global varialbe user/card.php

Fix a few issues, one of which noticed in V21 UI.

Also notified by phan:
```
htdocs\user\card.php:626 PhanUndeclaredGlobalVariable Global variable $mesgs is undeclared
htdocs\user\card.php:2967 PhanUndeclaredGlobalVariable Global variable $soc is undeclared

```
2024-10-11 16:05:37 +02:00
MDW
9c20e93860 Fix: Cope with undevined country key in search array. (#31354)
# Fix: Cope with undefined country key in search array

Fix:
```
htdocs\partnership\partnership_list.php:533 PhanUndeclaredProperty Reference to undeclared property \Partnership->login
htdocs\partnership\partnership_list.php:793 PhanTypeMismatchArgumentProbablyReal Argument 4 ($filter) is null of type null but \FormAdmin::select_language() takes array|string[] (no real type) defined at htdocs\core\class\html.formadmin.class.php:74 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
```
2024-10-11 16:04:46 +02:00
MDW
bde0f0d794 Qual: Fix ci (phpstan notice) (#31301)
# Qual: Fix ci (phpstan notice)

While fixing the ci notice, also fixed the array definitions
which fixes both phan notices and phpstan notices seen on cti.
Removed the exception for phan on this file
2024-10-07 15:44:06 +02:00
MDW
f4c91d5bb6 Qual: Fix phan/phpstan notices (#31297)
# Qual: Fix phan/phpstan notices

Fix several phan and phpstan notices.
2024-10-07 14:07:24 +02:00
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
34e3717dda Qual: Fix phan/phpstan notices (#31289)
* Qual: Fix phan/phpstan notices

# Qual: Fix phan/phpstan notices

Fix several phan/phpstan notices

* Fix spelling in Changelog
2024-10-06 13:03:43 +02:00
MDW
f70c945931 Qual: Fix phan/stan notices (#31271)
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall

Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
Frédéric FRANCE
8305c35b6b fix phpdoc (#31262)
* fix phpdoc

* fix phpdoc
2024-10-04 09:40:05 +02:00
MDW
1834c37c16 Qual: Fix phan notices (#31212)
* Qual: Fix phan notices

# Qual: Fix phan notices

Fix several phan notices related to classes with UnknownObject
classes.

* Qual: Fix phan notices

* Qual: Fix phan notices

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-03 19:40:34 +02:00
Frédéric FRANCE
7d36fe0715 fix typo phan and Co 💊 (#31214)
* fix typo

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* translation missing

* test win mariadb version

* test win mariadb version

* phpdoc

* phpdoc

* phpdoc
2024-10-03 15:43:04 +02:00
Frédéric FRANCE
44fdcdd8ed can set position of file with dol_move (#31201)
* can set position of file with dol_move

* Update api_documents.class.php

* Update api_documents.class.php

* fix

* fix

* fix

* fix

* fix
2024-09-30 16:49:38 +02:00
MDW
8236aed22f Qual: Fix phan notices (#31193)
# Qual: Fix phan notices

Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
MDW
0da4d51003 Qual: Fix multiple phan notifications (#31151)
* Qual: Fix notifications multiple files

# Qual: Fix notifications multiple files

Fixes to files with UnknownObject notices, fixing other
notices in these files as well

* Improve boxes typing

* Qual: Extend accepted types to reduce notices

* Fix type for GET/POST arguments of GETPOST* calls
2024-09-28 12:09:35 +02:00