Commit Graph

590 Commits

Author SHA1 Message Date
Laurent Destailleur
bb6cf2c6ed Fix warning 2024-03-08 23:00:55 +01:00
Laurent Destailleur
c44f102518 Try to remove phan error 2024-03-08 22:58:15 +01:00
MDW
3d0a85608b Qual: Fix and enable alias deprecation detection (#28716)
* Qual: Ignore some false positives for deprecated functions

# Qual: Ignore some false positives for deprecated functions

The Phan Deprecation Plugin for internal functions has mixed up some
mail functions and lists them as deprecated, this ignores that

* Qual: Enable detection and fixing of internal deprecations

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Replace 'join' with 'implode'

* Qual: Update codespell lines ignore list after format

# Qual: Update codespell lines ignore list after forma

Done using latest library, so also adds some exceptions that are needed
in the future;

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-08 21:34:18 +01:00
MDW
826d72d04b Qual: Reduce phan baseline (thanks to 'fixes') (#28715)
# Qual: Reduce phan baseline (thanks to 'fixes')

The number of phan exceptions has been reduced, the baseline is updated
accordingly.
2024-03-08 21:25:15 +01:00
MDW
6cce456b8c Qual: Add fixers for price(ARG2), and urlencode((string)...) (#28701)
# Qual: Add fixers for price(ARG2), and urlencode((string)...)

Register the fixers used to fix phan messages by adjusting arguments and casts.
2024-03-08 12:18:22 +01:00
Laurent Destailleur
ca297a751f Clean internal pahn warnings 2024-03-07 22:08:58 +01:00
Laurent Destailleur
04670b92b3 Fix var_dump 2024-03-04 20:13:08 +01:00
Laurent Destailleur
3bafcf5d00 Fix CLI tools must return a positive value on error for better cross
platform compatibility
2024-03-04 19:41:21 +01:00
Laurent Destailleur
8528b3f363 Clean conf 2024-03-04 18:33:32 +01:00
Laurent Destailleur
61dd78b95e Fix regression. Removed bad fixer. GETPOST(... int) is not GETPOSTINT 2024-03-04 17:49:43 +01:00
Laurent Destailleur
4f3a6d1959 Removed false positive 2024-03-01 01:58:06 +01:00
Laurent Destailleur
dd3415b1ac Fix phan error and remove false alert 2024-02-29 16:41:00 +01:00
Frédéric FRANCE
88fde71187 Update codespell-dict.txt (#28517) 2024-02-29 15:25:38 +01:00
MDW
7391ad42ed Qual: Enable detection of deprecated modulename & GETPOST(...,'int') (#28457)
* Qual: Enable detection of deprecated modulename & GETPOST(...,'int')

# Qual: Enable detection of deprecated modulename & GETPOST(...,'int')

Enable phan rules to verify deprecated modulename usage and GETPOST(...,'int')
usage in the code.

* Qual: Try type hint on  to help avoid notification

* Qual: Accept 3 parameters for GETPOST to GETPOSTINT conversion

* Qual: Convert GETPOST(...,'int',VALUE) to GETPOSTINT(...,VALUE)

# Qual: Convert GETPOST(...,'int',VALUE) to GETPOSTINT(...,VALUE)

Following the update to the fixer to also convert GETPOST... with 3 parameters.
The files are now converted.
2024-02-28 23:25:16 +01:00
MDW
a351bc05e5 New: Phan Plugin (with fixer) for GETPOST->GETPOSTINT (#28447)
* New: Phan Plugin (with fixer) for GETPOST->GETPOSTINT

# New: Phan Plugin (with fixer) for GETPOST->GETPOSTINT

This detects GETPOST calls with second parameter 'int' and can
convert to GETPOSTINT

* New: Fixer for deprecated module names
2024-02-27 14:08:07 +01:00
MDW
36f890f973 Fix: GETPOST(...,'int') to GETPOSTINT(...) (#28448)
* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: GETPOST(...,'int') to GETPOSTINT(...)

# Fix: GETPOST(...,'int') to GETPOSTINT(...)

Converted using Phan plugin

* Fix: Update spelling exceptions

* Qual: Ignore Phan Notice
2024-02-27 14:05:53 +01:00
MDW
1c3a035ae5 Qual: New Phan plugin for testing that argument matches regex (#28424)
* Qual: New Phan plugin for testing that argument matches regex

# Qual: New Phan plugin for testing that argument matches regex

This Plugin - currently applied to GETPOST - allows verifying that a selected
argument of a function matches a regular expression.

* Qual: Add isModEnabled verification to phan

# Qual: Add isModEnabled verification in phan

Using ParamMatchRegexPlugin, add isModEnabled parameter verification.

* Qual: Verify sanitizeVal check value

# Qual: Verify sanitizeVal check value

Use ParamMatchPlugin to check sanitizeVal check value

* Qual: Extend ParamMatchRegexPlugin with class_method

# Qual: Extend ParamMatchRegexPlugin with class_method

Allow matching class methods for argument verification.

* Update config.php

* Qual: New Phan plugin for testing that argument matches regex

# Qual: New Phan plugin for testing that argument matches regex

This Plugin - currently applied to GETPOST - allows verifying that a selected
argument of a function matches a regular expression.

* Qual: Add isModEnabled verification to phan

# Qual: Add isModEnabled verification in phan

Using ParamMatchRegexPlugin, add isModEnabled parameter verification.

* Qual: Verify sanitizeVal check value

# Qual: Verify sanitizeVal check value

Use ParamMatchPlugin to check sanitizeVal check value

* Qual: Extend ParamMatchRegexPlugin with class_method

# Qual: Extend ParamMatchRegexPlugin with class_method

Allow matching class methods for argument verification.

* Report scalar values (see null, etc)

* Qual: Ignore false Phan Notification

* Qual: Ignore false Phan Notification

* Qual: Fix Phan needs specific message keys for coloring.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-26 23:10:16 +01:00
MDW
0d60041d8f Qual: Add custom phan plugin to detect var_dump (#28420)
# Qual: Add custom phan plugin to detect var_dump

This adds a custom plugin to detect the presence of var_dump.

Also disable a standard plugin in the extended configuration
(avoid reporting suggestions to add typing to the function
definitions (/declarations).
2024-02-25 22:11:25 +01:00
Laurent Destailleur
08a61c542a Restore dolPrintLabel 2024-02-25 20:53:42 +01:00
Laurent Destailleur
87d25869ac Fix lost lines 2024-02-25 18:55:22 +01:00
Laurent Destailleur
2db3dc0eef Fix output for phpphan 2024-02-25 18:36:40 +01:00
MDW
20b740dcc8 Qual: Review pre-commit configure - re-enable no-commit-to-branch (#28385)
# Qual: Review pre-commit configure - re-enable no-commit-to-branch

This reviews some of the documentation inside the pre-commit-config.yaml file.
It also re-enables the no-commit-to-branch hook.

Also enable spelling on hidden files (changes to pyproject.toml +
exceptions file).
2024-02-24 15:38:20 +01:00
MDW
e77cd248f0 Fix: Spelling in "hidden" files (#28391)
* Fix: Spelling in 'hidden' file

* Fix: Spelling in 'hidden' file

* Fix: Spelling in 'hidden' file
2024-02-24 13:04:22 +01:00
MDW
8655d5a86b QUAL Use phan to help detect new issues (#27706)
* Qual: Add phan flow

- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.

* Add directives to ignore false phan notices

* Qual: Add typing hints for extrafields TPL files

# Qual: Add typing hints for extrafields TPL files

Add typing hints for phan on view files

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 18:14:29 +01:00
Laurent Destailleur
f01fa6e098 Fix datatable 2024-02-21 15:00:14 +01:00
Laurent Destailleur
a732e72be0 Fix apstats 2024-02-21 14:41:13 +01:00
MDW
b343181789 Update phpunit.bat sample script and setup_conf.sh (#28307)
# Update phpunit.bat sample script and setup_conf.sh

- setup_conf.sh - Added caching feature;
- phpunit.bat - Example updated based on experience with php web server
2024-02-20 23:02:59 +01:00
Laurent Destailleur
67a23fd57f Add more choices in lenght of list in apstats 2024-02-20 02:26:42 +01:00
MDW
afe17928f2 Qual: Improve test messages to help locate errors + php-cs-fixer on tests (#28272)
* Qual: Apply php-cs-fixer before changes

# Qual: Apply php-cs-fixer before changes

Apply php-cs-fixer before changes to make real changes stand out
in next commit.

* Qual: Improve test messages to help locate errors.

# Qual: Improve test messages to help locate errors.

Included a description of the test in the failing assertions to
help locate the error.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: Update spelling exception

# Qual: Update spelling exception

Formatting the code requires an update in the spelling exception list.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.

* Qual: php-cs-fixer on phpunit test file

# Qual: php-cs-fixer on phpunit test file

Apply php-cs-fixer on phpunit test files so that future manual changes
stand out.
2024-02-19 15:28:21 +01:00
Laurent Destailleur
f48ab54513 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-18 15:16:22 +01:00
Laurent Destailleur
9b4d53638f Fix html 2024-02-18 15:15:10 +01:00
MDW
9387616e7f Qual: Improve rendering of phpstan technical debt table in apstats. (#28236)
* Qual: Improve rendering of phpstan technical debt table in apstats.

# Qual: Improve rendering of phpstan technical debt table in apstats.

Apply the DataTable rendering to the phpstan technical debt (same as applied to phan).

* Fix spelling

* Qual: Harden apstats output.

# Qual: Harden apstats output.

Escaping output for phpstan, and more escaping for phan.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 15:13:43 +01:00
Laurent Destailleur
de210ce277 css 2024-02-17 23:47:47 +01:00
Laurent Destailleur
193a3717b4 css 2024-02-17 17:07:13 +01:00
Laurent Destailleur
0b85d9ac81 css 2024-02-17 17:02:14 +01:00
Laurent Destailleur
4bb8f573ea Fix apstats 2024-02-17 16:58:21 +01:00
Laurent Destailleur
750e3270ac Enhance apstats 2024-02-17 16:46:06 +01:00
MDW
e5423d5c59 Qual: Add exceptions for codespell (#28186)
* Dev: Add setup scripts for phpunit/database

# Dev: Add setup scripts for phpunit/database

Some scripts that helped to setup some unit testing.

* NEW Add Windows ci workflow

# NEW Add Windows ci workflow

This adds a workflow to execute ci on a windows platform

* Disable open_basedir for now, to test effect

* Qual: Exclude documents directory from codespell

# Qual: Exclude documents directory from codespell

Documents directory may be present during development (unit tests).
Do not check spelling there

* Qual: Add codespell exceptions

# Qual: Add codespell exceptions

Add new exceptions to codespell (var identified as misspelling).
2024-02-15 14:49:09 +01:00
MDW
1c452bc86e Qual: Fix apstats & add phan (#28127)
# Qual: Fix apstats & add phan

I fixed several issues that I ran into when running apstats.php
locally to test the phan integration.

So this commit only proposes the updates to apstats.php.

I added a test that disables phan when its configurations is not
found so it should be fine to integration in develop.
2024-02-12 02:01:51 +01:00
Laurent Destailleur
29eb98816e disable bad link 2024-02-11 18:09:20 +01:00
Laurent Destailleur
f26bbb022a Fix delay 2024-02-11 18:07:55 +01:00
Laurent Destailleur
12908df0d6 Work on scan security commits 2024-02-11 16:39:31 +01:00
Laurent Destailleur
aea35bbf47 Last security on last 6 month 2024-02-11 15:42:03 +01:00
Laurent Destailleur
8c0b42bf26 Fix link 2024-02-11 13:44:27 +01:00
Laurent Destailleur
9e1a28a8ce Add description 2024-02-11 13:43:05 +01:00
Laurent Destailleur
33c8d3ce68 Add latest security alerts in apstats 2024-02-11 13:35:49 +01:00
Laurent Destailleur
c27774463f Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-10 19:10:05 +01:00
Laurent Destailleur
3bf105aaa6 Add script with last security alerts 2024-02-10 19:09:47 +01:00
MDW
2e254892ea Qual: Clean up codespell exceptions (#28104)
The files with exceptions can be updated as there are many less cases to
exclude.

In the project files there are a few minor spelling corrections, and
`$scrit` was changed to `$search_crit` to avoid a spelling suggestion.
2024-02-10 17:27:36 +01:00
MDW
16f723f0ba Qual Language scripts fixed/updated (#28101)
* Qual: Fix/extend language scripts, integrate in pre-commit

Updated scripts to comply with shellscript.
Integrated one in pre-commit that seems useful.

* Qual: Find duplicate lang keys

* Add line numbers (to allow annotation)

* Fix fixaltlanguages.sh and add to pre-commit

* Make historical language checks 'manual' in 'pre-commit'
2024-02-10 17:26:34 +01:00