Frédéric France
a0e3f617e8
fix phpstan
2024-12-14 13:05:41 +01:00
Frédéric France
55ef8bfe5c
fix phpstan
2024-12-14 11:52:45 +01:00
Frédéric FRANCE
bd28d2c533
Merge branch 'develop' into fourn_facture_paiement
2024-12-07 08:33:02 +01:00
Frédéric FRANCE
2cae49bc54
fix phpstan
2024-12-05 18:00:38 +01:00
Frédéric FRANCE
af30464a75
Merge branch 'develop' into fourn_facture_paiement
2024-12-05 08:10:17 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Regis Houssin
87dd68a605
FIX try to fix phpstan error
2024-12-04 10:03:11 +01:00
Laurent Destailleur
c6cafe2f11
Debug v21
2024-12-04 08:59:25 +01:00
Frédéric FRANCE
f3222efa6a
fix phpstan
2024-12-04 08:54:18 +01:00
Laurent Destailleur
7a195e01b2
Debug v21 - manufacturing cost
2024-12-04 08:42:18 +01:00
Frédéric FRANCE
ead048e1fd
fix calculate costs bom ( #31755 )
...
* fix calculate costs bom
* fix calculate costs bom
* Update bom.class.php
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-15 15:05:51 +01:00
MDW
56dc321665
Qual: Fix phan notices (in order of appearance) ( #31768 )
...
* Qual: Fix phan notices (in order of appearance)
* Qual: Fix phan notices (in order of appearance)/2
2024-11-12 00:35:14 +01:00
Frédéric FRANCE
92ef950e6d
fix phpstan ( #31761 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* hide new error with phpstan 1.12.9
2024-11-10 23:47:14 +01:00
Laurent Destailleur
607f2708fc
Rename variables to avoid confusion between id and scale.
2024-11-10 18:09:18 +01:00
Frédéric FRANCE
15490b292f
fix phpstan and fix CI ( #31739 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-11-10 11:16:23 +01:00
Laurent Destailleur
4bdd848bbe
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-11-06 13:26:08 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Christian Humpel
578d2fe83f
Fix #31677 ( #31678 )
2024-11-04 12:34:44 +01:00
Frédéric FRANCE
10935d4fc4
add last_main_doc to bom_bom ( #31586 )
...
* add last_main_doc to bom_bom
* fix warning
* fix warning
* fix wording
2024-10-28 00:35:59 +01:00
Laurent Destailleur
f5e4ab0220
Rewrite code to prepare refactoring
2024-10-26 15:24:54 +02:00
MDW
0ac595364b
Qual: Fix phan/phpstan notices in class files (part 1) ( #31501 )
...
* Ignore phpstan configuration for spelling
* Qual: Fix phan notices in class files
2024-10-25 21:00:02 +02:00
MDW
0d2f1cf666
Qual: Fix phpstan notices (int expected) ( #31485 )
...
# Qual: Fix phpstan notices (int expected)
Fix several notices where int was expected (casting/phpdoc/GETPOSTINT).
Separate phpstan exceptions for methods containing 'pdf' from
other methods/functions.
2024-10-24 14:01:30 +02:00
Baptiste Boulongne
853f62dfac
FIX #31486 Add missing url params considering filtertype ( #31488 )
...
Add missing url params to the BOM's create product (or service) button taking into account the filtertype
2024-10-24 00:20:55 +02:00
Frédéric FRANCE
0b1d243a7a
add translations count ( #31398 )
2024-10-15 15:39:29 +02:00
Laurent Destailleur
10c58950bb
Look and feel v21
2024-10-15 10:16:48 +02:00
MDW
53cfbc35be
Qual: Fix several phan & stan notices ( #31308 )
...
* Qual: Fix several phan & stan notices
# Qual: Fix several phan & stan notices
Several fixes in files while fixing UnknownClass notices
* Qual: Update prepare_head PHPDoc return types
# Qual: Update prepare_head PHPDoc return types
Provide detailed array return types for prepare_head functions.
* Fix new phan notice
* Better loadLangs typing and fix call to loadLangs
* Fix new issues (stats)
* Other fixes of new issues
* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
Laurent Destailleur
d24069d5e2
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-10-03 20:35:33 +02:00
John BOTELLA
a333af2ceb
fix missing token for links ( #31225 )
2024-10-03 16:19:04 +02:00
Laurent Destailleur
1754ee61d5
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-29 22:49:02 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
atm-adrien
dfd18ef9f7
FIX : Wrong price for BOM with warkstation ( #31142 )
...
* FIX : Wrong price for BOM with warkstation
* FIX : PR returns
2024-09-28 12:22:30 +02:00
Laurent Destailleur
a7f3946d2b
FIX #31152
2024-09-27 21:36:17 +02:00
Laurent Destailleur
b32225283d
Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop
2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3
FIX Duplicate trigger printFieldPreListTitle
2024-09-25 13:43:11 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
William Mead
8c14d2d20f
Fixed usage of null with select products method ( #31066 )
2024-09-20 17:49:40 +02:00
MDW
099dbd9c1e
Qual: Fix notices for htdocs/admin/* ( #30982 )
...
* Fix (Possibly)UndeclaredGlobalVariable
* Update phan baseline
* Fix (Possibly)UndeclaredGlobalVariable (2)
* Qual: Fix notices for htdocs/admin/*
# Qual: Fix notices for htdocs/admin/*
Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Frédéric FRANCE
5fd996821b
fix phpstan ( #30962 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* Update html.formadmin.class.php
2024-09-17 02:54:44 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
William Mead
1e6ce621b8
Moved BOMLine class to separate file. Removed unused requires. Added contributor details. ( #30809 )
2024-08-31 19:28:02 +02:00
Laurent Destailleur
2009c6f09a
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-31 17:30:32 +02:00
Laurent Destailleur
2c28d039e2
Fix test on permissions
2024-08-31 16:26:08 +02:00
Laurent Destailleur
dcfaae3bd5
Clean code: fight against global vars
2024-08-27 06:20:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
MDW
aa49419e8f
Qual: Fix/initial type cannot be inferred ( #30591 )
...
* Update baseline
* Add/update phpdoc typings
* Fix type for AssetDepreciationOptions as is
* Fix typing for Asset->depreciation_lines
* $card is used in derived classes, add it back to ActionsAdherentCardCommon
* Adjust code with typing/corrections for defined types
* Fix typos, code update to match typing, extra typing
* Add type cast for numeric operation
* Phpdoc/cast adjustments detected because of new phpdoc hints
2024-08-10 23:21:46 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
MDW
8b71242997
Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests ( #30544 )
...
* Remove PhanPluginDuplicateExpressionAssignmentOperation from baseline
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* fixup! Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 02:53:45 +02:00
Laurent Destailleur
b3b21d56b6
Fix doxygen
2024-08-07 02:49:38 +02:00