Commit Graph

4697 Commits

Author SHA1 Message Date
Laurent Destailleur
8e6ac1ee8f Update card.php 2024-01-19 16:08:03 +01:00
thibdrev
ffcc89d387 qual: phpstan
htdocs/commande/card.php	293	Property CommonObject::$fk_project (int) does not accept array|string.
htdocs/commande/card.php	296	Property CommonObject::$cond_reglement_id (int) does not accept array|string.
htdocs/commande/card.php	297	Property Commande::$deposit_percent (float) does not accept array|string.
htdocs/commande/card.php	298	Property Commande::$mode_reglement_id (int) does not accept array|string.
htdocs/commande/card.php	299	Property Commande::$fk_account (int) does not accept array|string.
htdocs/commande/card.php	300	Property Commande::$availability_id (int) does not accept array|string.
htdocs/commande/card.php	301	Property Commande::$demand_reason_id (int) does not accept array|string.
htdocs/commande/card.php	303	Property CommonObject::$shipping_method_id (int) does not accept array|string.
htdocs/commande/card.php	304	Property Commande::$warehouse_id (int) does not accept array|string.
htdocs/commande/card.php	305	Property CommonObject::$fk_delivery_address (int) does not accept array|string.
htdocs/commande/card.php	306	Property CommonObject::$contact_id (int) does not accept array|string.
htdocs/commande/card.php	307	Property CommonOrder::$fk_incoterms (int) does not accept array|string.
htdocs/commande/card.php	310	Property Commande::$multicurrency_tx (float) does not accept array|string.
2024-01-19 12:58:50 +01:00
Frédéric France
4b3f351f95 phpdoc 2024-01-18 23:28:42 +01:00
Frédéric France
b3bcdeafe5 rename method 2024-01-18 18:55:53 +01:00
Laurent Destailleur
0d33ec4122 Avoid spell warning 2024-01-14 13:47:49 +01:00
MDW
a04f2bf4e7 Qual: Spelling fixes that newly appeared. (#27495)
* Qual: Spelling fixes that newly appeared.

# Qual: Fix spelling erros that appeared since the bulk updates.

These issues mostly appeared since the bulk updates (a few ones were postponed
to make sure no real spelling errors were missed.)

* Update modulebuilder.lib.php

* Update pdf_standard.modules.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-14 12:26:37 +01:00
Laurent Destailleur
c15627016a Fix bad test for disabling TCPDI. Add more phpunit 2024-01-10 21:51:32 +01:00
Laurent Destailleur
f0d910ecd3 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-10 19:20:16 +01:00
MDW
963afede5e Fix: Match local variable name to parameter variable name (#27316)
# Fix: Match local variable name to parameter variable name

Improve consistency and avoids that phan reports suspicious parameter order
2024-01-10 17:38:23 +01:00
Laurent Destailleur
9d1f991759 Clean code 2024-01-09 14:24:21 +01:00
Laurent Destailleur
910a541c60 Clean code 2024-01-09 13:08:22 +01:00
Laurent Destailleur
e2f49c407f Clean sql request to use exist instead of left join 2024-01-09 10:44:50 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Laurent Destailleur
b84b5d80d0 Merge pull request #27109 from altairisfr/reopenbilled
dont reopen billed orders
2024-01-04 00:30:19 +01:00
Laurent Destailleur
622bdb366b Merge pull request #27144 from atm-john/issue_265856_part_001
NEW :  llxHeader body css for command see #26856
2024-01-04 00:24:01 +01:00
Laurent Destailleur
6484f49fd8 Fix missing hook 2024-01-03 16:16:44 +01:00
Christophe Battarel
f6741591c7 add constant ORDER_DONT_REOPEN_BILLED 2024-01-02 09:10:28 +01:00
Fabian Heinz
b78632a20e api fixes
According to [RFC2616](https://www.rfc-editor.org/rfc/rfc2616#section-10.2), APIs should return 2xx status codes if the request was correct.
The response should be status 200 with an empty result array.
2023-12-31 14:11:05 +01:00
routmoute
1d38a3b7b8 fix conflict with develop branch 2023-12-29 20:19:17 +01:00
routmoute
48f4e52a22 fix: Display of the list of merged pdf 2023-12-29 02:30:32 +01:00
Laurent Destailleur
961deffd35 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-12-28 19:59:43 +01:00
Laurent Destailleur
4ea3dd9dc2 Debug v19 2023-12-28 19:55:35 +01:00
Laurent Destailleur
70ce043b58 Merge pull request #27165 from defrance/patch-310
Php V8 warning
2023-12-28 19:28:43 +01:00
Laurent Destailleur
47a633cf2e Update card.php 2023-12-28 19:28:28 +01:00
Laurent Destailleur
163a09d6fd Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2023-12-28 12:37:34 +01:00
Laurent Destailleur
3ef872bb3d Merge pull request #27175 from cfoellmann/19/PR/hooks-contact
QUAL fix hooks on contact.php files - fixes contexts
2023-12-27 16:05:00 +01:00
Laurent Destailleur
b28ae5d8d3 Clean code 2023-12-27 12:12:20 +01:00
Laurent Destailleur
b3020923b7 Merge pull request #27186 from Hystepik/fix-php-warnings-code-smell
Fix some php code smell
2023-12-22 11:07:07 +01:00
Hystepik
d08f91e4cb Fix some phpstan warnings 2023-12-21 13:43:19 +01:00
Hystepik
5e4a4da130 Fix some php codce smell 2023-12-20 14:22:45 +01:00
Laurent Destailleur
fb5393149a Merge pull request #27096 from defrance/patch-308
php V8 warning
2023-12-19 16:27:30 +01:00
Laurent Destailleur
d6e4b71958 Merge pull request #27104 from cfoellmann/19/PR/stings-supplier
make UI strings differenciate between orders torward customer or supplier
2023-12-19 16:08:48 +01:00
Christian Foellmann
045c623536 QUAL fix hooks on contact.php files - fixes contexts 2023-12-19 14:39:29 +01:00
Charlène Benke
b881dca994 php V8 warning 2023-12-18 16:53:12 +01:00
MDW
e49f32ab2d dolGetGlobalInt -> getDolGlobalInt
Detected with phan -> https://github.com/Dolibarr/dolibarr/actions/runs/7242660297/job/19728384233?pr=26480#step:5:39
2023-12-18 03:13:37 +01:00
Laurent Destailleur
5e28ab0ec3 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2023-12-17 23:54:37 +01:00
Laurent Destailleur
4dc5483b12 Fix warning 2023-12-17 23:54:08 +01:00
Laurent Destailleur
689ba89b21 Merge pull request #27108 from altairisfr/ORDER_REOPEN_TO_DRAFT_2023
add constant ORDER_REOPEN_TO_DRAFT
2023-12-17 23:27:56 +01:00
ATM john
2caf7e6c0b Add llxHeader body css for command 2023-12-16 13:46:47 +01:00
Laurent Destailleur
d92c65ad91 FIX infinite loop in API call/trigger by adding a caller 2023-12-15 12:15:33 +01:00
Christophe Battarel
273fbbc65c dont reopen billed orders 2023-12-14 15:54:09 +01:00
Christophe Battarel
30d181c933 aadd constant ORDER_REOPEN_TO_DRAFT 2023-12-14 15:35:37 +01:00
Christian Foellmann
88c0700ee5 QUAL make UI strings differenciate between orders torward customer or supplier 2023-12-14 13:42:15 +01:00
Charlène Benke
bcf015533e Update list_det.php 2023-12-14 10:56:11 +01:00
Christophe Battarel
d97dcb2538 better fix 2023-12-14 09:49:18 +01:00
Laurent Destailleur
0fc4be5d2b Merge pull request #27067 from alexandre-janniaux/commande-error-forward/1
Qual: command: forward database error on failure
2023-12-14 01:39:59 +01:00
Laurent Destailleur
fb083a6cfc Fix warning with rector 2023-12-13 16:33:17 +01:00
Christophe Battarel
e50f144bc7 display html notes 2023-12-13 15:15:04 +01:00
Alexandre Janniaux
d9e81cbabe command: forward database error on failure
If the database triggered a failure, it wasn't reported in the tests
because $this->error was not set. Conversely, the error was always
printed through dol_print_error() whose documentation explicitely states
that it should not be used for class and $this->error should be used
instead.
2023-12-12 19:18:16 +01:00
Charlène Benke
4b3e8109eb Update list.php for prevent mass order warning 2023-12-09 12:36:02 +01:00