Laurent Destailleur (aka Eldy)
cceccabc9c
Fix missing $notrigger param
2024-12-09 16:00:47 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Laurent Destailleur (aka Eldy)
8f486591b2
Complete log
2024-12-01 22:06:38 +01:00
Laurent Destailleur
6e9bbe42bb
Add code to make easier to test PDF generation with n lines of product
2024-11-21 19:40:52 +01:00
Frédéric FRANCE
57d121664f
set object entity at create ( #32019 )
...
* set object entity at create
* set object entity at create
* set object entity at create
* set object entity at create
* set object entity at create
* set object entity at create
* do not break multicompany thing
* do not break multicompany thing
* missing translation
* fix phpstan
* doc
* fix entity
* fix set entity
2024-11-21 19:11:32 +01:00
MDW
e7539f2e19
Qual: Fix notices in .lib.php files ( #31672 )
...
* Qual: Fix notices in .lib.php files
* Update wrapper.php
* Update availabilities_card.php
* Update index.php
* Update document.controller.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 12:32:13 +01:00
Laurent Destailleur
e6f1d4835f
Clean sql code
2024-10-29 02:58:20 +01:00
Frédéric FRANCE
0f563edb5f
replace fetch_projet() and fetch_project() by fetchProject() ( #29821 )
...
* fix cti
* fix cti
* deprecate fetch_projet fetch_project to fetchProject
* deprecate fetch_projet fetch_project to fetchProject
* deprecate fetch_projet fetch_project to fetchProject
* odfHandler->setSegment only throw OdfExceptionSegmentNotFound
* odfHandler->setSegment only throw OdfExceptionSegmentNotFound
* fix deprecated
* fix
* fix sql
2024-10-26 22:43:44 +02:00
MDW
d7b2f95baf
Qual: Fix phan notices ( #31372 )
...
* fix llx_webhook_target-webhook.sql
* Fix commande/list & facture-rec.class
* Fix bonprelevement
* Qual: Fix prelevement/create notices
* Qual: fix quadridetail notices & update baseline
* Qual: Fix CommonDocGenerator notices
* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
2024-10-13 16:45:42 +02:00
Frédéric FRANCE
a82410706c
fix phpstan ( #31088 )
...
* fix phpstan
* fix phpstan
2024-09-23 15:01:02 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
13d4d96dfc
fix phpstan ( #31061 )
...
* fix phpstan
* fix phpstan
2024-09-20 17:25:39 +02:00
Laurent Destailleur
a0fe8e4884
Add constant for the moment
2024-09-18 15:55:20 +02:00
William Mead
e644f05f98
Qual clean use of CommonSignedObject trait ( #30927 )
...
* Cleaned & refactored code to make full use of CommonSignedObject trait
* Fixed Phan warning
* Revert "Fixed Phan warning"
This reverts commit b79b362733 .
* Try @static tag
* Cleaned code
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-13 17:45:05 +02:00
Frédéric FRANCE
2a6bbf88df
fix phpstan ( #30944 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-13 17:40:03 +02:00
MDW
76eaf8bd8d
Qual: Fix phan notices in classes related to class using getNextValue. ( #30925 )
...
* FIX 🛟 phan
* getToolTip() can take null for $coc
* Fix uninitialized vars & arg types
* PHPDoc typing, argument fixes
* PHPDoc typing, argument fixes for AdherentType
* PHPDoc typing, argument fixes for AdherentStats
* Update baseline to enable adherent notices
* Fix PHPDoc typing in api_members
* Minor bug fixes, typing
* PHPDoc api_subscriptions
* PHPDoc Societe
* Ignore empty foreach notice
* Add initialiser
* Categorie is string, old int mode is deprecated
* Fix missing initialisations
* Fix missing initialisations adherents/note
* Fix typing (cast), initialisation of var
* Fix initialisations
* Fix argument types
* Improve array PHPDoc type
* PHPDoc array type
* PHPDoc: Improve typing
* Correct argument type to getNomUrl
* Improve typing for timespent
* Fix typing for getNextValue args
* Improve typing
* Fix typing hints contrat/card
* Update baseline
* Fix typing
* Fix extraparams property typing
* Fix argument typing
* Qual: Correct covariant type
* Impove typing for timespent
* Remove exclusion no longer matched (level 6)
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
2024-09-12 21:16:42 +02:00
William Mead
d0c96c99e0
Qual common signed object trait ( #30913 )
...
* Moved signed status properties & methods to reusable class trait
* Cleaned code
* Updated EN localization
* Fixed Phan warnings
* Fixed Phan warnings
* Added type check. Updated PHPDoc.
* Refactored class properties
* Cleaned PHPDoc
* Revert "Refactored class properties"
This reverts commit 1beb40a7
* Reapply "Refactored class properties"
This reverts commit 9e3d9d554c .
* Fixed PHPDoc
* Fixed class file name
2024-09-10 16:22:25 +02:00
William Mead
fb6677010d
NEW contract signed status update ( #30779 )
...
* Moved signed status constants to array dictionary
* Added getLibSignedStatus & getSignedStatusLocalisedArray methods
* Updated fetch & create methods for signed_status
* Added signed status to status badge
* Updated signed_status module builder field
* Added object context signed status for action trigger
* Added signed status to contract list
* Fixed signed status for contract list
* Added sign, unsign, confirm_sign, confirm_unsign actions. Added sign button.
* Fixed old contract without signed status
* Added contract modify notification
* Added contract signed status update
* Updated EN localizations
* Fixed contract notification administration
* Fixed notification message
* Fixed contract status badge
* Fixed langs
* Fixed langs key
* Fixed duplicate localization
2024-09-10 03:04:49 +02:00
William Mead
a1a77e6564
FIX late contract services search option ( #30741 )
...
* Fixed search late contract services. Added search late contract services checkbox. Cleaned code.
* Cleaned code
* Fixed escaped string
2024-09-01 14:56:24 +02:00
William Mead
e5a8023a83
Qual isolate ContratLigne class to separate file ( #30804 )
...
* Moved ContratLigne class to separate file
* Added require_once
* Fixed require_once
* Updated PHPDoc
* Fixed Phan
* Fixed Phan
2024-08-31 19:36:29 +02:00
Laurent Destailleur
953b56f7fb
Comment
2024-08-25 16:22:49 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
ptibogxiv
f613752bd3
Update api_contracts.class.php with pagination ( #30681 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-20 10:18:15 +02:00
MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod ( #30661 )
...
* Qual: Fix PhanUndeclaredMethod cases
* Fix PhanUndeclaredMethod cases
* Qual: Remove PhanUndeclaredMethod exceptions
* Fix spelling "disacard"
* Improve phpdoc, add abstract method to trait for typing
* Improve phpdoc typing for PHanUndeclaredMethod
* Suppress phan notices for guarded AliasNbPages calls
* Fix return value for printFile stub
* Fix getting message from Exception
* Define dummy getAllByProducts(), typing for it.
* Fix typo in comment
* Qual: Better typing for apiService (phan)
* Test that the Generic OAuth Service is provided
* Qual: Fix getSqlArrayForStats typing
* Force modTcpdfbarcode
* Correct typing hint
* Set ModelePDFAsset typehint
* Fix ModelePDFUserGroup typing hint
* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php
* Fix write_file in ModelePDFStock*
* Update printsheet.php
* Adjust typing hint for barcode generator
* Update printsheet.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-19 02:05:27 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
Frédéric FRANCE
a9f93f35c7
add phpdoc ( #30631 )
...
* add phpdoc
* Update contrat.class.php
2024-08-13 20:31:03 +02:00
Frédéric FRANCE
17c887a433
fix typos ( #30630 )
...
* fix typos
* fix typos
2024-08-13 20:29:40 +02:00
Laurent Destailleur
b3b21d56b6
Fix doxygen
2024-08-07 02:49:38 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
kkhelifa-opendsi
572061ff80
NEW: Add ID of the line in the trigger context for addLine(), updateLine() and deleteLine() on contract ( #30343 )
2024-07-10 18:49:49 +02:00
Frédéric FRANCE
29f223fd3c
fix checkFunctionArgumentTypes ( #30249 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Laurent Destailleur
db61320098
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
...
Conflicts:
htdocs/contrat/class/contrat.class.php
htdocs/core/menus/standard/eldy.lib.php
htdocs/product/price.php
htdocs/product/stock/stocktransfer/class/stocktransfer.class.php
htdocs/user/list.php
2024-06-30 04:05:46 +02:00
Laurent Destailleur
b2e288f8ec
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
...
Conflicts:
htdocs/accountancy/bookkeeping/list.php
htdocs/core/menus/standard/eldy.lib.php
2024-06-30 03:53:16 +02:00
HENRY Florian
9c6a1eac94
fix: bad errors variable for error return ( #30145 )
...
* fix: bad errors variable for error return
* fix: bad errors variable for error return
* Update contrat.class.php
fix review
2024-06-24 23:47:34 +02:00
Laurent Destailleur
6d8debd95e
Clean files not used in v20
2024-06-18 14:14:41 +02:00
Frédéric FRANCE
facb1930a7
fix phpstan Property Product::$oldcopy in empty() is not falsy ( #30003 )
...
* fix phpstan Property Product::$oldcopy in empty() is not falsy
* add token
* doc
* fix phpstan Property Product::$oldcopy in empty() is not falsy
* fix phpstan Property Product::$oldcopy in empty() is not falsy
* fix phpstan
2024-06-13 08:11:11 +02:00
Mathieu Moulin
abcb1dad4b
Define CommonObject relation in CommonObjectLine classes ( #29956 )
2024-06-10 16:08:39 +02:00
Frédéric FRANCE
741e75ee47
add phpdoc ( #29832 )
...
* add phpdoc
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* add phpdoc
* fix phan
* fix phan
2024-06-04 14:46:54 +02:00
Frédéric FRANCE
652c8526fa
fix cti ( #29813 )
...
* fix cti
* fix cti
* no photo in asset lines
* no photo in asset lines
* no photo in asset lines
* no photo in asset lines
* no photo in recruitment lines
* no photo in recruitment lines
* fix
* fix dead catch
2024-06-03 13:44:14 +02:00
Laurent Destailleur
1756796caa
Debug v20
2024-05-21 17:00:11 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Laurent Destailleur
60c0fc2386
Fix warning PHP 8.2
2024-04-22 18:42:34 +02:00
Laurent Destailleur
b5de782c6b
Fix use the good HTTP code
2024-04-07 14:59:25 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d
PHPDoc
2024-04-05 13:44:59 +02:00
Laurent Destailleur
c64bba12ee
Merge pull request #29171 from JonBendtsen/contact_update_single_array_option_element
...
allow updating contract single Complementary Attribute
2024-04-02 14:49:35 +02:00
Laurent Destailleur
7715513ac9
Some API HTTP return code were moved from 401 to 403 to better follow
...
REST specification.
2024-04-02 14:47:49 +02:00