Laurent Destailleur
7290ffd1ab
Better support for postgesql
2024-03-21 15:57:45 +01:00
Laurent Destailleur
a6d5b32c2e
Merge branch 'develop' into qual/db/typing
2024-03-21 14:13:58 +01:00
Laurent Destailleur
2d0e57ce7c
Fix test for pgsql
2024-03-21 14:13:17 +01:00
Laurent Destailleur
8ab80490e6
Merge branch 'develop' into qual/db/typing
2024-03-21 13:57:13 +01:00
Laurent Destailleur
477fb7a035
Fix warning
2024-03-21 13:55:23 +01:00
Laurent Destailleur
0d6675114e
Merge branch 'develop' into qual/db/typing
2024-03-21 13:19:51 +01:00
Laurent Destailleur
380c1092eb
Fix warnings
2024-03-21 13:19:31 +01:00
Laurent Destailleur
f3e6b38d9d
Fix warning
2024-03-21 13:16:59 +01:00
Laurent Destailleur
e97f0a7668
Merge branch 'develop' into qual/db/typing
2024-03-21 13:06:35 +01:00
Laurent Destailleur
aee4ccc32c
Fix warnings
2024-03-21 13:06:20 +01:00
Laurent Destailleur
58e719eb56
Fix sanitization
2024-03-21 13:03:30 +01:00
Laurent Destailleur
9d5aa4a448
Fix sanitization
2024-03-21 13:02:41 +01:00
Laurent Destailleur
5fa2bfff2e
Merge branch 'develop' into qual/db/typing
2024-03-21 12:55:20 +01:00
Laurent Destailleur
61eefe5fa9
Merge branch 'develop' into fix/PhanTypeMismatchReturnNullable
2024-03-21 12:51:27 +01:00
Laurent Destailleur
04d8a20b63
Merge branch 'develop' into qual/db/typing
2024-03-21 12:46:25 +01:00
Laurent Destailleur
aa77573cd9
Sanitize DDL instructions
2024-03-21 12:45:58 +01:00
Laurent Destailleur
171c32be34
Add DDLDropTable and DDLCreateTable into phpunit tests
2024-03-21 12:21:38 +01:00
Laurent Destailleur
ce2959b022
Clean method DDLCreateTable (used by modulebuilder only) #28996
2024-03-21 12:10:09 +01:00
Laurent Destailleur
ae10eedf2a
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-03-21 11:29:16 +01:00
Laurent Destailleur
57eb393dad
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-03-21 11:22:28 +01:00
Laurent Destailleur
01a058b208
Fix regression
2024-03-21 11:22:12 +01:00
Laurent Destailleur
27c0192b7c
cast smallint
2024-03-21 11:17:15 +01:00
Andrés Maldonado
976686262d
FIX: SQL syntax error in DDLUpdateField
2024-03-21 02:36:40 +01:00
MDW
fc6af20479
Update typing for database functions
2024-03-21 00:00:00 +01:00
MDW
942239b5d6
Update PHPdoc to show nullable return
2024-03-20 23:54:32 +01:00
MDW
23516ed5fa
Fix arg type for str_replace() with cast
2024-03-19 20:38:54 +01:00
Laurent Destailleur
06ae1deb1b
Fix better error message when using bad character_set_client
2024-03-18 17:27:06 +01:00
Frédéric FRANCE
1783d68fd4
Update pgsql.class.php
2024-03-18 14:10:55 +01:00
MDW
66c592717d
Fix PhanTypeMismatchBitwiseBinaryOperands by typing argument
2024-03-17 20:12:35 +01:00
MDW
9eed23c6d0
Fix return type by cast or typing update
...
# Fix return type by cast or typing update
Fix most PhanTypeMismatchReturn notifications.
The remaining ones are likely real bugs or need more Dolibarr
knowledge to fix them efficiently
2024-03-16 13:52:12 +01:00
MDW
6e5c4ef851
Fix PHPDoc date_m typo
2024-03-11 21:43:50 +01:00
Laurent Destailleur
b963a9ab36
Fix phpunit
2024-03-11 16:30:33 +01:00
Laurent Destailleur
2cbeca6d4f
Merge pull request #28668 from atm-john/fix_element_type_part_04
...
NEW : Factoring and Fix external module elementType limit - Part 04
2024-03-11 16:29:34 +01:00
Laurent Destailleur
553587b660
Update DoliDB.class.php
2024-03-11 16:27:46 +01:00
Laurent Destailleur
5b921d0dc4
Update DoliDB.class.php
2024-03-11 16:26:17 +01:00
MDW
dbfb1180ee
Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions ( #28749 )
...
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions
Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
2024-03-11 12:58:51 +01:00
MDW
6d9e7b8144
Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal ( #28732 )
...
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal
* Qual: phan: suppress false positive on ssl_set
* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal
# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal
PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.
* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing
* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal
# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal
False positive detecting that is not an int, rewriting to check
impact
2024-03-10 01:55:56 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
Laurent Destailleur
cb58ad2e60
Merge branch 'develop' into fix_element_type_part_04
2024-03-08 22:06:53 +01:00
thibdrev
cc5366249a
qual: phpdoc for htdocs/core/db/mysqli.class.php ( #28703 )
...
PHPDoc update to reflect what the code does today.
This update however doesn't solve this PHPStan warning:
htdocs/core/db/mysqli.class.php 243 Return type (mysqli|null) of method DoliDBMysqli::connect() should be compatible with return type (resource) of method Database::connect()
2024-03-08 12:10:09 +01:00
ATM john
24059b0b8d
get rows security
2024-03-06 17:24:23 +01:00
MDW
eb1f6be1e2
Qual: Add information from backtrace when mysql request fails. ( #28583 )
...
# Qual: Add information from backtrace when mysql request fails.
This helps locate the line that was responsible for the SQL request
2024-03-02 19:57:59 +01:00
lamrani abdelwadoud
b41020a801
Fix method by changing return type ( #28507 )
...
* FIX return method getListOfCharacterSet by adding null type
* Fix return method getListOfCollation by adding return null
2024-02-28 20:05:33 +01:00
MDW
8655d5a86b
QUAL Use phan to help detect new issues ( #27706 )
...
* Qual: Add phan flow
- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.
* Add directives to ignore false phan notices
* Qual: Add typing hints for extrafields TPL files
# Qual: Add typing hints for extrafields TPL files
Add typing hints for phan on view files
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-02-21 18:14:29 +01:00
Lucas Marcouiller
f84ae10dbf
Fix some php warnings ( #28278 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-02-19 17:57:16 +01:00
Frédéric FRANCE
3a1e6d2a58
fix phpstan pgsql.class.php ( #28152 )
2024-02-13 09:03:30 +01:00
Laurent Destailleur
eb4f53665d
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
.github/workflows/pre-commit.yml
ChangeLog
dev/tools/codespell/codespell-lines-ignore.txt
htdocs/comm/mailing/card.php
htdocs/contact/card.php
htdocs/langs/en_US/admin.lang
htdocs/modulebuilder/template/core/modules/mailings/mailinglist_mymodule_myobject.modules.php
2024-02-07 18:30:10 +01:00
Laurent Destailleur
4aeda8d28d
Fix escapeforlike/escape
2024-02-03 15:29:40 +01:00
MDW
044d342956
Fix: LABEL is required on the db classes.
...
# Fix: LABEL is required on the db classes.
Define const in parent type so that it is required in the subclasses.
2024-01-29 18:56:17 +01:00
MDW
3a4cef8705
fixup! QUAL Force subclass MINVERSION ( #26314 )
2024-01-23 21:20:35 +01:00
