Commit Graph

382 Commits

Author SHA1 Message Date
HENRY Florian
b7746121c5 fix: CronJob Propertyy 'comment' do not exist replace by note_private (#31970) 2024-11-18 17:17:09 +01:00
Laurent Destailleur
2d08d89d55 Trans 2024-11-18 13:58:29 +01:00
evarisk-kilyan
a811e061ca fix: fatal on install step-5 (#31954)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-16 18:58:24 +01:00
Delthair
e2b6762b3c ISSUE #31816 (#31820)
Bug correction to finalise step 5 of installation
2024-11-14 23:31:25 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
MDW
f4ff437026 Qual: Fix phan/phpstan notices in class files (part 4) (#31598)
* Qual: Fix phan notices for DolibarrModules.class

* Qual: Fix notices for classes actioncomm..task.class.php

* fixup! Qual: Fix notices for classes actioncomm..task.class.php

* Qual: Fix new notices blocking PR
2024-10-30 21:33:30 +01:00
Laurent Destailleur
acac575512 Fix phan 2024-10-20 00:20:16 +02:00
Laurent Destailleur
37880a7964 Debug v21 2024-10-19 23:42:26 +02:00
Laurent Destailleur
992dc88491 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-19 15:33:12 +02:00
Laurent Destailleur
76ec55b81e Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-19 15:31:00 +02:00
Laurent Destailleur
c160da91ed Change URL for module blacklist feature 2024-10-19 15:29:43 +02:00
Laurent Destailleur
c70973c0c8 Merge v20 2024-10-19 14:44:55 +02:00
Laurent Destailleur
17c50368c1 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-19 14:32:08 +02:00
Laurent Destailleur
e97c1dc48e Better message 2024-10-19 13:51:05 +02:00
Laurent Destailleur
0844ed2f9b NEW Include a protection into check update to detect malware 2024-10-19 13:16:13 +02:00
MDW
f70c945931 Qual: Fix phan/stan notices (#31271)
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall

Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
MDW
0da4d51003 Qual: Fix multiple phan notifications (#31151)
* Qual: Fix notifications multiple files

# Qual: Fix notifications multiple files

Fixes to files with UnknownObject notices, fixing other
notices in these files as well

* Improve boxes typing

* Qual: Extend accepted types to reduce notices

* Fix type for GET/POST arguments of GETPOST* calls
2024-09-28 12:09:35 +02:00
Frédéric FRANCE
9df2457236 fix phpstan (#31144)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-26 22:17:49 +02:00
Laurent Destailleur
1aae82898c Fix error management 2024-09-26 12:46:08 +02:00
Laurent Destailleur
7c2e2bfbea Fix error management 2024-09-26 12:44:38 +02:00
Laurent Destailleur
16bb994698 Debug v21 2024-09-02 13:55:08 +02:00
MDW
f5c7ca1769 Qual: Fix PhanPluginUnknownObjectMethodCall in classes with high occurence (#30754)
* Qual: Fix PhanPluginUnknownObjectMethodCall in import.php

* Qual: PHPDoc for import/export array types

* Qual: Add PHPDoc types to import.class.php

* Fix PhanPluginUnknownObjectMethodCall in stats.class.php

* Add methods expected on ModeleImport child classes

* Force imapemail type for phan

* Qual: Update phan baseline

* Qual: Fix Undefined/Undeclared phan notices in module_help

* Update baseline
2024-08-27 04:51:41 +02:00
noec764
18bf0c940e FIX: Dolibarrize DolibarrModules::insert_cronjobs() method (#24747)
* FIX: Dolibarrize DolibarrModules::insert_cronjobs() method

* Fixing style errors.

* Update DolibarrModules.class.php

---------

Co-authored-by: stickler-ci <support@stickler-ci.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-22 13:23:42 +02:00
Laurent Destailleur
52fdd19d0f Doc 2024-08-17 19:28:17 +02:00
Laurent Destailleur
f002fb4ed1 Use the non deprecated function loadRights instead of getrights 2024-08-02 10:36:43 +02:00
Laurent Destailleur
feee2e13e7 CSS 2024-07-28 20:05:10 +02:00
Laurent Destailleur
75d1fbc49f Debug v20 - fix cond to show dict, several fix in public ticket gui 2024-07-28 15:02:08 +02:00
Laurent Destailleur
7d1aa1e7f6 Debug v20 - fix cond to show dict, several fix in public ticket gui 2024-07-28 14:54:06 +02:00
Laurent Destailleur
5a9e0f7493 Debug v20 2024-05-17 12:53:21 +02:00
Laurent Destailleur
b7317e3e7c Fix warning 2024-05-05 00:02:25 +02:00
Florian Mortgat
702709f890 New declare dictionaries more easily (#29600)
* NEW: method to help declare dictionaries more easily

* Example use of `declareNewDictionary()` method (redeclaring dictionaries of module Ticket with the new method)

* minor fixes: $this->db->prefix() in modTicket.class.php
2024-05-03 19:03:00 +02:00
Laurent Destailleur
5c018013ed Debug v20 2024-04-29 19:38:02 +02:00
Laurent Destailleur
ca57bac266 Removed a deprecated page 2024-04-26 23:45:39 +02:00
Laurent Destailleur
7f780fcb57 It seems constant are for storing data only and used for
DolibarrModules.class.php file only (main code shoud only use
->hasRight), so i try to move them.
2024-04-08 11:53:49 +02:00
Regis Houssin
68eb5e409a NEW module user rights enhancement (#29150)
* NEW module user rights enhancement

* FIX syntax error

* FIX fuck

* FIX syntax error

* FIX Add label with the current language (key or with PermissionXXX)

* FIX wrong test

* FIX optimize

* FIX doc

* FIX add class "Rights" for constant

* FIX replace with constants

* FIX missing constant

* FIX wrong check

* TODO sql error : data too long for column 'libelle'

* FIX syntax error

* FIX synax error "the return"... i'll be back

* FIX use operator with double question mark

* FIX add comment

* FIX just remplace integer with constant

* FIX remove unused code

* FIX add an example

* FIX remove the possibility to have entity = 0 (too complicated)

* FIX perms must not be empty

* FIX sql syntax error

* FIX phpstan undefined property DolibarrModules::$modules

* FIX same fix of frederic34

* Update llx_rights_def.sql

* Update DolibarrModules.class.php

* Update DolibarrModules.class.php

* Update DolibarrModules.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-08 11:40:02 +02:00
Laurent Destailleur
0e5440f256 Fix bad var 2024-04-06 13:33:42 +02:00
Laurent Destailleur
2ca5518625 Fix use of dynamic property conf->xxx->enabled must be abandonned. 2024-04-05 16:51:27 +02:00
Florian Mortgat
8b00b89f9d FIX: $conf must reflect enabled/disabled state of modules (#29126) 2024-04-05 16:36:02 +02:00
Laurent Destailleur
f03eb260de Nicer combo of companies for external modules 2024-04-03 13:20:26 +02:00
MDW
1ee639bb81 Adjust to real typings 2024-03-27 10:18:35 +01:00
Laurent Destailleur
686463a292 Fix phan warning 2024-03-24 06:37:09 +01:00
Laurent Destailleur
d1c9475089 Better management of MD file with style HTML tags 2024-03-24 03:23:07 +01:00
MDW
2496d20d4f Fix nullable return with if($ok == 1) in stead of if($ok)
# Fix nullable return with if($ok == 1) in stead of if($ok)

This seems to be a bug in Phan where if($ok) changes the type of $ok.
Testing with '$ok == 1' instead fixes the issue.

This has been reported to the phan team.
2024-03-21 00:28:14 +01:00
MDW
942239b5d6 Update PHPdoc to show nullable return 2024-03-20 23:54:32 +01:00
MDW
9ecb4bd639 Fix null return by returning empty string in else case 2024-03-20 21:58:47 +01:00
MDW
f91d32de86 Qual: Fix typing - module_parts['hooks'] may be empty
# Qual: Fix typing - moduleparts['hooks'] may be empty

PHPstan reported on initialisation mismatch when module_parts['hooks']
is initialised to empty array.  This change makes the fields optional.
2024-03-15 10:46:20 +01:00
Laurent Destailleur
c664cdae0f NEW Init of a module with a website template copy also the preview 2024-03-14 12:39:42 +01:00
MDW
8e1b6543b8 Qual: Typing : make all $module_parts fields optional and add missing
# Qual: Typing : make all $module_parts fields optional and add missing

According to the initialisations of the modules all fields for $module_parts are optional
and some keys were missing in the definition.
This is updated.
2024-03-11 18:13:04 +01:00
Laurent Destailleur
39ea68ace4 Try fix phan 2024-03-11 15:20:56 +01:00
MDW
aee0509473 Qual: Force typing on variable fixing several phan notices (#28740)
* Qual: Force typing on variable fixing several phan notices

# Qual: Force typing on variable fixing several phan notices

Forcing DolibarrModules on $objMod after assignment to fix typing checks

* Qual: Fix typing on import_label/export_label
2024-03-11 12:56:55 +01:00