Commit Graph

506 Commits

Author SHA1 Message Date
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661)
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542)
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 17:05:00 +02:00
Laurent Destailleur
aa3a4fbf52 QUAL Clean code 2024-08-15 16:53:49 +02:00
Laurent Destailleur
88253bf647 WIP Work on generic OAuth service 2024-08-13 18:36:33 +02:00
MDW
45ed4caeb2 Qual: Enable Phan Simplify rule and fix notices (#30537)
* Qual: Phan - Enable Simplyfy expression

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Update functions2.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 03:05:02 +02:00
Laurent Destailleur
b3b21d56b6 Fix doxygen 2024-08-07 02:49:38 +02:00
Laurent Destailleur
ee0412dd27 Fix phan warning 2024-07-31 18:54:52 +02:00
Laurent Destailleur
8d7e2d7aa0 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-22 13:23:00 +02:00
Laurent Destailleur
940b946dfb Debug v20 2024-07-22 13:19:35 +02:00
Frédéric FRANCE
29f223fd3c fix checkFunctionArgumentTypes (#30249)
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Frédéric FRANCE
4b275dc148 add phpdoc (#30208)
* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* clean phpdoc
2024-06-30 19:39:01 +02:00
Frédéric FRANCE
f1302291de fix phan emailcollector (#30196)
* fix phan emailcollector

* fix phpstan

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc

* add phpdoc
2024-06-29 18:57:43 +02:00
Laurent Destailleur
8aeebe643e Fix code email out. 2024-06-27 20:26:38 +02:00
Laurent Destailleur
d510405092 Debug emailcollector 2024-06-27 20:21:42 +02:00
Laurent Destailleur
3eae3a70eb Fix error and timezone 2024-06-27 18:08:52 +02:00
Laurent Destailleur
1104b95137 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-27 13:47:27 +02:00
Laurent Destailleur
de4ebc34cc Debug v20 FIX emailcollector error mngt and support special char 2024-06-27 13:45:44 +02:00
Laurent Destailleur
4b7fb72760 FIX error management of emailcollector + support special chars in dirs 2024-06-27 13:35:33 +02:00
Laurent Destailleur
ee9d9a9d75 Debug emailcollector 2024-06-27 00:00:24 +02:00
Laurent Destailleur
2099631231 Fix detection of existing trackid 2024-06-26 23:22:08 +02:00
Laurent Destailleur
0a1680610e Log 2024-06-26 22:43:41 +02:00
Laurent Destailleur
12c7019c99 Add logs 2024-06-26 22:40:23 +02:00
Laurent Destailleur
cfaadbaa7c Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-06-26 21:50:14 +02:00
Laurent Destailleur
04f64714f1 Debug v20 2024-06-26 21:45:36 +02:00
Lucas Marcouiller
2cf322184e Fix php 8.3 warnings (#30160)
* Fix php 8.3 warnings

* fix deprecation

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-06-26 17:04:05 +02:00
Lucas Marcouiller
32ea86c62f Fix reply-to filter for email collector (#30152)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-06-25 15:19:26 +02:00
Frédéric FRANCE
50659ede04 fix phpstan (#30030) 2024-06-15 15:07:51 +02:00
Lucas Marcouiller
f6e00ac0b2 Fix email colllector collection to add date in meta data description (#29920)
* Fix email colllector collection to add date in meta data description

* Update emailcollector.class.php

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-08 12:06:42 +02:00
Laurent Destailleur
fc2462d62f Clean code 2024-05-24 16:57:43 +02:00
Laurent Destailleur
1b2bad3f42 NEW Add function to manipulate emojis 2024-05-14 18:19:48 +02:00
Frédéric FRANCE
d0830b3159 fix phpstan (#29602)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix travis

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-05-05 00:34:19 +02:00
Lucas Marcouiller
2928ae54c2 Fix email collector to add update of ticket email collector (#29541)
* Fix email collector to add update of ticket email collector

* update lang file

* fix lang file

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-05-01 17:34:55 +02:00
Laurent Destailleur
f008bf3473 More log 2024-04-29 13:48:26 +02:00
Laurent Destailleur
f5adfeca59 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-29 13:39:20 +02:00
Laurent Destailleur
d488ca2070 FIX #26015 2024-04-29 09:23:40 +02:00
Lucas Marcouiller
bfa3853acf Fix emailcollector ticket tracking (#29393)
* Fix emailcollector ticket tracking

* fix some things

* fix fetch ticket for email collector

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-27 12:41:29 +02:00
Laurent Destailleur
0a3f66c6c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	dev/tools/codespell/codespell-ignore.txt
	htdocs/admin/system/security.php
	htdocs/core/class/commondocgenerator.class.php
	htdocs/core/menus/standard/eldy.lib.php
	htdocs/product/fournisseurs.php
2024-04-11 22:57:43 +02:00
Laurent Destailleur
c575d26703 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
Conflicts:
	htdocs/core/class/commondocgenerator.class.php
	htdocs/core/menus/standard/eldy.lib.php
2024-04-11 22:19:08 +02:00
HENRY Florian
ed6247b640 18 fix emailcollector false positive for type="recordjoinpiece" (#29308)
* change git ignor

* change git ignor

* FIX: on email collector operation type : recordjoinpiece, check empty field return false positive

* revert changes from origin branch

* revert changes from origin branch

* revert changes from origin branch

* revert changes from origin branch

---------

Co-authored-by: moreauf <moreauf@theobald-groupe.com>
2024-04-11 22:03:27 +02:00
Laurent Destailleur
fd9475be03 Use same doc comment eveywhere. 2024-04-07 12:26:27 +02:00
Frédéric FRANCE
7cf6a0821f fix phpdoc for ismultientitymanaged (#29245)
* fix phpdoc

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-06 17:38:39 +02:00
Laurent Destailleur
38fb00489d PHPDoc 2024-04-05 13:44:59 +02:00
Laurent Destailleur
bf7109f51c Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-04 17:47:02 +02:00
Laurent Destailleur
4239a0cd8b FIX The filter ! was borken in emailcollector 2024-04-04 17:46:31 +02:00
Laurent Destailleur
1a4acc2a7a Remove debug 2024-03-27 14:09:50 +01:00
Laurent Destailleur
2a8f0c69a3 Fix regression in IMAP collecting 2024-03-26 21:51:43 +01:00
Laurent Destailleur
1b98d99434 Fix regression in IMAP collecting 2024-03-26 21:19:50 +01:00
MDW
cbb82042a5 Extra checks to fix PhanNonClassMethodCall 2024-03-24 15:40:19 +01:00
MDW
20c7b8509e Suppress PhanTypeMismatchArgumentInternal 2024-03-20 04:09:23 +01:00