MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
Frédéric FRANCE
4ed203bece
fix phpstan ( #29382 )
...
* fix phpstan
* remove unused code
2024-04-18 11:21:09 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
MDW
6b0f48ade7
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:48:16 +01:00
MDW
88d59896ec
Qual: 'enabled' in fields can be string ('isModEnabled(...)')
...
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')
Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
b04317adb6
Fix: Repeat fields typing in CommonClass children
...
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:32 +01:00
Frédéric FRANCE
8a5d40b749
fix phpstan
2024-01-14 21:12:52 +01:00
Laurent Destailleur
f201692001
Fix phpstan
2024-01-12 19:50:22 +01:00
Laurent Destailleur
ad6c4c2deb
Fix phpcs
2024-01-12 18:18:20 +01:00
Frédéric FRANCE
53c8a3acf8
clean phpdoc for phpstan ( #26905 )
2023-12-01 19:51:32 +01:00
Faustin
22ab13975f
scrutinizer on expensereport/class/expensereport_rule.class.php: method fetchLine wasn't defined
2022-09-12 16:57:23 +02:00
Laurent Destailleur
ed2e1bda46
Clean code v16
2022-05-18 11:00:43 +02:00
Laurent Destailleur
d4cc60640b
Clean code
2021-09-27 15:41:58 +02:00
Laurent Destailleur
29abbbe2fb
Clean code
2021-08-28 01:45:53 +02:00
Laurent Destailleur
d138e7410b
Clean code
2021-04-26 19:12:23 +02:00
Laurent Destailleur
6e422d26f3
FIX #yogosha5746 - next step (wip)
2021-03-30 16:20:18 +02:00
Frédéric FRANCE
8a69fa0d35
code syntax expensereport directory
2021-02-25 22:45:02 +01:00
Frédéric FRANCE
4e18f46f28
doxygen
2020-12-05 23:53:55 +01:00
Frédéric FRANCE
b41ac00b98
add new rule
2020-05-21 15:05:19 +02:00
Frédéric FRANCE
f5688b2eec
add new rule
2020-05-21 01:52:25 +02:00
Scrutinizer Auto-Fixer
fd48877dc6
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-02-18 22:47:25 +00:00
Laurent Destailleur
f4f3efec62
Fight against $_POST
2020-02-16 19:33:58 +01:00
Alexandre SPANGARO
02dbc11f98
Move Gnu.org to https
2019-09-23 21:55:30 +02:00
Laurent Destailleur
fff9b7db9d
Fix doxygen
2019-04-04 18:33:12 +02:00
Frédéric FRANCE
f0cdf300d1
Squiz.Functions.FunctionDeclarationArgumentSpacing
2019-01-27 15:20:16 +01:00
Philippe GRAND
74c86f477c
Standardize code
2018-10-06 12:01:00 +02:00
Philippe GRAND
87067b2bc9
Standardize and update code
2018-08-23 18:35:45 +02:00
Philippe GRAND
06da7f54a2
Update and standardize code
2018-08-22 18:48:53 +02:00
Scrutinizer Auto-Fixer
bd5bffa72c
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2017-10-16 06:47:05 +00:00
Laurent Destailleur
d12019d1b5
Fix from scrutinizer
2017-10-13 13:10:36 +02:00
atm-ph
1f3f9e40b1
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into new_develop_expense_report
2017-07-27 16:01:53 +02:00
phf
1beec51928
New expense report rules and ik (index kilometers) - MAIN_USE_EXPENSE_IK - MAIN_USE_EXPENSE_RULE
2017-07-05 10:44:52 +02:00
