Commit Graph

2149 Commits

Author SHA1 Message Date
Frédéric France
6623a3c23d remove no more used code 2024-12-17 17:59:21 +01:00
Frédéric FRANCE
b2479ae74f Update api_contacts.class.php 2024-12-17 15:06:06 +01:00
Laurent Destailleur (aka Eldy)
3fa0b65c0c Fix filter on contact 2024-12-17 13:33:29 +01:00
Laurent Destailleur (aka Eldy)
d542b21244 Debug v2 fix ufs for next_prev_filter 2024-12-10 11:54:33 +01:00
Laurent Destailleur
458579342a Merge pull request #32210 from atm-maxime/detect_country_code
NEW : auto-detect country from code in creation
2024-12-05 16:28:33 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Maxime Kohlhaas
c6e3ac592b Fix phpstan error 2024-12-04 15:12:38 +01:00
Maxime Kohlhaas
13bf82d9cd NEW : auto-detect country from code in creation 2024-12-03 11:31:04 +01:00
Frédéric FRANCE
286c3d1093 fix sql ticket list (#32080)
* fix sql ticket list

* fix sql ticket list

* fix phpstan

* fix

* fix
2024-11-28 12:11:50 +01:00
Frédéric FRANCE
13b8f5feff keep only commonobject property oldcopy (#32123)
* clean properties

* clean properties

* clean properties

* clean properties

* clean phpcs

* clean phan

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-27 21:59:41 +01:00
Laurent Destailleur
456163c758 Debug v21 2024-11-25 15:05:48 +01:00
Laurent Destailleur
63ac936652 Fix add an order to have same behavior in using stripe customer account
event if data are corrupted with duplicate record.
2024-11-25 14:46:22 +01:00
Laurent Destailleur
bc83d330b6 Debug v21 2024-11-25 03:16:30 +01:00
Laurent Destailleur
627f81acd5 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-11-24 14:01:36 +01:00
Frédéric FRANCE
75400611e1 fix phpstan (#32040)
* fix phpstan

* fix

* fix

* fix

* fix

* fix

* fix
2024-11-21 22:36:00 +01:00
Frédéric FRANCE
57d121664f set object entity at create (#32019)
* set object entity at create

* set object entity at create

* set object entity at create

* set object entity at create

* set object entity at create

* set object entity at create

* do not break multicompany thing

* do not break multicompany thing

* missing translation

* fix phpstan

* doc

* fix entity

* fix set entity
2024-11-21 19:11:32 +01:00
Frédéric FRANCE
e0562817d6 fix usf filters (#31897) 2024-11-15 23:45:24 +01:00
Laurent Destailleur
b1e3830c3b Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-11-13 00:38:58 +01:00
Laurent Destailleur
a186903844 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-11-13 00:38:00 +01:00
Laurent Destailleur
4cd2e572ae Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-11-13 00:30:26 +01:00
uvaldenaire-opendsi
0eee1ad18b Qual: remove php 8.2 warnings by casting trim() argument to string. (#28162) (#31693)
In create and update methods of societe class, the trim function triggered warnings when the argument passed is null.
Cast string properties to string to avoid php warnings when the property is null.

Co-authored-by: UltraViolet33 <93035200+UltraViolet33@users.noreply.github.com>
2024-11-12 19:45:52 +01:00
atm-lena
10e18da5d7 Develop new facture rec field societe rib management (#31698)
* Add field "fk_societe_rib" in llx_facture_rec

* Add field fk_societe_rib FactureRec

* Management of new field "Bank Account Customer" in facture rec

* Empty Value Management

* Change method of hide/show field

* Preselect RIB

* Rename function

* Edit structure formiban

* fix merge conflict

* Clean code

* clean code

* change translations

* default rib preselected in invoice rec create

* fix "=="

* Update card-rec.php

---------

Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-11 17:53:35 +01:00
Laurent Destailleur
a3cd50944d Fix missing property 2024-11-07 03:25:04 +01:00
MDW
278d301f32 Qual: Fix phan/phpstan notices in class files (part 6) (#31634)
* Qual: Fix notices for paymentdonation...workstationusergroup.class

* Qual: Fix PhanPluginRedundantReturnComment, update baseline

* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Laurent Destailleur
4bdd848bbe Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-11-06 13:26:08 +01:00
Laurent Destailleur
4d9283d8ab Clean code 2024-11-04 16:41:50 +01:00
omogenot
9e40176056 NEW: INTRA VAT ID field optionally mandatory and/or invoice mandatory in thirdparty module setup (#31663)
* Update societe.php

* Add VAT mandatory and VAT invoice mandatory setup
* Reuse `setprofid`, `setprofidmandatory` and `setprofidinvoicemandatory` functions to update constants by using same mechanism with $key='VAT_INTRA'

* Update societe.class.php

Add VAT value check is company uses VAT and VAT is mandatory

* Update facture.class.php

Add VAT invoice mandatory checking

* Update facture.class.php

Typo

* Update societe.php

Fix comment
2024-11-04 13:02:25 +01:00
iLLixM
c580e5fb5e FIX #30432 make thirdparty code_client and code_compta modifiable via API (#31668)
* make thirdparty code_client and code_compta modifiable via API

make code_client and code_compta modifiable via API call ( put /thirdparties/{id} ) for existing third parties

* fix: thirdparty code_client and code_compta modifiable via API (#30432)

make code_client and code_compta modifiable via API call ( put /thirdparties/{id} ) for existing third parties
2024-11-04 12:34:21 +01:00
Laurent Destailleur
e6f1d4835f Clean sql code 2024-10-29 02:58:20 +01:00
Frédéric FRANCE
2ae4bdcecb fix phpstan (#31588) 2024-10-28 00:35:26 +01:00
Laurent Destailleur
8bae2d99d8 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-24 20:13:12 +02:00
Laurent Destailleur
8abfcf71a9 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-10-24 13:54:13 +02:00
Laurent Destailleur
830029dd05 NEW Iban is saved encrypted 2024-10-24 13:03:52 +02:00
Laurent Destailleur
3bc1d35236 QUAL The property ->domiciliation and ->propio on bank accounts has been
deprecated and replaced with property ->address and ->owner_name
2024-10-24 12:38:41 +02:00
Laurent Destailleur
58c0b97300 FIX for #31237 #31524 2024-10-23 20:17:40 +02:00
MDW
fb3972b702 Qual: Fix phan notices in some payment/strip related classes (#31453)
* fix concat

* fix overwrite

* Clean code

* Do not analyze custom

* Update baseline, ignore everything in custom

* Qual: Fix notices in files related to ticket class

* Qual: Fix companybankaccount.class

* Fix phan/phpstan notices

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: Frédéric FRANCE <frederic.france@free.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-20 00:32:01 +02:00
MDW
cee4535975 Qual: Fix phan notices in admin.lib and tax.lib + related (#31414)
* Qual: Fix admin.lib phpstan/phan notices

* Qual: Fix some argument types in Societe methods

* Fixup phpdoc

* Qual: Improve typing for static analysis

* Qual: Improve typing for static analysis

* Fix tax typing

* Qual: further phan/phpstan notice fixes in dol_generic_project_odt

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-17 03:08:38 +02:00
Alexandre Janniaux
be50b49103 societe: fix warning during tests (#31387)
1) /home/alexandre/workspace/dolibarr/htdocs/societe/class/societe.class.php:1299
    Attempt to read property "country_id" on null

    Triggered by:

    * BookKeepingTest::testBookKeepingCreate (6 times)
      /home/alexandre/workspace/dolibarr/test/phpunit/BookKeepingTest.php:53

    * SocieteTest::testSocieteCreate (6 times)
      /home/alexandre/workspace/dolibarr/test/phpunit/SocieteTest.php:87

    * SocieteTest::testSocieteFetch (6 times)
      /home/alexandre/workspace/dolibarr/test/phpunit/SocieteTest.php:114

    * SocieteTest::testSocieteMerge (12 times)
      /home/alexandre/workspace/dolibarr/test/phpunit/SocieteTest.php:450

    * SocieteTest::testSocieteUpdate (6 times)
      /home/alexandre/workspace/dolibarr/test/phpunit/SocieteTest.php:143
2024-10-15 16:41:58 +02:00
Alexandre SPANGARO
4a91c2c734 NEW Accountancy - Add general account on thirdparty - Code supplier part (#31318)
* NEW Accountancy - Add general account on thirdparty - SQL Part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* Fix Phan

* Use isModEnabled

* NEW Accountancy - Add general account on thirdparty - Code supplier part

* Fix phan

* Fix phan

* Fix phan

* Use list of account instead of  simple input

* Use list of account instead of simple input

* Tabs

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-14 12:05:07 +02:00
MDW
67263522eb Fix: code_compta aliased as code_compta_client (#31349)
* Fix: code_compta aliased as code_compta_client

# Fix: code_compta aliased as code_compta_client

Fix warning regarding non-existing field on sql result

* Handle code_compta with deprecationhandler
2024-10-13 16:52:48 +02:00
Alexandre SPANGARO
6fe1adec7d NEW Accountancy - Add general account on thirdparty - Code customer part (#31294)
* NEW Accountancy - Add general account on thirdparty - SQL Part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* NEW Accountancy - Add general account on thirdparty - Code customer part

* Fix Phan

* Use isModEnabled

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-09 01:51:12 +02:00
Laurent Destailleur
a7db9f8b75 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-10-07 15:23:41 +02:00
Laurent Destailleur
081d3fabfc Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-07 15:20:16 +02:00
Laurent Destailleur
b07cc82058 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-10-07 15:17:49 +02:00
Laurent Destailleur
94ed718782 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-10-07 15:15:01 +02:00
MDW
34e3717dda Qual: Fix phan/phpstan notices (#31289)
* Qual: Fix phan/phpstan notices

# Qual: Fix phan/phpstan notices

Fix several phan/phpstan notices

* Fix spelling in Changelog
2024-10-06 13:03:43 +02:00
MDW
f70c945931 Qual: Fix phan/stan notices (#31271)
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall

Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
ptibogxiv
f74b072d72 NEW retrieve Thirdparty by account (#31283)
* NEW retreive Thirdparty by account

usefull for external link

* Update api_thirdparties.class.php

* Update api_thirdparties.class.php

* Update api_thirdparties.class.php
2024-10-05 18:46:16 +02:00
atm-irvine
f287d100a3 Use <= 0 instead of ! because delete method returns -1 or 1 (#31268)
* Use <= 0 instead of ! because delete method returns -1 or 1

* Added contact

* Removed user from parameters
2024-10-04 11:49:44 +02:00
Laurent Destailleur
42471decac Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 15:50:44 +02:00