Laurent Destailleur (aka Eldy)
2ddd518029
Debug v21
2024-12-13 18:11:05 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
UT from dolibit
e5caa2170e
Update workstation_list.php ( #25707 )
...
* Update workstation_list.php
* Update workstation_list.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-12 02:43:46 +01:00
MDW
278d301f32
Qual: Fix phan/phpstan notices in class files (part 6) ( #31634 )
...
* Qual: Fix notices for paymentdonation...workstationusergroup.class
* Qual: Fix PhanPluginRedundantReturnComment, update baseline
* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Laurent Destailleur
10c58950bb
Look and feel v21
2024-10-15 10:16:48 +02:00
MDW
53cfbc35be
Qual: Fix several phan & stan notices ( #31308 )
...
* Qual: Fix several phan & stan notices
# Qual: Fix several phan & stan notices
Several fixes in files while fixing UnknownClass notices
* Qual: Update prepare_head PHPDoc return types
# Qual: Update prepare_head PHPDoc return types
Provide detailed array return types for prepare_head functions.
* Fix new phan notice
* Better loadLangs typing and fix call to loadLangs
* Fix new issues (stats)
* Other fixes of new issues
* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
MDW
f70c945931
Qual: Fix phan/stan notices ( #31271 )
...
# Qual: Fix phan/stan notices in relation with UnknownObjectMethodCall
Fix notices in classes with UnknownObjectMethodCall notices or classes
related with these.
2024-10-05 18:55:36 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
Laurent Destailleur
b32225283d
Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop
2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3
FIX Duplicate trigger printFieldPreListTitle
2024-09-25 13:43:11 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
2009c6f09a
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-31 17:30:32 +02:00
Laurent Destailleur
ee6779dbcf
Clean code
2024-08-31 15:08:17 +02:00
Laurent Destailleur
a59e933d59
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-22 14:47:00 +02:00
Laurent Destailleur
e631ce7475
Fix sanitizing dol_openinpopup
2024-08-22 14:46:10 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
Laurent Destailleur
147a8bfaee
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/adherents/subscription/list.php
htdocs/categories/viewcat.php
htdocs/contrat/card.php
htdocs/contrat/list.php
htdocs/eventorganization/conferenceorbooth_list.php
htdocs/expedition/list.php
htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Laurent Destailleur
8a4f550d64
Debug v20
2024-07-09 17:33:27 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Frédéric FRANCE
409bccb4f0
fix phan api_workstations.class.php ( #30169 )
...
* fix api_workstations.class.php
* Update api_workstations.class.php
* Update api_workstations.class.php
* Update api_workstations.class.php
* Update html.formwebsite.class.php
2024-06-27 16:39:15 +02:00
Christian Humpel
64f53fcc67
New: Add REST Api functionality for workstations ( #30154 )
2024-06-26 17:05:42 +02:00
atm-lena
6bb90034ff
llxHeader - BodyCss - webhook/webservice/workstation ( #29953 )
...
Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr >
2024-06-09 11:49:02 +02:00
Frédéric FRANCE
1ff0e8a821
fix an old error ( #29850 )
...
* fix an old error
* fix OdfException is never thrown in the try block
* fix OdfException is never thrown in the try block
* fix Undefined array key "name"
* fix missing translation
* fix missing translation
* fix Undefined variable $lineid
* fix warnings
* fix upload dir
* fix phpcs
2024-06-08 16:59:40 +02:00
Laurent Destailleur
46b0bcefb7
Doc
2024-05-23 22:28:37 +02:00
Laurent Destailleur
66f4562300
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-05-23 14:50:17 +02:00
Laurent Destailleur
a854e58905
FIX Missing $param in hook call for list
2024-05-23 14:41:56 +02:00
Laurent Destailleur
629ccf9681
Merge branch 'FIX_Entity_on_workstation' of
...
github.com:ATM-Consulting/dolibarr into
ATM-Consulting-FIX_Entity_on_workstation
2024-05-23 13:02:07 +02:00
Adrien Raze
e5b5092549
FIX : Entities were not managed on workstation
2024-05-23 12:05:32 +02:00
Laurent Destailleur
458ffdb23e
css
2024-05-09 18:15:57 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Laurent Destailleur
e3daa23949
Look and feel v20
2024-04-30 09:45:28 +02:00
Laurent Destailleur
fd9475be03
Use same doc comment eveywhere.
2024-04-07 12:26:27 +02:00
Laurent Destailleur
38fb00489d
PHPDoc
2024-04-05 13:44:59 +02:00
Laurent Destailleur
7b0177a84d
Move to getDolGlobalString
2024-03-22 00:37:56 +01:00
MDW
c9d897ee35
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:52 +01:00
MDW
aeefca7e7e
Fix $arrayfields typing lost by dol_sort_array() by forcing the type
2024-03-20 23:29:48 +01:00
Frédéric France
dcc01e58e2
fix phpstan in workstation class
2024-03-20 08:46:16 +01:00
Frédéric France
a58eb10cea
fix phpstan in workstation class
2024-03-20 08:41:27 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
Laurent Destailleur
e994d6650f
Fix regression in GETPOST limit
2024-03-16 11:41:00 +01:00
Laurent Destailleur
79aa9fb1f1
Code simpler
2024-03-15 20:29:21 +01:00
MDW
23785393a3
Add csslist to json keys
2024-03-15 03:55:52 +01:00
MDW
460d43cfbe
Fix PhanTypeMismatchPropertyDefault
2024-03-15 03:55:49 +01:00
Laurent Destailleur
74b8162d22
Merge pull request #28700 from mdeweerd/urlencode/fixuptype
...
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
