Commit Graph

13947 Commits

Author SHA1 Message Date
Laurent Destailleur
c867bc2706 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-13 22:36:45 +01:00
Laurent Destailleur
8bfc0779c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-13 22:20:08 +01:00
Laurent Destailleur
a0b26ae7cd FIX Amount of localtaxes in foreign currency was wrong on screen and PDF 2024-03-13 22:04:44 +01:00
Laurent Destailleur
09b11719c4 Update report.php 2024-03-13 18:15:36 +01:00
MDW
1daa77650c Fix Initialise array to fix PhanTypeInvalidUnaryOperandIncOrDec 2024-03-13 16:50:28 +01:00
Laurent Destailleur
cad8f24322 Merge pull request #28799 from mdeweerd/fix/PhanPluginDuplicateExpressionAssignmentOperation
Fix & enable PhanPluginDuplicateExpressionAssignment
2024-03-13 14:49:21 +01:00
MDW
c7bd8b57cc Fix PhanPluginRedundantAssignment 2024-03-13 00:40:39 +01:00
MDW
9ee7611a08 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:38 +01:00
MDW
ca8ccd84f0 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:37 +01:00
MDW
944ba8a4c0 Fix PhanPluginDuplicateExpressionAssignment (NOOP assignment) 2024-03-12 22:25:33 +01:00
MDW
0f76544e0f Fix PhanPluginDuplicateExpressionAssignment (NOOP assignment) 2024-03-12 22:25:32 +01:00
MDW
c5659b5fbd Fix PhanPluginDuplicateExpressionAssignmentOperation $this to obj 2024-03-12 22:25:30 +01:00
MDW
d8c7aad698 Fix PhanPluginMixedKeyNoKey by using explicit keys 2024-03-12 21:35:45 +01:00
MDW
6a64b3a50f Fix duplicate if condition with same effect 2024-03-12 19:10:50 +01:00
Laurent Destailleur
74b8162d22 Merge pull request #28700 from mdeweerd/urlencode/fixuptype
Fix: Ensure the argument type for urlencode is string
2024-03-12 14:43:41 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
fd75753934 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:07 +01:00
MDW
0c0f04f2d5 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:05 +01:00
MDW
88ba7d1bc5 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:03 +01:00
MDW
a8a7d71426 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:01 +01:00
MDW
ec18ec0605 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:38:59 +01:00
Laurent Destailleur
464b1246f0 Merge pull request #28736 from JonBendtsen/cheque_number
attempt at fixing #28645 - API bankaccounts/transfer POST missing the cheque_number
2024-03-11 15:37:47 +01:00
Laurent Destailleur
f7024b61ee Update api_bankaccounts.class.php 2024-03-11 15:37:16 +01:00
MDW
b72cf193c4 Fix some cases of PhanTypeSuspiciousStringExpression (#28751)
* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

* Fix PhanTypeSuspiciousStringExpression

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-11 14:01:28 +01:00
Laurent Destailleur
0f2121e3ba Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-03-11 13:46:08 +01:00
Laurent Destailleur
e72671bf50 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-03-11 13:39:04 +01:00
Laurent Destailleur
f40ad6e90a Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-03-11 13:31:55 +01:00
Laurent Destailleur
f32bf4b3a7 Fix join -> implode 2024-03-11 12:38:21 +01:00
Laurent Destailleur
898aebdbf8 Fix missing tooltip 2024-03-11 12:06:57 +01:00
Laurent Destailleur
ec1b8284c9 Rename files to use an english name 2024-03-10 15:52:29 +01:00
MDW
37afba949e Fix most PhanTypeMismatchDimAssignment notices (#28739)
* Qual: Add typing to fix PhanTypeMismatchDimAssignment notice

* Fix: Initialise array for code in somme

* Qual: Update type hint for  argument in _Set_Format

* Qual: Update type hint for childtables

* Qual: Add typing to attributes

* Qual: Add typing for _msgContent

* Qual: Suppress PhanTypeMismatchDimAssignment

* Qual: Add typing for liste

* Qual: Add typing to fields

* Qual: Add typing hint for $objMod

* Qual: Modify assignment of array with bool keys for phan typing

Demonstration:
```
php -r '$a=[true=>"yes",false=>"no"];var_dump($a);'
# Result demonstrates bool keys are converted to int.
Command line code:1:
array(2) {
  [1] =>
  string(3) "yes"
  [0] =>
  string(2) "no"
}
```

* Qual: Add typing hint to indicate value is not null

* Force non-null type on $paramname

* Qual: Add typing hint to getCats()

* Update inc.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-03-10 01:53:04 +01:00
Jon Bendtsen
668d2fa6e8 making param string cheque_number line up and conform better with previous code 2024-03-09 22:43:53 +01:00
Jon Bendtsen
95d644615c remove trailing whitespace 2024-03-09 22:14:02 +01:00
Jon Bendtsen
0c91e3fe06 attempt at fixing #28645 2024-03-09 22:01:30 +01:00
MDW
3885d1ebfe Fix: Ensure string type for urlencode() 2024-03-09 16:53:51 +01:00
MDW
b43ec4056c Fix: Ensure string type for urlencode() 2024-03-09 16:53:50 +01:00
MDW
a696868f5c Fix: Ensure string type for urlencode() 2024-03-09 16:53:48 +01:00
MDW
86c1bb8fe5 Fix: Ensure string type for urlencode() 2024-03-09 16:53:47 +01:00
MDW
e2f6d646d3 Fix: Ensure string type for urlencode() 2024-03-09 16:53:46 +01:00
MDW
475aa5497d Fix: Ensure string type for urlencode() 2024-03-09 16:53:44 +01:00
MDW
106ff976b5 Fix: Ensure string type for urlencode() 2024-03-09 16:53:43 +01:00
MDW
1c8e034c35 Fix: Ensure string type for urlencode() 2024-03-09 16:53:41 +01:00
MDW
e1e3185c70 Fix: Ensure string type for urlencode() 2024-03-09 16:53:40 +01:00
MDW
1b5046661f Fix: Ensure string type for urlencode() 2024-03-09 16:53:38 +01:00
MDW
1d7c551a85 Fix: Ensure string type for urlencode() 2024-03-09 16:53:37 +01:00
MDW
76c336ee7b Fix: Ensure string type for urlencode() 2024-03-09 16:53:36 +01:00
MDW
10b3b617a7 Fix: Ensure string type for urlencode() 2024-03-09 16:53:34 +01:00
MDW
a361855b24 Fix: Ensure string type for urlencode() 2024-03-09 16:53:33 +01:00
MDW
bb3e90183c Fix: Ensure string type for urlencode() 2024-03-09 16:53:31 +01:00
MDW
bb144ed278 Fix: Ensure string type for urlencode() 2024-03-09 16:53:30 +01:00