Commit Graph

547 Commits

Author SHA1 Message Date
MDW
abbec034c6 Qual: Several typing hints/some fixes. (#28483)
* Update documentation to improve static tool messages

* Suppress PhanPluginSuspiciousParamOrder

* Fix typing hint

* Fix typing hint (number->int)

* Fix typing hint (PDF->TCPDF)

* Fix typing hint (PDF->TCPDF)

* Modify code to hint typing check

* Correct Noop statement (createfromclone)

* Remove useless if/else with same result

* Suppress PhanRedefineFunctionInternal

* Suppress PhanParamSuspiciousOrder

* Suppress PhanPluginDuplicateArrayKey

* Suppress multiple phan messages

* Ignore PhanPluginSuspiciousParamOrder

* Add phan typing

* Remove useless if statement

* Remove useless if/else condition

* Remove useless if

* Remove useless if

* Join duplicate if/else statements

* Fix useless if

* Fix useless if

* Fix phan notice by optimizing 2**$i to 1<<$i
2024-02-28 15:36:29 +01:00
Laurent Destailleur
e9a0905fba Use same return 2024-02-13 11:14:11 +01:00
MDW
7b54824d49 Fix #28071 - New branch to fix bad merge (#28083)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Qual: Introduce getDataToShowPhoto to prepare generic code

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix missing trans

* Fix langs

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Remove useless files in web templates

* Clean code

* Fix duplicate translation key

* Fix duplicate translation key

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix duplicate key

* Fix $object

* Debug v19

* WIP SMSing

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP EMAILINGS_SUPPORT_ALSO_SMS

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP SMSing

* Debug the "validate" feature

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Clean code

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Enhance rector to fix empty($user->rights->modulex->perm1)

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Fix template to use v19 dev rules

* Fix use v19 dev rules

* Fix phpunit

* Debug v19

* Clean code

* Use rector to convert user->rights into user->hasRight

* Clean code

* Use rector to convert user->rights into user->hasRight

* Use rector to convert user->rights into user->hasRight

* Clean code

* Fix phpcs

* add editorconfig for sql files (#27999)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* add model_pdf field in llx_ticket-ticket.sql (#27996)

* add model_pdf field in llx_ticket-ticket.sql

* Update 19.0.0-20.0.0.sql

* Update 19.0.0-20.0.0.sql

* Improve wording in README (#27994)

* fix phpstan (#27989)

* fix phpstan

* Update UserRightsToFunction.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* Qual: Fix spelling/working in datapolicy translations (#28006)

# Qual: Fix spelling/wording in datapolicy translations

Fixed some spelling and wording in datapolicy translations.

* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986)

htdocs/ticket/class/ticketstats.class.php	98	Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()

* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix user with readonly perm on email template must be able to read.

* Fix doc

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Better message

* Add missing fields in merge of thirdparty

* Debug v19 selection of ticket printer per terminal

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Use constant

* NEW: Adding a recipient on emails sent, change status to sent partialy.

* fix travis (#28052)

* fix travis

* Update partnership.class.php

* fix php doc (#28047)

* fix undefined array key (#28048)

* Add region and departament for Cuba (#28046)

* Update llx_10_c_regions.sql

Add Cuba Regions (id_country=77)

* Update llx_20_c_departements.sql

Add Provinces Cuba (id country=77)

* Find the typo (#28050)

* Find the typo

* clean code

* add last_main_doc field to product (#28045)

* add las_main_doc field to product

* add field fetch

* NEW Add Categorie filter for ActionComm (#28041)

* New Add Categorie filter for ActionComm

New Add Categorie filter for ActionComm

* Fix space errors

Fix space errors

* Fix space errors 2

Fix space errors 2

* Update cunits.class.php (#28056)

FIX: error SQL when creating a Cunit

* Update codespell-lines-ignore.txt to avoid PR merge conflict

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: thibdrev <thibault.drevet@gmail.com>
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com>
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com>
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com>
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com>
2024-02-09 15:58:49 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Charlène Benke
c32b1c4ed0 Update mod_expedition_safor.php 2023-12-30 08:15:57 +01:00
Laurent Destailleur
fb083a6cfc Fix warning with rector 2023-12-13 16:33:17 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
9e1b90e4a1 Fix with php-cs-fixer 2023-12-04 12:07:31 +01:00
Laurent Destailleur
240869f2f2 Fix warnings 2023-11-30 21:45:58 +01:00
Laurent Destailleur
53dab922fd Fix php8.2 warnings 2023-11-27 11:39:32 +01:00
Lucas Marcouiller
88e9e091cf fix some php stan errors (#26747)
* fis some php stan errors

* fix dolchmod

* Update stats.class.php

---------

Co-authored-by: Hystepik <lucas.marcouiller@gmail.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-11-22 00:23:16 +01:00
Laurent Destailleur
6cdb7c929a Debug v19 2023-11-10 15:10:41 +01:00
Mohamed DAOUD
00cbaa094c fix-warnings (#26500) 2023-11-08 17:26:00 +01:00
Laurent Destailleur
1f38e54e78 Clean code 2023-10-15 15:32:35 +02:00
Charlène Benke
d8fac8081f FIX : Bad hidden variable Name
the hidden constant MAIN_PDF_SHIPPING_DISPLAY_AMOUNT_HT had been renamed since version 9 to SHIPPING_PDF_DISPLAY_AMOUNT_HT
but not in this pdf file
2023-09-28 10:25:09 +02:00
Frédéric FRANCE
0de4f372a6 phpstan
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=113,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=528,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=532,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=533,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=678,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=718,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=722,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=723,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=812,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=817,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=817,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=819,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
::error file=htdocs/core/modules/expedition/doc/pdf_rouget.modules.php,line=820,col=0::Access to an undefined property pdf_rouget::$posxqtytoship.
2023-09-18 12:02:49 +02:00
Laurent Destailleur
b546e7c624 css 2023-09-10 20:24:58 +02:00
Laurent Destailleur
24040c78bb Tooltip for help in ODT doc generation setup is now clickable 2023-08-18 01:46:54 +02:00
Laurent Destailleur
a4d04b84f5 css 2023-08-18 01:06:47 +02:00
Laurent Destailleur
df4761e42a Fix numbering of shipments 2023-08-11 12:14:28 +02:00
Laurent Destailleur
5905fd2425 The method get_substitutionarray_shipment_lines() has been removed. Use
the generic get_substitutionarray_lines() instead.
2023-08-11 11:56:50 +02:00
Laurent Destailleur
707d853e84 Clean code 2023-08-10 11:29:09 +02:00
Laurent Destailleur
08e428b46d Fix missing param 2023-08-09 18:00:31 +02:00
Laurent Destailleur
15ddb9a3a8 Fix inherit of CommonNumRef 2023-08-09 17:35:35 +02:00
Laurent Destailleur
db2a70b86a NEW Factorize a lot of code for numbering modules 2023-08-09 14:50:28 +02:00
kkhelifa-opendsi
f49ecdb6ef NEW: Add get_substitutionarray_other() on shipping odt (#25080) 2023-08-08 21:04:02 +02:00
Laurent Destailleur
df76b9940d Debug v18 2023-08-05 13:27:56 +02:00
Laurent Destailleur
ff11a7442e Fix warnings 2023-08-04 04:28:45 +02:00
Florian HENRY
ce10c68d31 getDol rather than ->global 2023-06-08 22:38:11 +02:00
Frédéric FRANCE
c61d96c98f put phpmin info in one place 2023-05-31 09:31:22 +02:00
Laurent Destailleur
23a7491e12 NEW: Add option PDF_SHOW_EMAIL_AFTER_USER_CONTACT to show email after
specific assigned contact on PDF
2023-05-15 11:30:45 +02:00
Laurent Destailleur
5876e71072 NEW: Add option PDF_SHOW_PHONE_AFTER_USER_CONTACT to show phone after
specific assigned contact on PDF
2023-05-15 11:20:18 +02:00
Laurent Destailleur
2d17e77ff7 Fix warning 2023-05-01 17:29:54 +02:00
Laurent Destailleur
220d404d62 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-04-04 19:40:05 +02:00
Laurent Destailleur
53032fd6ed Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2023-04-01 15:09:30 +02:00
Laurent Destailleur
49eb6089df Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2023-04-01 15:03:21 +02:00
Laurent Destailleur
2ccbc1c2ce Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2023-04-01 15:02:19 +02:00
atm-lena
3fdec7cecf FIX - PDF Espadon => display extrafields 2023-03-31 15:36:16 +02:00
Laurent Destailleur
f1898e5ac0 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-03-31 02:54:22 +02:00
Laurent Destailleur
5b03337a00 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2023-03-31 02:17:37 +02:00
Laurent Destailleur
10f71216a4 Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2023-03-31 02:16:20 +02:00
stickler-ci
507abd4cc2 Fixing style errors. 2023-03-29 12:56:47 +00:00
atm-lena
0579c3f2f3 FIX PDF Espadon Expedition : notes and tracking number 2023-03-29 14:48:47 +02:00
Laurent Destailleur
0b4cacd291 Use dolChmod 2023-02-17 20:01:53 +01:00
Laurent Destailleur
80d46a22f1 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-18 21:36:57 +01:00
Laurent Destailleur
50db6de309 Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2023-01-18 00:20:53 +01:00
Florian HENRY
4fdf930269 make PDF custom volume work as it work on expedition/card.php 2023-01-12 12:49:45 +01:00
Laurent Destailleur
8ced29cb00 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-01-11 21:32:41 +01:00