MDW
d71cd352d5
Qual: Fix PhanUndeclaredMethod ( #30661 )
...
* Qual: Fix PhanUndeclaredMethod cases
* Fix PhanUndeclaredMethod cases
* Qual: Remove PhanUndeclaredMethod exceptions
* Fix spelling "disacard"
* Improve phpdoc, add abstract method to trait for typing
* Improve phpdoc typing for PHanUndeclaredMethod
* Suppress phan notices for guarded AliasNbPages calls
* Fix return value for printFile stub
* Fix getting message from Exception
* Define dummy getAllByProducts(), typing for it.
* Fix typo in comment
* Qual: Better typing for apiService (phan)
* Test that the Generic OAuth Service is provided
* Qual: Fix getSqlArrayForStats typing
* Force modTcpdfbarcode
* Correct typing hint
* Set ModelePDFAsset typehint
* Fix ModelePDFUserGroup typing hint
* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php
* Fix write_file in ModelePDFStock*
* Update printsheet.php
* Adjust typing hint for barcode generator
* Update printsheet.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-19 02:05:27 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
3d04a7195c
Qual: Updates regarding write_file(s) methods for Phan ( #30511 )
...
* Fix phpdoc for phpstan
* Add abstract write_file to ModelePDFContract
And update phpdoc for derived classes
* Fix typing for php_standard_actions writefile
* Improve phpdoc for write_files (& related)
* Add abstract write_file to ModelePDFBom
* Add abstract write_file to ModelePDFDeliveryOrder
* Add abstract write_file to ModeleExpenseReport
* Add abstract write_file to ModelePDFFicheinter
* Add abstract write_file to ModelePDFEvaluation
* Add abstract write_file to ModelePDFFactures
* Add abstract write_file to ModelePDFSuppliersInvoices
* Update ModelePDFProjects and ModelePDFTask related classes
* Qual: Add abstract write_file to ModelePdfExpedition
And update phpdoc for derived classes
* Qual: Correct reference (doc) to ModelePDFEvaluation
* Qual: Add abstract write_file to ModelePDFKnowledgeRecord
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFMo & ModelePDFMouvement
And update phpdoc for derived classes
* Qual: Set typehint to ModelePDFFicheinter
* Qual: Add abstract write_file to ModelePDFCommandes
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFPropales
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePdfReception
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersOrders
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersOrders
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersPayments
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSupplierProposal
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFWorkstation
And update phpdoc for derived classes
* Set typing for doc generator (commonobject)
* Improve typing for write_file
* Set typing for doc generator
* Qual: Add abstract write_file to ModelePDFMember
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFProduct
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFProductBatch
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFRecruitmentJobPosition
And update phpdoc for derived classes
* Add abstract write_file to ModelePDFTicket
* Add abstract write_file to ModelePDFUser
* Add abstract write_file to ModelePDFUserGroup
* Add abstract write_file to ModeleThirdPartyDoc
* Add abstract write_file to ModelePDFAsset
* Find all incompatible classes
* Qual: update phan baseline
* Set typing for doc generator (commonobject)
* Qual: update phan baseline
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-14 19:21:10 +02:00
MDW
8b71242997
Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests ( #30544 )
...
* Remove PhanPluginDuplicateExpressionAssignmentOperation from baseline
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* fixup! Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 02:53:45 +02:00
Laurent Destailleur
871e01d955
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 14:32:55 +02:00
Laurent Destailleur
09eaf38bd1
Fix phpstan
2024-07-31 14:31:29 +02:00
Laurent Destailleur
d2bd6a03ec
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-31 13:21:02 +02:00
Laurent Destailleur
2f7a252244
Fix warnings
2024-07-31 13:09:10 +02:00
Laurent Destailleur
038ce032e0
Fix tooltip on numbering modules
2024-07-31 12:40:24 +02:00
Laurent Destailleur
a701f84543
Fix tooltip on numbering modules
2024-07-31 12:14:39 +02:00
Frédéric FRANCE
2707475a12
fix phpstan ( #30319 )
...
* fix phpstan
* fix phpstan expects int, false given ...
* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Frédéric FRANCE
ea416aac93
replace old syntax, rename pdf models with same class name ( #30271 )
...
* replace old syntax
* replace old syntax
* replace old syntax
* replace old syntax
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* rename files with same class name
* fix class with same name
* fix class with same name
* clean code
2024-07-06 02:59:40 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Laurent Destailleur
82908a30eb
Clean phan warnings
2024-05-30 13:37:17 +02:00
Frédéric FRANCE
5b349cc318
clean code pdf ( #29399 )
2024-04-20 22:36:54 +01:00
MDW
6944e71ec2
Fix typing with phpdoc
2024-03-22 09:51:58 +01:00
MDW
378c98cac6
Fix typing with phpdoc
2024-03-22 09:51:56 +01:00
MDW
0f8b9e73f0
Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
...
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
MDW
edaad7eb62
Fix PhanPluginRedundantAssignment
2024-03-13 01:04:04 +01:00
MDW
b1b49b48c4
Fix PhanPluginRedundantAssignment
2024-03-13 01:04:03 +01:00
Frédéric France
16f161e263
clean
2024-03-12 08:06:42 +01:00
Frédéric France
23ae21958b
clean code and phpdoc
2024-03-11 20:57:48 +01:00
Frédéric France
7bcb635a4e
clean code and phpdoc
2024-03-11 18:13:48 +01:00
MDW
0b19aa415c
Fix: Initialise array before assigning values ( #28728 )
...
* Qual: Enable PhanUndeclaredVariableDim
# Qual: Enable PhanUndeclaredVariableDim
The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Fix: initialise array before adding fields
* Qual: Add type hint to array to avoid phan notification
* Qual: Add type hint to array to avoid phan notification
* Qual: Enable PhanParamSpecial1 (all resolved)
* Qual: Ignore false PhanTypeArraySuspiciousNullable
* Qual: Improve typing to fix PhanTypeArraySuspicious
* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array
* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Fix PhanTypeComparisonToArray with enhanced typing
* Qual: Enable phan messages that no longer appear
* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
MDW
8655d5a86b
QUAL Use phan to help detect new issues ( #27706 )
...
* Qual: Add phan flow
- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.
* Add directives to ignore false phan notices
* Qual: Add typing hints for extrafields TPL files
# Qual: Add typing hints for extrafields TPL files
Add typing hints for phan on view files
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-02-21 18:14:29 +01:00
Laurent Destailleur
e9a0905fba
Use same return
2024-02-13 11:14:11 +01:00
MDW
7b54824d49
Fix #28071 - New branch to fix bad merge ( #28083 )
...
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Qual: Introduce getDataToShowPhoto to prepare generic code
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix missing trans
* Fix langs
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Remove useless files in web templates
* Clean code
* Fix duplicate translation key
* Fix duplicate translation key
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix duplicate key
* Fix $object
* Debug v19
* WIP SMSing
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* WIP EMAILINGS_SUPPORT_ALSO_SMS
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* WIP SMSing
* Debug the "validate" feature
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Clean code
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Move rights->x->y into hasRight('x', 'y')
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Enhance rector to fix empty($user->rights->modulex->perm1)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
* Fix template to use v19 dev rules
* Fix use v19 dev rules
* Fix phpunit
* Debug v19
* Clean code
* Use rector to convert user->rights into user->hasRight
* Clean code
* Use rector to convert user->rights into user->hasRight
* Use rector to convert user->rights into user->hasRight
* Clean code
* Fix phpcs
* add editorconfig for sql files (#27999 )
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
* add model_pdf field in llx_ticket-ticket.sql (#27996 )
* add model_pdf field in llx_ticket-ticket.sql
* Update 19.0.0-20.0.0.sql
* Update 19.0.0-20.0.0.sql
* Improve wording in README (#27994 )
* fix phpstan (#27989 )
* fix phpstan
* Update UserRightsToFunction.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
* Qual: Fix spelling/working in datapolicy translations (#28006 )
# Qual: Fix spelling/wording in datapolicy translations
Fixed some spelling and wording in datapolicy translations.
* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986 )
htdocs/ticket/class/ticketstats.class.php 98 Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
* Fix user with readonly perm on email template must be able to read.
* Fix doc
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Better message
* Add missing fields in merge of thirdparty
* Debug v19 selection of ticket printer per terminal
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
* Use constant
* NEW: Adding a recipient on emails sent, change status to sent partialy.
* fix travis (#28052 )
* fix travis
* Update partnership.class.php
* fix php doc (#28047 )
* fix undefined array key (#28048 )
* Add region and departament for Cuba (#28046 )
* Update llx_10_c_regions.sql
Add Cuba Regions (id_country=77)
* Update llx_20_c_departements.sql
Add Provinces Cuba (id country=77)
* Find the typo (#28050 )
* Find the typo
* clean code
* add last_main_doc field to product (#28045 )
* add las_main_doc field to product
* add field fetch
* NEW Add Categorie filter for ActionComm (#28041 )
* New Add Categorie filter for ActionComm
New Add Categorie filter for ActionComm
* Fix space errors
Fix space errors
* Fix space errors 2
Fix space errors 2
* Update cunits.class.php (#28056 )
FIX: error SQL when creating a Cunit
* Update codespell-lines-ignore.txt to avoid PR merge conflict
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
Co-authored-by: thibdrev <thibault.drevet@gmail.com >
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com >
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com >
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com >
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com >
2024-02-09 15:58:49 +01:00
MDW
89004f7e03
Qual: Spelling htdocs/core ( #27491 )
...
Highlights:
- initialY in pdf_standard.modules.php was unused
- remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
39769482b1
Qual: Fix typing hints for DoliDB ( #27484 )
...
# Qual: Fix typing hints for DoliDB
This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Charlène Benke
00110f11c9
Update mod_delivery_jade.php
2023-12-30 08:15:32 +01:00
Laurent Destailleur
fb083a6cfc
Fix warning with rector
2023-12-13 16:33:17 +01:00
Laurent Destailleur
9e1b90e4a1
Fix with php-cs-fixer
2023-12-04 12:07:31 +01:00
Laurent Destailleur
240869f2f2
Fix warnings
2023-11-30 21:45:58 +01:00
Laurent Destailleur
53dab922fd
Fix php8.2 warnings
2023-11-27 11:39:32 +01:00
Frédéric FRANCE
010c2dd4be
fix phpstan ( #26812 )
...
* fix phpstan
* Update pdf_storm.modules.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2023-11-23 17:09:36 +01:00
Laurent Destailleur
1f38e54e78
Clean code
2023-10-15 15:32:35 +02:00
Laurent Destailleur
b546e7c624
css
2023-09-10 20:24:58 +02:00
Laurent Destailleur
707d853e84
Clean code
2023-08-10 11:29:09 +02:00
Laurent Destailleur
08e428b46d
Fix missing param
2023-08-09 18:00:31 +02:00
Laurent Destailleur
15ddb9a3a8
Fix inherit of CommonNumRef
2023-08-09 17:35:35 +02:00
Laurent Destailleur
db2a70b86a
NEW Factorize a lot of code for numbering modules
2023-08-09 14:50:28 +02:00
Laurent Destailleur
da1d622f80
Fix warnings
2023-08-06 00:41:59 +02:00
Frédéric FRANCE
c61d96c98f
put phpmin info in one place
2023-05-31 09:31:22 +02:00
HENRY Florian
4f22b1b9b2
Merge branch 'develop' into dev_upgrade_default_pdf_models
2023-05-21 17:37:27 +02:00
Florian HENRY
93551c8e64
feat: Upgrade default PDF models to the 'new' ones (eproved since 4 dolibarr versions from now)
2023-05-05 12:43:09 +02:00
Laurent Destailleur
2d17e77ff7
Fix warning
2023-05-01 17:29:54 +02:00
Laurent Destailleur
0b4cacd291
Use dolChmod
2023-02-17 20:01:53 +01:00
Laurent Destailleur
57358b618b
Clean code
2022-12-31 17:08:10 +01:00
Laurent Destailleur
8dd332a606
Merge pull request #23245 from grandoc/new_branch_17_12_2022
...
update code toward php 8 compliance
2022-12-22 14:42:00 +01:00
Frédéric FRANCE
42cf7acfe5
doc translation
2022-12-21 17:26:16 +01:00