MDW
14d68131de
Qual: Fix phan notices (workstation)
2025-02-28 14:39:00 +01:00
MDW
78f5938485
Qual: Fix phan notices (resource+salary)
2025-02-14 01:42:25 +01:00
Laurent Destailleur (aka Eldy)
de321e8f01
Fix typo
2025-01-09 02:01:49 +01:00
Laurent Destailleur (aka Eldy)
c0250e4c91
FIX CVE-2024-55227 CSRF when MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
...
on (hidden option not on by default)
2025-01-08 17:41:45 +01:00
Frédéric FRANCE
13b8f5feff
keep only commonobject property oldcopy ( #32123 )
...
* clean properties
* clean properties
* clean properties
* clean properties
* clean phpcs
* clean phan
* clean code
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-27 21:59:41 +01:00
iouston
7a84561bba
Fix issue n° 30845 - Resources not saved on new event creation ( #31889 )
...
* short_open_tag was always on No
* Fix Bug - Return an error if SOCIETE_EMAIL_UNIQUE = 1
if SOCIETE_EMAIL_UNIQUE is on 1, this form return an error because thirdparty already exist.
* fix issue n°31839
* fix wrong parameters
* fix issue n°30845
* Revert "fix issue n°30845"
This reverts commit cf88b7b236eldy@destailleur.fr >
2024-11-16 14:56:42 +01:00
MDW
278d301f32
Qual: Fix phan/phpstan notices in class files (part 6) ( #31634 )
...
* Qual: Fix notices for paymentdonation...workstationusergroup.class
* Qual: Fix PhanPluginRedundantReturnComment, update baseline
* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Frédéric FRANCE
24e7285539
fix CI ( #31692 )
...
* Update commonobjectline.class.php
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-05 15:33:09 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Frédéric FRANCE
17b1f13c11
fix phpstan ( #31584 )
...
* fix phpstan
* fix phpstan
2024-10-29 17:39:16 +01:00
Frédéric FRANCE
0bcb54fd7e
fix phpstan ( #31596 )
...
* fix phpstan
* fix phpstan
2024-10-28 00:50:51 +01:00
MDW
53cfbc35be
Qual: Fix several phan & stan notices ( #31308 )
...
* Qual: Fix several phan & stan notices
# Qual: Fix several phan & stan notices
Several fixes in files while fixing UnknownClass notices
* Qual: Update prepare_head PHPDoc return types
# Qual: Update prepare_head PHPDoc return types
Provide detailed array return types for prepare_head functions.
* Fix new phan notice
* Better loadLangs typing and fix call to loadLangs
* Fix new issues (stats)
* Other fixes of new issues
* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
MDW
1834c37c16
Qual: Fix phan notices ( #31212 )
...
* Qual: Fix phan notices
# Qual: Fix phan notices
Fix several phan notices related to classes with UnknownObject
classes.
* Qual: Fix phan notices
* Qual: Fix phan notices
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-10-03 19:40:34 +02:00
Laurent Destailleur
6b2fa56d52
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-10-01 15:01:18 +02:00
Laurent Destailleur
075d0dee3c
FIX Selection of country - state in resource
2024-10-01 14:27:45 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
a586e2c851
fix phpstan ( #31018 )
...
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-20 01:33:20 +02:00
Laurent Destailleur
26ba862540
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-14 02:45:04 +02:00
Laurent Destailleur
b66f7be923
Debug v20 - Fix td balance
2024-09-13 18:51:25 +02:00
Frédéric FRANCE
2a6bbf88df
fix phpstan ( #30944 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-13 17:40:03 +02:00
Laurent Destailleur
43f42d08ad
Fix warning
2024-09-06 14:01:55 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
5fcda2157e
Fix missing test on permissions
2024-09-01 14:32:49 +02:00
Laurent Destailleur
84ce31b8f8
Fix missing test on permissions
2024-09-01 14:04:10 +02:00
Laurent Destailleur
827c3daa03
Fix test on permissions
2024-08-31 19:15:14 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
HENRY Florian
d551f200f2
new: when initHook() and restrictedArea() exists always execute first initHook() ( #30703 )
2024-08-20 23:32:43 +02:00
Frédéric FRANCE
173dc1a70e
fix constructor expects int ( #30512 )
...
* constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
* fix constructor expects int
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-01 10:52:53 +02:00
Frédéric FRANCE
94feb2cfa7
fix phpstan expects values ( #30324 )
...
* fix phpstan expects values
* fix phpstan expects values
2024-07-09 19:28:59 +02:00
Laurent Destailleur
21e4c0e73c
Clean code
2024-07-03 18:35:19 +02:00
Alexandre SPANGARO
96afcaa476
Better comments ( #30200 )
...
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* Fix language
* CI Missing language key
* Update eventorganization.lang
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-30 21:02:50 +02:00
Frédéric FRANCE
6cfd7d16e6
fix phpstan check class case ( #30058 )
2024-06-18 15:48:18 +02:00
Frédéric FRANCE
efdc7f92b9
fix phpstan empty oldcopy is not falsy ( #30049 )
...
* fix phpstan empty olcopy is not falsy
* fix phpstan empty olcopy is not falsy
* remove code not used
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-06-17 13:22:20 +02:00
Laurent Destailleur
1d07e2a36b
css
2024-06-10 15:01:45 +02:00
Anthony Damhet
c604c005d3
Add llxHeader body css for resource ( #29924 )
2024-06-08 12:03:31 +02:00
Laurent Destailleur
796440459d
Debug v20
2024-04-22 18:57:21 +02:00
MDW
04c3e80fc5
Fix typing
2024-03-29 18:26:48 +01:00
MDW
6690b03bdf
Fix arguments to dol_get_fiche_head
2024-03-27 10:23:05 +01:00
Laurent Destailleur
7b0177a84d
Move to getDolGlobalString
2024-03-22 00:37:56 +01:00
MDW
aeefca7e7e
Fix $arrayfields typing lost by dol_sort_array() by forcing the type
2024-03-20 23:29:48 +01:00
MDW
8602ca9885
Fix: implode->join and duplicated if condition ( #28761 )
...
* Fix: join->implode
# Fix: join->implode
Update new cases of join
* Fix: Duplicate if condition in if/else sequence
# Fix: Duplicate if condition in if/else sequence
Fixed repeated if condition and action
2024-03-11 12:55:55 +01:00
Laurent Destailleur
f32bf4b3a7
Fix join -> implode
2024-03-11 12:38:21 +01:00
Laurent Destailleur
0887664888
NEW: All fetchAll() method now support the USF syntax.
2024-03-11 11:23:34 +01:00
William Mead
3583c4aeea
NEW updated resource list for new fields ( #28705 )
...
* Added address, zip & town
* Added state & country
* Added phone, email, max_users & url
* Added link formatting. Cleaned code.
* Updated EN & FR localization
* Added country select list
* Cleaned code
2024-03-08 12:09:32 +01:00
Laurent Destailleur
a63d7e0802
Fix regression
2024-03-07 19:06:08 +01:00
Laurent Destailleur
e6b2756c19
QUAL The signature for all ->delete() method has been modified to match
...
the modulebuilder template (so first param is now always $user), except
the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
2024-03-07 17:58:02 +01:00
William Mead
f1c7b5729f
Fix resource list ( #28661 )
...
* Move sql SELECT request to list
* Refactored list. Added mass actions. Added contributor details.
* Added dolresource delete
* Cleaned code
2024-03-07 17:01:36 +01:00
Laurent Destailleur
c544efec7f
QUAL: Remove use of customurl filter. Must use the USF syntax.
2024-03-05 03:51:36 +01:00
Laurent Destailleur
04c560faa4
Fix warning
2024-03-01 01:52:40 +01:00
