MDW
469ced0a8d
Qual: Fix phan notices (ticket,variants,webhook)
2025-02-20 10:29:39 +01:00
Frédéric France
ed3f115a1e
remove duplicate code
2025-02-18 20:16:00 +01:00
MDW
24fa28dfe2
Qual: Fix getKanban phpdoc
...
# Qual: Fix getKanban phpdoc
Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Laurent Destailleur (aka Eldy)
732f97d73c
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2025-02-05 00:40:06 +01:00
Laurent Destailleur
adae4f0fb3
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-01-27 01:37:52 +01:00
Laurent Destailleur
940e42c1e4
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-01-27 01:30:34 +01:00
Regis Houssin
6ae1c60097
FIX sql error with the new sql forge filter
2025-01-25 07:50:24 +01:00
MDW
133c67510c
Qual: Fix phpstan, remove useless test that price_var_percent is array
2025-01-20 16:47:29 +01:00
Laurent Destailleur (aka Eldy)
fa9fe2efa7
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-01-20 15:02:37 +01:00
Laurent Destailleur (aka Eldy)
c9ab22782e
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2025-01-20 14:57:45 +01:00
Laurent Destailleur (aka Eldy)
1f360ca498
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2025-01-20 12:28:49 +01:00
Laurent Destailleur (aka Eldy)
3ab49cf061
Debug v21 - Standardize code and translation of RefExt
2025-01-12 18:08:25 +01:00
Marc de Lima Lucio
ef564caf28
FIX: qual
2025-01-07 17:37:30 +01:00
Marc de Lima Lucio
3ef6299c83
FIX: phpcs
2025-01-07 17:20:57 +01:00
Marc de Lima Lucio
ec58ee940a
FIX: product variants copy: also copy multiprice variations
2025-01-07 17:09:48 +01:00
Laurent Destailleur (aka Eldy)
1d194efc3d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0
2025-01-05 18:43:15 +01:00
Regis Houssin
367173a4d1
FIX clean unique extrafields when create product combination
2025-01-04 08:20:18 +01:00
Laurent Destailleur (aka Eldy)
81e64ed9a4
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-12-17 16:59:13 +01:00
Laurent Destailleur (aka Eldy)
91eb9fc9fb
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-12-17 16:54:55 +01:00
Frédéric France
e24ad829f3
fix getPositionOfAttribute
2024-12-14 13:59:56 +01:00
Florian HENRY
f8bd644b58
fix: Variant with multiprice, on creation of variant, percent variation is not save
2024-12-09 17:41:56 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Frédéric FRANCE
1b6ee9e654
fix phpdoc ( #32097 )
...
* fix phpdoc
* Update accountancycategory.class.php
* fix phpstan
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-28 11:15:56 +01:00
Frédéric FRANCE
ec91ed2af9
test action ( #31815 )
...
* NEW : Add category feature on Fichinter
category update
* Update viewcat.php
* Update categories.lang
* Update categorie.class.php
* Update categories.lang
* Update viewcat.php
* Update viewcat.php
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* clean baseline
Debug v21
NEW: use Expedition::$date_shipping property in card and list (#31701 )
* NEW: use Expedition::$date_shipping property in card and list
* FIX: translation
* FIX: PHPStan rebutal
* FIX: not a great idea to copy and not edit comment
* FIX: on create, expected delivery date should precede sending date
* Update card.php
* Update list.php
* Update list.php
* Update list.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
clean baseline
clean baseline
clean baseline
* clean baseline
* clean baseline
* merge
* fix
* fix
* fix
* fix
* fix
* fix
* fix translations
* fix translations
* fix translations
* fix translations
* fix
* fix filters
* fix filters
* fix filters
* fix filters
* fix
---------
Co-authored-by: Charlène Benke <1179011+defrance@users.noreply.github.com >
2024-11-15 14:09:04 +01:00
Frédéric FRANCE
92ef950e6d
fix phpstan ( #31761 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* hide new error with phpstan 1.12.9
2024-11-10 23:47:14 +01:00
Laurent Destailleur
7e8fff6cb0
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-11-10 18:28:05 +01:00
Francis Appels
e17eafacb2
FIX select variant by attribute. ( #31759 )
...
DISTINCT needs order field in select.
Solved by removing DISTINCT
2024-11-10 18:15:04 +01:00
Laurent Destailleur
31f147622a
The deprecated GET parameter "&sall=" has been removed, use now the
...
"&search_all=".
2024-11-07 12:26:42 +01:00
MDW
278d301f32
Qual: Fix phan/phpstan notices in class files (part 6) ( #31634 )
...
* Qual: Fix notices for paymentdonation...workstationusergroup.class
* Qual: Fix PhanPluginRedundantReturnComment, update baseline
* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Frédéric FRANCE
6dd6ab7906
fix phpstan ( #31614 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-10-29 17:40:56 +01:00
Frédéric FRANCE
a6d17f7397
add extrafields count in variants setup ( #31388 )
2024-10-15 16:40:20 +02:00
Frédéric FRANCE
0b1d243a7a
add translations count ( #31398 )
2024-10-15 15:39:29 +02:00
Laurent Destailleur
10c58950bb
Look and feel v21
2024-10-15 10:16:48 +02:00
Laurent Destailleur
046166f483
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-10-14 21:38:12 +02:00
Laurent Destailleur
916014707d
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0
2024-10-14 21:18:24 +02:00
Frédéric FRANCE
820333b02f
fix variants sql init ( #31319 )
...
* fix variants sql init
* add setup
* add setup
* add setup
* update class
* update list
* update list
* update list
* update class
* fix typos
* fix translations
* fix html
* fix update
* fix sql
* fix extrafields
* fix extrafields
2024-10-13 21:08:55 +02:00
Frédéric FRANCE
20a2f546e6
add nodrag nodrop ( #31218 )
2024-10-03 19:37:25 +02:00
Frédéric FRANCE
7d36fe0715
fix typo phan and Co 💊 ( #31214 )
...
* fix typo
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* translation missing
* test win mariadb version
* test win mariadb version
* phpdoc
* phpdoc
* phpdoc
2024-10-03 15:43:04 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
MDW
c62e015410
Qual: Fix (propal|facture|contrat|fichinter)/card, commonobject, files.lib/card_presend.tpl ( #31087 )
...
# Qual: Fix (propal|facture|contrat|fichinter)/card, commonobject, files.lib/card_presend.tpl
Fix phan notices in these files
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-26 23:01:02 +02:00
Laurent Destailleur
b32225283d
Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop
2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3
FIX Duplicate trigger printFieldPreListTitle
2024-09-25 13:43:11 +02:00
Frédéric FRANCE
000173c7b9
fix phpstan ( #31075 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-23 01:59:14 +02:00
MDW
7b4c4d772c
Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related ( #31086 )
...
* Qual: Fix Array of tabs typing hints
# Qual: Fix Array of tabs typing hints
Fixed same typing hints accross several files
* Qual: Fix pdf.lib.php, project.lib.php and related files
# Qual: Fix pdf.lib.php, project.lib.php and related files
Fix most phan notices for pdf.lib.php and project.lib.php.
And fixed some items in other files in the process
* Qual: Fix notifications commande/card advtarget.tpl fichinter/card societe/card supplier_proposal/card
* Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related
# Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related
Fix notices in the files for the classes above and other files to accomodate
these changes/fixes
2024-09-23 00:37:30 +02:00
MDW
9a9e851494
Qual: Fix new UndeclaredGlobalVariable notices & enable ( #30963 )
...
* Qual: 🛟 Fix typing
Qual: Fix typing
Fix some typing currently failing ci in develop.
* Fix typing for grabimages
* Qual: Fix new UndeclaredGlobalVariable notices & enable
# Qual: Fix new UndeclaredGlobalVariable notices & enable
This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).
This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
fef73cc6e0
Fix remove not used code
2024-09-01 14:47:31 +02:00
Laurent Destailleur
e3c9f1db7c
Standardize name of var for permission check
2024-09-01 13:02:28 +02:00
Laurent Destailleur
95f86172d2
Fix CTI error
2024-08-31 19:46:00 +02:00
