Commit Graph

4316 Commits

Author SHA1 Message Date
Vincent de Grandpré
869ee70c44 FIX#29901 blocking tasktimesel for nonbillabletime with dblclick enabling option (#32023)
* FIX#29901 - Disable task checkbox in list with enable option on dbl-click when aligned in left column ans task not billable

* typo

* Managing $invoiced variable for phpstan

* pre-commit hook correct.

* phpcs

* Update time.php

* Update time.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-21 19:11:58 +01:00
Laurent Destailleur
4bc1eebcb5 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-11-21 12:47:48 +01:00
Nicolas Domenech
cc0db78984 FIX #32007 missing parameter on function multiSelectArrayWithCheckbox (#32008) 2024-11-21 08:48:55 +01:00
Nicolas Domenech
de8d705eeb fix: missing hook printFieldListOption (#32006) 2024-11-20 21:25:47 +01:00
Frédéric FRANCE
c51011b8d1 fix CI phpstan (#32001)
* Update project.class.php

* Update assetmodel.class.php

* Update assetmodel.class.php

* test

* Update assetmodel.class.php

* Update assetmodel.class.php

* Update assetmodel.class.php

* Update assetmodel.class.php

* Update project.class.php

* Update project.class.php
2024-11-19 15:40:37 +01:00
Laurent Destailleur
1a75883124 Try to fix phpstan 2024-11-19 12:18:47 +01:00
Laurent Destailleur
1386d8c388 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-11-19 04:21:29 +01:00
Laurent Destailleur
e9e1175134 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-11-19 04:04:10 +01:00
Laurent Destailleur
93b11038d5 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-11-19 03:44:50 +01:00
uvaldenaire-opendsi
98d106e6b5 Fix delete project when mrp module never enabled (#31982)
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
2024-11-18 14:55:20 +01:00
Frédéric FRANCE
e0562817d6 fix usf filters (#31897) 2024-11-15 23:45:24 +01:00
Frédéric FRANCE
cb7d4d1ad5 clean phpstan baseline (#31921)
* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline
2024-11-15 22:57:43 +01:00
Frédéric FRANCE
ec91ed2af9 test action (#31815)
* NEW : Add category feature on Fichinter

category update

* Update viewcat.php

* Update categories.lang

* Update categorie.class.php

* Update categories.lang

* Update viewcat.php

* Update viewcat.php

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* clean baseline

Debug v21

NEW: use Expedition::$date_shipping property in card and list (#31701)

* NEW: use Expedition::$date_shipping property in card and list

* FIX: translation

* FIX: PHPStan rebutal

* FIX: not a great idea to copy and not edit comment

* FIX: on create, expected delivery date should precede sending date

* Update card.php

* Update list.php

* Update list.php

* Update list.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

clean baseline

clean baseline

clean baseline

* clean baseline

* clean baseline

* merge

* fix

* fix

* fix

* fix

* fix

* fix

* fix translations

* fix translations

* fix translations

* fix translations

* fix

* fix filters

* fix filters

* fix filters

* fix filters

* fix

---------

Co-authored-by: Charlène Benke <1179011+defrance@users.noreply.github.com>
2024-11-15 14:09:04 +01:00
lvessiller-opendsi
dccde49388 FIX calculate start date of cloned task from cloned project (#31799)
* FIX calculate start date of cloned task from cloned project

* Fix wrong strat comment
2024-11-13 21:31:22 +01:00
MDW
9ec4618199 Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Frédéric FRANCE
15490b292f fix phpstan and fix CI (#31739)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-11-10 11:16:23 +01:00
Frédéric FRANCE
5cf3074d28 clean phpstan baseline (#31725)
* clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

* fix and clean phpstan baseline

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-08 14:41:01 +01:00
Laurent Destailleur
feeda29328 Fix phan 2024-11-07 15:08:44 +01:00
Laurent Destailleur
31f147622a The deprecated GET parameter "&sall=" has been removed, use now the
"&search_all=".
2024-11-07 12:26:42 +01:00
MDW
278d301f32 Qual: Fix phan/phpstan notices in class files (part 6) (#31634)
* Qual: Fix notices for paymentdonation...workstationusergroup.class

* Qual: Fix PhanPluginRedundantReturnComment, update baseline

* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Frédéric FRANCE
0d7bc505d3 add phpdoc and clean phpstan baseline (#31702)
* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline
2024-11-06 19:39:46 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
MDW
f4ff437026 Qual: Fix phan/phpstan notices in class files (part 4) (#31598)
* Qual: Fix phan notices for DolibarrModules.class

* Qual: Fix notices for classes actioncomm..task.class.php

* fixup! Qual: Fix notices for classes actioncomm..task.class.php

* Qual: Fix new notices blocking PR
2024-10-30 21:33:30 +01:00
Frédéric FRANCE
6dd6ab7906 fix phpstan (#31614)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-10-29 17:40:56 +01:00
Laurent Destailleur
e6f1d4835f Clean sql code 2024-10-29 02:58:20 +01:00
Frédéric FRANCE
0f563edb5f replace fetch_projet() and fetch_project() by fetchProject() (#29821)
* fix cti

* fix cti

* deprecate fetch_projet fetch_project to fetchProject

* deprecate fetch_projet fetch_project to fetchProject

* deprecate fetch_projet fetch_project to fetchProject

* odfHandler->setSegment only throw OdfExceptionSegmentNotFound

* odfHandler->setSegment only throw OdfExceptionSegmentNotFound

* fix deprecated

* fix

* fix sql
2024-10-26 22:43:44 +02:00
Laurent Destailleur
f5e4ab0220 Rewrite code to prepare refactoring 2024-10-26 15:24:54 +02:00
Lucas Marcouiller
9e4fe0afbe NEW show holidays at bottom of activity/permonth.php page (#31550)
* New add holidays in activity/permonth.php page

* change var name

---------

Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-10-25 14:22:30 +02:00
MDW
0d2f1cf666 Qual: Fix phpstan notices (int expected) (#31485)
# Qual: Fix phpstan notices (int expected)

Fix several notices where int was expected (casting/phpdoc/GETPOSTINT).
Separate phpstan exceptions for methods containing 'pdf' from
other methods/functions.
2024-10-24 14:01:30 +02:00
Lucas Marcouiller
dad1634994 New add link to smaller period of time in some project activity pages (#31506)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-10-23 23:07:37 +02:00
Laurent Destailleur
86d3352332 Fix delete project when mrp module never enabled 2024-10-18 23:23:03 +02:00
Laurent Destailleur
dd680a85fd Fix delete project when mrp module never enabled 2024-10-18 23:14:31 +02:00
IC-Victorien
c789c4fc42 NEW Projet - Add hook formconfirm (#31408)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-17 02:21:38 +02:00
MDW
53cfbc35be Qual: Fix several phan & stan notices (#31308)
* Qual: Fix several phan & stan notices

# Qual: Fix several phan & stan notices

Several fixes in files while fixing UnknownClass notices

* Qual: Update prepare_head PHPDoc return types

# Qual: Update prepare_head PHPDoc return types

Provide detailed array return types for prepare_head functions.

* Fix new phan notice

* Better loadLangs typing and fix call to loadLangs

* Fix new issues (stats)

* Other fixes of new issues

* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
Laurent Destailleur
a255e9b5c8 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-10-13 20:58:40 +02:00
MDW
611019ec4d Qual: Fix WARNING messages in syslog - add getCallerInfoString() (#31351)
* Qual: Fix dolIsTms() call with empty string

# Qual: Fix dolIsTms() call with empty string

The dolibarr log indicated that dolIsTms() was called with the
empty string:

- Add code to log the caller in the log;
- Fix the dolIsTms() calls by updating project/element.php

* Fix comparison of ''<0

# Fix comparison of ''<0

As ''<0 is true, non-existing errors were added resulting in
Try to add a message in stack, but value to add is empty message
in the log.
2024-10-13 17:17:37 +02:00
HENRY Florian
add1b28a76 fix: when tobill field is displayes SQL Error (#31358) 2024-10-11 16:02:48 +02:00
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
34e3717dda Qual: Fix phan/phpstan notices (#31289)
* Qual: Fix phan/phpstan notices

# Qual: Fix phan/phpstan notices

Fix several phan/phpstan notices

* Fix spelling in Changelog
2024-10-06 13:03:43 +02:00
Laurent Destailleur
d24069d5e2 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 20:35:33 +02:00
MDW
2d0b1de36f Qual: Add codespell entries to catch some css typos (#31222)
# Qual: Add codespell entries to catch some css typos

Added some codespell entries based on the observed typos in css
tags
2024-10-03 19:36:59 +02:00
Laurent Destailleur
e412dbbe05 Merge manually fix of #31217 + other fix for use by external modules 2024-10-03 19:30:06 +02:00
Laurent Destailleur
d7d8f87045 Clean code. Add permission test after action = something. 2024-09-30 11:38:29 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
741cca5eb4 fix phpstan (#31184)
* fix phpstan

* fix phpstan
2024-09-29 13:07:40 +02:00
Laurent Destailleur
3aa9f5df61 Fix phan 2024-09-26 03:02:08 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
Laurent Destailleur
ae6e35cc84 Look and feel v21 enhancement on smartphone 2024-09-25 02:35:56 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00