Noé Cendrier
22729516fe
NEW Add mode Customer price + level price ( #31091 )
...
* NEW: customer price and level price together
* NEW: translation
* FIX: If a price per customer exist
* FIX: do not use default price if the customer price and level price option is active
* Don't display the price level amount if the customer price is known
* FIX: double check and php cs correction
* FIX: vatrate call
* FIX: get_htmloutput_msg call
---------
Co-authored-by: Mélina JOUM <melina.joum@altairis.fr >
2024-09-25 23:18:16 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Lucas Marcouiller
03a1f0fcf8
New add post protection in company/new.php ( #31059 )
...
* New add post protection in company/new.php
* fix CI
* Update new.php
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-23 03:22:42 +02:00
Lucas Marcouiller
23b3b07526
New add ip field on recurtementcandidature and societe ( #31045 )
...
* New add ip field on recurtementcandidature and societe
* fix CI
* fix CI
---------
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
2024-09-20 00:22:42 +02:00
John BOTELLA
308178d5bc
QUAL : Ergo btn and fix ( #30947 )
...
* Clean sql
* Doc
* Fix ergo feedback and accessibility button
* Add hsl color var to allow css use user color with variants
* Add hsl color var to allow css use user color with variants
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-13 17:30:41 +02:00
MDW
76eaf8bd8d
Qual: Fix phan notices in classes related to class using getNextValue. ( #30925 )
...
* FIX 🛟 phan
* getToolTip() can take null for $coc
* Fix uninitialized vars & arg types
* PHPDoc typing, argument fixes
* PHPDoc typing, argument fixes for AdherentType
* PHPDoc typing, argument fixes for AdherentStats
* Update baseline to enable adherent notices
* Fix PHPDoc typing in api_members
* Minor bug fixes, typing
* PHPDoc api_subscriptions
* PHPDoc Societe
* Ignore empty foreach notice
* Add initialiser
* Categorie is string, old int mode is deprecated
* Fix missing initialisations
* Fix missing initialisations adherents/note
* Fix typing (cast), initialisation of var
* Fix initialisations
* Fix argument types
* Improve array PHPDoc type
* PHPDoc array type
* PHPDoc: Improve typing
* Correct argument type to getNomUrl
* Improve typing for timespent
* Fix typing for getNextValue args
* Improve typing
* Fix typing hints contrat/card
* Update baseline
* Fix typing
* Fix extraparams property typing
* Fix argument typing
* Qual: Correct covariant type
* Impove typing for timespent
* Remove exclusion no longer matched (level 6)
---------
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com >
2024-09-12 21:16:42 +02:00
Laurent Destailleur
e4227c6913
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-12 16:30:57 +02:00
Laurent Destailleur
94cdc284b3
Better log and fix search of contact for emailcollector
2024-09-12 12:32:33 +02:00
Frédéric FRANCE
d12fd8d175
fix phpstan ( #30869 )
...
* fix phpstan
* fix phpstan
2024-09-06 13:50:27 +02:00
Frédéric FRANCE
eb04c5c427
fix phpstan ( #30860 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-06 13:44:29 +02:00
Frédéric FRANCE
80d1f47d4d
fix ignored phpstan (most of expects string, int given) ( #30649 )
...
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* fix ignored phpstan
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* more ignore
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
eb30f2efa6
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-28 12:23:46 +02:00
Laurent Destailleur
85d2080081
Debug emailcollector - finding thirdparty
2024-08-28 12:21:39 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
Mohamed DAOUD
de420b30ef
fix contacts default roles ( #30700 )
2024-08-21 00:24:07 +02:00
ptibogxiv
465b7dc2c6
Update api_contacts.class.php with pagination ( #30679 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-20 10:18:06 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
Laurent Destailleur
2c86c9b21b
Clean code to swith to code_compta_client
2024-08-14 16:51:53 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
thibdrev
e5c0150be4
qual: avoid double negations by introducing getDolGlobalBool() ( #30618 )
...
* Update index.php
* Update api.class.php
* Update pdf_eratosthene.modules.php
* Update pdf_sponge.modules.php
* Update pdf_cyan.modules.php
* Update partnershiputils.class.php
* Update paypalfunctions.lib.php
* Update societe.class.php
* Update functions.lib.php - create getDolGlobalBool()
* Update index.php
* Update api.class.php
* Update pdf_eratosthene.modules.php
* Update pdf_sponge.modules.php
* Update pdf_cyan.modules.php
* Update partnershiputils.class.php
* Update paypalfunctions.lib.php
* Update societe.class.php
* Update functions.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-13 22:50:31 +02:00
Frédéric FRANCE
803c3c2f30
fix phpstan sendXXX expects int ( #30519 )
...
* fix sendXXX expects int
* fix sendEmailTo expects int
* fix regression
* fix loadxxx expects int
* fix loadxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
* fix getxxx expects int
2024-08-13 20:39:40 +02:00
Jon Bendtsen
8a35651b3f
NEW: Create thirdparty notification by action code ( #30541 )
...
* based on createCompanyNotification, just trying to do it with code and not id number
* can now create notifications by action trigger code
* will now prevent duplications
* checks if request_data contains event or fk_action key because then it uses that and not the action code supplied as text
* checks if request_data contains event or fk_action key because then it uses that and not the action code supplied as text
* now requires a well formed request_data with an event key
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-08-11 00:20:45 +02:00
MDW
45ed4caeb2
Qual: Enable Phan Simplify rule and fix notices ( #30537 )
...
* Qual: Phan - Enable Simplyfy expression
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Qual: Simplify expression (phan notice)
* Update functions2.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-07 03:05:02 +02:00
Jon Bendtsen
7fe990e972
FIX api call Get Notifications to make output more in line with what post notifications expects as input. This also removes duplicated fields ( #30539 )
...
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-08-07 02:58:35 +02:00
Jon Bendtsen
a8d3586d4b
FIX api call Get Notifications to make output more in line with what post notifications expects as input. This also removes duplicated fields ( #30539 )
...
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
2024-08-07 02:58:05 +02:00
Laurent Destailleur
b3b21d56b6
Fix doxygen
2024-08-07 02:49:38 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
MDW
46eb5f83c2
Qual: Updates for phpstan notices ( #30509 )
...
* Fix int<0> typing to int<0,0> for phpstan
* Fix phpdoc for phpstan
* Fix phpdoc for phpstan
* Qual: Several phpstan notice fixes
* Fix phpdoc
* Qual: totalpaid is never null, remove null test
* improve phpdoc typing
* Also return null to statisfy phpstan
* Allow null value for $var
* object->Object to make it meaningful
* Type EvalMathStack properties
* Comment out unused private methods (phpstan)
* Changes for phpstan (return values, phpdoc, code)
* Change order of tests for phpstan
* phpdoc object to Object for correct typing
* Typing hing for phpstan
* UPdate test for phpstan
* Change phpdoc position for phpstan
* Update phpdoc for phpstan
This needs further improvement
* Change $op to $ope to fix phpstan
* Update sqlite3.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-01 12:59:45 +02:00
Sylvain Legrand
2c7dc2f28f
NEW option: assign default roles to "individual" third-party contacts ( #30499 )
...
* New option: assign default roles to "individual" third-party contacts
When the option to automatically create a contact for third parties of the "Individuals" type is active (THIRDPARTY_SUGGEST_ALSO_ADDRESS_CREATION).
Allow to define the default roles assigned to these contacts.
Process:
1 Selection of default roles in the settings (and saving)
2 Creation of a third party of the "Individuals" type and therefore of its associated contact.
3 The contact thus created is automatically assigned the predefined roles.
* Update societe.php
* Update societe.php
2024-07-31 15:32:07 +02:00
Laurent Destailleur
292080ca14
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-30 12:28:15 +02:00
Laurent Destailleur
4223c6241c
Fix tooltip
2024-07-30 11:52:40 +02:00
Mohamed DAOUD
4dca8eb7bf
add column to societe account table ( #30442 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-07-25 18:23:31 +02:00
Laurent Destailleur
7e0ab62486
Fix phan
2024-07-25 14:50:36 +02:00
Laurent Destailleur
cf631563f9
Look and feel v21
2024-07-24 16:07:15 +02:00
Rémi Champlon
d2907b68c0
NEW : Add pagination data to some api routes ( #29895 )
...
* Add pagination date
* Spaces to tabs
* fix
2024-07-06 15:04:11 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Frédéric FRANCE
4b275dc148
add phpdoc ( #30208 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* clean phpdoc
2024-06-30 19:39:01 +02:00
Frédéric FRANCE
3e750c2f0b
ignore more phan lines with phpstan ( #30135 )
...
* ignore more phan lines with phpstan
* fix
2024-06-23 17:46:34 +02:00
Laurent Destailleur
6a12de58ed
Introduce length of field in fields array
2024-06-23 13:24:26 +02:00
Frédéric FRANCE
0f1ae42691
fix phan ( #30113 )
...
* fix phan
* Update project.class.php
* Update project.class.php
* try to fix
* try to fix
* try to fix
* try to fix
* try to fix
2024-06-22 15:36:10 +02:00
Laurent Destailleur
a5621c83c2
Fix deprecated var
2024-06-20 20:11:50 +02:00
Laurent Destailleur
dc024a1f18
Debug v20
2024-05-30 14:43:16 +02:00
Laurent Destailleur
74c2d34e5d
Debug v20
2024-05-30 13:59:16 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Laurent Destailleur
93eded598e
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-05-03 18:24:03 +02:00
Laurent Destailleur
e9f7a1996f
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-05-03 18:18:39 +02:00
Laurent Destailleur
4fef808efa
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-05-03 18:16:58 +02:00
Florian Mortgat
cf6cbafa8c
FIX: PUT /thirdparties/{id} and PUT /contacts/{id} should throw exception if update returns < 0 ( #29596 )
...
+ FIX some PHPDoc (types and throws)
+ FIX issue #29594 : trigger should be called on contact update by API
2024-05-03 18:03:14 +02:00
Laurent Destailleur
642a3d5984
Fix regression
2024-05-03 01:28:19 +02:00
Laurent Destailleur
dc28879ffb
Fix warning
2024-05-01 18:34:38 +02:00
