Commit Graph

13621 Commits

Author SHA1 Message Date
Laurent Destailleur
eff2f4da7f Merge branch 'develop' into fix/phan/lowoccurrence2 2024-03-17 20:27:59 +01:00
Laurent Destailleur
b117d24cba Try to fix PhanUndeclaredFunctionInCallable 2024-03-17 20:26:05 +01:00
MDW
6148a0f7a3 fixup! Fix PhanUndeclaredFunctionInCallable by disabling notification in specific case 2024-03-17 20:12:55 +01:00
MDW
18cfd0dae6 Fix PhanTypeComparisonFromArray by testing $error field
# Fix PhanTypeComparisonFromArray by testing $error field

getListOfPayments always returns an array, comparing it to 0 is invalid.
To know if there was an error, we should test error, not the size of the result.
Updated getListOfPayments as well to initialize error to ""
2024-03-17 20:12:45 +01:00
MDW
78f2e8752e Fix PhanPluginUnsafeEval by ignoring notification 2024-03-17 20:12:33 +01:00
MDW
7d15cd3267 Fix PhanUndeclaredFunctionInCallable by disabling notification in specific case 2024-03-17 20:12:31 +01:00
MDW
c5f8cccb88 Fix/ignore PhanPluginPrintfVariableFormatString 2024-03-17 18:56:37 +01:00
Laurent Destailleur
a132f53311 Fix removed var_dump 2024-03-16 23:28:22 +01:00
Laurent Destailleur
d3262ace71 Fix phpunit error due to regression in removing the $conf 2024-03-16 23:22:12 +01:00
Laurent Destailleur
87388d7dab Debug v20 2024-03-16 21:33:55 +01:00
Laurent Destailleur
75fae0f27d Merge branch 'develop' into fix/PhanTypeMismatchReturn 2024-03-16 16:08:08 +01:00
Laurent Destailleur
a9f3cdf5d0 Merge pull request #28886 from mdeweerd/fix/deprecatedfunccall
Fix Deprecated Function Calls
2024-03-16 15:33:34 +01:00
MDW
4a343466aa Suppress PhanTypeMismatchReturnNullable notification
# Suppress PhanTypeMismatchReturnNullable notification

There is no "straightforward" way to avoid this notification, ignoring
it.
2024-03-16 13:53:04 +01:00
MDW
9eed23c6d0 Fix return type by cast or typing update
# Fix return type by cast or typing update

Fix most PhanTypeMismatchReturn notifications.

The remaining ones are likely real bugs or need more Dolibarr
knowledge to fix them efficiently
2024-03-16 13:52:12 +01:00
Laurent Destailleur
3d02ca0fdc Debug v20 2024-03-16 13:41:24 +01:00
MDW
13ab939691 Fix deprecated function calls 2024-03-16 13:27:51 +01:00
Laurent Destailleur
52dfeaaf8d Merge pull request #28894 from rycks/develop_natural_sort_list
natural sort of result
2024-03-16 12:30:13 +01:00
Laurent Destailleur
d686ce02d9 Merge pull request #28884 from lamrani002/addDelay
NEW animation for display spinner when waiting response
2024-03-16 12:12:33 +01:00
Laurent Destailleur
e9c4be9856 Merge pull request #28883 from lamrani002/getMsgInEditor
FIX problem for display content in editor
2024-03-16 11:49:00 +01:00
Laurent Destailleur
a247b474d7 Merge pull request #28885 from mdeweerd/fix/phan/low_occurrence
Fix some phan notifications with low occurrence
2024-03-16 11:48:10 +01:00
Eric Seigne
6a50978206 natural sort of result 2024-03-16 11:17:00 +01:00
Jon Bendtsen
2f7d6afc6e escaping type and reorder the field order to reduce line length 2024-03-16 10:57:53 +01:00
Jon Bendtsen
158622dfb9 looking in git blame it seems people insert this for far less changes 2024-03-16 10:08:19 +01:00
Jon Bendtsen
bc68755c40 creating notification in database 2024-03-16 09:45:55 +01:00
Lamrani Abdel
5422cbdfc2 remove variables withaiprompt 2024-03-16 01:07:17 +01:00
Lamrani Abdel
28e10cb999 Change icon spinner 2024-03-16 01:02:32 +01:00
Jon Bendtsen
e90d35870b there is no trigger available + indent fix 2024-03-16 00:15:40 +01:00
MDW
c9135d0c33 Fix: Main email configuration was not added to list 2024-03-16 00:00:19 +01:00
Jon Bendtsen
8d1d1666bf also based on update bank account 2024-03-15 23:51:57 +01:00
Jon Bendtsen
8625fc717d Merge branch 'develop' into new_thirdparty_notification_api 2024-03-15 22:05:51 +01:00
Jon Bendtsen
d28835ef7d adding 2 new notification triggers, Order and Invoice cancellation 2024-03-15 20:56:12 +01:00
Laurent Destailleur
5fadea4d0d NEW Support Reply-To tracking in emails sending (tickets only for the
moment)
2024-03-15 19:40:32 +01:00
Lamrani Abdel
7d49d0e20b NEW annimation for display spinner when waiting response 2024-03-15 18:05:32 +01:00
Lamrani Abdel
13e1209c01 FIX problem for display content in editor 2024-03-15 17:15:24 +01:00
Laurent Destailleur
799ccf1a2f Merge pull request #28708 from atm-john/fix_element_type_part_05
NEW : Factoring and Fix external module elementType limit - Part 05
2024-03-15 15:29:03 +01:00
Laurent Destailleur
b658beab99 Merge pull request #28872 from mdeweerd/fix/PhanTypeMismatchReturnProbablyReal
Fix & enable PhanTypeMismatchReturnProbablyReal
2024-03-15 15:24:31 +01:00
Laurent Destailleur
1a722fa436 Merge branch 'develop' into fix/PhanTypeMismatchPropertyProbablyReal 2024-03-15 15:07:35 +01:00
MDW
3b0e83c533 Fix PhanTypeMismatchReturnProbablyReal 2024-03-15 14:20:57 +01:00
evarisk-micka
d43c3227db Add signed status CRUD to contract and fichinter 2024-03-15 12:12:21 +01:00
Laurent Destailleur
066565938c Merge pull request #28812 from mdeweerd/fix/PhanTypeSuspiciousEcho
Fix & enable PhanTypeSuspiciousEcho
2024-03-15 11:02:33 +01:00
MDW
651b5a22eb Fix & enable PhanTypeSuspiciousEcho
# Fix & enable PhanTypeSuspiciousEcho

Fix occurences by improving typing - array key was not found and
supposed null in a print statement.

Example:
  PhanTypeSuspiciousEcho Suspicious argument $menu_array[$i]['prefix'] of type null for an echo/print statement

Enabled detection because all cases are fixed
2024-03-15 10:14:40 +01:00
MDW
6a606bf7c1 Adjust typing for 'origin' & 'origin_object' 2024-03-15 10:12:46 +01:00
MDW
b57b4c8f17 Qual: Improve typing hints, in particular sendtoid 2024-03-15 10:11:55 +01:00
MDW
3384a0b847 Fix & enable PhanUndeclaredTypeReturnType
# Fix & enable PhanUndeclaredTypeReturnType

One typo, and replace 'number' with int or int|float
2024-03-15 10:07:15 +01:00
Laurent Destailleur
80e2e59373 Merge pull request #28862 from mdeweerd/fix/PhanTypeMismatchPropertyDefault
Fix & enable PhanTypeMismatchPropertyDefault
2024-03-15 09:33:40 +01:00
Laurent Destailleur
e238cc204e Merge pull request #28750 from mdeweerd/fix/PhanPluginSuspiciousParamPosition
Fix: Resolve several PhanPluginSuspiciousParamPosition cases
2024-03-15 08:45:25 +01:00
Laurent Destailleur
1a63080e44 Merge branch 'develop' into fix/PhanTypeMismatchPropertyDefault 2024-03-15 08:41:23 +01:00
Laurent Destailleur
176d8173a6 Merge pull request #28861 from mdeweerd/fix/PhanPluginPHPDocInWrongComment
Fix & enable PhanPluginPHPDocInWrongComment
2024-03-15 08:28:47 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
1e5dd2f209 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:48:11 +01:00