* FIX: Issue #37425 filling of field amount_main_currency for foreign money accounts
The parameter amount_main_currency (argument #13 of addline()) was previously
filled even when the bank account was already using the company main currency.
This caused the field amount_main_currency to be populated incorrectly for
transactions that were not foreign currency operations.
The logic has been updated so that amount_main_currency is only filled when the
transaction involves a foreign currency account. For accounts already using the
company main currency, the value is now left NULL as expected.
This aligns the behavior with the intended usage of addline() and prevents
incorrect data in bank transaction records.
(cherry picked from commit cdc36551d9)
* FIX: Issue #37425 filling of field amount_main_currency for foreign money accounts
transfer.php: PhanTypeMismatchArgument: Argument 4 ($amount) is price2num((-1 * (float)($amount[$n]))) of type string but \Account::addline() takes float defined at htdocs/compta/bank/class/account.class.php:611
CI-PULL-REQUEST / phan / Run phan
Check warning on line R189
Check warning:
transfer.php: PhanTypeMismatchArgument: Argument 13 ($amount_main_currency) is $amount_main_currency_from of type ?string but \Account::addline() takes ?float defined at htdocs/compta/bank/class/account.class.php:611
CI-PULL-REQUEST / phan / Run phan
(cherry picked from commit b8f222c3d9)
* declare dateo
(cherry picked from commit 1401f74969)
* declare of variables before action script
(cherry picked from commit 2b07209935)
* Fix: replace $_REQUEST with GETPOST() in projet/note.php
Use GETPOST('mode', 'alpha') instead of direct $_REQUEST['mode']
access to follow Dolibarr coding conventions for input sanitization.
* Fix: replace $_REQUEST with GETPOSTINT() in compta/tva/clients.php
Use GETPOSTINT('extra_report') instead of direct $_REQUEST access
to follow Dolibarr coding conventions for input sanitization.
* FIX - Show POS in Order and Invoice list
* Update list.php
* Change $showpos value type from int to string
* Refactor POS fields visibility logic
---------
Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* backport de la liste des ressources v23
* fix oauth api conexion
* fix oauth api conexion
* fix oauth api conexion
* Fix CI
* fix: in some case on create invoice when create PDF the lang is not correcly defined because ->thirdparty is not set (#37287)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* add microsoft exchange oauth
* add microsoft exchange oauth
* add microsoft exchange oauth
* add microsoft exchange oauth
* add microsoft exchange oauth
* Revert unintended changes to resource list
* Tidy OAuth logging and consent prompt
* Fix PHPCS blank line warnings
---------
Co-authored-by: ATM-Lucas <lucas.mantegari@atm-consulting.fr>
Co-authored-by: VIAL-GOUTEYRON Quentin <quentin.vial-gouteyron@atm-consulting.fr>
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* FIX: Backport fix on v20 for result page of compta (/compta/resultat/index.php). The expense report were not included when the module was activated
* Update index.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Fixing the API route as it is currently impossible to pay a Facture::TYPE_CREDIT_NOTE with this route (it keeps negating the ttc amount used as resteapayer), inspired by the other route /paymentsdistributed, line 1717.