Commit Graph

3141 Commits

Author SHA1 Message Date
Frédéric FRANCE
3a8b82ec0e clean workstation setup (#36100)
* clean workstation setup

* clean workstation setup

* clean setup
2025-11-05 22:24:02 +01:00
github-actions[bot]
0411367b8a PHPStan > Update baseline (#36108)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-05 22:22:43 +01:00
Frédéric FRANCE
13bc1e2e16 clean code (#36098)
* clean code

* clean baseline
2025-11-04 18:46:24 +01:00
Frédéric FRANCE
39f54ca1d0 test phpstan (#36069)
* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* clean baseline

* test

* test
2025-11-04 18:41:36 +01:00
Laurent Destailleur
f355bff45a Fix scc 2025-11-04 12:50:17 +01:00
MDW
c4712cbca7 Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php (#36068)
# Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php

- Update pertype.php and peruser.php to resolve PhanTypeComparisonFromArray notices.
When an array value is set, it's already an array so comparing to '' is
useless and invalid.
- Update baseline.txt to reflect reduced occurrences of phan issues.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-02 16:56:31 +01:00
MDW
be588ee1be Qual: Update TVA intra field reference in quadri_detail.php (#36064)
- Changed reference from 'tva_intra' to 'company_tva_intra' in multiple locations
- Updated baseline.txt to reflect reduced occurrences of PhanTypeArraySuspiciousNull and PhanPluginUndeclaredVariableIsset
2025-11-02 13:06:34 +01:00
MDW
2de1724786 Qual: Fix donation notices (#36058)
* Qual: Fix missing abstract isEnabled for ModeleDon

# Qual: Fix missing abstract isEnabled for ModeleDon

* Qual: Fix donation list fields

# Qual: Fix donation list fields

Fixes PhanTypeMismatchProperty issues in don/list.php by typecasting and
adding d.ref field to query & using it.

* Fix: Fix call to ModeleDon::write_file

- Refactored write_file method in don.class.php to extraneous parameters
- Removed PhanParamTooMany warning from baseline.txt

* Qual: Remove duplicate assignment in list.php

Removed redundant assignment of projectstatic.id.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-02 12:58:12 +01:00
MDW
6c5cd1c7b0 Fix: Uniform assign_values method signatures (#36063)
# Fix: Uniform `assign_values` method signatures

`Canvas` is calling `assign_values` with three arguments, so all methods
must have three arguments.

- Modified `actions_adherentcard_common.class.php` and `actions_contactcard_common.class.php` to add object reference parameter
- Updated `actions_adherentcard_default.class.php` and `actions_contactcard_default.class.php` to pass reference parameter to parent class
- Updated Phan baseline to reflect changes in canvas classes
2025-11-02 12:49:33 +01:00
MDW
7655c259f8 FIX: Define keyCodeForEnter before first use (takepos) (#36060)
# FIX: Define keyCodeForEnter before first use (takepos)

Move the code to get the keyCodeForEnter from the bottom of the file closer to the top.
This ensure that the variable is defined before first use.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 22:43:24 +01:00
Frédéric FRANCE
dd58e49736 clean code (#36057)
* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 22:42:12 +01:00
Frédéric FRANCE
ff7a684a0a clean code (#36054)
* clean code

* clean code

* avoid obj to be false

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-01 17:48:18 +01:00
MDW
073426d97e Qual: Fix multiple phan notices, update baseline (#36022)
* Qual: Fix phan notice with copy of attribute

* Qual: Fix phan notices with cast and updated param definition

* Qual: Fix phan notice with cast

* Qual: Update parameter type hint in utf8_check function

The parameter type hint for the $str parameter in the utf8_check function has been updated to include nullable types (string or int).

* Qual: Update User parameter type to nullable in call_trigger methods

The User parameter in call_trigger methods has been updated to be nullable to accommodate cases where the user object might not be available. This change ensures better flexibility and robustness in the codebase.

* Qual: Update phan baseline

* Qual: phpstan compatible type

* Qual: Add missing type hints for phan

- Add missing type hints for phan
- Fix indentation issues
- Improved consistency in code structure

* Qual: Update field configuration for backward compatibility

Enhanced the field configuration for backward compatibility by adding expected properties to the 'ref' field array.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 17:47:28 +01:00
Frédéric FRANCE
0a3d2c7ddc clean code (#36053)
* clean code

* clean code
2025-11-01 17:47:13 +01:00
Frédéric FRANCE
e00559b242 fix CI after file rename (#36021)
* fix CI after file rename

* clean code

* clean code

* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 03:12:58 +01:00
Frédéric FRANCE
bda086bf0e add missing translation and clean code (#35956)
* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add doc

* add doc
2025-10-29 22:25:23 +01:00
Frédéric FRANCE
77a06a6cfd fix CI (#35995)
* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update societe.class.php

* Update societe.class.php
2025-10-29 22:07:14 +01:00
Laurent Destailleur
9214ee5d2a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2025-10-28 13:07:31 +01:00
Laurent Destailleur
a1b4d1a06e WIP LNE 2025-10-28 13:07:19 +01:00
Frédéric FRANCE
34a1c824b7 NEW public pages donation, ticket and member use captcha setup (#35913)
* donation use captcha setup

* donation use captcha setup

* member use captcha setup

* member use captcha setup

* member use captcha setup

* member use captcha setup

* member use captcha setup

* ticket use captcha setup

* ticket use captcha setup

* clean

* clean
2025-10-28 02:21:06 +01:00
Frédéric FRANCE
7342a58044 clean phpstan baseline for supplier invoice class (#35945)
* clean phpstan baseline for supplier invoice class

* clean phpstan baseline for supplier invoice class
2025-10-28 01:25:46 +01:00
Frédéric FRANCE
03ea0cda01 clean code class commondict (#35952)
* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* clean code
2025-10-28 01:25:30 +01:00
Frédéric FRANCE
972295ea3c add missing translation (#35958) 2025-10-28 01:13:14 +01:00
Frédéric FRANCE
a487ce4923 add missing translation (#35959)
* add missing translation

* add missing translation

* clean missing
2025-10-28 01:12:45 +01:00
Frédéric FRANCE
9b512f565f try to make new checks (#35976)
* try to make new checks

* try to make new checks

* try to make new checks

* try to make new checks

* try to make new checks

* try to make new checks
2025-10-28 00:57:01 +01:00
Laurent Destailleur
a7a3ad2352 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2025-10-27 20:59:21 +01:00
Laurent Destailleur
bf4140e8f8 Doc 2025-10-27 20:59:11 +01:00
Frédéric FRANCE
48d2dd8956 clean code (#35915)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-10-25 23:09:16 +02:00
Frédéric FRANCE
a31a02dbe5 Update setup_conf.sh (#35937)
* Update setup_conf.sh

* Update setup_conf.sh
2025-10-25 23:04:44 +02:00
Frédéric FRANCE
d07de98ad8 Update makepack-dolibarr.pl (#35938) 2025-10-25 23:04:15 +02:00
Frédéric FRANCE
e67651f5bc Update github_commits_byversion.sh (#35939) 2025-10-25 23:02:55 +02:00
Frédéric FRANCE
4ac3c3f8b6 clean phpstan baseline of supplier order class (#35942)
* clean phpstan baseline of supplier order class

* clean phpstan baseline of supplier order class

* clean phpstan baseline of supplier order class

* clean phpstan baseline of supplier order class

* clean phpstan baseline of supplier order class

* clean phpstan baseline of supplier order class
2025-10-25 22:55:06 +02:00
Frédéric FRANCE
675ec205f4 clean phpstan baseline (#35946) 2025-10-25 22:53:09 +02:00
github-actions[bot]
21a933bd2e PHPStan > Update baseline (#35949)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-10-25 20:39:40 +02:00
github-actions[bot]
d4905ca777 PHPStan > Update baseline (#35926)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-10-24 18:28:50 +02:00
Laurent Destailleur
2c1ab9b40a Clean code 2025-10-22 14:14:58 +02:00
Frédéric FRANCE
acb1bc22c4 add upload on recruitment job and fix CI (#35880)
* add upload on recruitment job

* add upload on recruitment job

* fix

* fix

* fix

* fix

* fix

* fix

* fix
2025-10-22 00:48:28 +02:00
Laurent Destailleur
f35536712f WIP LNE 2025-10-21 14:41:42 +02:00
Frédéric FRANCE
1e329f2325 clean code (#35843)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-10-19 17:09:54 +02:00
MDW
8a84fad171 Qual: Fix misuse of Mo->error (#35841)
# Qual: Fix misuse of Mo->error

Phan identified that ++ was performed on Mo->error which is a string.
This fixes that by using a local $error variable (as in another
function).
2025-10-19 03:35:04 +02:00
Frédéric FRANCE
9193aa889a clean phpstan baseline (#35839) 2025-10-19 03:34:22 +02:00
Frédéric FRANCE
8f7931eb49 clean phpstan baseline (#35837)
* clean phpstan baseline

* clean phpstan baseline

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-10-19 03:34:09 +02:00
Frédéric FRANCE
ed4b7ce58d clean phpstan baseline (#35838)
* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* fix
2025-10-19 01:58:11 +02:00
Frédéric FRANCE
4bc77ebcda clean phpstan baseline (#35836)
* clean phpstan baseline

* clean phpstan baseline
2025-10-19 01:56:26 +02:00
MDW
66683105f1 Qual: Fix phan notices (#35827)
# Qual: Fix phan notices

Some type hints updates + correction to get week from date (action/pertype.php)
+ check that value is not null (pdf_* classes).
2025-10-18 19:10:43 +02:00
Frédéric FRANCE
05e6c8ce11 Fix phpstan (#35828)
* clean phpstan baseline

* clean baseline

* clean baseline

* clean baseline

* clean baseline
2025-10-18 19:09:52 +02:00
Frédéric FRANCE
3d852682ec clean baseline (#35822)
* clean baseline

* clean baseline

* clean baseline

* clean baseline

* clean baseline

* clean baseline
2025-10-18 11:20:54 +02:00
github-actions[bot]
9447f04876 PHPStan > Update baseline (#35810)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-10-17 15:46:08 +02:00
Frédéric FRANCE
29b3880e6c add dolBuildUrl (#35664)
* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

* clean baseline

* add dolBuildUrl

* add dolBuildUrl

* add dolBuildUrl

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-10-17 02:31:07 +02:00
Frédéric FRANCE
90a0d3cc28 clean phpstan baseline (#35798)
* fix missing translation

* fix missing translation

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

* clean phpstan baseline

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-10-17 02:01:47 +02:00