Commit Graph

585 Commits

Author SHA1 Message Date
Laurent Destailleur
d523cb24e6 Disable useless phan warnings 2024-05-10 11:48:27 +02:00
MDW
2115980560 Qual: Fix Phan notices in CommonObject (#29354)
* Fix PhanPluginSimplifyExpressionBool in commonobject

* Fix commonobject for phan notices

* Allow null for $usedolidb argument

* Allow null for $outputlangs argument of \dol_format_address()

* Fix multiple phan notices

* Ignore PhanTypeArraySuspiciousNullable

* Fix PhanTypeMismatchArgumentProbablyReal

* Update baseline

* Improve typings

* Update type specification getCountry/withCode

* Fix CommonObject Phan notices & update baseline

* Fix phan notices

* Correct typing for showInputField to be the same as parent class

* Fix PhanPluginSimplifyExpressionBool in commonobject

* Fix commonobject for phan notices

* Allow null for $usedolidb argument

* Allow null for $outputlangs argument of \dol_format_address()

* Fix multiple phan notices

* Ignore PhanTypeArraySuspiciousNullable

* Fix PhanTypeMismatchArgumentProbablyReal

* Update baseline

* Improve typings

* Update type specification getCountry/withCode

* Fix CommonObject Phan notices & update baseline

* Fix phan notices

* fixup! Correct typing for showInputField to be the same as parent class
2024-05-02 19:33:51 +02:00
Laurent Destailleur
95467db0c7 Fix RSS 2024-04-30 21:14:53 +02:00
Laurent Destailleur
eda839a49a Fix RSS 2024-04-30 21:13:53 +02:00
Laurent Destailleur
679e06048c Fix RSS 2024-04-30 21:12:21 +02:00
Laurent Destailleur
5890e715bf Fix RSS 2024-04-30 21:02:02 +02:00
Laurent Destailleur
19afa4bb03 Fix RSS 2024-04-30 20:44:38 +02:00
Laurent Destailleur
bf8e25c41f Fix security rss file 2024-04-30 19:11:30 +02:00
Laurent Destailleur
dbb9ae1667 Log 2024-04-30 19:00:11 +02:00
Laurent Destailleur
26a0732fb9 Use PHPSTan level 4 2024-04-30 08:35:45 +02:00
Laurent Destailleur
1af7ad923c Fix phan 2024-04-28 21:56:41 +02:00
Laurent Destailleur
29b6d6b918 Add phpstan version in report 2024-04-28 16:20:44 +02:00
Frédéric FRANCE
26da44e254 fix phpstan (#29431)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* remove params not used

* add WARNING
2024-04-27 12:45:50 +02:00
Laurent Destailleur
2de1287afd Make CTI less paranoiac to avoid alert at any code change 2024-04-27 00:47:45 +02:00
Laurent Destailleur
ca65e9a333 QUAL the config_extended of phpstan will be kept on apstats only for the
moment: Too many CTI error not related to PR.
2024-04-24 21:44:58 +02:00
Laurent Destailleur
a669c3d3fa Disable PhanUndeclaredGlobalVariable 2024-04-24 20:56:41 +02:00
Laurent Destailleur
85b4077d0d Clean code 2024-04-24 20:35:36 +02:00
Laurent Destailleur
5166eee88c Clean code 2024-04-24 20:29:37 +02:00
Laurent Destailleur
7712a80c55 Fix phpstan 2024-04-24 16:48:05 +02:00
Laurent Destailleur
51c233e2bf Add branch name of security fixes 2024-04-23 12:55:21 +02:00
Laurent Destailleur
caa0004622 Fix report of branches 2024-04-23 12:27:01 +02:00
Laurent Destailleur
d3f4b146b2 NEW Try to add branches into apstats security report 2024-04-23 11:50:10 +02:00
Laurent Destailleur
3aa2875532 Fix url_root param 2024-04-22 15:02:43 +02:00
Laurent Destailleur
bce2575309 Add image to RSS feed 2024-04-22 13:57:12 +02:00
Laurent Destailleur
90201c508a Alert on last 3 month 2024-04-18 17:40:44 +02:00
Laurent Destailleur
9bb1fe6600 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-18 17:39:34 +02:00
Laurent Destailleur
bd3077ce67 Fix for smartphone 2024-04-18 17:38:33 +02:00
MDW
090970ed4f Fix #29359 Add exception for contributor email (#29394) 2024-04-18 15:43:59 +01:00
MDW
da9fd874bc Qual: Fix or ignore functions.lib.php phan notices (#29344)
* Fix: LogHandler parent class, implements interface & provides $code

* Fix: functions.lib phan notices

* Fix phan notifications

* Match expected DebugBar signature - rename getRenderer

* Call the correct renderer method for the DebugBar

* Use correct key type to access array

* Ignore notices

* Update functions.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-14 04:46:33 +02:00
MDW
bc5e5b67af Qual: Update phan baseline (#29300)
* Qual: Update phan baseline

* Init variable to ensure it is defined

* Init $module_part to ensure it is defined

* Init $modulepart to ensure it is defined

* phpdoc typing for getNetNeeds and getNetNeedsTree

* Enforce type for phan

* Initialise  $massactionbutton so that it is defined

* phpdoc: improve typing

* Encore character_set value is string (for typing)

* fixup! Qual: Update phan baseline

* Fix duplicate code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-04-12 01:06:52 +02:00
Laurent Destailleur
6fcec74fed Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-11 22:58:17 +02:00
Laurent Destailleur
0a3f66c6c4 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	dev/tools/codespell/codespell-ignore.txt
	htdocs/admin/system/security.php
	htdocs/core/class/commondocgenerator.class.php
	htdocs/core/menus/standard/eldy.lib.php
	htdocs/product/fournisseurs.php
2024-04-11 22:57:43 +02:00
MDW
e171e8e7ef Qual: Fix all active phan notices in html.form.class.php (#29316) 2024-04-11 19:14:46 +02:00
Laurent Destailleur
efaccbc519 Remove duplicate graph 2024-04-10 01:50:29 +02:00
Laurent Destailleur
89c9651fde Fix example of security options 2024-04-09 15:31:13 +02:00
Laurent Destailleur
345a315b50 Fix example of security options 2024-04-09 15:29:43 +02:00
Laurent Destailleur
39491976e1 Fix title 2024-04-08 19:26:37 +02:00
Laurent Destailleur
b6822272b3 Look and feel 2024-04-08 16:37:33 +02:00
Laurent Destailleur
f1a3df108f Fix thumbs replace by opencollective 2024-04-08 14:59:21 +02:00
Laurent Destailleur
3215fa1184 Try to add stats fro ossinsight 2024-04-08 14:30:44 +02:00
Laurent Destailleur
ea1c9ad11d Fix grouping of security alerts 2024-04-08 14:00:13 +02:00
MDW
4d496209ce Qual: Phan/apstats should not be using the standard baseline (#29267)
# Qual: Phan/apstats should not be using the standard baseline

Fix to get apstats reporting on the technical debt.  The 'baseline.txt'
is for the ci regression.  The code is changed to allow a
'baseline_extended.txt' which should not be generated, only hand-crafted
2024-04-07 15:02:00 +02:00
MDW
bbde552979 Qual: Enable Phan Rules and update baseline (#29255)
* Fix script generating trailing whitespace

* Add nusoap as a stub for better analysis

* Qual: Return type for fetch_name_optionals_label to fix phan message

* Qual: Enable Phan Rules and update baseline

# Qual: Enable Phan Rules and update baseline

This enables all of the rules that are currently also
enabled for cti, but sets the baseline to ignore the
exceptions already present.
This will help detect exceptions added by code modifications
if the rule is not ignored for the given file.
2024-04-07 11:55:39 +02:00
Laurent Destailleur
fa43938f76 Fix merge same title of security issue 2024-04-07 11:46:12 +02:00
Laurent Destailleur
d0c7c7f2c7 Add CR on RSS feed of apstat 2024-04-05 15:51:41 +02:00
Laurent Destailleur
e9857d5473 Try new line in description of rss 2024-04-05 15:49:52 +02:00
Laurent Destailleur
5702c31110 Typo 2024-04-05 15:47:25 +02:00
Laurent Destailleur
f12826a952 Add link to securities 2024-04-05 15:43:43 +02:00
Laurent Destailleur
0d5b81796f Fix escape 2024-04-05 15:34:30 +02:00
Laurent Destailleur
5d0125870d Add link into rss 2024-04-05 15:32:46 +02:00