Commit Graph

1142 Commits

Author SHA1 Message Date
Laurent Destailleur
f4b3081568 Clean code 2024-02-08 02:00:54 +01:00
Laurent Destailleur
eb4f53665d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	.github/workflows/pre-commit.yml
	ChangeLog
	dev/tools/codespell/codespell-lines-ignore.txt
	htdocs/comm/mailing/card.php
	htdocs/contact/card.php
	htdocs/langs/en_US/admin.lang
	htdocs/modulebuilder/template/core/modules/mailings/mailinglist_mymodule_myobject.modules.php
2024-02-07 18:30:10 +01:00
Laurent Destailleur
9a73612d65 Doc 2024-02-02 13:40:09 +01:00
Laurent Destailleur
c9823f2b8d Move 401 to 403 2024-02-01 19:34:13 +01:00
thibdrev
cbe1b75332 qual: phpstan for htdocs/adherents/class/adherent_type.class.php (#27946)
htdocs/adherents/class/adherent_type.class.php	130	Property AdherentType::$other (string) does not accept default value of type array.
2024-02-01 17:49:02 +01:00
Laurent Destailleur
768e0b54c8 Clean code 2024-02-01 13:45:15 +01:00
Laurent Destailleur
20a2e8e38a Clean code 2024-02-01 13:43:12 +01:00
thibdrev
2018e577b8 qual: phpstan for htdocs/adherents/class/adherent.class.php (#27945)
* qual: phpstan for htdocs/adherents/class/adherent.class.php

htdocs/adherents/class/adherent.class.php	1692	Property Adherent::$invoice (Facture) does not accept null.
htdocs/adherents/class/adherent.class.php	2626	Property Adherent::$civility_id (string) does not accept int.

* phpcs
2024-02-01 13:39:25 +01:00
Laurent Destailleur
b514c1afbe Move code 401 to 403 2024-02-01 13:34:55 +01:00
Laurent Destailleur
f39a439895 Clean code 2024-01-26 03:35:00 +01:00
Laurent Destailleur
7f84b1e569 Merge pull request #27614 from frederic34/patch-3
fix box_dolibarr_state_board.php
2024-01-18 21:28:03 +01:00
thibdrev
e35c987559 fix: phpstan
htdocs/adherents/class/adherent.class.php	1198	Method Adherent::setPassword() should return string but returns int.
2024-01-18 20:16:32 +01:00
Frédéric FRANCE
e87362a9ad Update adherent.class.php 2024-01-18 18:45:35 +01:00
Laurent Destailleur
3ac7706a63 Clean code 2024-01-15 11:28:25 +01:00
Pascal Hubrecht
0cdcd3d7a0 Qual enhance API description (#27490) 2024-01-13 15:34:27 +01:00
Pascal Hubrecht
c03a41e914 Enhance API description (#27485) 2024-01-13 15:32:22 +01:00
Pascal Hubrecht
c4ef3f007f Qual enhance API description (#27487) 2024-01-13 15:30:51 +01:00
Laurent Destailleur
f773fa2dbd Fix phan report 2024-01-12 22:09:51 +01:00
MDW
85ad4ecdf8 Qual: Spelling for htdocs/[a-b]* (#27422)
Mostly comments, one variable changed from misspelling to .
Also changed CNAT to C.N.A.T in comment to avoid fix from CNAT to CAN'T.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 20:58:09 +01:00
Frédéric FRANCE
0d3e0c8ec4 fix incorrect case and remove exclude check (#27449) 2024-01-12 20:40:34 +01:00
Laurent Destailleur
ad6c4c2deb Fix phpcs 2024-01-12 18:18:20 +01:00
Laurent Destailleur
618a364064 FIX #27439 but using the opposite direction. int is bette as we can evolve to add a third value in a future. 2024-01-12 17:47:54 +01:00
MDW
58ba3e31fa Qual: Fix spelling for crypted and referer (#27408)
# Qual: Fix spelling for crypted and referer.

The proper spelling is encrypted and referrer, but the code has
some occurences where referer and crypted need to be maintained.

To make verification easier, this spelling correction is limited to
mostly these corrections and some minor translations and a only a
few other corrections.

crypted and referer are added as exceptions for spelling after this fix.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-11 10:07:06 +01:00
Laurent Destailleur
e2f49c407f Clean sql request to use exist instead of left join 2024-01-09 10:44:50 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Fabian Heinz
b78632a20e api fixes
According to [RFC2616](https://www.rfc-editor.org/rfc/rfc2616#section-10.2), APIs should return 2xx status codes if the request was correct.
The response should be status 200 with an empty result array.
2023-12-31 14:11:05 +01:00
Fabian Heinz
aa43e18d56 API status code fix
apis currently returning 404 if no entry found fixed
2023-12-31 14:05:21 +01:00
Laurent Destailleur
89686e74dc Clean code 2023-12-26 22:33:22 +01:00
Laurent Destailleur
b3020923b7 Merge pull request #27186 from Hystepik/fix-php-warnings-code-smell
Fix some php code smell
2023-12-22 11:07:07 +01:00
Laurent Destailleur
5c6c5853ab Clean code 2023-12-21 15:27:13 +01:00
Laurent Destailleur
756180cfb5 Debug v19 2023-12-20 22:21:41 +01:00
Hystepik
5e4a4da130 Fix some php codce smell 2023-12-20 14:22:45 +01:00
Laurent Destailleur
7f5df80efd Debug v19 2023-12-19 11:51:48 +01:00
Laurent Destailleur
d92c65ad91 FIX infinite loop in API call/trigger by adding a caller 2023-12-15 12:15:33 +01:00
Laurent Destailleur
8f7d258a83 Work on rector to fix warnings 2023-12-13 15:19:25 +01:00
Frédéric FRANCE
61b79fda17 avoid phpstan error with phpdoc 2023-12-06 15:46:39 +01:00
Laurent Destailleur
987d6c41b9 Fix with php-cs-fixer 2023-12-04 11:41:14 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
56e8872ddc Clean code+warnings: The delete() method of AdherentType, Contact,
Delivery, MultiCurrency, CurrencyRate now need $user as first parameter.
2023-11-28 15:33:42 +01:00
Laurent Destailleur
353298ec62 Code comment 2023-11-18 01:23:30 +01:00
Laurent Destailleur
ca3c7f0a37 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2023-10-26 13:52:22 +02:00
daraelmin
a815c99d53 FIX suggested end for membership can be before subscription start (#26351)
* Fix wrong debug log

* Fix suggested end for membership can be in the past

MEMBER_SUBSCRIPTION_SUGGEST_END_OF_YEAR and MEMBER_SUBSCRIPTION_SUGGEST_END_OF_MONTH should be based on the subscription start date, not on the creation date

* Fix typo
2023-10-26 12:48:40 +02:00
Laurent Destailleur
5b15b5c647 QUAL Move conf->global into getDolGlobal... 2023-10-24 17:00:13 +02:00
Laurent Destailleur
a318031034 QUAL Standardize code. Renamed ID of user properties into ->user_xxx_id 2023-10-24 11:37:29 +02:00
Laurent Destailleur
2cfa9f8290 Debug v19 2023-10-17 15:43:56 +02:00
Laurent Destailleur
bae75281e3 QUAL: Code fix using rector 2023-10-11 19:44:06 +02:00
Dev2a
fcd4c4e429 Fix: Change access to $conf->global to function getDolGlobal (automatique) 2023-10-08 23:19:49 +02:00
Laurent Destailleur
8851615528 Look and feel v19 2023-10-01 20:15:01 +02:00
pascal
80f060c771 fix tab indentation 2023-09-26 18:43:25 +02:00
pascal
871f896962 implementation of properties filter 2023-09-26 18:04:48 +02:00