Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
MDW
099dbd9c1e
Qual: Fix notices for htdocs/admin/* ( #30982 )
...
* Fix (Possibly)UndeclaredGlobalVariable
* Update phan baseline
* Fix (Possibly)UndeclaredGlobalVariable (2)
* Qual: Fix notices for htdocs/admin/*
# Qual: Fix notices for htdocs/admin/*
Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
3d04a7195c
Qual: Updates regarding write_file(s) methods for Phan ( #30511 )
...
* Fix phpdoc for phpstan
* Add abstract write_file to ModelePDFContract
And update phpdoc for derived classes
* Fix typing for php_standard_actions writefile
* Improve phpdoc for write_files (& related)
* Add abstract write_file to ModelePDFBom
* Add abstract write_file to ModelePDFDeliveryOrder
* Add abstract write_file to ModeleExpenseReport
* Add abstract write_file to ModelePDFFicheinter
* Add abstract write_file to ModelePDFEvaluation
* Add abstract write_file to ModelePDFFactures
* Add abstract write_file to ModelePDFSuppliersInvoices
* Update ModelePDFProjects and ModelePDFTask related classes
* Qual: Add abstract write_file to ModelePdfExpedition
And update phpdoc for derived classes
* Qual: Correct reference (doc) to ModelePDFEvaluation
* Qual: Add abstract write_file to ModelePDFKnowledgeRecord
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFMo & ModelePDFMouvement
And update phpdoc for derived classes
* Qual: Set typehint to ModelePDFFicheinter
* Qual: Add abstract write_file to ModelePDFCommandes
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFPropales
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePdfReception
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersOrders
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersOrders
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSuppliersPayments
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFSupplierProposal
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFWorkstation
And update phpdoc for derived classes
* Set typing for doc generator (commonobject)
* Improve typing for write_file
* Set typing for doc generator
* Qual: Add abstract write_file to ModelePDFMember
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFProduct
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFProductBatch
And update phpdoc for derived classes
* Qual: Add abstract write_file to ModelePDFRecruitmentJobPosition
And update phpdoc for derived classes
* Add abstract write_file to ModelePDFTicket
* Add abstract write_file to ModelePDFUser
* Add abstract write_file to ModelePDFUserGroup
* Add abstract write_file to ModeleThirdPartyDoc
* Add abstract write_file to ModelePDFAsset
* Find all incompatible classes
* Qual: update phan baseline
* Set typing for doc generator (commonobject)
* Qual: update phan baseline
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-14 19:21:10 +02:00
atm-lena
290af578aa
New llx header body css admin part2 ( #29933 )
...
* llxHeader CSSBody - admin part 2
* clean
* Fix param llxHeader
---------
Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr >
2024-06-08 17:03:08 +02:00
atm-etienne
dc8b79e0d4
New classify billed order without invoice ( #29614 )
...
* Add new conf in admin page for supplier order classify billed without invoice
* Add translations en_US
* Add check on new config to allow or not the classify billed button
* Add possibility to set the hidden conf to disallow classify billed button from order, from the admin page
* Update conf names and move code to right parts, according to PR returns
2024-05-22 13:30:44 +02:00
Frédéric FRANCE
82d63247d7
fix phpstan pgsql.class.php ( #29511 )
...
* fix phpstan pgsql.class.php
* Update Database.interface.php
* fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
fix phan
fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
2024-04-27 22:01:34 +02:00
MDW
ca980bcee4
Force typing (phan) for typing checks
2024-03-27 10:17:54 +01:00
MDW
b5f0b6ae17
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
...
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:39:55 +01:00
MDW
71f906c280
Qual: Spelling of admin code. ( #27412 )
...
# Qual: Fix spelling of admin code.
Mostly changes in the comments.
Some french text was modified to not trigger a bad spelling.
htdocs/admin/contract.php has a change to $langs->trans(Activated)
which probably fixes a bug.
htdocs/admin/system/xcache.php used ->trans(Recommanded)
but the proper key is ->trans(Recommended).
2024-01-11 09:59:52 +01:00
Laurent Destailleur
987d6c41b9
Fix with php-cs-fixer
2023-12-04 11:41:14 +01:00
Laurent Destailleur
b69059af76
Fix warning
2023-11-27 12:24:18 +01:00
Laurent Destailleur
5b15b5c647
QUAL Move conf->global into getDolGlobal...
2023-10-24 17:00:13 +02:00
Laurent Destailleur
08e428b46d
Fix missing param
2023-08-09 18:00:31 +02:00
Laurent Destailleur
98a05a0ddb
FIX ODT management inverted between purchase invoice and order
2023-03-08 02:08:25 +01:00
Laurent Destailleur
eed3cdd9cc
Debug v17
2023-01-04 15:10:53 +01:00
Laurent Destailleur
d436991c98
Removed useless plugin specialchar in CKeditor
2022-10-06 17:20:12 +02:00
Laurent Destailleur
09ee684c9f
NEW Default template of contract is not mandatory
2022-10-06 17:07:23 +02:00
Laurent Destailleur
7a277d9560
Merge branch 'develop' into loaddolibarrenv
2022-09-09 17:02:05 +02:00
Frédéric FRANCE
52586e5c37
remove multiples tabs added by error
2022-09-09 16:03:22 +02:00
Frédéric FRANCE
7f2b797a7b
remove multiples tabs added by error
2022-09-09 16:02:39 +02:00
lmarcouiller
14a3bc7360
Fix : php 8.1 warnings
2022-09-09 12:26:17 +02:00
Frédéric France
8d33953142
add comment
2022-09-07 20:08:59 +02:00
Frédéric France
8e66b7207e
replace ! empty by !empty
2022-08-31 22:14:20 +02:00
Frédéric France
889856d55f
use getDolGlobalString
2022-06-21 23:39:31 +02:00
Frédéric France
1f7fc7a2ae
getDolGlobalString
2022-06-21 20:25:25 +02:00
Frédéric France
5dcfc28913
use isModEnabled function
2022-06-09 22:41:59 +02:00
Laurent Destailleur
416543a5f5
Standardize code to allow deletion of an odt template
2022-01-26 13:49:46 +01:00
Laurent Destailleur
ad1cb443e4
Merge pull request #18520 from cfoellmann/PR/pdf-no-template
...
allow supplier order to not generate pdfs
2021-10-06 15:35:08 +02:00
Laurent Destailleur
1d597e8a72
Fix add unset* action as sensible GET actions
2021-09-19 18:03:38 +02:00
Laurent Destailleur
5c8fb38426
Fix add del* action into list of sensitive actions
2021-09-19 14:41:46 +02:00
Laurent Destailleur
ed3919da13
Look and feel
2021-09-05 02:25:32 +02:00
stickler-ci
b48566eed8
Fixing style errors.
2021-08-27 08:27:04 +00:00
Christian Foellmann
9914ebe90b
add missing actions to admin page
2021-08-27 10:21:02 +02:00
Christian Foellmann
f094b4c70c
fix up most of the remaining submit inputs
2021-08-24 17:04:17 +02:00
Frédéric FRANCE
608b933ef5
code syntax admin dir
2021-02-26 22:04:03 +01:00
Frédéric FRANCE
8d49ca9f0d
fix html
2021-02-07 18:49:46 +01:00
Laurent Destailleur
dd69aed27b
Fix error test
2021-01-23 17:49:08 +01:00
Laurent Destailleur
1ec3d4cfdf
CSS
2020-12-03 13:19:35 +01:00
Laurent Destailleur
7e6af6a54f
FIX translation not loaded for error message of numbering modules
2020-11-28 02:09:27 +01:00
Scrutinizer Auto-Fixer
7f52920716
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2020-10-31 13:32:18 +00:00
Frédéric FRANCE
9a470fa42d
replace deprecated
2020-10-22 22:50:03 +02:00
Laurent Destailleur
f442dac2c9
Add token on most GET url for admin action
2020-09-30 15:13:28 +02:00
Laurent Destailleur
c4b5f5a249
Maxi clean of code
2020-09-18 01:29:17 +02:00
Laurent Destailleur
bfbb217607
Fix GETPOST on 'action'
2020-09-16 19:39:50 +02:00
Frédéric FRANCE
85625a46bb
add new rule
2020-05-21 09:35:30 +02:00
Frédéric FRANCE
ee6fadd0d5
add new rule
2020-05-21 01:41:27 +02:00
Laurent Destailleur
f4f3efec62
Fight against $_POST
2020-02-16 19:33:58 +01:00
Laurent Destailleur
74d3912763
Merge branch '11.0' of git@github.com:Dolibarr/dolibarr.git into develop
...
Conflicts:
htdocs/fourn/class/fournisseur.facture.class.php
2020-02-11 16:52:58 +01:00
Laurent Destailleur
94d6fa06dc
FIX #13022
2020-02-09 18:34:53 +01:00
