* Qual: 🛟 Fix typing
Qual: Fix typing
Fix some typing currently failing ci in develop.
* Fix typing for grabimages
* Qual: Fix new UndeclaredGlobalVariable notices & enable
# Qual: Fix new UndeclaredGlobalVariable notices & enable
This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).
This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice
* Update phan baseline
* Fix $website global type in some contexts
* Moved signed status constants to array dictionary
* Added getLibSignedStatus & getSignedStatusLocalisedArray methods
* Updated fetch & create methods for signed_status
* Added signed status to status badge
* Updated signed_status module builder field
* Added object context signed status for action trigger
* Added signed status to contract list
* Fixed signed status for contract list
* Added sign, unsign, confirm_sign, confirm_unsign actions. Added sign button.
* Fixed old contract without signed status
* Added contract modify notification
* Added contract signed status update
* Updated EN localizations
* Fixed contract notification administration
* Fixed notification message
* Fixed contract status badge
* Fixed langs
* Fixed langs key
* Fixed duplicate localization
* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Fix suspected issue with environment max size and md5sum working on limited files
* Qual: Fix LDAP typing
* Qual: Fix some phan typing related to getNextValue()
# Qual: Fix some phan typing related to getNextValue()
This fixes a few typings in relation to getNextValue().
* Update phan baseline
* PHPDoc: set arguments as nullable (+update array types)
* Improve PHPDoc
* Force toselect type to int[]
* Enable all phan notices on actions_massactions.inc.php
* Test was wrong, can not count when it's not an array
* Update baseline
* Remove ignore for notice that no longer exists
* Update baseline
* Fix format argument
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Disable global CommonObject $obj type (phan)
# Qual: Disable global CommonObject $obj type (phan)
This removes the global typing hint for $obj from the phan configuration
* Fix issues with undeclared $obj
* Fix issues with undeclared $obj
* Fix issues with undeclared $obj