Commit Graph

1469 Commits

Author SHA1 Message Date
Laurent Destailleur
6b4722c8f7 Merge pull request #32234 from altairis-noe/cat_filters
FIX: sort categories objects with relevant field
2024-12-08 10:43:47 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Noé Cendrier
e0823e3f4e oops 2024-12-04 15:14:53 +01:00
Noé Cendrier
aae0a2c7a6 FIX: sort categories objects with relevant field 2024-12-03 19:20:51 +01:00
Frédéric FRANCE
943d10c60a fix phpstan and CI (#31969)
* fix phpstan

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline
2024-11-18 15:10:29 +01:00
Nicolas SILOBRE
31926333e1 Update viewcat.php (#31849)
* Update viewcat.php

* Update viewcat.php
2024-11-16 10:58:48 +01:00
Thibault Parodi
be72bfa664 FIX #29424 API GET member categories (#31881)
* Fix members categories when user is not found

* Return empty array instead of 0 when member does not have category assigned
2024-11-15 23:57:58 +01:00
Frédéric FRANCE
ec91ed2af9 test action (#31815)
* NEW : Add category feature on Fichinter

category update

* Update viewcat.php

* Update categories.lang

* Update categorie.class.php

* Update categories.lang

* Update viewcat.php

* Update viewcat.php

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* test action

* clean baseline

Debug v21

NEW: use Expedition::$date_shipping property in card and list (#31701)

* NEW: use Expedition::$date_shipping property in card and list

* FIX: translation

* FIX: PHPStan rebutal

* FIX: not a great idea to copy and not edit comment

* FIX: on create, expected delivery date should precede sending date

* Update card.php

* Update list.php

* Update list.php

* Update list.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

clean baseline

clean baseline

clean baseline

* clean baseline

* clean baseline

* merge

* fix

* fix

* fix

* fix

* fix

* fix

* fix translations

* fix translations

* fix translations

* fix translations

* fix

* fix filters

* fix filters

* fix filters

* fix filters

* fix

---------

Co-authored-by: Charlène Benke <1179011+defrance@users.noreply.github.com>
2024-11-15 14:09:04 +01:00
MDW
56dc321665 Qual: Fix phan notices (in order of appearance) (#31768)
* Qual: Fix phan notices (in order of appearance)

* Qual: Fix phan notices (in order of appearance)/2
2024-11-12 00:35:14 +01:00
MDW
9ec4618199 Qual: Fix FunctionArray phan notices (#31754)
* Qual: Fix FunctionArray phan notices

* Fix class name in typing of htdocs/modulebuilder/index.php

* Fix customreports phpdoc

* Adjust file type after completeFileArrayWithDatabaseInfo

* Further phpdoc typing improvements

* More phpdoc

* Improve typing with cast on position field

* Force phpstan version

* Add phpstan exception

* Fix array index type + adjust phan config comment
2024-11-11 14:48:18 +01:00
Laurent Destailleur
13e7cefe39 Debug v21 2024-11-08 11:04:46 +01:00
Laurent Destailleur
d9f79eaa7d Debug v20 2024-11-08 10:08:06 +01:00
Laurent Destailleur
4942f60a24 Debug v21 2024-11-08 09:40:48 +01:00
Laurent Destailleur
dd2cfd33c2 Debug v21 2024-11-08 09:38:35 +01:00
Laurent Destailleur
f37c33bb2c Debug v21 2024-11-08 09:33:51 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
MDW
e7539f2e19 Qual: Fix notices in .lib.php files (#31672)
* Qual: Fix notices in .lib.php files

* Update wrapper.php

* Update availabilities_card.php

* Update index.php

* Update document.controller.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 12:32:13 +01:00
MDW
67e9eaff46 Qual: Fix phan/phpstan notices in class files (part 2) (#31523)
* Qual: Fix phan notices in class files (part 2)

* Qual: Fix phan notices doleditor...events.class

* Qual: Fix phan notices defaultvalues...formprojet.class

* Qual: Fix notices formsetup...formwebsite.class

* Qual: Fix phan notices in class files (part 2)

* Qual: Fix phan notices doleditor...events.class

* Qual: Fix phan notices defaultvalues...formprojet.class

* Qual: Fix notices formsetup...formwebsite.class
2024-10-26 18:24:40 +02:00
Laurent Destailleur
1739acf715 CSS 2024-10-25 16:37:24 +02:00
Frédéric FRANCE
0b1d243a7a add translations count (#31398) 2024-10-15 15:39:29 +02:00
Frédéric FRANCE
077f5b7e00 NEW can delete a category translation (#31396)
* can delete a category translation

* Update traduction.php
2024-10-14 16:46:19 +02:00
Laurent Destailleur
58b0d4512a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-14 14:05:43 +02:00
Laurent Destailleur
73265e45ab Standardize trigger codes 2024-10-14 14:05:20 +02:00
Frédéric FRANCE
b340091522 add delMultilangs method to category class (#31394)
* add delMultilangs method to category class

* add delMultilangs method to category class
2024-10-14 13:59:36 +02:00
MDW
53cfbc35be Qual: Fix several phan & stan notices (#31308)
* Qual: Fix several phan & stan notices

# Qual: Fix several phan & stan notices

Several fixes in files while fixing UnknownClass notices

* Qual: Update prepare_head PHPDoc return types

# Qual: Update prepare_head PHPDoc return types

Provide detailed array return types for prepare_head functions.

* Fix new phan notice

* Better loadLangs typing and fix call to loadLangs

* Fix new issues (stats)

* Other fixes of new issues

* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
Frédéric FRANCE
820333b02f fix variants sql init (#31319)
* fix variants sql init

* add setup

* add setup

* add setup

* update class

* update list

* update list

* update list

* update class

* fix typos

* fix translations

* fix html

* fix update

* fix sql

* fix extrafields

* fix extrafields
2024-10-13 21:08:55 +02:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
Mohamed DAOUD
1ea380c5c2 Code Update For Migration of llx_categorie_bank content into llx_categorie (#31306)
* move category_bank to categorie

* fix

* fix cast

* fix phpunit
2024-10-09 01:48:05 +02:00
Laurent Destailleur
a7db9f8b75 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-10-07 15:23:41 +02:00
Laurent Destailleur
081d3fabfc Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-07 15:20:16 +02:00
Laurent Destailleur
b07cc82058 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-10-07 15:17:49 +02:00
Laurent Destailleur
94ed718782 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-10-07 15:15:01 +02:00
atm-irvine
f287d100a3 Use <= 0 instead of ! because delete method returns -1 or 1 (#31268)
* Use <= 0 instead of ! because delete method returns -1 or 1

* Added contact

* Removed user from parameters
2024-10-04 11:49:44 +02:00
Frédéric FRANCE
4cc9074e30 phpdoc (#31223)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-03 19:34:43 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
MDW
93005b2c08 Qual: Add centpecent to codespell, fix css (#31178)
# Qual: Add centpecent to codespell, fix css

Try to prevent misspelling in css by adding centpecent.
Fix corresponding cases

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 13:09:09 +02:00
Frédéric FRANCE
a94cff63a7 fix phpstan (#31102)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-25 22:21:31 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Mohamed DAOUD
ef39801dc7 Add lang parameter to getObjectsInCateg function (#31070)
* add lang parameter to getObjectsInCateg

* fix phan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 02:41:29 +02:00
MDW
099dbd9c1e Qual: Fix notices for htdocs/admin/* (#30982)
* Fix (Possibly)UndeclaredGlobalVariable

* Update phan baseline

* Fix (Possibly)UndeclaredGlobalVariable (2)

* Qual: Fix notices for htdocs/admin/*

# Qual: Fix notices for htdocs/admin/*

Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
Frédéric FRANCE
d5fe4f998a fix phpstan (#30989)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-18 02:45:54 +02:00
MDW
115627a054 Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957)
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
Laurent Destailleur
70a8f2e9ee Fix test on permission 2024-09-06 16:40:06 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Laurent Destailleur
38612e3cf7 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-03 01:58:02 +02:00
Laurent Destailleur
ebab2bfdc7 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-03 01:56:05 +02:00
Laurent Destailleur
ec3dcc9565 Debug v20 Fix regression 2024-09-03 01:54:10 +02:00
Laurent Destailleur
12799d5485 Fix regression 2024-09-03 01:38:59 +02:00
Laurent Destailleur
2009c6f09a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-31 17:30:32 +02:00
Laurent Destailleur
2c28d039e2 Fix test on permissions 2024-08-31 16:26:08 +02:00