Commit Graph

411 Commits

Author SHA1 Message Date
Laurent Destailleur (aka Eldy)
352d156dd7 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-12-08 17:07:14 +01:00
Laurent Destailleur (aka Eldy)
774a48fa29 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-12-08 16:53:21 +01:00
Laurent Destailleur (aka Eldy)
7beb874f93 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-12-08 16:47:36 +01:00
Laurent Destailleur (aka Eldy)
28213b3129 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-12-08 16:44:08 +01:00
Irvine Fleith
3aad5fd283 Added new error message for CRON createRecurringInvoice 2024-12-05 09:02:51 +01:00
MDW
ec2a1928ba Qual: Update fields phpdoc to include fields that are defined/used in some cases
# Qual: Update fields phpdoc to include fields that are defined/used in some cases

comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
HENRY Florian
1f386fb808 fix #32060 (#32061)
* fix #32060

* fix #32060
2024-11-22 13:21:18 +01:00
Laurent Destailleur
6e9bbe42bb Add code to make easier to test PDF generation with n lines of product 2024-11-21 19:40:52 +01:00
Frédéric FRANCE
943d10c60a fix phpstan and CI (#31969)
* fix phpstan

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline

* fix errors and refresh phpstan baseline
2024-11-18 15:10:29 +01:00
Laurent Destailleur
4b384b3753 Doc 2024-11-12 13:28:50 +01:00
Laurent Destailleur
405444879a Debug v21 2024-11-12 13:25:46 +01:00
atm-lena
10e18da5d7 Develop new facture rec field societe rib management (#31698)
* Add field "fk_societe_rib" in llx_facture_rec

* Add field fk_societe_rib FactureRec

* Management of new field "Bank Account Customer" in facture rec

* Empty Value Management

* Change method of hide/show field

* Preselect RIB

* Rename function

* Edit structure formiban

* fix merge conflict

* Clean code

* clean code

* change translations

* default rib preselected in invoice rec create

* fix "=="

* Update card-rec.php

---------

Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-11 17:53:35 +01:00
MDW
e7539f2e19 Qual: Fix notices in .lib.php files (#31672)
* Qual: Fix notices in .lib.php files

* Update wrapper.php

* Update availabilities_card.php

* Update index.php

* Update document.controller.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 12:32:13 +01:00
atm-irvine
fd094638dd NEW : Suspend facture rec when nb gen max is reached (#31623) 2024-10-29 20:41:01 +01:00
Laurent Destailleur
c70973c0c8 Merge v20 2024-10-19 14:44:55 +02:00
Laurent Destailleur
17c50368c1 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-10-19 14:32:08 +02:00
Laurent Destailleur
402570e1c5 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-10-19 14:00:10 +02:00
Laurent Destailleur
a0b791a4a6 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-10-19 13:59:35 +02:00
atm-irvine
352bdaf9c4 FIX : Extrafield following between rec invoice and classic invoice (#31445) 2024-10-19 01:33:31 +02:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
Laurent Destailleur
fa3c2fc870 Close #31219 - Better fix 2024-10-03 16:47:38 +02:00
William Mead
15633f50ca Qual isolate FactureLigne class to separate file (#30870)
* Moved invoice line class to separate file. Removed unnecessary requires.

* Fixed requires

* Fixed require
2024-09-06 13:49:44 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542)
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 17:05:00 +02:00
MDW
d6948077b2 Qual: Fix spelling/update .pre-commit configuration (versions) (#30546)
* Qual: Update pre-commit configuration

* Qual: Update spelling

* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Laurent Destailleur
73562b8734 FIX Missing trunc to $max 2024-07-13 01:59:15 +02:00
Laurent Destailleur
33edcbdd59 FIX Missing trunc to $max 2024-07-13 01:32:21 +02:00
Mathieu Moulin
abcb1dad4b Define CommonObject relation in CommonObjectLine classes (#29956) 2024-06-10 16:08:39 +02:00
Laurent Destailleur
82908a30eb Clean phan warnings 2024-05-30 13:37:17 +02:00
Laurent Destailleur
16336a66ad Rename french module name into english 2024-05-13 10:45:20 +02:00
Frédéric FRANCE
5d421b1437 fix phpstan supplier invoice rec (#29398) 2024-04-20 22:45:14 +01:00
Laurent Destailleur
714236a1ec Merge pull request #29203 from rycks/16_move_trigger_to_facture
move BILLREC_CREATEBILL to facture because of ui actions
2024-04-03 02:29:12 +02:00
Eric Seigne
850ec25f23 move BILLREC_CREATEBILL to facture because of user can click on button "create" from ui, not only from cron 2024-04-02 21:29:21 +02:00
Frédéric France
5b1af95864 fix phpstan 2024-03-28 20:16:32 +01:00
MDW
991ce81f93 Fix arg type to preg_match() and preg_replace() with cast 2024-03-20 04:08:34 +01:00
MDW
fd9d48faac Fix phpstan CommonObject->fields - notnull is optional field 2024-03-19 00:32:00 +01:00
MDW
23785393a3 Add csslist to json keys 2024-03-15 03:55:52 +01:00
MDW
b7b05d4d49 Fix PhanTypeMismatchPropertyDefault 2024-03-15 03:44:46 +01:00
MDW
ca8ccd84f0 Fix PhanPluginRedundantAssignment 2024-03-13 00:40:37 +01:00
MDW
88d59896ec Qual: 'enabled' in fields can be string ('isModEnabled(...)')
# Qual: 'enabled' in fields can be string ('isModEnabled(...)')

Update PHPdoc to allow that enabled is a string
2024-03-12 13:38:08 +01:00
MDW
88ba7d1bc5 Fix: Repeat fields typing in CommonClass children
# Fix: Repeat fields typing in CommonClass children

phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
2024-03-11 17:39:03 +01:00
Frédéric FRANCE
fba15178eb all initAsSpecimen return int (#28577)
* all initAsSpecimen return int

* all initAsSpecimen return int

* all initAsSpecimen return int
2024-03-02 16:38:35 +01:00
MDW
c332251816 Fix: Replace deprecated module names in code strings (#28462)
* Fix: Replace deprecated module names in code strings

# Fix: Replace deprecated module names in code strings

A few cases that slipped through the manual replacements

* Qual: Enable deprecation notices in CodingPhpTest for isModEnabled

# Qual: Enable deprecation notices in CodingPhpTest for isModEnabled

As all detections are now fixed, we can enable the deprecation notice
trigger in the CodingPhpTest.
2024-02-28 23:01:01 +01:00
thibdrev
21af889405 qual: phpstan for htdocs/compta/facture/class/facture-rec.class.php (#28061)
* qual: phpstan for htdocs/compta/facture/class/facture-rec.class.php

htdocs/compta/facture/class/facture-rec.class.php	1271	Method FactureRec::strikeIfMaxNbGenReached() should return bool but returns string.
htdocs/compta/facture/class/facture-rec.class.php	1299	Property CommonObject::$output (string) does not accept null.

* typo

* phpcs
2024-02-08 00:17:02 +01:00
Laurent Destailleur
a7529665da Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/ticket/class/ticket.class.php
2024-02-08 00:06:52 +01:00
Laurent Destailleur
1322c20f91 Clean code 2024-02-08 00:04:50 +01:00
Frédéric France
4b3f351f95 phpdoc 2024-01-18 23:28:42 +01:00
MDW
52ee926bac Qual: Spelling compta code (#27413)
# Qual: Fix spelling of files in htdocs/compta

No code should be changed, only comments modified or translated.
2024-01-11 09:58:34 +01:00
Frédéric FRANCE
4fad299e9f tooltip recurring invoice 2024-01-06 10:48:43 +01:00
Hystepik
d08f91e4cb Fix some phpstan warnings 2023-12-21 13:43:19 +01:00