Commit Graph

14689 Commits

Author SHA1 Message Date
Laurent Destailleur
59477a2055 FIX Remove wrong button 2024-09-24 13:23:37 +02:00
Laurent Destailleur
75f3978159 FIX Missing picto on user link 2024-09-24 13:14:07 +02:00
Laurent Destailleur
950d749198 FIX Warning visible when it should not 2024-09-24 13:11:52 +02:00
Laurent Destailleur
cd5900da3c Fix CSS 2024-09-24 12:08:05 +02:00
MDW
5e02bec9df Qual: Fix getTooltipContentArray typing hints (#31081)
* Qual: Fix getTooltipContentArray typing hints

# Qual: Fix getTooltipContentArray typing hints

This defines the aray type for all getTooltipContentArray occurences

* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
000173c7b9 fix phpstan (#31075)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-23 01:59:14 +02:00
MDW
7b4c4d772c Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related (#31086)
* Qual: Fix Array of tabs typing hints

# Qual: Fix Array of tabs typing hints

Fixed same typing hints accross several files

* Qual: Fix pdf.lib.php, project.lib.php and related files

# Qual: Fix pdf.lib.php, project.lib.php and related files

Fix most phan notices for pdf.lib.php and project.lib.php.
And fixed some items in other files in the process

* Qual: Fix notifications commande/card advtarget.tpl fichinter/card societe/card supplier_proposal/card

* Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

# Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

Fix notices in the files for the classes above and other files to accomodate
these changes/fixes
2024-09-23 00:37:30 +02:00
Frédéric FRANCE
13d4d96dfc fix phpstan (#31061)
* fix phpstan

* fix phpstan
2024-09-20 17:25:39 +02:00
Laurent Destailleur
c8a1ac578d Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-20 16:09:24 +02:00
Laurent Destailleur
bc9746891d NEW Can change the type of a social contribution if no payment 2024-09-20 16:09:06 +02:00
Laurent Destailleur
84e5f5e7b4 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-20 02:51:59 +02:00
Laurent Destailleur
401c9898bb Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-20 02:46:03 +02:00
Laurent Destailleur
87adbbb769 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-09-20 02:39:55 +02:00
William Mead
7d92e4daef Fix bank account domiciliation address (#31019)
* Fixed bank account domicilation update

* Fixed bank address on create
2024-09-20 01:47:23 +02:00
hansemschnokeloch
357186722d Fix #31015 (#31035)
datepaye is already a timestamp
2024-09-20 01:40:34 +02:00
HENRY Florian
126dc77ef3 fix: add missing hook in propal and invoice (contact and document tabs) (#30518)
* add missing hook in propal contact and document

* add missing hook in propal contact and document

* add missing hook in propal and invoice (contact and document)

* add missing hook in propal and invoice (contact and document)

* add missing hook in propal and invoice (contact and document)

* review: change inithook place
2024-09-18 03:03:05 +02:00
Frédéric FRANCE
d5fe4f998a fix phpstan (#30989)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-18 02:45:54 +02:00
atm-thomasb
fdca7b691a FIX: BIC requirement is now checked separately from IBAN (#30994) 2024-09-18 01:30:56 +02:00
Laurent Destailleur
8007e6ff86 NEW Can set date of transmission in 1 click when validating SEPA
transfer file
2024-09-17 10:29:57 +02:00
MDW
9a9e851494 Qual: Fix new UndeclaredGlobalVariable notices & enable (#30963)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: Fix new UndeclaredGlobalVariable notices & enable

# Qual: Fix new UndeclaredGlobalVariable notices & enable

This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).

This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
MDW
115627a054 Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice (#30957)
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice

Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice

* Update phan baseline

* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
Laurent Destailleur
10065e413b center 2024-09-15 13:28:37 +02:00
Laurent Destailleur
f6ae913056 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-15 13:18:28 +02:00
Laurent Destailleur
411e0eac86 Fix placeholder 2024-09-15 13:03:04 +02:00
Laurent Destailleur
490deb8ef6 Debug v20 token on reconcile 2024-09-15 12:52:27 +02:00
Laurent Destailleur
90c3b342f2 Debug v20 token on reconcile 2024-09-15 12:51:13 +02:00
Laurent Destailleur
2ad1c61976 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-15 12:33:25 +02:00
Laurent Destailleur
3612113e1c css 2024-09-15 12:32:27 +02:00
Frédéric FRANCE
2a6bbf88df fix phpstan (#30944)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-13 17:40:03 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925)
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
Laurent Destailleur
26a199a877 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-11 14:03:35 +02:00
Laurent Destailleur
303e9ed891 Debug v20 2024-09-11 14:01:31 +02:00
Frédéric FRANCE
97b97c6665 fix phpstan (#30912)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-10 14:58:36 +02:00
Laurent Destailleur
e003c6a516 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-07 02:20:15 +02:00
Laurent Destailleur
bd04568799 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-07 02:18:33 +02:00
Laurent Destailleur
70a8f2e9ee Fix test on permission 2024-09-06 16:40:06 +02:00
Laurent Destailleur
b02a891f2f Enhance the protection on missing permissions 2024-09-06 15:49:57 +02:00
Laurent Destailleur
1c5d759816 Doc 2024-09-06 14:26:44 +02:00
atm-thomasb
63c54a06f0 NEW: added column default_rib in llx_user_rib (#30850)
* NEW: added column

* NEW: Added the TODO requested feature

* FIX: changed default value to 0 instead of 1, see PR

* NEW: Updated TODO

* Update llx_user_rib.sql

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-06 14:10:23 +02:00
Frédéric FRANCE
f29e9e760f fix phpstan (#30861)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 14:02:53 +02:00
William Mead
15633f50ca Qual isolate FactureLigne class to separate file (#30870)
* Moved invoice line class to separate file. Removed unnecessary requires.

* Fixed requires

* Fixed require
2024-09-06 13:49:44 +02:00
Frédéric FRANCE
eb04c5c427 fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
atm-adrien
40acd45398 FIX : Wrong default PDF model when creating the second situation invoice (#30843)
* FIX : Wrong default PDF model when creating the second situation invoice

* FIX : PR Returns
2024-09-05 15:52:02 +02:00
Alexandre SPANGARO
a4ddb9ff17 FIX #30772 Accountancy document export - The project filter on expenses report don't work (#30824)
* FIX #30772 Accountancy document export - The project filter on expenses report don't work

* Add SUM() if several lines exist on an expense report
2024-09-04 23:27:33 +02:00
Laurent Destailleur
c79f72f785 Fix missing tests on permissions 2024-09-03 16:19:18 +02:00
Laurent Destailleur
c8505f9c0a Fix missing test on permissions 2024-09-01 21:04:53 +02:00
Laurent Destailleur
8d786cb73a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-01 14:35:58 +02:00
Laurent Destailleur
3f9b2d9d57 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-09-01 14:15:57 +02:00