Commit Graph

128 Commits

Author SHA1 Message Date
MDW
a0f515ef12 Qual: Improve write_file typing (part 2) (#30527)
* Qual: Add abstract write_file to ModeleDon

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModeleChequeReceipts

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFRecruitmentCandidature

And update phpdoc for derived classes

* Qual: Add abstract write_file to ModelePDFStock & ModelePDFStockTransfer

And update phpdoc for derived classes

* Qual: Update phpdoc write_file for CommonStickerGenerator classes

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-13 23:58:32 +01:00
Frédéric FRANCE
0f563edb5f replace fetch_projet() and fetch_project() by fetchProject() (#29821)
* fix cti

* fix cti

* deprecate fetch_projet fetch_project to fetchProject

* deprecate fetch_projet fetch_project to fetchProject

* deprecate fetch_projet fetch_project to fetchProject

* odfHandler->setSegment only throw OdfExceptionSegmentNotFound

* odfHandler->setSegment only throw OdfExceptionSegmentNotFound

* fix deprecated

* fix

* fix sql
2024-10-26 22:43:44 +02:00
Frédéric FRANCE
0d7523d928 fix phpstan (#31567)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-10-26 13:05:05 +02:00
MDW
33b9479692 Qual: Ignore phan notice for pagebreak property (#31427)
# Qual: Ignore phan notice for pagebreak property

The access to the undeclared pagebreak property is protected with isset().
So these notices are now suppressed.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-17 01:49:43 +02:00
MDW
9677a370e9 Qual: Nullable mysoc hint (#31393)
* Qual: Nullable mysoc hint

# Qual: Nullable mysoc hint

$mysoc can be nullable resulting in issues (#31387) so
it is best to detect these cases with static analysis

* Prevent null assignment
2024-10-17 01:44:54 +02:00
sonikf
c5587519f0 NEW: PDF Add option to print rounded corner frames (#31172)
* NEW: Add option to enable PDF frame rounded corners

* NEW: function printRoundedRect

* NEW PDF frame rounded corners

* New add rounded corners in frames

* New add rounded corners in frames

* Update admin.lang

* fix incoterm frame height

* Update pdf_sponge.modules.php

* fix pre-commit

* fix pre-commit

* fix php-stan (8.2)

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* fix phan php-stan (8.2) declare property

* New add rounded corners in frames

* New add rounded corners in frames

* add phpdoc for corner radius

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* fix php-stan (8.2)

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* fix whitespace

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* New add rounded corners in frames

* fix pre-commit empty line

* fix phan php-stan (8.2)

* fix phan php-stan (8.2)

* fix Travis

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix title color

* fix phan

* fix phan

* fix phan

* fix phan

* fix phan phpdoc

* fix pre-commit

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-04 09:13:44 +02:00
MDW
7b4c4d772c Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related (#31086)
* Qual: Fix Array of tabs typing hints

# Qual: Fix Array of tabs typing hints

Fixed same typing hints accross several files

* Qual: Fix pdf.lib.php, project.lib.php and related files

# Qual: Fix pdf.lib.php, project.lib.php and related files

Fix most phan notices for pdf.lib.php and project.lib.php.
And fixed some items in other files in the process

* Qual: Fix notifications commande/card advtarget.tpl fichinter/card societe/card supplier_proposal/card

* Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

# Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related

Fix notices in the files for the classes above and other files to accomodate
these changes/fixes
2024-09-23 00:37:30 +02:00
Laurent Destailleur
001dc9378f Fix phan 2024-09-04 22:10:33 +02:00
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661)
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00
MDW
75ed925f06 Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") (#30563)
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add typing hint to fix phan notice.

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add typing hint in phan config to fix phan notice.

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint to fix phan notice.

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for linkedObjectBlock

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for linkedObjectBlock

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for linkedObjects

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)

Add/improve typing hint for PhanPluginUnknownObjectMethodCall

* Fix: MemberNumRefNumbers getExample does not take any arguments

Found thanks to adding the typing for phan!

* Qual: Correct forced type for $module

* Qual: Ignore phan false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Ignore false positive

* Qual: phan/Ignore false positive, replace depr.prop with method

* Qual: Fix typing for count by adding is_array check

* Qual: replace depr.prop `nom` with method

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Fix depr.prop with getter and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: phan/Correct module type and ignore false positive

* Qual: Improve typing for mymodule template

* Make info method arguments match calls

* Make PrintingDriver abstract class because we added abstract methods

* Add phpdoc typing for phan

* Update getExample function signature for compatibility

* Update getExample function signature for compatibility

* Update getExample function signature for compatibility

* Update header wit correct information

* Update getExample method signature

* Update getExample method signature

* Correct reference to class in comment

* Force php phan typing for numbering modules

* Correct $_GLOBALS to $GLOBALS

* Add phpdoc to indicat type of properties

* Correct default to null

* Improve getNextValue typehint

* Improve getNextValue typehint

* Qual: Improve ModeleNumRefTakepos typing

* Qual: Improve ModeleNumRefRecruitmentJobPosition typing

* Fix default for $langs

* Do not use non-existing ModeleNumRefTakepos::nom

* Allow getNextValue argument to be null

* Correct $_GLOBAL into $GLOBALS

* Improve typing for ldap functions

* Allow null for outputlangs argument

* Improve typing for printOriginLine

* Improve typing for linkedObject access

* Fix PhanTypeMismatchArgumentNullableInternal and optimize

* Fix PhanPossiblyUndeclaredVariable by setting default value

* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4

* getToolTip does not accept null, changed to ''

* Improve getNextValue typing

* Change PrintingDriver back to normal class (instantiated)

And add errors for functions that should be overloaded

* Adjust pringOriginLine typing to match parent

* Fix phpdoc for getNextValue

* Fix phan typing

* Add/Improve phpdoc typing hints

* Qual: Adjustments to match typing

* Update typing for unit, use GETPOSTINT

* ModeleNumRefTask needs Project

* Fix several notices appearing after update from develop

* Index for choices is int, use GETPOSTINT

* Qual: Ignore empty foreach

* Force BOMLine on object line

* phan typing to indicate that linked objects are BOM

* Type the correct variable name (phan)

* Add typing for $langs

* Type to CommonNumRefGenerator (no class for availabilities)

* Resolve several phan notices after update from dev branch

* Extra typing fixes

* Move common attributes to parent class (phan)

* Add typing to Calendar class

* Improve typing hints

* Add typing to pdf_eagle_proforma

* Qual: Add typing for token in generic_oauthcallback.php

* Add typing for objMod

* Correct getNextValue function signature (phpstan)

* Fix typing (phpstan)

* Update version declarations (fix phpstan)

* Fix phpstan typing issues

* Adjust typing (phpstan)

* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
8b71242997 Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests (#30544)
* Remove PhanPluginDuplicateExpressionAssignmentOperation from baseline

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* fixup! Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

* Qual: Apply PhanPluginDuplicateExpressionAssignmentOperation as phan suggests

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 02:53:45 +02:00
Laurent Destailleur
033f0aa0a7 Fix translations 2024-08-02 14:52:34 +02:00
Laurent Destailleur
a41d9daa21 Debug v20 2024-08-02 14:35:42 +02:00
Laurent Destailleur
d2bd6a03ec Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-31 13:21:02 +02:00
Laurent Destailleur
038ce032e0 Fix tooltip on numbering modules 2024-07-31 12:40:24 +02:00
Laurent Destailleur
a701f84543 Fix tooltip on numbering modules 2024-07-31 12:14:39 +02:00
Laurent Destailleur
c9b92bb32d Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-25 18:21:47 +02:00
Laurent Destailleur
6b076821e3 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2024-07-25 18:20:01 +02:00
Laurent Destailleur
f4611fcec9 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-07-25 18:06:37 +02:00
Thibault Fiacre
7c9e6b1fb9 FIX lang output for sales representative on PDF (#30469) 2024-07-25 17:56:13 +02:00
Frédéric FRANCE
2707475a12 fix phpstan (#30319)
* fix phpstan

* fix phpstan expects int, false given ...

* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Frédéric FRANCE
ea416aac93 replace old syntax, rename pdf models with same class name (#30271)
* replace old syntax

* replace old syntax

* replace old syntax

* replace old syntax

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* rename files with same class name

* fix class with same name

* fix class with same name

* clean code
2024-07-06 02:59:40 +02:00
Laurent Destailleur
644ba77323 Clean code 2024-05-23 13:34:34 +02:00
Laurent Destailleur
d1e4205e46 Fix bad var 2024-05-23 13:05:49 +02:00
Laurent Destailleur
c8e457c73c Debug v20 2024-05-22 22:21:02 +02:00
lamrani abdelwadoud
7c02a468c5 Fix qr code in stock transf (#29743)
* Fix display Qrcode on stock transfer pdf

* Fix php run
2024-05-22 21:39:59 +02:00
Laurent Destailleur
d7b9e7b4ef Fix warnings 2024-05-22 17:25:31 +02:00
lamrani abdelwadoud
4f0cbb6188 NEW functionality for display codebar on pdf files (#29623)
* NEW functionality for display codebar on pdf files

* update encoding and add option to set pdf

* fix CI/phan

* fix CI/phan

* fix CI/phan

* Update pdf_rouget.modules.php

* Update pdf_eagle.modules.php

* Update pdf_rouget.modules.php

* Update pdf_rouget.modules.php

* fix undeclared variables

* Update pdf_rouget.modules.php

* Update pdf_espadon.modules.php

* Update pdf_eagle.modules.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Lucas Marcouiller <45882981+Hystepik@users.noreply.github.com>
2024-05-22 16:04:18 +02:00
Laurent Destailleur
16336a66ad Rename french module name into english 2024-05-13 10:45:20 +02:00
Frédéric FRANCE
5b349cc318 clean code pdf (#29399) 2024-04-20 22:36:54 +01:00
Frédéric FRANCE
dbd8657de1 Cleanaccount (#29271)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* wip

* wip

* wip
2024-04-20 21:53:40 +01:00
Laurent Destailleur
0fe0cd7c01 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-04-04 11:39:02 +02:00
Laurent Destailleur
a001d48252 Clean duplicate comment 2024-03-31 21:17:20 +02:00
Laurent Destailleur
3bbbf8ac38 Clean code 2024-03-24 16:03:00 +01:00
MDW
e31fa59fd4 Fix typing with phpdoc 2024-03-22 09:52:17 +01:00
MDW
396bf9079e Fix typing with phpdoc 2024-03-22 09:52:16 +01:00
MDW
0f8b9e73f0 Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences
# Fix: Enable/fix PhanPluginPrintfIncompatibleArgumentTypeWeak occurences

Fix the PhanPluginPrintfIncompatibleArgumentTypeWeak occurences and fix the rule
2024-03-14 23:00:47 +01:00
Frédéric FRANCE
0bcd1035cc clean 2024-03-12 09:29:11 +01:00
Frédéric France
e160ba6ba4 clean code and phpdoc 2024-03-11 18:29:41 +01:00
MDW
0b19aa415c Fix: Initialise array before assigning values (#28728)
* Qual: Enable PhanUndeclaredVariableDim

# Qual: Enable PhanUndeclaredVariableDim

The notifications are fixed in the code so the detection no longer
needs to be suppressed in the default flow

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Fix: initialise array before adding fields

* Qual: Add type hint to array to avoid phan notification

* Qual: Add type hint to array to avoid phan notification

* Qual: Enable PhanParamSpecial1 (all resolved)

* Qual: Ignore false PhanTypeArraySuspiciousNullable

* Qual: Improve typing to fix PhanTypeArraySuspicious

* Qual: Fix PhanTypeArraySuspicious by replacing null assignment with empty array

* Qual: Fix PhanTypeArraySuspicious by testing as instancof DebugBar

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Fix PhanTypeComparisonToArray with enhanced typing

* Qual: Enable phan messages that no longer appear

* Qual: Exclude phan stubs from codesniffer ruleset
2024-03-09 16:32:02 +01:00
MDW
7fd606b336 Qual: Ignore/workaround SuspiciousParamOrder detection (#28688)
* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)

* Qual: Ignore/workaround SuspiciousParamOrder detction

# Qual: Ignore/workaround SuspiciousParamOrder detction

Ignore the false positive SuspiciousParamOrder or workaround (rename vars)
2024-03-08 12:34:25 +01:00
MDW
abbec034c6 Qual: Several typing hints/some fixes. (#28483)
* Update documentation to improve static tool messages

* Suppress PhanPluginSuspiciousParamOrder

* Fix typing hint

* Fix typing hint (number->int)

* Fix typing hint (PDF->TCPDF)

* Fix typing hint (PDF->TCPDF)

* Modify code to hint typing check

* Correct Noop statement (createfromclone)

* Remove useless if/else with same result

* Suppress PhanRedefineFunctionInternal

* Suppress PhanParamSuspiciousOrder

* Suppress PhanPluginDuplicateArrayKey

* Suppress multiple phan messages

* Ignore PhanPluginSuspiciousParamOrder

* Add phan typing

* Remove useless if statement

* Remove useless if/else condition

* Remove useless if

* Remove useless if

* Join duplicate if/else statements

* Fix useless if

* Fix useless if

* Fix phan notice by optimizing 2**$i to 1<<$i
2024-02-28 15:36:29 +01:00
MDW
b72294bf4c Fix: Typing for PDF parameter (#28383)
* Fix: Typing for PDF parameter

# Fix: Typing for PDF parameter

Change PDF to known type.

* Fix: Typing for PDF parameter

# Fix: Typing for PDF parameter

Change PDF to known type.
2024-02-24 14:07:21 +01:00
thibdrev
aadea9db4f qual: phpstan for htdocs/core/modules/stocktransfer/doc/pdf_eagle.modules.php (#28286)
htdocs/core/modules/stocktransfer/doc/pdf_eagle.modules.php	182	Property pdf_eagle::$atLeastOneBatch (int) does not accept bool.
2024-02-20 02:02:18 +01:00
Laurent Destailleur
e9a0905fba Use same return 2024-02-13 11:14:11 +01:00
MDW
7b54824d49 Fix #28071 - New branch to fix bad merge (#28083)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Qual: Introduce getDataToShowPhoto to prepare generic code

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix missing trans

* Fix langs

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Remove useless files in web templates

* Clean code

* Fix duplicate translation key

* Fix duplicate translation key

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix duplicate key

* Fix $object

* Debug v19

* WIP SMSing

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP EMAILINGS_SUPPORT_ALSO_SMS

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP SMSing

* Debug the "validate" feature

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Clean code

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Enhance rector to fix empty($user->rights->modulex->perm1)

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Fix template to use v19 dev rules

* Fix use v19 dev rules

* Fix phpunit

* Debug v19

* Clean code

* Use rector to convert user->rights into user->hasRight

* Clean code

* Use rector to convert user->rights into user->hasRight

* Use rector to convert user->rights into user->hasRight

* Clean code

* Fix phpcs

* add editorconfig for sql files (#27999)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* add model_pdf field in llx_ticket-ticket.sql (#27996)

* add model_pdf field in llx_ticket-ticket.sql

* Update 19.0.0-20.0.0.sql

* Update 19.0.0-20.0.0.sql

* Improve wording in README (#27994)

* fix phpstan (#27989)

* fix phpstan

* Update UserRightsToFunction.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* Qual: Fix spelling/working in datapolicy translations (#28006)

# Qual: Fix spelling/wording in datapolicy translations

Fixed some spelling and wording in datapolicy translations.

* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986)

htdocs/ticket/class/ticketstats.class.php	98	Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()

* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix user with readonly perm on email template must be able to read.

* Fix doc

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Better message

* Add missing fields in merge of thirdparty

* Debug v19 selection of ticket printer per terminal

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Use constant

* NEW: Adding a recipient on emails sent, change status to sent partialy.

* fix travis (#28052)

* fix travis

* Update partnership.class.php

* fix php doc (#28047)

* fix undefined array key (#28048)

* Add region and departament for Cuba (#28046)

* Update llx_10_c_regions.sql

Add Cuba Regions (id_country=77)

* Update llx_20_c_departements.sql

Add Provinces Cuba (id country=77)

* Find the typo (#28050)

* Find the typo

* clean code

* add last_main_doc field to product (#28045)

* add las_main_doc field to product

* add field fetch

* NEW Add Categorie filter for ActionComm (#28041)

* New Add Categorie filter for ActionComm

New Add Categorie filter for ActionComm

* Fix space errors

Fix space errors

* Fix space errors 2

Fix space errors 2

* Update cunits.class.php (#28056)

FIX: error SQL when creating a Cunit

* Update codespell-lines-ignore.txt to avoid PR merge conflict

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: thibdrev <thibault.drevet@gmail.com>
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com>
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com>
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com>
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com>
2024-02-09 15:58:49 +01:00
Frédéric France
a1e117283d fix warnings 2024-01-15 21:28:19 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Frédéric FRANCE
677109df41 fix phpstan (#27483)
* fix phpstan

* fix phpstan
2024-01-13 15:32:07 +01:00