Laurent Destailleur (aka Eldy)
77c5fe5500
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-12-06 12:21:22 +01:00
Laurent Destailleur (aka Eldy)
d897ef74c1
Fix bug due to mix periode / period
2024-12-06 12:21:00 +01:00
MDW
ec2a1928ba
Qual: Update fields phpdoc to include fields that are defined/used in some cases
...
# Qual: Update fields phpdoc to include fields that are defined/used in some cases
comment, copytoclipboard, autofocusoncreated are documented and used in some cases for the
$fields definition
2024-12-05 02:36:50 +01:00
Frédéric FRANCE
efcf6c6b24
fix pre-commit and CI ( #32213 )
...
* fix pre-commit
* fix phpstan
* clean code
2024-12-03 20:34:47 +01:00
Norbert Penel
f6fe770695
Add extrafield support on API for expensereport.class.php ( #32184 )
...
* Add extrafield support on API for expensereport.class.php
https://github.com/Dolibarr/dolibarr/issues/29178
* Update expensereport.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-12-01 23:24:27 +01:00
Laurent Destailleur
6e9bbe42bb
Add code to make easier to test PDF generation with n lines of product
2024-11-21 19:40:52 +01:00
Lucas Marcouiller
5f5fc076b5
fix undefined property in expensereportline class ( #31854 )
...
Co-authored-by: Hystepik <lmarcouiller@nltechno.com >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-16 10:55:31 +01:00
MDW
178d748cad
Qual: Fix phan/phpstan notices in class files (part 5) ( #31617 )
...
* Qual: fix commonstickergen..don.class
* Fix notifications for pdf_paiement...cronjob.class
* Qual: Fix notifications for emailcollector..price_parser.class
* Ensure that NULL is used in the database when fk's are 0/empty
* Fix notifications for pdf_paiement...cronjob.class
* Cope with updated phpstan, and make fk_origin_stock int in multiple locations
2024-11-06 20:15:15 +01:00
MDW
e7539f2e19
Qual: Fix notices in .lib.php files ( #31672 )
...
* Qual: Fix notices in .lib.php files
* Update wrapper.php
* Update availabilities_card.php
* Update index.php
* Update document.controller.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 12:32:13 +01:00
Laurent Destailleur
e6f1d4835f
Clean sql code
2024-10-29 02:58:20 +01:00
Frédéric FRANCE
03fa5617da
move trigger into line class ( #31457 )
...
* move trigger into line class
* move trigger into line class
* fix
2024-10-19 01:14:20 +02:00
MDW
53cfbc35be
Qual: Fix several phan & stan notices ( #31308 )
...
* Qual: Fix several phan & stan notices
# Qual: Fix several phan & stan notices
Several fixes in files while fixing UnknownClass notices
* Qual: Update prepare_head PHPDoc return types
# Qual: Update prepare_head PHPDoc return types
Provide detailed array return types for prepare_head functions.
* Fix new phan notice
* Better loadLangs typing and fix call to loadLangs
* Fix new issues (stats)
* Other fixes of new issues
* Qual: update phan baseline
2024-10-14 01:59:44 +02:00
MDW
8236aed22f
Qual: Fix phan notices ( #31193 )
...
# Qual: Fix phan notices
Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
William Mead
7bf0596f3c
Qual isolate expense report line class to separate file ( #30953 )
...
* Moved expense report line class to separate file. Updated requires. Added contributor details.
* Updated PHPDoc
* Fixed PHPDoc
2024-09-23 03:34:00 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
MDW
7b4c4d772c
Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related ( #31086 )
...
* Qual: Fix Array of tabs typing hints
# Qual: Fix Array of tabs typing hints
Fixed same typing hints accross several files
* Qual: Fix pdf.lib.php, project.lib.php and related files
# Qual: Fix pdf.lib.php, project.lib.php and related files
Fix most phan notices for pdf.lib.php and project.lib.php.
And fixed some items in other files in the process
* Qual: Fix notifications commande/card advtarget.tpl fichinter/card societe/card supplier_proposal/card
* Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related
# Qual: Fix notices for FormSms, RssParser, ExpenseReportIk and related
Fix notices in the files for the classes above and other files to accomodate
these changes/fixes
2024-09-23 00:37:30 +02:00
Frédéric FRANCE
2a6bbf88df
fix phpstan ( #30944 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-13 17:40:03 +02:00
ptibogxiv
a94c94abb3
Update api_expensereports.class.php with pagination ( #30815 )
...
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-04 23:14:45 +02:00
MDW
a8367a6cd8
Qual: Fix getNextValue related phan notices (part2) ( #30752 )
...
* Qual: 🛟 Fix reference to $db with $this->db
# Qual: reference to $db with $this->db
$db was undeclared, use $this->db.
* Fix suspected issue with environment max size and md5sum working on limited files
* Qual: Fix LDAP typing
* Qual: Fix getNextValue related phan notices (part2)
* Update baseline
* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
MDW
ca414de526
Qual: Fix $fields related notices with Phan ( #30704 )
...
* Qual: Typing hints/ignore directives for phan notices
* Update field typing
2024-08-21 13:23:35 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
54880f92cd
Qual: Fix PhanTypeMismatchProperty and some other phan notices ( #30542 )
...
* Qual: Fix PhanTypeMismatchProperty and some other phan notices
* Qual: Phan fixes for BOM
* Phan - fix fields
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Fix $fields phpdoc
* Fix phan typing issues with intermediate var and ??
* Fix phan typing issue with ?? operator
* Ignore htdocs/install/install.forced.php for git
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Update baseline
* Qual: Phan fixes for BOM
* fixup! Qual: Phan fixes for BOM
* Fix phpstan double array keys for syslog
* Qual: Revert to original code, ignore notice
When changing the method to avoid one notice type, another one
appears. So simply ignoring this error.
* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration
* Fix typing hints (phpstan)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-15 17:05:00 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
Laurent Destailleur
f002fb4ed1
Use the non deprecated function loadRights instead of getrights
2024-08-02 10:36:43 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Frédéric FRANCE
741e75ee47
add phpdoc ( #29832 )
...
* add phpdoc
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* fix phan
* add phpdoc
* fix phan
* fix phan
2024-06-04 14:46:54 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Frédéric FRANCE
4ed203bece
fix phpstan ( #29382 )
...
* fix phpstan
* remove unused code
2024-04-18 11:21:09 +01:00
Laurent Destailleur
b5de782c6b
Fix use the good HTTP code
2024-04-07 14:59:25 +02:00
thibdrev
229c2dd4b6
qual: phpstan for api_expensereports.class.php
...
htdocs/expensereport/class/api_expensereports.class.php 608 Method ExpenseReports::getPayments() should return array but returns object.
htdocs/expensereport/class/api_expensereports.class.php 680 Method ExpenseReports::updatePayment() should return int but returns object.
2024-04-04 21:06:31 +02:00
Laurent Destailleur
ad79acf63c
QUAL removed duplicate language file
2024-04-04 11:00:35 +02:00
Laurent Destailleur
7715513ac9
Some API HTTP return code were moved from 401 to 403 to better follow
...
REST specification.
2024-04-02 14:47:49 +02:00
Laurent Destailleur
9811ef1a78
Fix phpstan
2024-04-02 14:43:05 +02:00
Laurent Destailleur
990216b13f
NEW Api parameters are sanitized by the WAF, same code than GET/POST
2024-04-02 13:07:13 +02:00
MDW
08733e8aed
Fix a final left add operand typing issue + some typos
2024-03-22 09:52:43 +01:00
MDW
1164ba68d5
Fix labelStatus typing, casts for typing, PHPdoc
2024-03-22 09:52:40 +01:00
MDW
1e0f368d6a
Fix $mybool |=... which is binary op, not boolean op
...
# Fix $mybool |=... which is binary op, not boolean op
This fixes PhanTypeInvalidLeftOperandOfBitwiseOp.
Replace $var |= ... with $var = ... || $var .
Add cast before ... when needed (@include does not always return bool).
|= always evaluates expression, there for || $var, not $var ||
2024-03-21 13:45:16 +01:00
MDW
9b2c6e2afb
Fix arg type to preg_match(),preg_replace() with cast
2024-03-20 04:09:28 +01:00
Laurent Destailleur
5d073ac208
Fix hasRights into hasRight
2024-03-19 22:02:42 +01:00
MDW
a46dfec5c6
Fix return type for deleteLine
2024-03-19 00:32:05 +01:00
MDW
fd9d48faac
Fix phpstan CommonObject->fields - notnull is optional field
2024-03-19 00:32:00 +01:00
Frédéric France
17ea003a69
fix phpstan
2024-03-17 21:20:36 +01:00
Frédéric France
26303dc4d3
fix phan
2024-03-17 13:21:34 +01:00
Frédéric France
5e5995731d
fix phan
2024-03-17 13:17:51 +01:00
Frédéric France
912be1e1bd
fix phan
2024-03-17 13:15:37 +01:00
Laurent Destailleur
0ee6fd6bad
Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
...
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00
Laurent Destailleur
e3c4c1aff0
Fix warning
2024-03-15 15:16:22 +01:00
MDW
8495a75f43
Fix PhanTypeMismatchDefault by removing defaults, update typing
...
Also remove some unused references to globals
2024-03-15 14:53:01 +01:00
