Commit Graph

486 Commits

Author SHA1 Message Date
Frédéric FRANCE
286c3d1093 fix sql ticket list (#32080)
* fix sql ticket list

* fix sql ticket list

* fix phpstan

* fix

* fix
2024-11-28 12:11:50 +01:00
Frédéric FRANCE
15490b292f fix phpstan and fix CI (#31739)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-11-10 11:16:23 +01:00
Laurent Destailleur
feeda29328 Fix phan 2024-11-07 15:08:44 +01:00
Laurent Destailleur
31f147622a The deprecated GET parameter "&sall=" has been removed, use now the
"&search_all=".
2024-11-07 12:26:42 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
MDW
0c26110636 Qual: Fix notices related to user classes (#31291)
# Qual: Fix notices related to user classes

This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
Laurent Destailleur
b1ee18864f Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 01:43:43 +02:00
Laurent Destailleur
c8bae560f1 Debug v20 2024-09-11 17:59:12 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
William Mead
40c090d550 FIX late project search option (#30739)
* Fixed search late project. Added search late project checkbox.

* Added contributor details
2024-08-23 14:58:50 +02:00
Laurent Destailleur
bd57bcf617 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-15 19:52:31 +02:00
Laurent Destailleur
d2f286fddb Fix css 2024-07-15 11:52:21 +02:00
Laurent Destailleur
ab6c02aa9e Fix css 2024-07-15 11:48:22 +02:00
Laurent Destailleur
0ece58dcd1 Fix css 2024-07-15 11:41:00 +02:00
Anthony Damhet
c1270ac2f5 Add llxHeader to projects (#30357)
* Add llxHeader to projects

* Correction llxHeader for compta/prelevement

* Add space after comma

* Add missing space

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-13 18:10:40 +02:00
Laurent Destailleur
147a8bfaee Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	htdocs/adherents/subscription/list.php
	htdocs/categories/viewcat.php
	htdocs/contrat/card.php
	htdocs/contrat/list.php
	htdocs/eventorganization/conferenceorbooth_list.php
	htdocs/expedition/list.php
	htdocs/societe/card.php
2024-07-11 10:44:39 +02:00
Laurent Destailleur
3b98b16b35 NEW Add country in search of project 2024-07-11 10:10:39 +02:00
Alexandre SPANGARO
128769811c Add css bodylist on list (#30334)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-11 00:45:05 +02:00
Laurent Destailleur
8a4f550d64 Debug v20 2024-07-09 17:33:27 +02:00
Laurent Destailleur
253fdba882 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-07-02 23:11:21 +02:00
Laurent Destailleur
331fb36f47 Debug v20 2024-07-02 18:52:26 +02:00
Laurent Destailleur
a75d6e6ffe Finished the groupby experimental into project list 2024-07-02 18:46:20 +02:00
Zephyriony
4170bd410c NEW Opacity for finished lines (#30219)
* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

* Update list.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-07-01 14:17:44 +02:00
Alexandre SPANGARO
96afcaa476 Better comments (#30200)
* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* Fix language

* CI Missing language key

* Update eventorganization.lang

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-06-30 21:02:50 +02:00
Laurent Destailleur
e92302a41b Debug v20 2024-06-20 17:16:53 +02:00
Laurent Destailleur
eb4474dfa6 Fix vardump 2024-05-29 23:24:10 +02:00
Laurent Destailleur
386a40b4a6 Debug look and feel v20 - Fix groupby in kanban 2024-05-29 23:23:20 +02:00
Laurent Destailleur
1cea3e36cd Debug v20 2024-05-25 15:14:49 +02:00
Laurent Destailleur
66f4562300 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-05-23 14:50:17 +02:00
Laurent Destailleur
a854e58905 FIX Missing $param in hook call for list 2024-05-23 14:41:56 +02:00
Laurent Destailleur
29ce64ec07 Debug v20 2024-05-20 22:59:01 +02:00
Laurent Destailleur
21be37d308 Work on prototype for kanban grouped by type 2024-05-20 22:53:04 +02:00
Laurent Destailleur
47511a6903 PERF Use cache for loaded users/contact on project list 2024-05-08 12:17:08 +02:00
Laurent Destailleur
8b84be2d6c Add select component to support correctly option C
ONTACT_USE_SEARCH_TO_SELECT
2024-05-07 19:59:20 +02:00
Laurent Destailleur
e3daa23949 Look and feel v20 2024-04-30 09:45:28 +02:00
Laurent Destailleur
1908d6cf98 Look and feel v20 - All combo of categories are using the colored picto 2024-04-24 02:40:53 +02:00
Laurent Destailleur
1e3b2c6a7c Try to fix GETPOSTINT regressions 2024-04-19 13:34:48 +02:00
Benjamin Falière
948e204fae ADD arrayfields as parameter in doActions (#29326)
* ADD arrayfields as parameter in doActions

* FIX typo

* FIX syntax error

---------

Co-authored-by: Benjamin Falière <benjamin.faliere@altairis.fr>
2024-04-11 20:07:13 +02:00
MDW
e64e57716c Fix fatal (PHP8.X) type issue with abs, and amend dol_eval return type
# Fix fatal (PHP8.X) type issue with abs, and amend dol_eval return type

I got the following message:
`Fatal error: Uncaught TypeError: abs(): Argument #1 ($num) must be of type int|float, string given in D:\mdeweerd\workspace\dolibarr\htdocs\projet\list.php on line 233`

I examined the phan report and there was no mention of this because dol_eval was
said to return mixed.

In order to detect such cases, I amended the dol_eval return type to ensure to find
most of the locations where a cast is needed.
2024-04-02 22:52:52 +02:00
Frédéric France
7a7b1953ed fix phpstan 2024-03-28 20:34:33 +01:00
MDW
aeefca7e7e Fix $arrayfields typing lost by dol_sort_array() by forcing the type 2024-03-20 23:29:48 +01:00
MDW
dfd47dfe2c Fix: Ensure string type for urlencode() 2024-03-09 16:56:38 +01:00
Laurent Destailleur
7866ee472b QUAL Clean code around dol_eval use 2024-03-06 17:07:24 +01:00
Laurent Destailleur
67d637554c Fix regression with GETPOSTINT, not same than GETPOST(..., 'int') 2024-03-04 10:55:52 +01:00
Laurent Destailleur
04c560faa4 Fix warning 2024-03-01 01:52:40 +01:00
Laurent Destailleur
ef224a7a45 Clean code 2024-02-29 16:48:52 +01:00
MDW
abbec034c6 Qual: Several typing hints/some fixes. (#28483)
* Update documentation to improve static tool messages

* Suppress PhanPluginSuspiciousParamOrder

* Fix typing hint

* Fix typing hint (number->int)

* Fix typing hint (PDF->TCPDF)

* Fix typing hint (PDF->TCPDF)

* Modify code to hint typing check

* Correct Noop statement (createfromclone)

* Remove useless if/else with same result

* Suppress PhanRedefineFunctionInternal

* Suppress PhanParamSuspiciousOrder

* Suppress PhanPluginDuplicateArrayKey

* Suppress multiple phan messages

* Ignore PhanPluginSuspiciousParamOrder

* Add phan typing

* Remove useless if statement

* Remove useless if/else condition

* Remove useless if

* Remove useless if

* Join duplicate if/else statements

* Fix useless if

* Fix useless if

* Fix phan notice by optimizing 2**$i to 1<<$i
2024-02-28 15:36:29 +01:00