Commit Graph

3166 Commits

Author SHA1 Message Date
MDW
45184e9741 Qual: Update phan baseline (#36318)
# Qual: Update phan baseline

Remove fixed notices from exceptions.
2025-11-19 10:58:00 +01:00
Frédéric FRANCE
8d459e469d clean code (#36260)
* clean code

* clean code

* clean code

* clean code

* fix $val might not be defined

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* fix phpstan errors reported

* ignore phpstan reported for later

* clean code

* clean code

* clean code

* clean

* test
2025-11-18 11:41:28 +01:00
MDW
991706e731 FIX: Fix version extraction in setup_conf.sh (#36281)
# FIX: Fix version extraction in setup_conf.sh

The version extraction regex was updated to handle both DOL_VERSION and DOL_MAJOR_VERSION constants in version.inc.php.
The version is now available as DOL_MAJOR_VERSION since 29b1e75

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-17 22:05:33 +01:00
MDW
1072419141 Qual: Update pre-commit hooks (#36262)
* Qual: Update pre-commit hooks

# Qual: Update pre-commit hook

Updated several pre-commit hooks as long as the new ones are not alpha or beta versions

* Qual: Fix/ignore some shellcheck issues
2025-11-17 21:50:29 +01:00
github-actions[bot]
f799113fac PHPStan > Update baseline (#36264)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-17 21:47:22 +01:00
Laurent Destailleur
4703344acc Debug 2025-11-17 16:50:53 +01:00
Laurent Destailleur
7b6186c137 Doc 2025-11-17 16:45:04 +01:00
Laurent Destailleur
e8e61605da Doc 2025-11-17 16:41:58 +01:00
Laurent Destailleur
68e6bedd27 The script generate_filelist_xml.php can check integrity from command
line.
2025-11-17 16:39:27 +01:00
Laurent Destailleur
72afda872d WIP LNE 2025-11-17 13:53:53 +01:00
github-actions[bot]
1578715f54 PHPStan > Update baseline (#36242)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-13 16:57:26 +01:00
Laurent Destailleur
65024ebf63 Fix bad translation string 2025-11-12 17:34:53 +01:00
Frédéric FRANCE
d07e8c03a0 avoid changing object after call (#36159)
* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* avoid changing object after call

* clean code

* clean code

* clean code

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* clean code

* clean

* clean

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-12 09:44:39 +01:00
PierrickV
6e3fabeeab Fix typo in DLLMissing message for MyGerman.isl (#36223)
* Fix typo in DLLMissing message for MyGerman.isl

Typos:
- s/Mcrsoft/Microsoft/g
- s/credist_x86.exe/vc_redist.x86.exe/g
- dl link

* Fix DLLMissing message link for Visual C++ Redistributable

Updated the link for the Microsoft Visual C++ Redistributable installation instructions.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-12 09:38:55 +01:00
github-actions[bot]
1ee0c4f4ba PHPStan > Update baseline (#36208)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-11 08:52:46 +01:00
Frédéric FRANCE
4334797588 clean code (#36179)
* clean code

* clean code

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-09 17:59:36 +01:00
MDW
0831c65913 Qual: Update Phan baseline.txt (#36190)
#Qual: Update Phan baseline.txt

Update the Phan baseline.txt file to reflect changes in the number of occurrences of specific issues.
2025-11-09 17:58:08 +01:00
Frédéric FRANCE
114131d59d clean code (#36180)
* clean code

* clean code

* clean code
2025-11-09 01:34:33 +01:00
Frédéric FRANCE
eaf2b694c0 ticket progress nullable (#36178)
* ticket progress nullable

* ticket progress nullable
2025-11-09 01:32:47 +01:00
Frédéric FRANCE
ca0052e82d clean code (#36176)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-08 19:29:54 +01:00
Frédéric FRANCE
e343b4ab1f clean code (#36166)
* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-08 14:01:19 +01:00
Frédéric FRANCE
223ce3fb84 clean code (#36157)
* clean code

* clean code
2025-11-08 11:31:09 +01:00
Frédéric FRANCE
cad3574179 common delete also files (#36146)
* common delete also files

* common delete also files

* common delete also files

* common delete also files

* common delete also files

* common delete also files
2025-11-07 18:44:14 +01:00
Frédéric FRANCE
a420e9a79a clean code (#36154)
* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-07 18:41:56 +01:00
github-actions[bot]
f70e12fc2b PHPStan > Update baseline (#36151)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-07 18:41:01 +01:00
Frédéric FRANCE
3a8b82ec0e clean workstation setup (#36100)
* clean workstation setup

* clean workstation setup

* clean setup
2025-11-05 22:24:02 +01:00
github-actions[bot]
0411367b8a PHPStan > Update baseline (#36108)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-11-05 22:22:43 +01:00
Frédéric FRANCE
13bc1e2e16 clean code (#36098)
* clean code

* clean baseline
2025-11-04 18:46:24 +01:00
Frédéric FRANCE
39f54ca1d0 test phpstan (#36069)
* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* test phpstan

* clean baseline

* test

* test
2025-11-04 18:41:36 +01:00
Laurent Destailleur
f355bff45a Fix scc 2025-11-04 12:50:17 +01:00
MDW
c4712cbca7 Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php (#36068)
# Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php

- Update pertype.php and peruser.php to resolve PhanTypeComparisonFromArray notices.
When an array value is set, it's already an array so comparing to '' is
useless and invalid.
- Update baseline.txt to reflect reduced occurrences of phan issues.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-02 16:56:31 +01:00
MDW
be588ee1be Qual: Update TVA intra field reference in quadri_detail.php (#36064)
- Changed reference from 'tva_intra' to 'company_tva_intra' in multiple locations
- Updated baseline.txt to reflect reduced occurrences of PhanTypeArraySuspiciousNull and PhanPluginUndeclaredVariableIsset
2025-11-02 13:06:34 +01:00
MDW
2de1724786 Qual: Fix donation notices (#36058)
* Qual: Fix missing abstract isEnabled for ModeleDon

# Qual: Fix missing abstract isEnabled for ModeleDon

* Qual: Fix donation list fields

# Qual: Fix donation list fields

Fixes PhanTypeMismatchProperty issues in don/list.php by typecasting and
adding d.ref field to query & using it.

* Fix: Fix call to ModeleDon::write_file

- Refactored write_file method in don.class.php to extraneous parameters
- Removed PhanParamTooMany warning from baseline.txt

* Qual: Remove duplicate assignment in list.php

Removed redundant assignment of projectstatic.id.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-02 12:58:12 +01:00
MDW
6c5cd1c7b0 Fix: Uniform assign_values method signatures (#36063)
# Fix: Uniform `assign_values` method signatures

`Canvas` is calling `assign_values` with three arguments, so all methods
must have three arguments.

- Modified `actions_adherentcard_common.class.php` and `actions_contactcard_common.class.php` to add object reference parameter
- Updated `actions_adherentcard_default.class.php` and `actions_contactcard_default.class.php` to pass reference parameter to parent class
- Updated Phan baseline to reflect changes in canvas classes
2025-11-02 12:49:33 +01:00
MDW
7655c259f8 FIX: Define keyCodeForEnter before first use (takepos) (#36060)
# FIX: Define keyCodeForEnter before first use (takepos)

Move the code to get the keyCodeForEnter from the bottom of the file closer to the top.
This ensure that the variable is defined before first use.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 22:43:24 +01:00
Frédéric FRANCE
dd58e49736 clean code (#36057)
* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 22:42:12 +01:00
Frédéric FRANCE
ff7a684a0a clean code (#36054)
* clean code

* clean code

* avoid obj to be false

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-11-01 17:48:18 +01:00
MDW
073426d97e Qual: Fix multiple phan notices, update baseline (#36022)
* Qual: Fix phan notice with copy of attribute

* Qual: Fix phan notices with cast and updated param definition

* Qual: Fix phan notice with cast

* Qual: Update parameter type hint in utf8_check function

The parameter type hint for the $str parameter in the utf8_check function has been updated to include nullable types (string or int).

* Qual: Update User parameter type to nullable in call_trigger methods

The User parameter in call_trigger methods has been updated to be nullable to accommodate cases where the user object might not be available. This change ensures better flexibility and robustness in the codebase.

* Qual: Update phan baseline

* Qual: phpstan compatible type

* Qual: Add missing type hints for phan

- Add missing type hints for phan
- Fix indentation issues
- Improved consistency in code structure

* Qual: Update field configuration for backward compatibility

Enhanced the field configuration for backward compatibility by adding expected properties to the 'ref' field array.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 17:47:28 +01:00
Frédéric FRANCE
0a3d2c7ddc clean code (#36053)
* clean code

* clean code
2025-11-01 17:47:13 +01:00
Frédéric FRANCE
e00559b242 fix CI after file rename (#36021)
* fix CI after file rename

* clean code

* clean code

* clean code

* clean code

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 03:12:58 +01:00
Frédéric FRANCE
bda086bf0e add missing translation and clean code (#35956)
* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add missing translation

* add doc

* add doc
2025-10-29 22:25:23 +01:00
Frédéric FRANCE
77a06a6cfd fix CI (#35995)
* Update phpstan-baseline.neon

* Update phpstan-baseline.neon

* Update societe.class.php

* Update societe.class.php
2025-10-29 22:07:14 +01:00
Laurent Destailleur
9214ee5d2a Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2025-10-28 13:07:31 +01:00
Laurent Destailleur
a1b4d1a06e WIP LNE 2025-10-28 13:07:19 +01:00
Frédéric FRANCE
34a1c824b7 NEW public pages donation, ticket and member use captcha setup (#35913)
* donation use captcha setup

* donation use captcha setup

* member use captcha setup

* member use captcha setup

* member use captcha setup

* member use captcha setup

* member use captcha setup

* ticket use captcha setup

* ticket use captcha setup

* clean

* clean
2025-10-28 02:21:06 +01:00
Frédéric FRANCE
7342a58044 clean phpstan baseline for supplier invoice class (#35945)
* clean phpstan baseline for supplier invoice class

* clean phpstan baseline for supplier invoice class
2025-10-28 01:25:46 +01:00
Frédéric FRANCE
03ea0cda01 clean code class commondict (#35952)
* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* add fetchAll in abstract class commondict

* clean code
2025-10-28 01:25:30 +01:00
Frédéric FRANCE
972295ea3c add missing translation (#35958) 2025-10-28 01:13:14 +01:00
Frédéric FRANCE
a487ce4923 add missing translation (#35959)
* add missing translation

* add missing translation

* clean missing
2025-10-28 01:12:45 +01:00
Frédéric FRANCE
9b512f565f try to make new checks (#35976)
* try to make new checks

* try to make new checks

* try to make new checks

* try to make new checks

* try to make new checks

* try to make new checks
2025-10-28 00:57:01 +01:00