* Qual: Make $fields covariant
* Qual: Update BankAccounts class phpDoc ($FIELDS)
# Qual: Update BankAccounts class phpDoc ($FIELDS)
Updated the documentation for the $FIELDS property.
# Qual: Fix PhanTypeComparisonFromArray in pertype.php and peruser.php
- Update pertype.php and peruser.php to resolve PhanTypeComparisonFromArray notices.
When an array value is set, it's already an array so comparing to '' is
useless and invalid.
- Update baseline.txt to reflect reduced occurrences of phan issues.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Manage STOCK_MUST_BE_ENOUGH_FOR_(PROPAL|ORDER|INVOICE) with new attribute stockable_product
* Use static properties for product types. Controle product type service.
* simpler condition for STOCK_MUST_BE_ENOUGH_FOR_PROPOSAL
* Add hook manager support for appending custom filter clauses across various SQL queries.
* Add hook manager support for custom SQL filters across multiple modules.
* Remove obsolete test code from api_proposals.class.php
* Remove unnecessary blank lines in card.php
* Remove unnecessary blank lines in card.php
* Remove unused object initialization and 'boxcode' parameter in product class
* Update api_proposals.class.php
* Initialize hooks for order API access
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix incorrect total discount (missing loop after GROUP BY query)
* Make phpcs happy
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix incorrect total discount (missing loop after GROUP BY query)
* Make phpcs happy
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
This patch fixes task events so that they are correctly displayed in the
task event list and that in the event the Linked Object referes back to
the task.
The issue was that the elementtype value in the database was being
referenced as both 'project_task' and 'task' by different parts of code
Co-authored-by: brad <brad@endurotags.com.au>
# Qual: Fix phan notices
Some type hints updates + correction to get week from date (action/pertype.php)
+ check that value is not null (pdf_* classes).
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Update commonobject.class.php
* Refactor checkActiveProductInLines method
* Fix comment formatting in commonobject.class.php
* Update commonobject.class.php
---------
Co-authored-by: vmaury <vmaury@vmaury-Lafite-Pro-16-AMD>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* New: Adding linked project to mass mailing card
* modify project on mailing card
* mailing card load fk_project pre commit fix
* only fetch projects with id>0
* fix PHPstan errors regarding mesg
* projects related to mass mailings does not have a soc or socid
* remove last trace of soc and socid
* checking if mesg is set before using it
* just loading all projects, because maybe you have a mailing list with workers for a thirdparty? think company party
* showing the project during edit
* given that action is already something else, it will never not be classify
* making PHPstan happy
* Adding project column to list of mass mailings. Search, order and click able
* pasted the wrong place
* no need to check for filtermail
* x now also clears project search
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Mass mailing list: make title a clickable link
* Update list.php
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix: 3 modules where list.php redirected to /mymodule/myobject_card.php
* remove an commented segment of the code which did the same kind of dolbuildpath to /mymodule/myobject_card.php which is obviously wrong, since it was a comment anyway, no risk
* remove an commented line of the code which did the same kind of dolbuildpath to /mymodule/myobject_card.php which is obviously wrong, since it was a comment anyway, no risk
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
