# Qual: Fix phan notices
Some type hints updates + correction to get week from date (action/pertype.php)
+ check that value is not null (pdf_* classes).
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Fix#35700 : Throw an error when validating a propal, order, supplier proposal, supplier order if some products doesn't have the good status (on sale, on buy)
* Update commonobject.class.php
* Refactor checkActiveProductInLines method
* Fix comment formatting in commonobject.class.php
* Update commonobject.class.php
---------
Co-authored-by: vmaury <vmaury@vmaury-Lafite-Pro-16-AMD>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* New: Adding linked project to mass mailing card
* modify project on mailing card
* mailing card load fk_project pre commit fix
* only fetch projects with id>0
* fix PHPstan errors regarding mesg
* projects related to mass mailings does not have a soc or socid
* remove last trace of soc and socid
* checking if mesg is set before using it
* just loading all projects, because maybe you have a mailing list with workers for a thirdparty? think company party
* showing the project during edit
* given that action is already something else, it will never not be classify
* making PHPstan happy
* Adding project column to list of mass mailings. Search, order and click able
* pasted the wrong place
* no need to check for filtermail
* x now also clears project search
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Mass mailing list: make title a clickable link
* Update list.php
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix: 3 modules where list.php redirected to /mymodule/myobject_card.php
* remove an commented segment of the code which did the same kind of dolbuildpath to /mymodule/myobject_card.php which is obviously wrong, since it was a comment anyway, no risk
* remove an commented line of the code which did the same kind of dolbuildpath to /mymodule/myobject_card.php which is obviously wrong, since it was a comment anyway, no risk
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
* NEW API for handling mailing targets
* fix PHP Codesniffer
* adding return values to make phpstan happy
* Update function actually updates
* defining mailing_target public function create
* using a different language translation
* mailing_target - phpstan fixes
* mailing target - no check properties body
* mailing target int typecast fk_mailing
* mailing target - just 1 parameter
* mailing_target phpstan fixes
* mailing_target setting labelStatus
* mailing target class public function delete
* reveal the list of status name for the Mass mailing object in the API
* set tms to now when it is set to draft
* functions to set the mailing target status
* hurl testing api mailings
* hurl test - exit run script at first error
* hurl test mailings - should cover all endpoints
* using self:: in front of the CONST
* Trying to find out which line evaluates to noting
* API mailings can now get the targets of a mailing
* Protected method name "Mailings::_cleanTargetDatas" must not be prefixed with an underscore
* give me fk_project
* API endpoints for: Get all targets of a mass mailing + Get information about a specific target id
* API endpoint to update a mailing target
* telling pre-commit check to ignore, just like done in the function I copied
* be more explicit about for GUI tests we need username and password
* Prevent updating fk_mailing value
* API endpoint deleteTarget
* post to create a mailing target does work, but need slight more testing after work
* correct indent
* fixing some build errors
* More comprehensive hurl test of creation of a target
* adding status_dest to mailing targets json
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
* add dol_buildurl with examples of use
* add dol_buildurl with examples of use
* add dol_buildurl with examples of use
* add dol_buildurl with examples of use
* wip
* wip
* add more example
* add more example
* add more example
* add more example
* add more example
* add more example
* add more example
* add example
* add example
* add example
* add example
* add example
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* stay in the same area even we are on other area in other tab
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* add example
* add example
* add example
* add example
* add example
* add example
add example
add example
add example
add example
* add example
* add example
add example
add example
add example
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* clean code
* fix
* wip
* wip
* clean code
* Add fk_project to Mass Emailings
* Mass Mailing fk_project SQL definition dispre
* mailing typecasting fk_project
* mailing using correct variable name
* more type casting to fix phpstan errors related to fk_project in mass mailing
* mailing fk_project NULL better default in DB
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
* Add getContacts method to retrieve contact information
* Implement getContacts method for proposals
Added a method to retrieve contacts associated with a proposal, including access checks and data cleaning.
* Implement getContacts method for invoices
Added a method to retrieve contacts associated with a specific invoice, including access checks and error handling.
* Update api_proposals.class.php
* Update api_invoices.class.php
* Update api_interventions.class.php
* Update api_interventions.class.php
* Add method to set invoice as draft
* Return contacts directly instead of cleaned data
* Return raw contacts instead of cleaned data
* Combine external and internal contacts in order list
Merge external and internal contacts for orders.
* Change return type from Object to array in API doc
Updated return type in API documentation for contact information.
* Change return type in api_orders.class.php docblock
Updated return type in docblock to reflect array return.
* Change return type from Object to array in API doc
* Update api_orders.class.php
* Update api_interventions.class.php
* Update api_proposals.class.php
* Update api_orders.class.php
* Update api_interventions.class.php
* Update api_interventions.class.php
* Update api_interventions.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* adding function to set it to draft mode
* New API endpoint for controlling mass mailings
* report which id we could not find + unset some fields not on this object + write that source was com/propal/class/api_propal.class.php
* extending the fetch function for the mailing object so the API can show all columns in the database
* filling more data into the object and don't unset it later
* adding notrigger to clone creation
* still some cleaning up from when cloning api_proposals.class.php
* do not unset the ID, because we want the ID so we can use it
* adding endpoint to clone a mass mailing
* extending count function with 'all' that just returns all rows, no matter the status
* API endpoints to delete all targets of a mass mailing
* setting which http method to use
* pretty print clone endpoint in API explorer
* endpoint resetTargetsStatus of mass mailing
* Typo receipients fixed
* Update api_mailings.class.php
* Update api_mailings.class.php
* Update api_mailings.class.php
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* add country and custom code in fetch line
* add country and custom code in fetch line
* add country and custom code in fetch line
* add country and custom code in fetch line
* add country and custom code in fetch line
* add country and custom code in fetch line
* add country and custom code in fetch line
* add country and custom code in fetch line
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* NEW : Change the path for the mailing files because if you have more than 100 mailing you have the files of the previous mailing show in the newest.
Only activate if the global MAILING_USE_NEW_PATH_FOR_FILES is set to 1.
Add a script for move files to new path.
* Place migration script into repair.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: tnegre <tnegre@open-dsi.fr>
* New : Copy support of the deposit percent of the payment mode found in customer proposal, customer order and customer invoice to supplier proposal, order and invoice
* Correction pre-commit / travis CI
* Correction pre-commit / travis CI
* Correction pre-commit / travis CI
* Correction pre-commit / travis CI
