* FIX: Issue #37425 filling of field amount_main_currency for foreign money accounts
The parameter amount_main_currency (argument #13 of addline()) was previously
filled even when the bank account was already using the company main currency.
This caused the field amount_main_currency to be populated incorrectly for
transactions that were not foreign currency operations.
The logic has been updated so that amount_main_currency is only filled when the
transaction involves a foreign currency account. For accounts already using the
company main currency, the value is now left NULL as expected.
This aligns the behavior with the intended usage of addline() and prevents
incorrect data in bank transaction records.
* FIX: Issue #37425 filling of field amount_main_currency for foreign money accounts
transfer.php: PhanTypeMismatchArgument: Argument 4 ($amount) is price2num((-1 * (float)($amount[$n]))) of type string but \Account::addline() takes float defined at htdocs/compta/bank/class/account.class.php:611
CI-PULL-REQUEST / phan / Run phan
Check warning on line R189
Check warning:
transfer.php: PhanTypeMismatchArgument: Argument 13 ($amount_main_currency) is $amount_main_currency_from of type ?string but \Account::addline() takes ?float defined at htdocs/compta/bank/class/account.class.php:611
CI-PULL-REQUEST / phan / Run phan
* declare dateo
* declare of variables before action script
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* This PR adds visual indicators on the Sales Order card (commande/card.php) to quickly identify if an order or its lines are shippable based on current stock levels. This feature mirrors the existing functionality found in the Orders List, bringing valuable logistics information directly into the Order Card context.
Key Features:
Global Shippable Status: Adds a "shippable" icon (Truck) next to the "Planned delivery date" field.
Logic: Checks if all products in the order are in stock.
Condition: Visible only if Stock and Shipment modules are enabled, a delivery date is set, and the order is validated.
Visual: Green icon if fully shippable, Red/Warning if stock is insufficient. Includes a detailed tooltip.
Per-Line Shippable Status: Adds a new "Shippable" column in the product lines table.
Logic: Compares real stock vs. remaining quantity to ship for each line.
Visual: Displays a green/red status bullet (standard Dolibarr status icons) directly in the line.
Implementation: Done by updating objectline_title.tpl.php and objectline_view.tpl.php with specific checks for the commande element.
New Configuration Option: Added a hidden option ORDER_DISABLE_SHIPPABLE_ICON_ON_CARD to disable this feature if needed (configurable in Home > Setup > Other Setup or via module settings).
Backend Optimization: Added a new method getShippableInfos() in commande.class.php to centralize the stock check logic (optimized with stock caching to avoid N+1 query issues).
Technical Details:
Modified Files:
commande/card.php: Integration of the global icon next to the date.
commande/class/commande.class.php: Added getShippableInfos() method.
core/tpl/objectline_title.tpl.php: Added "Shippable" column header (conditional for Orders).
core/tpl/objectline_view.tpl.php: Added "Shippable" column cell content (conditional for Orders).
Performance: Logic uses static caching for product stock to minimize database impact when rendering large orders.
* missed element
* img_picto
* phan add
* load_stock and global $i
* phan
* ci retour
* change icon
change phan directive
* phan
* Fight against optionflation
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
* Change condition for displaying shippable icon
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
* Change condition for displaying shippable status icon
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
* Update card.php
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
* Update shippable status condition in template
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
* Update shippable status condition logic
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
---------
Signed-off-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: jpb <jean-pascal.boudet@atm-consulting>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* New show bom net needs treeview by line position.
* bom_net_needs fix level is also position.
* bom_net_needs position need numeric sort.
* Fix sorting string
* Fix warning
* fix stan/phan
* Fix stan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fixed a bug that initialized the deprecated status variable without initializing the new status variable.
Upon quote approval, the interface is based on “status” rather than “statut.” The approved quote still had the edit button visible.
* Fix reload object if not MAIN_DISABLE_PDF_AUTOUPDATE after addline or updateline
Fix reload object if not MAIN_DISABLE_PDF_AUTOUPDATE after addline or updateline
* Update card.php
* FIX : Fix SQL request for fix duplicate accounting account and remove wrong and obsolete SQL request who break the accounting account when we launch repair with multi-entities
* Same fix for migration 8.0 to 9.0
* Add removed sql needed
* Fix: replace $_REQUEST with GETPOST() in projet/note.php
Use GETPOST('mode', 'alpha') instead of direct $_REQUEST['mode']
access to follow Dolibarr coding conventions for input sanitization.
* Fix: replace $_REQUEST with GETPOSTINT() in compta/tva/clients.php
Use GETPOSTINT('extra_report') instead of direct $_REQUEST access
to follow Dolibarr coding conventions for input sanitization.
* Fix: replace $_REQUEST with GETPOST() in projet/note.php
Use GETPOST('mode', 'alpha') instead of direct $_REQUEST['mode']
access to follow Dolibarr coding conventions for input sanitization.
* Fix: replace $_REQUEST with GETPOSTINT() in compta/tva/clients.php
Use GETPOSTINT('extra_report') instead of direct $_REQUEST access
to follow Dolibarr coding conventions for input sanitization.
* QUAL Add missing Spanish translations in es_ES locale
Add missing keys in ticket.lang, agenda.lang and errors.lang:
- Ticket email notification template keys
- Auto-read on assign keys
- ManualActions key in agenda
- OIDC user auto-creation messages
- ErrorFailedToGetTokenFromClientIdAndSecret
* QUAL Fix untranslated key in es_ES errors.lang
Translate UserDoesNotHaveRightsToChangeHisPassword key that was
left in English in the Spanish locale file.
