Commit Graph

11575 Commits

Author SHA1 Message Date
thibdrev
f41a5bc752 phpstan
Function dol_get_first_day() should return int but returns string.
Function getWeekNumber() should return int but returns string.
2024-01-15 18:54:33 +01:00
Eric Seigne
5a04b2393d end fix #10417 : custom payment number for supplier invoices 2024-01-15 18:43:17 +01:00
Laurent Destailleur
55067371ca Doc 2024-01-15 18:06:11 +01:00
Frédéric France
4fbb5b01be use shorter name for function 2024-01-15 17:48:20 +01:00
Laurent Destailleur
5b04976a2a Merge pull request #27518 from frederic34/patch-7
fix phpstan
2024-01-15 11:37:57 +01:00
Laurent Destailleur
a2df2f2553 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-15 11:33:16 +01:00
Laurent Destailleur
3ac7706a63 Clean code 2024-01-15 11:28:25 +01:00
Christophe Battarel
ab206910ab change to receptiondet_batch into scripts 2024-01-15 09:40:59 +01:00
Frédéric FRANCE
15b1ff5b69 fix phpcs 2024-01-15 00:08:02 +01:00
Frédéric FRANCE
c8ecdb8e7a add function isDolValidTms 2024-01-15 00:02:34 +01:00
Frédéric FRANCE
13c9707c9d fix phpstan 2024-01-14 22:34:37 +01:00
Frédéric FRANCE
b0e840e970 fix phpstan 2024-01-14 22:27:23 +01:00
MDW
a04f2bf4e7 Qual: Spelling fixes that newly appeared. (#27495)
* Qual: Spelling fixes that newly appeared.

# Qual: Fix spelling erros that appeared since the bulk updates.

These issues mostly appeared since the bulk updates (a few ones were postponed
to make sure no real spelling errors were missed.)

* Update modulebuilder.lib.php

* Update pdf_standard.modules.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-14 12:26:37 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Frédéric FRANCE
c5db3e2d8f fix phpstan (#27482) 2024-01-13 15:32:37 +01:00
Frédéric FRANCE
677109df41 fix phpstan (#27483)
* fix phpstan

* fix phpstan
2024-01-13 15:32:07 +01:00
Laurent Destailleur
e2c91e67a0 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-12 21:41:20 +01:00
Laurent Destailleur
569d9426d7 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-01-12 21:40:51 +01:00
thibdrev
96383a10a5 qual: move the function checking the syntax of Spanish Tax Identification Numbers (CIF, NIF, NIE) to profid.lib.php (#27472)
* qual: Move the function checking Spanish Tax Identification Numbers from societe.class.php to profid.lib.php

Create the function isValidTinForES($str)

* qual: Update societe.class.php using function isValidTinForES($str) from profid.lib.php

* phpcs

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-12 20:59:42 +01:00
Frédéric FRANCE
0d3e0c8ec4 fix incorrect case and remove exclude check (#27449) 2024-01-12 20:40:34 +01:00
thibdrev
dd2a3c05d9 qual: move into profid.lib.php the code checking the idprof1 syntax for BE, DZ and PT (#27443)
* qual: Update profid.lib.php - move functions checking profid from societe.class.php

- One function checking the Tax Identification Number for PT (called NIF)
- One function checking the Tax Identification Number for DZ (called NIF)
- One function checking the Tax Identification Number for BE (called NN)

* qual: Update societe.class.php - use the isValidTinXX() functions from profid.lib.php

isValidTinForPT($this->idprof1)
isValidTinForDZ($this->idprof1)
isValidTinForBE($this->idprof1)

* typo
2024-01-12 17:53:29 +01:00
Frédéric FRANCE
45d47d1dc9 fix phpstan (#27444) 2024-01-12 17:15:39 +01:00
Frédéric FRANCE
09daa41a1e remove use not used (#27463)
* remove use not used

* Update website.lib.php
2024-01-12 16:48:29 +01:00
Laurent Destailleur
f03eb1f505 Fix restore old code due to regression on some lang.
Add hidden PDF_USE_GETALIASNBPAGE_FOR_TOTAL for the case it bugs
2024-01-12 16:47:09 +01:00
Christophe Battarel
3e7cf0a463 fix pdf nbpages (#27457)
Co-authored-by: Christophe Battarel <christophe@altairis.fr>
2024-01-12 16:14:15 +01:00
Laurent Destailleur
cc5838c0d0 Add method getNbOfImagePublicURLOfObject() 2024-01-12 16:12:23 +01:00
Laurent Destailleur
32f0443289 Rename into getImagePublicURLOfObject 2024-01-12 13:45:10 +01:00
Laurent Destailleur
aba9afe9f1 NEW Add method getPublicImageOfObject() for website module 2024-01-12 13:05:28 +01:00
thibdrev
d3416b864c Fix: SIRET syntax check - Handle the specific case of "La Poste" businesses (#27418)
* fix: SIRET syntax check - Handle the specific case of "La Poste" businesses

* phpcs

* phpcs

* typo
2024-01-11 12:49:39 +01:00
Laurent Destailleur
e4360d181b Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-11 10:53:58 +01:00
Laurent Destailleur
a9e43d0c9d Doc 2024-01-11 10:44:43 +01:00
Christophe Battarel
42162ac024 NEW allow [] in dol_eval (#27290)
* allow []

* fix dol_eval call to authorize brackets

* ad dparam to verifCond

---------

Co-authored-by: Christophe Battarel <christophe@altairis.fr>
2024-01-11 10:28:37 +01:00
Frédéric FRANCE
746c2366a1 fix #27256 (#27318)
* fix #27256

* Update functions.lib.php
2024-01-11 10:17:50 +01:00
thibdrev
f9a5b9a6dd qual: Update profid.lib.php - use the Luhn agorithm instead within isValidSiren() and isValidSiret() (#27405) 2024-01-11 10:14:06 +01:00
MDW
2057731e77 Fix most detected spelling errors + some translations (#27406) 2024-01-11 10:07:43 +01:00
MDW
58ba3e31fa Qual: Fix spelling for crypted and referer (#27408)
# Qual: Fix spelling for crypted and referer.

The proper spelling is encrypted and referrer, but the code has
some occurences where referer and crypted need to be maintained.

To make verification easier, this spelling correction is limited to
mostly these corrections and some minor translations and a only a
few other corrections.

crypted and referer are added as exceptions for spelling after this fix.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-11 10:07:06 +01:00
Laurent Destailleur
c15627016a Fix bad test for disabling TCPDI. Add more phpunit 2024-01-10 21:51:32 +01:00
Laurent Destailleur
f0d910ecd3 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-10 19:20:16 +01:00
MDW
95da30a224 Fix: files.lib.php - Add optional sort parameter to array_multisort for static tool check (#27340)
# Fix: files.lib.php - Add optional sort parameter to array_multisort for static tool check

Phan flags the call to array_multisort as suspicious - adding the optional sort parameter
avoids this.
2024-01-10 16:41:39 +01:00
Laurent Destailleur
d41c4d954b Merge pull request #27341 from mdeweerd/fix/add_missing_argument_getOnlineSignature
Fix: Add missing argument in getOnlineSignatureUrl
2024-01-10 15:37:14 +01:00
Laurent Destailleur
c8f3333408 Merge pull request #27327 from frederic34/patch-12
fix phpdoc
2024-01-10 15:27:30 +01:00
Frédéric FRANCE
7b45347b01 dol_compress_dir creates invalid zip with windoze 2024-01-10 15:20:12 +01:00
Laurent Destailleur
e37dc22aa7 Merge pull request #27347 from frederic34/patch-14
dol_compress_dir creates invalid zip with windoze
2024-01-10 15:19:48 +01:00
Laurent Destailleur
706fecb97f Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-10 15:16:12 +01:00
Laurent Destailleur
b418bc9e1e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-01-10 15:14:11 +01:00
Laurent Destailleur
64eff062f2 Clean code 2024-01-10 15:10:15 +01:00
Laurent Destailleur
2c1e7a8381 Merge pull request #27339 from mdeweerd/optim/dol_mimetype
Perf: Optimise dol_mimetype
2024-01-10 15:05:01 +01:00
Laurent Destailleur
da56b40ab5 Merge pull request #27329 from thibdrev/thibdrev-patch-1
qual move the code used to validate a SIRET into profid.lib.php
2024-01-10 15:03:42 +01:00
Laurent Destailleur
1e5076634b Merge pull request #27361 from frederic34/patch-22
Function should return string|null but return statement is missing.
2024-01-10 12:44:16 +01:00