Frédéric FRANCE
ec91ed2af9
test action ( #31815 )
...
* NEW : Add category feature on Fichinter
category update
* Update viewcat.php
* Update categories.lang
* Update categorie.class.php
* Update categories.lang
* Update viewcat.php
* Update viewcat.php
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* test action
* clean baseline
Debug v21
NEW: use Expedition::$date_shipping property in card and list (#31701 )
* NEW: use Expedition::$date_shipping property in card and list
* FIX: translation
* FIX: PHPStan rebutal
* FIX: not a great idea to copy and not edit comment
* FIX: on create, expected delivery date should precede sending date
* Update card.php
* Update list.php
* Update list.php
* Update list.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
clean baseline
clean baseline
clean baseline
* clean baseline
* clean baseline
* merge
* fix
* fix
* fix
* fix
* fix
* fix
* fix translations
* fix translations
* fix translations
* fix translations
* fix
* fix filters
* fix filters
* fix filters
* fix filters
* fix
---------
Co-authored-by: Charlène Benke <1179011+defrance@users.noreply.github.com >
2024-11-15 14:09:04 +01:00
lamrani abdelwadoud
7e283c29cf
NEW funclionality to Clone user with permissions and categories ( #29773 )
...
* first clone confirm
* complete the cloning functionality
* Fix phan error
* Fix php phan errors
* fix sanitized varible
* Fix error CTI
* variable undeclared
* initialise variable
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-13 22:19:40 +01:00
Laurent Destailleur
0fb7771f2d
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-11-07 19:51:41 +01:00
Laurent Destailleur
1b7c412787
WIP generic upload files
2024-11-07 19:51:21 +01:00
Alexandre SPANGARO
48d5d2b831
NEW Accountancy - Add general account on thirdparty - Code user part ( #31676 )
...
* NEW Accountancy - Add general account on thirdparty - SQL Part
* NEW Accountancy - Add general account on thirdparty - Code customer part
* NEW Accountancy - Add general account on thirdparty - Code customer part
* NEW Accountancy - Add general account on thirdparty - Code customer part
* Fix Phan
* Use isModEnabled
* NEW Accountancy - Add general account on thirdparty - Code supplier part
* Fix phan
* Fix phan
* Fix phan
* Use list of account instead of simple input
* Use list of account instead of simple input
* Tabs
* NEW Accountancy - Add general account on thirdparty - Code user part
* NEW Accountancy - Add general account on thirdparty - Code user part
* Fix indent
* Fix indent
* Remove duplicate language key
* Fix phan
* Fix phan
* Update card.php
* Fix accountancy export CSV
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-07 18:40:58 +01:00
Laurent Destailleur
00403fc0dc
Fix phan
2024-11-07 15:43:51 +01:00
Laurent Destailleur
9034703045
Add more info on audit event password renew
2024-11-07 13:52:40 +01:00
MDW
278d301f32
Qual: Fix phan/phpstan notices in class files (part 6) ( #31634 )
...
* Qual: Fix notices for paymentdonation...workstationusergroup.class
* Qual: Fix PhanPluginRedundantReturnComment, update baseline
* Qual: Complete array phpdoc for properties
2024-11-06 23:57:45 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Laurent Destailleur
e38fed2f09
Merge
2024-10-28 18:13:02 +01:00
Frédéric FRANCE
e0c1b067d8
add phpdoc ( #31562 )
...
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
* add phpdoc
2024-10-26 13:02:00 +02:00
Laurent Destailleur
3bc1d35236
QUAL The property ->domiciliation and ->propio on bank accounts has been
...
deprecated and replaced with property ->address and ->owner_name
2024-10-24 12:38:41 +02:00
MDW
0c26110636
Qual: Fix notices related to user classes ( #31291 )
...
# Qual: Fix notices related to user classes
This fixes several notices related to user classes (and reveals
some actual bugs or inconsistent typing).
2024-10-06 13:52:05 +02:00
MDW
42bb4fbf3e
Qual: Enable & fix or ignore Invalid DimOffset ( #31176 )
...
* Qual: Enable & fix or ignore Invalid DimOffset
# Qual: Enable & fix or ignore Invalid DimOffset
The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.
This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later
* Nullable object typing in function signature not ok for 7.0/8.4
Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-29 21:52:31 +02:00
MDW
5e02bec9df
Qual: Fix getTooltipContentArray typing hints ( #31081 )
...
* Qual: Fix getTooltipContentArray typing hints
# Qual: Fix getTooltipContentArray typing hints
This defines the aray type for all getTooltipContentArray occurences
* Ignore undeclared property ref_supplier (does not exist on OrderLine)
2024-09-23 03:24:19 +02:00
Frédéric FRANCE
000173c7b9
fix phpstan ( #31075 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-09-23 01:59:14 +02:00
MDW
099dbd9c1e
Qual: Fix notices for htdocs/admin/* ( #30982 )
...
* Fix (Possibly)UndeclaredGlobalVariable
* Update phan baseline
* Fix (Possibly)UndeclaredGlobalVariable (2)
* Qual: Fix notices for htdocs/admin/*
# Qual: Fix notices for htdocs/admin/*
Fixes most phan/phpstan noticies for files under htdocs/admin/* and ai.
2024-09-18 03:27:25 +02:00
MDW
0efe669e4b
Fix: 🛟 getrights must return a value ( #30904 )
...
# Fix:getrights must return a value
The phan notice is all about the function not returning a value
while it is said to return a value.
Added the missing 'return'
2024-09-10 00:57:02 +02:00
Laurent Destailleur
f5c57e1608
deprecate method getrights that is conflict with getRights() of
...
CommonObject.
2024-09-07 18:03:43 +02:00
Laurent Destailleur
14d5b4bcc3
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-09-02 12:14:51 +02:00
Laurent Destailleur
ef84ba2a13
Debug v20
2024-09-02 10:21:24 +02:00
Laurent Destailleur
4c0e978d42
Fix phan
2024-09-01 12:46:17 +02:00
Laurent Destailleur
f126e015a3
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-31 12:25:43 +02:00
Laurent Destailleur
ff79295e2c
Debug v20
2024-08-31 12:24:49 +02:00
thibdrev
3dbd79dad8
qual: Method getKanbanView() has parameter $arraydata with no value type specified in iterable type array. ( #30712 )
...
* Update adherent.class.php
* Update adherent_type.class.php
* Update availabilities.class.php
* Update propal.class.php
* Update account.class.php
* Update paymentvarious.class.php
* Update cashcontrol.class.php
* Update localtax.class.php
* Update remisecheque.class.php
* Update bonprelevement.class.php
* Update chargesociales.class.php
* Update contact.class.php
* Update contrat.class.php
* Update commonorder.class.php
* Update timespent.class.php
* Update don.class.php
* Update conferenceorbooth.class.php
* Update expedition.class.php
* Update expensereport.class.php
* Update paymentexpensereport.class.php
* Update fichinter.class.php
* Update fournisseur.commande.class.php
* Update holiday.class.php
* Update evaluation.class.php
* Update job.class.php
* Update position.class.php
* Update skill.class.php
* Update intracommreport.class.php
* Update knowledgerecord.class.php
* Update loan.class.php
* Update mo.class.php
* Update partnership.class.php
* Update inventory.class.php
* Update entrepot.class.php
* Update project.class.php
* Update holiday.class.php - fix phan error
* Update task.class.php
* Update reception.class.php
* Update recruitmentcandidature.class.php
* Update recruitmentjobposition.class.php
* Update paymentsalary.class.php
* Update salary.class.php
* Update supplier_proposal.class.php
* Update ticket.class.php
* Update user.class.php
* Update usergroup.class.php
* Update webportalinvoice.class.php
* Update webportalorder.class.php
* Update webportalpropal.class.php
* Update workstation.class.php
* Update facture.class.php
2024-08-22 03:31:04 +02:00
Laurent Destailleur
fdb209ca41
Add a check to allow setPassword from apis
2024-08-17 16:41:30 +02:00
Laurent Destailleur
52c8b669c9
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-17 16:20:17 +02:00
Laurent Destailleur
c481be58f7
Clean code
2024-08-17 16:20:06 +02:00
Jon Bendtsen
5c6594b4ce
NEW API call to re-generate a users password. ( #30590 )
...
* NEW API call to re-generate a users password.
* fixing job:pre-commit that gave an error saying it was missing here
* adding the variable
* trying to load global user variable based on this comment https://github.com/Dolibarr/dolibarr/pull/30589#issuecomment-2276631147
* first attempt didnt work, but I found that global $conf at the top of the function
* adjust http error code to 500
* removing some comments and pre commit fix
* making send password a bool + using ->useraccount as pr. @eldy request
* lower case false
* Update api_users.class.php
---------
Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk >
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-08-17 16:19:55 +02:00
MDW
be0f28245c
Qual: Fix phan notices wrt main.inc.php, menus ( #30633 )
...
* Qual: Fix phan notices wrt main.inc.php, menus
# Qual: Fix phan notices wrt main.inc.php, menus
This fixes phan notices stemming from main.inc.php and the menu classes.
* Qual: Fix phpstan notice that dol_authmode always set
# Qual: Fix phpstan notice that dol_authmode always set
dol_authmode is always set because it is now initialised.
2024-08-14 14:05:56 +02:00
MDW
d6948077b2
Qual: Fix spelling/update .pre-commit configuration (versions) ( #30546 )
...
* Qual: Update pre-commit configuration
* Qual: Update spelling
* Ignore use of deprecated constant
2024-08-07 01:20:43 +02:00
MDW
e3d3bad080
Fix: 🛟 Fix getrights usage & Update the documentation to suggest to use loadRights ( #30543 )
...
* Qual: Update the documentation to suggest to use loadRights
# Qual: Update the documentation to suggest to use loadRights
Given the pending issues, update the documention regarding getrights to
point to loadRights.
* Fix: call loadRights on User (not getRights)
2024-08-04 18:47:22 +02:00
Laurent Destailleur
823e53803d
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-08-03 15:45:33 +02:00
Laurent Destailleur
6558c69ac7
Doc
2024-08-02 11:17:14 +02:00
Laurent Destailleur
5727dadfdd
Fix condition to get permission
2024-08-02 10:55:53 +02:00
Laurent Destailleur
f002fb4ed1
Use the non deprecated function loadRights instead of getrights
2024-08-02 10:36:43 +02:00
Laurent Destailleur
46cde6431a
NEW Can use a specific profile to send email for password forgotten
2024-08-01 11:36:21 +02:00
Laurent Destailleur
292080ca14
Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-07-30 12:28:15 +02:00
Laurent Destailleur
4223c6241c
Fix tooltip
2024-07-30 11:52:40 +02:00
Laurent Destailleur
6ac589b0a9
NEW Introduce value 'password' formode of sanitization in GETPOST.
2024-07-21 14:44:14 +02:00
Frédéric FRANCE
2f5647e4e3
fix checkFunctionArgumentTypes ( #30234 )
...
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* add ignore
* add ignore
add ignore
add ignore
add ignore
add ignore
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Frédéric FRANCE
facb1930a7
fix phpstan Property Product::$oldcopy in empty() is not falsy ( #30003 )
...
* fix phpstan Property Product::$oldcopy in empty() is not falsy
* add token
* doc
* fix phpstan Property Product::$oldcopy in empty() is not falsy
* fix phpstan Property Product::$oldcopy in empty() is not falsy
* fix phpstan
2024-06-13 08:11:11 +02:00
Frédéric FRANCE
acd8fdc24e
fix phpstan level 4 ( #29954 )
...
* fix phpstan level 4
* fix phpstan level 4
2024-06-09 13:26:45 +02:00
Laurent Destailleur
82908a30eb
Clean phan warnings
2024-05-30 13:37:17 +02:00
Laurent Destailleur
88d9a945dc
Debug v20
2024-05-20 18:34:02 +02:00
Laurent Destailleur
b1f4f09b1c
Code comment
2024-05-06 18:25:06 +02:00
Frédéric FRANCE
d0830b3159
fix phpstan ( #29602 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
fix phpstan
fix phpstan
fix phpstan
fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix travis
* fix phpstan
* fix phpstan
* fix phpstan
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-05-05 00:34:19 +02:00
Laurent Destailleur
577491b799
Fix permissions on external users
2024-05-02 21:48:50 +02:00
Laurent Destailleur
50aa16c270
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-05-02 21:03:26 +02:00
Laurent Destailleur
cb604da904
Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
...
develop
2024-04-28 22:16:01 +02:00
