Commit Graph

897 Commits

Author SHA1 Message Date
Frédéric FRANCE
6afec608a3 fix CI (#35631)
* fix CI

* fix CI

* fix CI

* fix CI

* fix CI

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code
2025-10-04 13:29:57 +02:00
Anthony Damhet
c17f13316a UIUX - More intuitive select table (#35485)
* More intuitive select table

Added for objects:
- Members
- ActionComm
- Mailing
- Bank Accounts
- Various Payments
- Cash Control
- Paiement
- Contacts
- VAT
- Contracts
- Cron
- Gifts (Dons)
- Expedition
- Expense Reports
- FichInter
- Supplier Proposals
- Supplier Orders
- Supplier Invoices
- Supplier Paiements
- Products and supplier products
- Holidays
- Knowledge record
- Partnership
- Inventory
- Stock
- Projects
- Tasks
- Tickets
- Societes
- Salaries
- Resource
- Users

* Add Status message on documentation

* Remove intuitive select experimetns

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-09-28 01:21:40 +02:00
ldestailleur
6ed764bedf Clean code 2025-09-18 11:40:56 +02:00
ldestailleur
5e74b622bd Fix size of popup 2025-09-11 15:10:01 +02:00
ldestailleur
7e6b37fcd4 Fix CI 2025-09-03 19:29:26 +02:00
ldestailleur
cc6f43493c Clean code 2025-09-03 12:53:38 +02:00
Laurent Destailleur
4a30325361 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-08-26 05:21:51 +02:00
Laurent Destailleur
cfbafcc31f Fix CI 2025-08-26 05:20:54 +02:00
Laurent Destailleur
0d58e1ce05 Fix CSS 2025-08-26 05:20:31 +02:00
Laurent Destailleur
438b7d2eb0 Fix CI 2025-08-26 05:12:04 +02:00
Laurent Destailleur
b19ac8c38c Clean code 2025-08-26 04:49:15 +02:00
Laurent Destailleur
336c3bce3f Debug Fix CI 2025-08-26 04:12:51 +02:00
ldestailleur
2d848e5512 Parameters $maxlen and $notooltip of Contract have been inverted to
follow the standard.
2025-08-17 02:20:52 +02:00
Laurent Destailleur
82098594a6 Fix warning 2025-07-31 22:13:45 +02:00
Lenin Rivas
14dd86d75d NEW Withholdingtax how VatRefund (#34649)
* Withholdingtax VatRefund

* Withholdingtax VatRefund

* Withholding save VatRefund

* Use $this->db->escape() label in Where

* Use GETPOSTFLOAT of resteapayer

* Fix Whitespace

* Update card.php

* Update card.php

* Update card.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-07-24 19:18:06 +02:00
ldestailleur
2df53594a8 Debug look and feel v23 2025-06-25 16:12:19 +02:00
MDW
6fe1effa5e Qual: Fix PhanTypeMismatchArgumentNullable notices (#33684) 2025-04-02 11:35:53 +02:00
MDW
8669993ecf Qual: Fix phan notices (compta/prel..fichinter) (#33485)
* Qual: Fix phan notices (asset..compta/paiement)

* Qual: Fix phan notices (compta/prel..fichinter)
2025-03-19 15:21:48 +01:00
Laurent Destailleur
7ce3f23b21 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-03-17 20:36:32 +01:00
Laurent Destailleur
5443b7cc11 FIX Bad link to download tax vat document 2025-03-17 20:30:02 +01:00
MDW
0cc1aa6d80 Qual: Fix phan notices (asset..compta/paiement) (#33484)
* Qual: Fix phan notices (accountancy, adherents)

* Qual: Fix phan notices (admin)

* Qual: Fix phan notices (asset..compta/paiement)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-03-16 20:45:04 +01:00
MDW
9dcf7fa0f5 Qual:Fix phan notices (multiple) (#33465) 2025-03-15 11:26:19 +01:00
MDW
2cd6459d10 Qual: Fix phan notices (*card) (#33450) 2025-03-14 17:25:11 +01:00
MDW
24fa28dfe2 Qual: Fix getKanban phpdoc
# Qual: Fix getKanban phpdoc

Array phpdoc for getKanban corrections.
2025-02-05 01:43:37 +01:00
Laurent Destailleur
b4bf3978ef Better tooltips 2025-01-27 03:46:51 +01:00
Laurent Destailleur (aka Eldy)
b024b95948 Fix typo 2025-01-09 19:35:01 +01:00
Laurent Destailleur (aka Eldy)
56710ce9b7 FIX CVE-2024-55227 and CVE-2024-55228 CSRF when
MAIN_RESTRICTHTML_ONLY_VALID_HTML_TIDY is
on (hidden option not on by default)
2025-01-09 19:35:01 +01:00
Frédéric FRANCE
b2135c0b50 Update payments.php 2024-12-06 13:33:05 +01:00
Laurent Destailleur
538c10fa6e Fix phpstan 2024-11-21 22:59:24 +01:00
Laurent Destailleur
235b61e07a FIX Debug v21 2024-11-21 22:13:45 +01:00
MDW
7304048afb Qual: Fix phan notices (#31996)
# Qual: Fix phan notices

Fix phan notices up to htdocs\core\ajax\selectsearchbox.php.
2024-11-19 03:07:18 +01:00
MDW
58fa1ac626 Qual: Fix phan notices (#31962) 2024-11-18 15:40:54 +01:00
Frédéric FRANCE
661059ca9a fix phpstan (#31763)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-11 14:33:53 +01:00
Frédéric FRANCE
92ef950e6d fix phpstan (#31761)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* hide new error with phpstan 1.12.9
2024-11-10 23:47:14 +01:00
Frédéric FRANCE
0d7bc505d3 add phpdoc and clean phpstan baseline (#31702)
* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline

* add phpdoc and clean phpstan baseline
2024-11-06 19:39:46 +01:00
Frédéric FRANCE
1adc883b56 add baseline exclude for phpstan (#31632)
* add baseline exclude for phpstan

* update

* update

* update

* update

* update

* merge

* restore one filter

* delete old errors

* fix

* fix

* fix

* $moreforfilter can t be empty

* fix

* enable check

* refresh baseline

* add phpdoc

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* update phpstan baseline

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-11-04 23:53:20 +01:00
Frédéric FRANCE
a65b35bb9a fix phpstan (#31580) 2024-10-27 00:37:15 +02:00
Laurent Destailleur
f5e4ab0220 Rewrite code to prepare refactoring 2024-10-26 15:24:54 +02:00
MDW
0ac595364b Qual: Fix phan/phpstan notices in class files (part 1) (#31501)
* Ignore phpstan configuration for spelling

* Qual: Fix phan notices in class files
2024-10-25 21:00:02 +02:00
MDW
cee4535975 Qual: Fix phan notices in admin.lib and tax.lib + related (#31414)
* Qual: Fix admin.lib phpstan/phan notices

* Qual: Fix some argument types in Societe methods

* Fixup phpdoc

* Qual: Improve typing for static analysis

* Qual: Improve typing for static analysis

* Fix tax typing

* Qual: further phan/phpstan notice fixes in dol_generic_project_odt

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-10-17 03:08:38 +02:00
MDW
d7b2f95baf Qual: Fix phan notices (#31372)
* fix llx_webhook_target-webhook.sql

* Fix commande/list & facture-rec.class

* Fix bonprelevement

* Qual: Fix prelevement/create notices

* Qual: fix quadridetail notices & update baseline

* Qual: Fix CommonDocGenerator notices

* Qual: Fix commoninvoice and commonobjectline notices (phan/phpstan)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-10-13 16:45:42 +02:00
MDW
2d0b1de36f Qual: Add codespell entries to catch some css typos (#31222)
# Qual: Add codespell entries to catch some css typos

Added some codespell entries based on the observed typos in css
tags
2024-10-03 19:36:59 +02:00
MDW
8236aed22f Qual: Fix phan notices (#31193)
# Qual: Fix phan notices

Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Laurent Destailleur
90f49fbd83 Try more complete fix for #31117 2024-09-28 13:05:24 +02:00
Laurent Destailleur
b32225283d Merge branch '20.0' of github.com:Dolibarr/dolibarr into develop 2024-09-25 22:32:36 +02:00
Laurent Destailleur
59dadd88a3 FIX Duplicate trigger printFieldPreListTitle 2024-09-25 13:43:11 +02:00
Frédéric FRANCE
2a6bbf88df fix phpstan (#30944)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-13 17:40:03 +02:00
Laurent Destailleur
c8505f9c0a Fix missing test on permissions 2024-09-01 21:04:53 +02:00
thibdrev
4e5ea524f4 qual: PHPStan for tva.class.php (#30711)
* qual: PPHStan for tva.class.php

htdocs/compta/tva/class/tva.class.php	57	Property Tva::$total has no type specified.

htdocs/compta/tva/class/tva.class.php	59	Property Tva::$datep has no type specified.

htdocs/compta/tva/class/tva.class.php	60	Property Tva::$datev has no type specified.

htdocs/compta/tva/class/tva.class.php	61	Property Tva::$amount has no type specified.

htdocs/compta/tva/class/tva.class.php	62	Property Tva::$type_payment has no type specified.

htdocs/compta/tva/class/tva.class.php	924	Method Tva::getKanbanView() has parameter $arraydata with no value type specified in iterable type array.

* tva.class.php - correction of phan warnings

* tva.class.php - correction of phan warnings

* $amout can be float|string

* Update card.php - fix phan warning
2024-08-21 15:11:28 +02:00