Commit Graph

549 Commits

Author SHA1 Message Date
Laurent Destailleur
3b2c7a32f7 Fix regression 2024-10-31 16:29:19 +01:00
Laurent Destailleur
b70df2fcc8 Add log 2024-10-31 16:18:55 +01:00
Laurent Destailleur
d9a5636b77 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-29 15:55:42 +01:00
Laurent Destailleur
3caead1dc0 Help debug with button "Refresh token" 2024-10-29 13:01:14 +01:00
itkuchlbauer
ad2578db4a Fix: hooks are not initiated if Hookmanager exists. (#31552) 2024-10-25 13:38:32 +02:00
Laurent Destailleur
d24069d5e2 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 20:35:33 +02:00
Laurent Destailleur
86e34d8513 Fix typo 2024-10-03 16:20:56 +02:00
Laurent Destailleur
42471decac Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 15:50:44 +02:00
Laurent Destailleur
0674754ad7 Restore regression 2024-10-03 14:03:15 +02:00
Laurent Destailleur
0676a5e718 Fix a fix has been lsot by merge 2024-10-03 13:52:55 +02:00
Hasanuzzaman Sattar
877a6f6c4a FIX#31237 (#31239)
* FIX#31237

* FIX#31241

* FIX#31237

* FIX#31237
2024-10-03 13:47:28 +02:00
Laurent Destailleur
c955ab06e7 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-03 01:07:09 +02:00
Laurent Destailleur
52616db1b7 Fix mutitenant MS oauth refresh 2024-10-03 01:06:44 +02:00
Laurent Destailleur
30c3ffa9dd Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-10-02 21:43:15 +02:00
Laurent Destailleur
50d2613124 Fix use of OAUTH for SMTP use with Microsoft 2024-10-02 21:25:21 +02:00
Laurent Destailleur
352077999a Clean code 2024-09-30 10:06:31 +02:00
MDW
8236aed22f Qual: Fix phan notices (#31193)
# Qual: Fix phan notices

Fix phan notices in several classes that have UnknownObjectMethod calls and classes
that had notices in relation with these classes
2024-09-30 10:05:24 +02:00
MDW
42bb4fbf3e Qual: Enable & fix or ignore Invalid DimOffset (#31176)
* Qual: Enable & fix or ignore Invalid DimOffset

# Qual: Enable & fix or ignore Invalid DimOffset

The Invalid DimOffset notices occur when array keys are defined and
the index used is not amongst the known array keys.

This PR enables these notices and fixes array definitions when needed,
or ignores the notices locally if it's a false positive, or in the
baseline.txt when it does not seem to be a false positive so that
it can be fixed later

* Nullable object typing in function signature not ok for 7.0/8.4

Can't user '?User' as argument type for PHP7.0 which is required by PHP8.4.
Therefore, removing the typing specification in the function definition

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-29 21:52:31 +02:00
Frédéric FRANCE
a94cff63a7 fix phpstan (#31102)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-25 22:21:31 +02:00
Laurent Destailleur
e4227c6913 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-12 16:30:57 +02:00
Laurent Destailleur
94cdc284b3 Better log and fix search of contact for emailcollector 2024-09-12 12:32:33 +02:00
Laurent Destailleur
613c25b5ff Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-10 02:02:16 +02:00
Laurent Destailleur
4511e25895 Fix parsing header 2024-09-09 20:01:33 +02:00
Laurent Destailleur
cb0a751384 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-09-09 16:22:28 +02:00
Laurent Destailleur
e2bed26bb3 Log 2024-09-09 13:41:28 +02:00
Frédéric FRANCE
eb04c5c427 fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
MDW
a8367a6cd8 Qual: Fix getNextValue related phan notices (part2) (#30752)
* Qual: 🛟 Fix reference to $db with $this->db

# Qual: reference to $db with $this->db

$db was undeclared, use $this->db.

* Fix suspected issue with environment max size and md5sum working on limited files

* Qual: Fix LDAP typing

* Qual: Fix getNextValue related phan notices (part2)

* Update baseline

* Qual: Fix phan notice
2024-08-29 13:34:24 +02:00
Laurent Destailleur
eb30f2efa6 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-28 12:23:46 +02:00
Laurent Destailleur
85d2080081 Debug emailcollector - finding thirdparty 2024-08-28 12:21:39 +02:00
Laurent Destailleur
8958aed2ef Fix cursor 2024-08-28 03:30:06 +02:00
Laurent Destailleur
a31c0b09cd Process emails by email date 2024-08-28 02:41:58 +02:00
Laurent Destailleur
a40d280a01 Log 2024-08-28 01:32:46 +02:00
Laurent Destailleur
7464e22a4d Debug emailcollector with PHP-IMAP lib 2024-08-28 00:19:23 +02:00
Laurent Destailleur
921cbe40b8 More logs 2024-08-28 00:07:59 +02:00
Laurent Destailleur
d61efecc10 Fix move of several emails when using PHP-IMAP 2024-08-27 23:59:39 +02:00
Laurent Destailleur
367cdd7ccc Fix emailcollector from tickets 2024-08-27 22:21:29 +02:00
Laurent Destailleur
7e60db00b7 Fix log of emailcollector 2024-08-27 22:21:22 +02:00
Laurent Destailleur
1277c19a2d Fix emailcollector from tickets 2024-08-27 22:20:51 +02:00
Laurent Destailleur
9319727a39 Fix log of emailcollector 2024-08-27 21:50:44 +02:00
Laurent Destailleur
c0be147c02 Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-08-27 20:01:25 +02:00
Laurent Destailleur
e0d714d377 Doc 2024-08-27 14:39:51 +02:00
MDW
f5c7ca1769 Qual: Fix PhanPluginUnknownObjectMethodCall in classes with high occurence (#30754)
* Qual: Fix PhanPluginUnknownObjectMethodCall in import.php

* Qual: PHPDoc for import/export array types

* Qual: Add PHPDoc types to import.class.php

* Fix PhanPluginUnknownObjectMethodCall in stats.class.php

* Add methods expected on ModeleImport child classes

* Force imapemail type for phan

* Qual: Update phan baseline

* Qual: Fix Undefined/Undeclared phan notices in module_help

* Update baseline
2024-08-27 04:51:41 +02:00
MDW
ca414de526 Qual: Fix $fields related notices with Phan (#30704)
* Qual: Typing hints/ignore directives for phan notices

* Update field typing
2024-08-21 13:23:35 +02:00
MDW
d71cd352d5 Qual: Fix PhanUndeclaredMethod (#30661)
* Qual: Fix PhanUndeclaredMethod cases

* Fix PhanUndeclaredMethod cases

* Qual: Remove PhanUndeclaredMethod exceptions

* Fix spelling "disacard"

* Improve phpdoc, add abstract method to trait for typing

* Improve phpdoc typing for PHanUndeclaredMethod

* Suppress phan notices for guarded AliasNbPages calls

* Fix return value for printFile stub

* Fix getting message from Exception

* Define dummy getAllByProducts(), typing for it.

* Fix typo in comment

* Qual: Better typing for apiService (phan)

* Test that the Generic OAuth Service is provided

* Qual: Fix getSqlArrayForStats typing

* Force modTcpdfbarcode

* Correct typing hint

* Set ModelePDFAsset typehint

* Fix ModelePDFUserGroup typing hint

* Fix phan typing hints htdocs/core/modules/printing/printgcp.modules.php

* Fix write_file in ModelePDFStock*

* Update printsheet.php

* Adjust typing hint for barcode generator

* Update printsheet.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-19 02:05:27 +02:00
MDW
54880f92cd Qual: Fix PhanTypeMismatchProperty and some other phan notices (#30542)
* Qual: Fix PhanTypeMismatchProperty and some other phan notices

* Qual: Phan fixes for BOM

* Phan - fix fields

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Fix $fields phpdoc

* Fix phan typing issues with intermediate var and ??

* Fix phan typing issue with ?? operator

* Ignore htdocs/install/install.forced.php for git

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Update baseline

* Qual: Phan fixes for BOM

* fixup! Qual: Phan fixes for BOM

* Fix phpstan double array keys for syslog

* Qual: Revert to original code, ignore notice

When changing the method to avoid one notice type, another one
appears.  So simply ignoring this error.

* Ignore PhanTypeSuspiciousNonTraversableForeach to allow integration

* Fix typing hints (phpstan)

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 17:05:00 +02:00
Laurent Destailleur
aa3a4fbf52 QUAL Clean code 2024-08-15 16:53:49 +02:00
Laurent Destailleur
88253bf647 WIP Work on generic OAuth service 2024-08-13 18:36:33 +02:00
MDW
45ed4caeb2 Qual: Enable Phan Simplify rule and fix notices (#30537)
* Qual: Phan - Enable Simplyfy expression

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Qual: Simplify expression (phan notice)

* Update functions2.lib.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-07 03:05:02 +02:00
Laurent Destailleur
b3b21d56b6 Fix doxygen 2024-08-07 02:49:38 +02:00