Commit Graph

13167 Commits

Author SHA1 Message Date
thibdrev
db2fc174cd qual: phpstan for htdocs/compta/paiement/class/paiement.class.php (#28364)
htdocs/compta/paiement/class/paiement.class.php	115	PHPDoc type array<int, float> of property Paiement::$multicurrency_tx is not covariant with PHPDoc type float of overridden property CommonObject::$multicurrency_tx.

htdocs/compta/paiement/class/paiement.class.php	120	PHPDoc type array<int, string> of property Paiement::$multicurrency_code is not covariant with PHPDoc type string of overridden property CommonObject::$multicurrency_code.
2024-02-23 13:40:22 +01:00
Laurent Destailleur
007b2bf758 Doygen 2024-02-22 19:29:31 +01:00
Laurent Destailleur
260505e2aa Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-22 19:27:03 +01:00
Laurent Destailleur
71dc610c25 Doc 2024-02-22 19:26:47 +01:00
thibdrev
132e98a4c7 qual: phpstan for CommonObject->origin (#28361)
htdocs/commande/class/commande.class.php	538	Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/commande/class/commande.class.php	675	Property CommonObject::$origin (string) does not accept $this(Commande).
htdocs/compta/facture/class/facture.class.php	2859	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php	3378	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/compta/facture/class/facture.class.php	3696	Property CommonObject::$origin (string) does not accept $this(Facture).
htdocs/expedition/class/expedition.class.php	1245	Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php	1438	Property CommonObject::$origin (string) does not accept null.
htdocs/expedition/class/expedition.class.php	2326	Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/expedition/class/expedition.class.php	2487	Property CommonObject::$origin (string) does not accept $this(Expedition).
htdocs/fourn/class/fournisseur.commande.class.php	1283	Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.commande.class.php	2278	Property CommonObject::$origin (string) does not accept $this(CommandeFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php	1858	Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/class/fournisseur.facture.class.php	1999	Property CommonObject::$origin (string) does not accept $this(FactureFournisseur).
htdocs/fourn/commande/dispatch.php	435	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php	482	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/fourn/commande/dispatch.php	489	Property CommonObject::$origin (string) does not accept CommandeFournisseur.
htdocs/reception/class/reception.class.php	582	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1081	Property CommonObject::$origin (string) does not accept null.
htdocs/reception/class/reception.class.php	1674	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1833	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/reception/class/reception.class.php	1967	Property CommonObject::$origin (string) does not accept $this(Reception).
htdocs/takepos/invoice.php	332	Property CommonObject::$origin (string) does not accept Facture.
htdocs/takepos/invoice.php	336	Property CommonObject::$origin (string) does not accept Facture.
2024-02-22 19:25:01 +01:00
thibdrev
87a5ca7756 qual: phpstan for $fk_unit (#28359)
* Update bom.class.php

* Update commonobjectline.class.php

* Update product.class.php

* phpcs

* phpcs

* phpcs

* phpcs

* phpcs

* phpcs
2024-02-22 19:14:31 +01:00
Laurent Destailleur
757abcfaae Fix warning 2024-02-22 13:20:00 +01:00
Laurent Destailleur
ff524c9a52 Reduce label 2024-02-21 19:05:08 +01:00
Laurent Destailleur
3a23581b9e Mutualize code 2024-02-21 18:59:46 +01:00
MDW
8655d5a86b QUAL Use phan to help detect new issues (#27706)
* Qual: Add phan flow

- Add phan configuration (config, baseline, stubs);
- Add github action;
- Update apstats.php.

* Add directives to ignore false phan notices

* Qual: Add typing hints for extrafields TPL files

# Qual: Add typing hints for extrafields TPL files

Add typing hints for phan on view files

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 18:14:29 +01:00
Benjamin Falière
5460b97e8b NEW contact type on auto add contributor (#26077)
* NEW contact type on auto add contributor

* ADD second option

* RESTORE ticket module for external and fix constant

* GetDolGlobalInt

* Update ticket.class.php

---------

Co-authored-by: Benjamin Falière <benjamin.faliere@altairis.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 18:08:35 +01:00
William Mead
37a31f75b7 Qual clean dolresource class (#28308)
* Use address, town, zip & email from CommonPeople

* Use element & table_element from CommonObject

* Updated PHPDoc

* Deleted unused properties

* Revert "Use element & table_element from CommonObject"

This reverts commit 88a06164d1.

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-21 13:59:41 +01:00
Laurent Destailleur
ae49542197 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-20 14:50:51 +01:00
Laurent Destailleur
0492fb6098 FIX close #28279 2024-02-20 14:46:56 +01:00
Laurent Destailleur
f0ffe83fe6 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-20 11:18:01 +01:00
Laurent Destailleur
977f6b5a61 Complete doc to mention MAIN_DISALLOW_URL_INTO_DESCRIPTIONS option 2024-02-20 11:17:40 +01:00
noec764
db6b17ad49 NEW: Add Filter on product reffering object status(Order and Order Supplier) (#28275)
* NEW: Add Filter on product reffering object status(Order and Order Supplier)

* Update html.formorder.class.php

* Update commande.php

* Update commande_fournisseur.php

---------

Co-authored-by: Noé <noe@scopen.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-20 02:12:06 +01:00
thibdrev
7b1c8c43f6 qual : phpstan for htdocs/core/class/dolgraph.class.php (#28284)
* qual : phpstan for htdocs/core/class/dolgraph.class.php

htdocs/core/class/dolgraph.class.php	703	Method DolGraph::GetCeilMaxValue() should return int but returns float.

htdocs/core/class/dolgraph.class.php	1551	Method DolGraph::total() should return string but returns (float|int).

htdocs/core/class/dolgraph.class.php	1593	Method DolGraph::getDefaultGraphSizeForStats() should return int but returns string.

htdocs/core/class/dolgraph.class.php	1599	Method DolGraph::getDefaultGraphSizeForStats() should return int but returns string.

* phpcs
2024-02-20 02:04:41 +01:00
MDW
b2d90629e7 Qual: Apply php-cs-fixer to make only manual changes stand-out (#28300)
* Qual: Apply php-cs-fixer to make only manual changes stand-out

# Qual: Apply php-cs-fixer to make only manual changes stand-out

A few changes will be proposed in the future to these files.  This already commits
the esthetic changes using php-cs-fixes.

* Qual: Apply php-cs-fixer to make only manual changes stand-out

# Qual: Apply php-cs-fixer to make only manual changes stand-out

A few changes will be proposed in the future to these files.  This already commits
the esthetic changes using php-cs-fixes.

* Qual: Apply php-cs-fixer to make only manual changes stand-out

# Qual: Apply php-cs-fixer to make only manual changes stand-out

A few changes will be proposed in the future to these files.  This already commits
the esthetic changes using php-cs-fixes.
2024-02-20 01:27:46 +01:00
Laurent Destailleur
978dd06c67 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-19 15:02:37 +01:00
Laurent Destailleur
b153e5ee0b css 2024-02-19 10:39:51 +01:00
Laurent Destailleur
5e4be61e7a Clean code 2024-02-19 10:16:50 +01:00
Laurent Destailleur
059c69667c Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-19 09:59:57 +01:00
Laurent Destailleur
c3ba74173a Fix phpstan 2024-02-18 23:42:00 +01:00
Laurent Destailleur
778e7364e6 Fix phpunit 2024-02-18 23:23:01 +01:00
Lucas Marcouiller
88232ff0fc fix php warnings and errors (#28207)
Co-authored-by: Hystepik <lmarcouiller@nltechno.com>
2024-02-18 23:00:01 +01:00
kkhelifa-opendsi
926462e218 FIX: Not trancate the multicurrency rate shown on cards (even if the global MAIN_MAX_DECIMALS_SHOWN is set to 0) (#28211) 2024-02-18 22:56:19 +01:00
Laurent Destailleur
fe7f94e1d9 Debug v20 2024-02-18 22:23:26 +01:00
Laurent Destailleur
50b4e6f81a NEW Add a link "Fill with layout" 2024-02-18 21:15:26 +01:00
Laurent Destailleur
3c108a1e53 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-18 17:20:29 +01:00
Laurent Destailleur
9b288e349e Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-18 17:20:16 +01:00
Laurent Destailleur
e38e9618ac Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-18 17:14:03 +01:00
Laurent Destailleur
ebe68c9075 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-02-18 17:06:36 +01:00
William Mead
21752d7a4d Fixed null dir_output (#28213) 2024-02-18 16:32:48 +01:00
thibdrev
d12b2d7ee6 qual: phpstan for htdocs/commande/card.php (#28215)
* Update commonobject.class.php

* Update card.php
2024-02-18 16:32:12 +01:00
Florian Mortgat
6e5fd5eb58 FIX: notification module: for supplier orders (any of the 3 triggers), user can choose an e-mail template in conf, but the conf is not used when sending the notification (#28216) 2024-02-18 16:31:12 +01:00
Frédéric FRANCE
cb995b293d add photos in category banner (#28221) 2024-02-18 15:39:42 +01:00
thibdrev
56ddeadd07 qual: phpstan for htdocs/compta/bank/class/account.class.php (#28242)
* qual: phpstan for htdocs/compta/bank/class/account.class.php

htdocs/compta/bank/class/account.class.php	206	PHPDoc type array of property Account::$status is not covariant with PHPDoc type int of overridden property CommonObject::$status.

htdocs/compta/bank/class/account.class.php	799	Property AccountLine::$amount (float) does not accept string.

* Update commonobject.class.php

* phpcs
2024-02-18 15:04:44 +01:00
thibdrev
538dbb509e qual: phpstan for htdocs/compta/facture/class/facture.class.php (#28243)
* qual: phpstan for htdocs/compta/facture/class/facture.class.php

htdocs/compta/facture/class/facture.class.php	1253	Property CommonObject::$fk_project (int) does not accept string.

htdocs/compta/facture/class/facture.class.php	1254	Property CommonObject::$fk_delivery_address (int) does not accept string.

htdocs/compta/facture/class/facture.class.php	4474	Property Facture::$remise_percent (int) does not accept float.

* Update commoninvoice.class.php

* Update facture.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-02-18 15:04:18 +01:00
Laurent Destailleur
56bd7be836 Add log 2024-02-18 02:12:34 +01:00
Laurent Destailleur
66615477ae Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-17 20:58:40 +01:00
Laurent Destailleur
17c3f6003e Fix pb letting think a user with no perm can change prospect status 2024-02-17 19:30:42 +01:00
Laurent Destailleur
bb06e674ad Add dol_escape_htmltag 2024-02-17 18:05:31 +01:00
Frédéric FRANCE
647cf21b54 fix warnings in select_resource_list (#28189)
* fix warnings in select_resource_list

* fix warnings in select_resource_list

* fix warnings in select_resource_list

* fix warnings in select_resource_list
2024-02-16 02:40:27 +01:00
Laurent Destailleur
b48455c9d7 Can remove filter entries 2024-02-16 01:50:03 +01:00
Laurent Destailleur
7107b5feb3 Debug custom report filter management 2024-02-16 01:19:53 +01:00
thibdrev
b0658c48f0 qual: phpstan - Property mod_xxxx::$code_modifiable (string) does not accept int. (#28173)
* qual: phpstan for commonnumrefgenerator.class.php

* qual: phpstan for mod_codeproduct_elephant.php

* qual: phpstan for mod_codeproduct_leopard.php

htdocs/core/modules/product/mod_codeproduct_leopard.php	79	Property mod_codeproduct_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_lot_free.php

htdocs/core/modules/product_batch/mod_lot_free.php	76	Property mod_lot_free::$code_modifiable (string) does not accept int.

* Update mod_codeclient_elephant.php

htdocs/core/modules/societe/mod_codeclient_elephant.php	46	PHPDoc type int of property mod_codeclient_elephant::$code_modifiable is not covariant with PHPDoc type string of overridden property ModeleThirdPartyCode::$code_modifiable.

* qual: phpstan for mod_codeclient_leopard.php

htdocs/core/modules/societe/mod_codeclient_leopard.php	76	Property mod_codeclient_leopard::$code_modifiable (string) does not accept int.

* qual: phpstan for mod_codeclient_monkey.php

htdocs/core/modules/societe/mod_codeclient_monkey.php	76	Property mod_codeclient_monkey::$code_modifiable (string) does not accept int.

* phpcs

* phpcs

* phpcs

* qual: phpstan for modules_societe.class.php

* Update mod_lot_free.php
2024-02-15 14:59:07 +01:00
Laurent Destailleur
c65870c026 QUAL: Properties ->date_update and ->date_modification were merged into
date_modification.
2024-02-15 14:08:08 +01:00
Frédéric FRANCE
5f1c679142 fix warning (#28177)
* fix warning

* clean properties

* clean properties
2024-02-15 13:59:19 +01:00
Frédéric FRANCE
69a766b300 use browser cache for pictures (#28179)
* use browser cache for pictures

* test

* Update phpstan.yml

* Update phpstan.yml
2024-02-15 13:58:07 +01:00