Commit Graph

2668 Commits

Author SHA1 Message Date
thibdrev
dbcfa15f72 qual: phpstan for htdocs/commande/class/commande.class.php (#28099)
* Update commande.class.php

* Update commonobject.class.php
2024-02-09 18:57:04 +01:00
thibdrev
07edb9b967 qual: phpstan for htdocs/adherents/class/api_memberstypes.class.php (#28098)
* Update subscription.class.php

* Update commonobject.class.php

* Update subscription.class.php

* Update commonobject.class.php

* Update subscription.class.php

* Update subscription.class.php

* Update commonobject.class.php

* Update commonobject.class.php

* Update subscription.class.php
2024-02-09 18:56:50 +01:00
MDW
7b54824d49 Fix #28071 - New branch to fix bad merge (#28083)
* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Qual: Introduce getDataToShowPhoto to prepare generic code

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix missing trans

* Fix langs

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Remove useless files in web templates

* Clean code

* Fix duplicate translation key

* Fix duplicate translation key

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix duplicate key

* Fix $object

* Debug v19

* WIP SMSing

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP EMAILINGS_SUPPORT_ALSO_SMS

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* WIP SMSing

* Debug the "validate" feature

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Clean code

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Move rights->x->y into hasRight('x', 'y')

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Enhance rector to fix empty($user->rights->modulex->perm1)

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop

* Fix template to use v19 dev rules

* Fix use v19 dev rules

* Fix phpunit

* Debug v19

* Clean code

* Use rector to convert user->rights into user->hasRight

* Clean code

* Use rector to convert user->rights into user->hasRight

* Use rector to convert user->rights into user->hasRight

* Clean code

* Fix phpcs

* add editorconfig for sql files (#27999)

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* add model_pdf field in llx_ticket-ticket.sql (#27996)

* add model_pdf field in llx_ticket-ticket.sql

* Update 19.0.0-20.0.0.sql

* Update 19.0.0-20.0.0.sql

* Improve wording in README (#27994)

* fix phpstan (#27989)

* fix phpstan

* Update UserRightsToFunction.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>

* Qual: Fix spelling/working in datapolicy translations (#28006)

# Qual: Fix spelling/wording in datapolicy translations

Fixed some spelling and wording in datapolicy translations.

* qual: phpstan for htdocs/ticket/class/ticketstats.class.php (#27986)

htdocs/ticket/class/ticketstats.class.php	98	Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()

* Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop

* Fix user with readonly perm on email template must be able to read.

* Fix doc

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Better message

* Add missing fields in merge of thirdparty

* Debug v19 selection of ticket printer per terminal

* Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into develop

* Use constant

* NEW: Adding a recipient on emails sent, change status to sent partialy.

* fix travis (#28052)

* fix travis

* Update partnership.class.php

* fix php doc (#28047)

* fix undefined array key (#28048)

* Add region and departament for Cuba (#28046)

* Update llx_10_c_regions.sql

Add Cuba Regions (id_country=77)

* Update llx_20_c_departements.sql

Add Provinces Cuba (id country=77)

* Find the typo (#28050)

* Find the typo

* clean code

* add last_main_doc field to product (#28045)

* add las_main_doc field to product

* add field fetch

* NEW Add Categorie filter for ActionComm (#28041)

* New Add Categorie filter for ActionComm

New Add Categorie filter for ActionComm

* Fix space errors

Fix space errors

* Fix space errors 2

Fix space errors 2

* Update cunits.class.php (#28056)

FIX: error SQL when creating a Cunit

* Update codespell-lines-ignore.txt to avoid PR merge conflict

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: thibdrev <thibault.drevet@gmail.com>
Co-authored-by: sonikf <93765174+sonikf@users.noreply.github.com>
Co-authored-by: Ikarus <44511582+LeKarSol@users.noreply.github.com>
Co-authored-by: Anthony Damhet <73399671+EchoLoGeek@users.noreply.github.com>
Co-authored-by: Quentin-Seekness <72733832+Quentin-Seekness@users.noreply.github.com>
2024-02-09 15:58:49 +01:00
thibdrev
c81ac78594 qual: phpstan for htdocs/core/class/commonobject.class.php (#28063)
htdocs/core/class/commonobject.class.php	9613	Method CommonObject::quote() should return string but returns int.
2024-02-08 00:14:48 +01:00
Laurent Destailleur
eb4f53665d Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
Conflicts:
	.github/workflows/pre-commit.yml
	ChangeLog
	dev/tools/codespell/codespell-lines-ignore.txt
	htdocs/comm/mailing/card.php
	htdocs/contact/card.php
	htdocs/langs/en_US/admin.lang
	htdocs/modulebuilder/template/core/modules/mailings/mailinglist_mymodule_myobject.modules.php
2024-02-07 18:30:10 +01:00
Laurent Destailleur
097290fc38 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
Conflicts:
	htdocs/comm/action/peruser.php
	htdocs/core/class/commonobject.class.php
2024-02-07 18:16:57 +01:00
Laurent Destailleur
4b60b3d991 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
Conflicts:
	htdocs/core/class/commonobject.class.php
2024-02-07 18:11:36 +01:00
Laurent Destailleur
e6b165003f Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
Conflicts:
	htdocs/core/class/commonobject.class.php
2024-02-07 18:01:11 +01:00
Frédéric FRANCE
10eaa1d269 fix saved model_pdf after generating odt (#28005) 2024-02-05 01:10:35 +01:00
Laurent Destailleur
32e205b5d1 Clean code 2024-02-02 19:50:43 +01:00
Laurent Destailleur
61921f0364 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-02-01 12:24:00 +01:00
Laurent Destailleur
4cba87129c Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2024-02-01 12:22:54 +01:00
Laurent Destailleur
9dd1646818 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-02-01 12:20:12 +01:00
thibdrev
4ad9e9b828 qual: phpstan for htdocs/core/class/commonobject.class.php
htdocs/core/class/commonobject.class.php	1032	Method CommonObject::getLastMainDocLink() should return string but returns int.
htdocs/core/class/commonobject.class.php	1550	Method CommonObject::liste_type_contact() should return array but returns null.
htdocs/core/class/commonobject.class.php	1638	Method CommonObject::listeTypeContacts() should return array but returns null.
htdocs/core/class/commonobject.class.php	1708	Method CommonObject::getIdContact() should return array but returns null.
htdocs/core/class/commonobject.class.php	2011	Method CommonObject::fetchObjectFrom() should return int but returns false.
htdocs/core/class/commonobject.class.php	2891	Property CommonObject::$retained_warranty_fk_cond_reglement (string) does not accept int.
htdocs/core/class/commonobject.class.php	4868	Method CommonObject::getTotalDiscount() should return float|string but returns null.
htdocs/core/class/commonobject.class.php	9557	Property CommonObject::$ref (string) does not accept int.
htdocs/core/class/commonobject.class.php	10407	Method CommonObject::fetchComments() should return bool but returns int.
htdocs/core/class/commonobject.class.php	10411	Method CommonObject::fetchComments() should return bool but returns int<0, max>.
2024-01-31 21:04:08 +01:00
Laurent Destailleur
cd7bab52ea Reduce the size of an export of website template. Removed useless files. 2024-01-31 18:08:50 +01:00
atm-florian
101c5a2dca FIX 17.0 - php8 warnings: test for $field existence before checking if it is null or empty 2024-01-30 16:21:51 +01:00
Laurent Destailleur
079b2aa3a0 Debug webportal 2024-01-27 17:58:19 +01:00
Laurent Destailleur
25a91c63cf Debug webportal module 2024-01-27 17:23:03 +01:00
Laurent Destailleur
3a22fb28e3 Merge pull request #27784 from thibdrev/patch-3
qual: phpstan for htdocs/compta/facture/class/facture.class.php
2024-01-26 02:27:43 +01:00
EchoLoGeek
67db158278 Fix PHPCS error 2024-01-25 12:53:23 +01:00
EchoLoGeek
2275dd9610 Add morecss properties to common textarea 2024-01-25 12:27:07 +01:00
thibdrev
3f7e51f448 Update commonobject.class.php - defineBuyPrice() return type 2024-01-24 21:04:02 +01:00
Laurent Destailleur
b7f50fe0d9 Merge pull request #27752 from Daoud-mohamed/Technical-debts-7
Fix some warnings -Technical debts-
2024-01-24 14:29:01 +01:00
Laurent Destailleur
99fee99a52 Merge pull request #27769 from thibdrev/patch-4
qual: phpdoc
2024-01-24 10:48:41 +01:00
thibdrev
d0224e0714 fix conflict with last commit 2024-01-24 07:45:37 +01:00
thibdrev
1a0639662f typo 2024-01-24 07:42:35 +01:00
MDW
565fe09cb5 Qual: Fix translation keys.
# Qual: Fix translation keys

Modify some translation keys so that they correspond to each other,
use an existing key or fix the contents as it's not translated yet.
2024-01-23 23:56:20 +01:00
thibdrev
fcc3ecd455 phpcs 2024-01-23 22:31:12 +01:00
thibdrev
1f73c1110e phpdoc 2024-01-23 22:26:55 +01:00
Laurent Destailleur
ce21af7b6c Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-23 22:17:46 +01:00
Laurent Destailleur
cca01cbda4 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2024-01-23 22:15:36 +01:00
mohamed daoud
0b4e02821f Fix some warnings -Technical debts- 2024-01-23 16:07:59 +01:00
Frédéric France
03e29c6960 fix param 2024-01-20 09:22:38 +01:00
Laurent Destailleur
4795c40601 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2024-01-19 15:36:53 +01:00
Laurent Destailleur
f711d0d144 Typo doc 2024-01-19 12:36:07 +01:00
VESSILLER
26a05d3046 FIX update price extrafield on propal card 2024-01-19 10:15:42 +01:00
Frédéric FRANCE
17335b25b4 fix phpstan 2024-01-18 22:06:56 +01:00
Frédéric FRANCE
f03a8fdc65 fix phpstan 2024-01-15 09:20:57 +01:00
MDW
89004f7e03 Qual: Spelling htdocs/core (#27491)
Highlights:
- initialY in pdf_standard.modules.php was unused
  - remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
MDW
39769482b1 Qual: Fix typing hints for DoliDB (#27484)
# Qual: Fix typing hints for DoliDB

This should help the static tools for type and method checking.
2024-01-13 15:50:02 +01:00
Laurent Destailleur
f201692001 Fix phpstan 2024-01-12 19:50:22 +01:00
Laurent Destailleur
618a364064 FIX #27439 but using the opposite direction. int is bette as we can evolve to add a third value in a future. 2024-01-12 17:47:54 +01:00
MDW
58ba3e31fa Qual: Fix spelling for crypted and referer (#27408)
# Qual: Fix spelling for crypted and referer.

The proper spelling is encrypted and referrer, but the code has
some occurences where referer and crypted need to be maintained.

To make verification easier, this spelling correction is limited to
mostly these corrections and some minor translations and a only a
few other corrections.

crypted and referer are added as exceptions for spelling after this fix.

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-01-11 10:07:06 +01:00
MDW
d7fc7b408f Qual: Spelling commonobject (#27409)
# Qual: Fix spelling in commonobject.class.php.

Most corrections are in comments.
Variable  was changed to  and is local to the file.
Some comments were translated.
Variable  was changed to , used locally.
2024-01-11 10:00:48 +01:00
Laurent Destailleur
78601732d2 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-09 17:13:20 +01:00
Laurent Destailleur
cdf2e4408c Debug v19 2024-01-09 16:56:32 +01:00
Laurent Destailleur
27fc5a2f84 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop 2024-01-06 16:56:28 +01:00
Laurent Destailleur
76ee9e506d Debug v19 2024-01-06 16:43:01 +01:00
Laurent Destailleur
4501872f17 Clean code with rector 2 2024-01-05 04:33:58 +01:00
Laurent Destailleur
b28ae5d8d3 Clean code 2023-12-27 12:12:20 +01:00