# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
# Fix: Repeat fields typing in CommonClass children
phpstan needs typing to be 'co-variant' and therefore typing must be repeated as
the method is not to initialise the property in the constructor, but to override
the proparty by a 'local' definition in the child class
# Qual: Fix PhanPluginDuplicateIfStatements & remove exceptions
Fix occurences of PhanPluginDuplicateIfStatements which are if statements where the
consecutive branches execute the same code, making it useles to test the condition
* Fix: join->implode
# Fix: join->implode
Update new cases of join
* Fix: Duplicate if condition in if/else sequence
# Fix: Duplicate if condition in if/else sequence
Fixed repeated if condition and action
* Fix: False positive for PhanTypeMismatchArgumentInternalProbablyReal
* Qual: phan: suppress false positive on ssl_set
* Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal
# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal
PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.
* Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal by improving typing
* Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal
# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal
False positive detecting that is not an int, rewriting to check
impact
* Qual: Add typing to fix PhanTypeMismatchDimAssignment notice
* Fix: Initialise array for code in somme
* Qual: Update type hint for argument in _Set_Format
* Qual: Update type hint for childtables
* Qual: Add typing to attributes
* Qual: Add typing for _msgContent
* Qual: Suppress PhanTypeMismatchDimAssignment
* Qual: Add typing for liste
* Qual: Add typing to fields
* Qual: Add typing hint for $objMod
* Qual: Modify assignment of array with bool keys for phan typing
Demonstration:
```
php -r '$a=[true=>"yes",false=>"no"];var_dump($a);'
# Result demonstrates bool keys are converted to int.
Command line code:1:
array(2) {
[1] =>
string(3) "yes"
[0] =>
string(2) "no"
}
```
* Qual: Add typing hint to indicate value is not null
* Force non-null type on $paramname
* Qual: Add typing hint to getCats()
* Update inc.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Improve typing hint for (ext)Object, and allow null
# Qual: Improve typing hint for object, and allow null
As the key "->element" is expected, the object type should be derived from CommonObject.
Also extObject can be nullable
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Fix: Use null instead of 0 for extObject in call to Form::editfieldval()
* Qual: Ignore some false positives for deprecated functions
# Qual: Ignore some false positives for deprecated functions
The Phan Deprecation Plugin for internal functions has mixed up some
mail functions and lists them as deprecated, this ignores that
* Qual: Enable detection and fixing of internal deprecations
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Replace 'join' with 'implode'
* Qual: Update codespell lines ignore list after format
# Qual: Update codespell lines ignore list after forma
Done using latest library, so also adds some exceptions that are needed
in the future;
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: $form argument to price() must be int
# Fix: $form argument to price() must be int
Changed '' for $form into 0
* Fix: PHPDoc annotations in unappropriate comment
# Fix: PHPDoc annotations in unappropriate comment
PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)
* Fix: PHPDoc annotations in unappropriate comment
# Fix: PHPDoc annotations in unappropriate comment
PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)
* Fix: PHPDoc annotations in unappropriate comment
# Fix: PHPDoc annotations in unappropriate comment
PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)
* Fix: PHPDoc annotations in unappropriate comment
# Fix: PHPDoc annotations in unappropriate comment
PHPDoc annotations need to be in /** */ or // comments.
Fixed that (change type, move comment, add suppress directive)
* Update dolreceiptprinter.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* NEW - See the documents of my subordinates
* cop
* Rewriting
* up
* ok
* FIX - Restriction on sale representative
---------
Co-authored-by: Anthony Berton <anthony.berton@bb2a.fr>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
htdocs/compta/paiement/class/paiement.class.php 115 PHPDoc type array of property Paiement::$multicurrency_tx is not covariant with PHPDoc type array|float of overridden property CommonObject::$multicurrency_tx.
htdocs/compta/paiement/class/paiement.class.php 120 PHPDoc type array of property Paiement::$multicurrency_code is not covariant with PHPDoc type array|string of overridden property CommonObject::$multicurrency_code.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
* Qual: Ignore suspicious param positions
# Qual: Ignore suspicious param positions
Add annotations to ignore false positives about suspicious parameter positions.
The cases that require more analysis or may be actual bad parameters positions
are not ignored
the modulebuilder template (so first param is now always $user), except
the delete for thirdparty (still accept the id of thirdparty to delete
as first parameter). Will probably be modified into another version.
