Commit Graph

2080 Commits

Author SHA1 Message Date
Jon Bendtsen
df4cd2fc65 FIX adding tms and datec to email templates (#36189)
* NEW: adding tms and datec to email templates

* Escaping a timestamp string I just generated myself

* switching single and double quotes in escape line for tms and datec to make the build system happy?

* Add an id to the table

* showing better names than tms and datec

* Changing code to label to fix #29116

* using hregis advice to use idate not escape the string with date

* requested changes

* forgot to add my name to editors

* had to make class changes for API to work

* setting datec back to int|string

* removing unused code lines and using idate in the api file

* no tms in create or update, but select. No datec in update

* expanding hurl tests to prevent post with id or tms, put with id or datec

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2025-11-11 09:02:57 +01:00
Laurent Destailleur
c42d783abe Fix regression 2025-11-09 14:53:09 +01:00
Frédéric FRANCE
9491d880cf clean code (#36170)
* clean code

* Update bom.class.php

* Update commondocgenerator.class.php

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-09 01:19:31 +01:00
Laurent Destailleur
240352b89e Fix regression 2025-11-08 15:59:31 +01:00
Laurent Destailleur
0b8f8ee8a0 Clean code 2025-11-08 12:13:39 +01:00
Jon Bendtsen
31cc6a702a NEW qual fixes on api contract (#36066)
* QUAL: API contract: RestException update, check if thirdparty exists before creating contract

* using the entity of this contract

* Safer usage of getEntity

* using global ->entity

* testing if create with socid=0 should fail

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2025-11-05 22:35:25 +01:00
Laurent Destailleur
70d4461c1d QUAL Add phpunit test to avoid a bad code sequence 2025-11-03 02:00:01 +01:00
Laurent Destailleur
71b4612a47 Remove module 2025-11-02 16:34:12 +01:00
Jon Bendtsen
20a428e2de QUAL: API contract: RestException update, check if thirdparty exists before creating/updating contract (#36007)
* QUAL: API contract: RestException update, check if thirdparty exists before creating contract

* also checking if socid exists during put

* using the entity of this contract

* also fixing entity during post

* some hurl tests of contract api

* check if contract id is 0, because that is not possible

* check (un)activate permissions and getEntity()

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-11-01 22:47:18 +01:00
Jon Bendtsen
982e0ed64e NEW: API endpoint for getting products in a warehouse (#35918)
* mostly updating fetch with all the fields and adding 2 missing variables

* adding throw RestException numbers, @url and a test for if you try with id=0

* Adding hurl file that do some testing og warehouses API endpoints

* Class for API prevented ever seeing model_pdf in API json

* Check for auth before doing other tests on the request

* New function list Products in warehouse. Work done by defrance, revived by JonB

* API PUT/update now allows for more database fields

* hurl tests for the new list products in warehouse endpoint

* also rejecting warehouse_id in a post

* pre-commit fix api warehouses

* copy paste error from api_usergroup

* Just return the lines, no cleaning needed

* PHAN fixes

* trying to fix PHAN error

* fix api update so it returns error when error, and fix object->update with import_key

* this->db not global db

* Advice from hregis

* Typo this d not dB

* Array of strings

* Changed listProducts in warehouse, uses api_product->get with variables from that

* hurl tests for API warehouses, and the new function get products in warehouse

* some STAN fixes

* more phan fixes

* changes revealed necessary by hurl testing

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2025-10-28 10:23:06 +01:00
Laurent Destailleur
eec7c592c0 FIX dol_print_date with param gmt when server is not UTC. 2025-10-24 15:30:02 +02:00
Jon Bendtsen
802e4b6491 NEW API user/groups/ POST, PUT, DELETE + some hurl tests (#35903)
* NEW API user/groups/ POST, PUT, DELETE + some hurl tests

* indent fix

* saving note_private (Ryan) during create and detect if we call ourselves?

* fix call with wrong arguments

* Reshow array's in the json output

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2025-10-23 13:56:22 +02:00
Jon Bendtsen
1f47cfd583 NEW API for getting, adding, deleting and/or modifying email templates (#35853)
* NEW API for getting, adding, deleting and/or modifying email templates

* removing duplicate class formmail which has been moved to a separate file

* hurl file for testing the emailtemplates api

* more comprehensive tests of posting a new email template, all required fields and making sure that ID is rejected

* first GUI test of email templates

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-10-22 18:04:39 +02:00
Laurent Destailleur
8d50b69bce Add a test if command not found 2025-10-22 13:30:36 +02:00
Laurent Destailleur
74455fd391 FIX #35887 2025-10-22 02:21:52 +02:00
Laurent Destailleur
0df13aedcb Ignore file to avoid commiting it 2025-10-18 11:53:37 +02:00
Laurent Destailleur
f0c61790eb Clean code 2025-10-17 23:43:28 +02:00
Laurent Destailleur
384d40ca01 phpunit more complete 2025-10-17 19:39:45 +02:00
Laurent Destailleur
412fe1df32 Fix regression 2025-10-16 21:26:35 +02:00
Laurent Destailleur
5228c9827e Fix CI 2025-10-16 19:46:46 +02:00
Laurent Destailleur
c45ab5c387 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2025-10-15 20:03:54 +02:00
Jon Bendtsen
7fc9b253bf Reviving some old PR with API get, activate and disable modules (#35718)
* Reviving some old PR with API get, activate and disable modules

* expanding hurl test for setup wih some module tests

* return array, not object

* fix PHPStan on getmodules

* typecasting module functions to string

* instiating class DolibarrModule into an object so we can call functions on it

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2025-10-14 19:33:40 +02:00
Jon Bendtsen
e8a347f89e NEW API for handling mass mailing targets (#35603)
* NEW API for handling mailing targets

* fix PHP Codesniffer

* adding return values to make phpstan happy

* Update function actually updates

* defining mailing_target public function create

* using a different language translation

* mailing_target - phpstan fixes

* mailing target - no check properties body

* mailing target int typecast fk_mailing

* mailing target - just 1 parameter

* mailing_target phpstan fixes

* mailing_target setting labelStatus

* mailing target class public function delete

* reveal the list of status name for the Mass mailing object in the API

* set tms to now when it is set to draft

* functions to set the mailing target status

* hurl testing api mailings

* hurl test - exit run script at first error

* hurl test mailings - should cover all endpoints

* using self:: in front of the CONST

* Trying to find out which line evaluates to noting

* API mailings can now get the targets of a mailing

* Protected method name "Mailings::_cleanTargetDatas" must not be prefixed with an underscore

* give me fk_project

* API endpoints for: Get all targets of a mass mailing + Get information about a specific target id

* API endpoint to update a mailing target

* telling pre-commit check to ignore, just like done in the function I copied

* be more explicit about for GUI tests we need username and password

* Prevent updating fk_mailing value

* API endpoint deleteTarget

* post to create a mailing target does work, but need slight more testing after work

* correct indent

* fixing some build errors

* More comprehensive hurl test of creation of a target

* adding status_dest to mailing targets json

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
2025-10-09 18:38:13 +02:00
Jon Bendtsen
1cb221efe9 Make hurl tests work on GUI page requiring login (#35652)
* Adding hurl tests to Dolibarr

* modifying run.sh to get it past commit checks

* change the APIHEADER to be read from the environment

* spell fix

* test to see if build system will accept this file

* deleting script method that doesn't work

* beginning to make hurl tests accept environment variables for the location

* Add GUI login to hurl tests

* Fix CI

* clean code (#35640)

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* clean code

* Fix warning

* Clean code

* PHPStan > Update baseline (#35644)

Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>

* NEW Can drag and drop in BOM card

* WIP Upload files

* WIP Upload files

* Adding hurl tests to Dolibarr

* using hostnport variable for all remaining tests

* Add some asserts and gui login tests

* double quotes around shell variables

* adding -r to read

* expand mass mail gui test with all 6 columns in the table

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: ldestailleur <eldy@destailleur.fr>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
2025-10-06 01:38:44 +02:00
Jon Bendtsen
c1aceed820 Adding hurl tests to Dolibarr (#35643)
* Adding hurl tests to Dolibarr

* modifying run.sh to get it past commit checks

* change the APIHEADER to be read from the environment

* spell fix

* test to see if build system will accept this file

* deleting script method that doesn't work

* beginning to make hurl tests accept environment variables for the location

---------

Co-authored-by: Jon Bendtsen <xcodeauthor@jonb.dk>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-10-05 18:08:10 +02:00
ldestailleur
9458392ae1 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-09-30 02:50:38 +02:00
ldestailleur
a3ee1b0c11 Check there is no dolcrypt data into demo files. 2025-09-30 02:50:17 +02:00
ldestailleur
ad830a346e Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2025-09-23 16:50:17 +02:00
ldestailleur
6ead2839d0 Fix missing several test on permission on actions 2025-09-23 16:41:53 +02:00
ldestailleur
4a363478ae Clean code with rector 2025-09-18 16:26:38 +02:00
Eric - CAP-REL
1f8b5db2c7 exit code must be >= 0 (#35311) 2025-09-12 02:29:23 +02:00
ldestailleur
97d5025c08 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-09-07 18:51:58 +02:00
ldestailleur
f160e23918 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into 22.0 2025-09-05 17:23:25 +02:00
ldestailleur
6c0873708a Merge branch '20.0' of git@github.com:Dolibarr/dolibarr.git into 21.0 2025-09-05 15:34:13 +02:00
ldestailleur
c2ed4519b1 Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 20.0 2025-09-05 11:38:30 +02:00
ldestailleur
781adf507b Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0 2025-09-04 20:47:13 +02:00
ThomasNgr-OpenDSI
01aa901f93 18.0 fix CVE 2024 40137 (#34762)
* Sec: Remove all functions that accept callable params - CVE-2024-40137

* FIX #34746 - More complete fix for CVE-2024-40137

---------

Co-authored-by: ldestailleur <eldy@destailleur.fr>
2025-09-04 14:59:44 +02:00
ldestailleur
96a74c4976 Disable this test where result is not predicable 2025-09-04 14:13:13 +02:00
Frédéric FRANCE
f88f7136c3 clean code (#35210) 2025-09-03 22:33:43 +02:00
Frédéric FRANCE
87c94e1a31 fix parameters (#35209) 2025-09-03 22:33:25 +02:00
Frédéric FRANCE
5b104f4625 clean test code (#35205)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2025-09-03 21:43:23 +02:00
Frédéric FRANCE
d4601a26ff fix CI (#35204) 2025-09-03 18:58:06 +02:00
ldestailleur
564d245d23 Fix phpunit 2025-09-03 18:54:48 +02:00
Frédéric FRANCE
d8b167851c add a combining character in dol_string_unaccent test (#35153)
* add a combining character in dol_string_unaccent test

* fix
2025-09-03 12:14:33 +02:00
ldestailleur
62f761ac71 Merge branch '22.0' of git@github.com:Dolibarr/dolibarr.git into develop 2025-09-02 12:07:15 +02:00
Frédéric FRANCE
34498d3437 fetch greatest tms for user and fix user creation and modification (#35145)
* fetch greatest tms for user and fix user creation and modification

* fetch greatest tms for user and fix user creation and modification

* fetch greatest tms for user and fix user creation and modification

* fetch greatest tms for user and fix user creation and modification

* fetch greatest tms for user and fix user creation and modification

* fetch greatest tms for user and fix user creation and modification
2025-09-01 19:21:54 +02:00
ldestailleur
4e89f046d1 Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into 22.0 2025-09-01 16:47:39 +02:00
ldestailleur
bb0974add9 FIX Security when using feature Advanced Target of emailing (hidden in
v21, default in v22+). Possible SQL injection by users with permissions
to make mass emailing. Reported by Simon Perdrisat.
2025-09-01 16:38:01 +02:00
Frédéric FRANCE
7d04067b4e fix CI (Travis) (#35099)
* fix test

* fix test

* fix test

* fix test

* fix test

* fix

* fix

* fix
2025-08-28 02:15:41 +02:00
Laurent Destailleur
4932cd5f7e Execute phpunit for functionsbe in all tests 2025-08-26 05:27:02 +02:00