ldestailleur
6856b66d85
Clean code
2025-10-02 10:56:12 +02:00
ldestailleur
8dbd59a71b
Look and feel v23 - Add an arrow back to module page
2025-08-09 20:44:30 +02:00
Frédéric FRANCE
e95235b977
clean code ( #34882 )
...
* clean code
* clean code
* clean code
* clean code
* clean code
2025-08-06 19:25:15 +02:00
ldestailleur
7689f12960
Merge branch '21.0' of git@github.com:Dolibarr/dolibarr.git into develop
2025-03-25 20:30:27 +01:00
ldestailleur
99e898fa64
Fix trans
2025-03-25 13:48:21 +01:00
MDW
fd7fee2e8f
Qual: Fix textwithpicto $type argument (0->info,1->help)
2025-02-08 01:49:54 +01:00
Laurent Destailleur (aka Eldy)
697a9fc599
Finish cleaning v21 of the setup pages
2025-01-24 13:12:48 +01:00
Laurent Destailleur (aka Eldy)
6250439309
Debug v21
2025-01-09 19:35:01 +01:00
Laurent Destailleur
a746c6aab0
Show a legal warning when enabling online signature
2024-11-18 13:20:55 +01:00
Frédéric FRANCE
1adc883b56
add baseline exclude for phpstan ( #31632 )
...
* add baseline exclude for phpstan
* update
* update
* update
* update
* update
* merge
* restore one filter
* delete old errors
* fix
* fix
* fix
* $moreforfilter can t be empty
* fix
* enable check
* refresh baseline
* add phpdoc
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* update phpstan baseline
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* fix
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-11-04 23:53:20 +01:00
Frédéric FRANCE
f6776541b6
Fix ignored phpstan ( #31009 )
...
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-20 02:19:05 +02:00
MDW
9a9e851494
Qual: Fix new UndeclaredGlobalVariable notices & enable ( #30963 )
...
* Qual: 🛟 Fix typing
Qual: Fix typing
Fix some typing currently failing ci in develop.
* Fix typing for grabimages
* Qual: Fix new UndeclaredGlobalVariable notices & enable
# Qual: Fix new UndeclaredGlobalVariable notices & enable
This fixes several new notices regarding 'undeclared globals' which
mostly correspond to missing initialisations in views and some real
bugs where the variable name was incorrect.
Some less obvious cases are unsolved and ignored (adherents/list,
and fourn/commande/card).
This is in preparation of fixing the notices in the other files
where the baseline was already set to ignore them where most just
need a phan-var-force declaration which will help with verifying
type compatibity and object member verifications
2024-09-16 01:50:58 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
atm-lena
8363d610de
llxHeader CSSBody - admin part 1 ( #29930 )
...
Co-authored-by: atm-lena <lena.papazian@atm-consulting.fr >
2024-06-08 14:53:14 +02:00
Frédéric FRANCE
82d63247d7
fix phpstan pgsql.class.php ( #29511 )
...
* fix phpstan pgsql.class.php
* Update Database.interface.php
* fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
fix phan
fix phan
fix phan
fix phan
* fix phan
* fix phan
* fix phan
* fix phan
2024-04-27 22:01:34 +02:00
MDW
526fcee668
Force typing (phan) for typing checks
2024-03-27 10:17:39 +01:00
MDW
9fe6fd7694
Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
...
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-12 18:39:40 +01:00
MDW
d116934301
Fix: Initialise array variables before assigning fields ( #28725 )
...
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
* Fix: Initialise array variables before assigning fields
2024-03-09 02:43:57 +01:00
Frédéric FRANCE
6a6e287428
fix admin contract ( #28225 )
...
* fix admin contract
* Update contract.php
2024-02-18 15:38:11 +01:00
MDW
71f906c280
Qual: Spelling of admin code. ( #27412 )
...
# Qual: Fix spelling of admin code.
Mostly changes in the comments.
Some french text was modified to not trigger a bad spelling.
htdocs/admin/contract.php has a change to $langs->trans(Activated)
which probably fixes a bug.
htdocs/admin/system/xcache.php used ->trans(Recommanded)
but the proper key is ->trans(Recommended).
2024-01-11 09:59:52 +01:00
Laurent Destailleur
ccaae7ab24
Clean code
2024-01-05 03:41:22 +01:00
Laurent Destailleur
6b0a4d578f
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-01-03 17:34:50 +01:00
MDW
b08d6b5019
Fix Correct call to dolibarr_set_const for CONTRACT_ALLOW_ONLINESIGN
2024-01-02 22:10:05 +01:00
Laurent Destailleur
987d6c41b9
Fix with php-cs-fixer
2023-12-04 11:41:14 +01:00
Laurent Destailleur
b69059af76
Fix warning
2023-11-27 12:24:18 +01:00
Laurent Destailleur
5b15b5c647
QUAL Move conf->global into getDolGlobal...
2023-10-24 17:00:13 +02:00
Laurent Destailleur
b546e7c624
css
2023-09-10 20:24:58 +02:00
Laurent Destailleur
08e428b46d
Fix missing param
2023-08-09 18:00:31 +02:00
Florian HENRY
5cec30aeae
agin fix php8 warning
2023-06-09 01:14:57 +02:00
Laurent Destailleur
eed3cdd9cc
Debug v17
2023-01-04 15:10:53 +01:00
Laurent Destailleur
e1e9ff8cda
Fix debug v17
2022-12-08 19:34:16 +01:00
Florian HENRY
b3c7d64cb2
NEW: Allow download link in module configuration (propal,invoice,supplier proposal, order)
2022-10-28 10:40:43 +02:00
Laurent Destailleur
d436991c98
Removed useless plugin specialchar in CKeditor
2022-10-06 17:20:12 +02:00
Laurent Destailleur
09ee684c9f
NEW Default template of contract is not mandatory
2022-10-06 17:07:23 +02:00
Faustin
30c3543d20
Online pdf contract signature
2022-09-29 14:28:58 +02:00
Frédéric France
8d33953142
add comment
2022-09-07 20:08:59 +02:00
Laurent Destailleur
059d0073ff
FIX Maxi debug v16
2022-08-12 15:54:50 +02:00
Laurent Destailleur
e465c0f34b
Debug v16
2022-07-24 19:05:55 +02:00
Frédéric France
889856d55f
use getDolGlobalString
2022-06-21 23:39:31 +02:00
Frédéric France
1f7fc7a2ae
getDolGlobalString
2022-06-21 20:25:25 +02:00
Laurent Destailleur
416543a5f5
Standardize code to allow deletion of an odt template
2022-01-26 13:49:46 +01:00
Laurent Destailleur
1d597e8a72
Fix add unset* action as sensible GET actions
2021-09-19 18:03:38 +02:00
Laurent Destailleur
5c8fb38426
Fix add del* action into list of sensitive actions
2021-09-19 14:41:46 +02:00
Laurent Destailleur
ed3919da13
Look and feel
2021-09-05 02:25:32 +02:00
Christian Foellmann
d706c3b1ec
use Forms::buttonsSaveCreate() to generate most of the Save|Cancel forms combination
2021-08-20 14:41:30 +02:00
Laurent Destailleur
8b9af8f5ab
Responsive
2021-06-13 01:27:04 +02:00
Frédéric FRANCE
608b933ef5
code syntax admin dir
2021-02-26 22:04:03 +01:00
Laurent Destailleur
dd69aed27b
Fix error test
2021-01-23 17:49:08 +01:00
Laurent Destailleur
1ec3d4cfdf
CSS
2020-12-03 13:19:35 +01:00
Laurent Destailleur
7e6af6a54f
FIX translation not loaded for error message of numbering modules
2020-11-28 02:09:27 +01:00
