Frédéric FRANCE
0afc7eed80
clean code ( #35515 )
...
* clean code
* add doc
* add doc
2025-09-27 12:28:31 +02:00
Frédéric FRANCE
c6145d7723
clean code ( #35151 )
...
* clean code
* Update mod_barcode_thirdparty_standard.php
* Update mod_barcode_product_standard.php
2025-09-01 19:32:03 +02:00
ldestailleur
9cbeff83a4
FIX Test on mandatory product or thirdparty barcode
2025-08-09 11:46:41 +02:00
ldestailleur
11f9f032d9
Debug v22
2025-06-07 14:15:56 +02:00
MDW
56c060e14a
Qual: Define types for properties
2025-01-24 10:55:53 +01:00
MDW
ac9301dc8f
Qual: Handle case where code to convert is <false>
2025-01-24 10:55:52 +01:00
Frédéric France
1dd86e9d32
fix
2024-12-14 09:08:33 +01:00
Laurent Destailleur (aka Eldy)
778b07dabd
Debug v21 Fix tooltip on setup pages
2024-12-13 17:22:48 +01:00
MDW
f4ff437026
Qual: Fix phan/phpstan notices in class files (part 4) ( #31598 )
...
* Qual: Fix phan notices for DolibarrModules.class
* Qual: Fix notices for classes actioncomm..task.class.php
* fixup! Qual: Fix notices for classes actioncomm..task.class.php
* Qual: Fix new notices blocking PR
2024-10-30 21:33:30 +01:00
Frédéric FRANCE
0e1292e253
fix phpstan ( #31177 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-09-29 02:49:34 +02:00
MDW
115627a054
Qual: Fix PhanPluginUnknownObjectMethodCall where is the only phan notice ( #30957 )
...
* Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
# Qual: PhanPluginUnknownObjectMethodCall where it is the only phan notice
Fix PhanPluginUnknownObjectMethodCall in files where it is the only phan notice
* Update phan baseline
* Fix $website global type in some contexts
2024-09-16 01:49:38 +02:00
MDW
75ed925f06
Qual: Fix PhanPluginUnknownObjectMethodCall ("part 1") ( #30563 )
...
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add typing hint in phan config to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint to fix phan notice.
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjectBlock
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for linkedObjects
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
# Qual: Fix PhanPluginUnknownObjectMethodCall (add typing hints)
Add/improve typing hint for PhanPluginUnknownObjectMethodCall
* Fix: MemberNumRefNumbers getExample does not take any arguments
Found thanks to adding the typing for phan!
* Qual: Correct forced type for $module
* Qual: Ignore phan false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Ignore false positive
* Qual: phan/Ignore false positive, replace depr.prop with method
* Qual: Fix typing for count by adding is_array check
* Qual: replace depr.prop `nom` with method
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Fix depr.prop with getter and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: phan/Correct module type and ignore false positive
* Qual: Improve typing for mymodule template
* Make info method arguments match calls
* Make PrintingDriver abstract class because we added abstract methods
* Add phpdoc typing for phan
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update getExample function signature for compatibility
* Update header wit correct information
* Update getExample method signature
* Update getExample method signature
* Correct reference to class in comment
* Force php phan typing for numbering modules
* Correct $_GLOBALS to $GLOBALS
* Add phpdoc to indicat type of properties
* Correct default to null
* Improve getNextValue typehint
* Improve getNextValue typehint
* Qual: Improve ModeleNumRefTakepos typing
* Qual: Improve ModeleNumRefRecruitmentJobPosition typing
* Fix default for $langs
* Do not use non-existing ModeleNumRefTakepos::nom
* Allow getNextValue argument to be null
* Correct $_GLOBAL into $GLOBALS
* Improve typing for ldap functions
* Allow null for outputlangs argument
* Improve typing for printOriginLine
* Improve typing for linkedObject access
* Fix PhanTypeMismatchArgumentNullableInternal and optimize
* Fix PhanPossiblyUndeclaredVariable by setting default value
* Ignore PhanPluginDuplicateExpressionAssignmentOperation - needs PHP7.4
* getToolTip does not accept null, changed to ''
* Improve getNextValue typing
* Change PrintingDriver back to normal class (instantiated)
And add errors for functions that should be overloaded
* Adjust pringOriginLine typing to match parent
* Fix phpdoc for getNextValue
* Fix phan typing
* Add/Improve phpdoc typing hints
* Qual: Adjustments to match typing
* Update typing for unit, use GETPOSTINT
* ModeleNumRefTask needs Project
* Fix several notices appearing after update from develop
* Index for choices is int, use GETPOSTINT
* Qual: Ignore empty foreach
* Force BOMLine on object line
* phan typing to indicate that linked objects are BOM
* Type the correct variable name (phan)
* Add typing for $langs
* Type to CommonNumRefGenerator (no class for availabilities)
* Resolve several phan notices after update from dev branch
* Extra typing fixes
* Move common attributes to parent class (phan)
* Add typing to Calendar class
* Improve typing hints
* Add typing to pdf_eagle_proforma
* Qual: Add typing for token in generic_oauthcallback.php
* Add typing for objMod
* Correct getNextValue function signature (phpstan)
* Fix typing (phpstan)
* Update version declarations (fix phpstan)
* Fix phpstan typing issues
* Adjust typing (phpstan)
* Qual: Update baseline & conf to detect 25% of PhanPluginUnknownObjectMethodCall
2024-08-17 19:32:52 +02:00
MDW
e570f59e2d
Qual: Phan fixes (mainly Initial type cannot be inferred) in popular changed classes ( #30604 )
...
* Update setValueFrom $id type to include null
* Only 2 arguments for ModeleNumRefMembers::getToolTip
* Fix PhanTypeConversionFromArray
* Only 6 args for PaymentSalary::addPaymentToBank
* Fix typing hints (array -> string)
* Fix uninitialized variables
* Add cssview to attributes phpdoc
* Avoid double typing specification (Phan notice)
* Qual: Ensure variable is defined (phan)
* Ensure phpdoc typing for verif method
* Ensure phpdoc typing for getNextValue method
* Add status as data key in cols array
* Ensure preg_replace operates on string (phan)
* Correct type for desiredstock
* Fix typing with casts (phan)
* Fix check that notification already exists
* Initialise fk_parent_id to fix typing issue
* Qual: Fix phan notices for Societe & related
* Qual: Fix typing for Facture and related
* Qual: Fix typing for Product & related
* Update baseline
* Fix new phpstan notices
2024-08-14 01:24:55 +02:00
Laurent Destailleur
038ce032e0
Fix tooltip on numbering modules
2024-07-31 12:40:24 +02:00
Laurent Destailleur
a701f84543
Fix tooltip on numbering modules
2024-07-31 12:14:39 +02:00
Laurent Destailleur
82908a30eb
Clean phan warnings
2024-05-30 13:37:17 +02:00
Laurent Destailleur
1cccc808e7
Clean code for barcode generators
2024-05-22 15:49:33 +02:00
Laurent Destailleur
71524d819b
Clean code
2024-05-22 00:27:42 +02:00
Laurent Destailleur
ad28872b74
Clean code
2024-05-21 20:23:24 +02:00
Laurent Destailleur
c02194a3c5
Doc
2024-04-29 16:32:28 +02:00
Laurent Destailleur
f5adfeca59
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-04-29 13:39:20 +02:00
Philippe Grand
661582875a
Fix : Warning: Undefined property: stdClass::$PRODUIT_DEFAULT_BARCODE_TYPE in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/modules/barcode/mod_barcode_product_standard.php on line 187 ( #29479 )
...
* fix : Warning: Undefined variable in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/compta/bank/various_payment/list.php on line 370
* backward
* fix : Warning: Undefined property: stdClass:: in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/modules/barcode/mod_barcode_product_standard.php on line 187
* fix : Warning: Undefined property: stdClass:: in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/modules/barcode/mod_barcode_thirdparty_standard.php on line 188
* fix : Warning: Undefined property: stdClass:: in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/class/html.formbarcode.class.php on line 83
* fix : Warning: Undefined property: stdClass:: in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/class/html.formbarcode.class.php on line 84
* fix :Warning: Undefined property: stdClass:: in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/admin/barcode.php on line 460
* fix : Warning: Undefined property: stdClass:: in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/admin/barcode.php on line 471
* Update mod_barcode_product_standard.php
* Update mod_barcode_thirdparty_standard.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-04-27 18:14:20 +02:00
Francis Appels
6a330096fd
Fix debug phpbarcode
2024-04-02 09:48:48 +02:00
Laurent Destailleur
7158757fa1
Debug v20
2024-03-31 23:48:29 +02:00
Laurent Destailleur
3e8c3edd6d
Clean code from _GET
2024-03-28 17:10:22 +01:00
MDW
cde95b3037
Fix bad typing in thirdparty lib (TCPDF) with cast
2024-03-19 02:59:20 +01:00
Laurent Destailleur
75fae0f27d
Merge branch 'develop' into fix/PhanTypeMismatchReturn
2024-03-16 16:08:08 +01:00
MDW
9eed23c6d0
Fix return type by cast or typing update
...
# Fix return type by cast or typing update
Fix most PhanTypeMismatchReturn notifications.
The remaining ones are likely real bugs or need more Dolibarr
knowledge to fix them efficiently
2024-03-16 13:52:12 +01:00
MDW
13ab939691
Fix deprecated function calls
2024-03-16 13:27:51 +01:00
Frédéric France
41fccbaac5
fix phpstan warnings
2024-03-16 08:49:50 +01:00
MDW
5c57a24fbc
Fix PhanPluginRedundantAssignment
2024-03-13 01:04:01 +01:00
MDW
b2528e2727
Fix PhanPluginRedundantAssignment
2024-03-13 01:04:00 +01:00
Frédéric France
fc732b1be5
fix mod barcode product
2024-03-12 18:49:29 +01:00
Laurent Destailleur
949c885477
Merge branch 'develop' into fix/phpdoc1
2024-03-12 14:11:30 +01:00
Frédéric FRANCE
9b4c8f2445
clean
2024-03-12 09:48:42 +01:00
Frédéric France
8b79cfa095
clean
2024-03-12 00:16:06 +01:00
MDW
eefe123dcb
fixup! fix phpstan ( #28727 )
2024-03-11 23:46:53 +01:00
MDW
4e20c644c2
Qual: Correct PHPdoc typing
2024-03-11 21:51:04 +01:00
Frédéric France
7bcb635a4e
clean code and phpdoc
2024-03-11 18:13:48 +01:00
Frédéric FRANCE
e00a9816f8
fix phpstan ( #28727 )
...
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
* fix phpstan
2024-03-09 14:48:06 +01:00
Frédéric FRANCE
3c055f671e
fix phpstan ( #28545 )
...
* fix phpstan
* fix phpstan
2024-03-01 12:51:48 +01:00
thibdrev
e9eccb7ad2
qual: phpstan for htdocs/core/modules/barcode/modules_barcode.class.php ( #28244 )
...
* qual: phpstan for htdocs/core/modules/barcode/modules_barcode.class.php
htdocs/core/modules/barcode/modules_barcode.class.php 59 PHPDoc type int of property ModeleNumRefBarCode::$code_null is not covariant with PHPDoc type int<0, 1> of overridden property CommonNumRefGenerator::$code_null.
htdocs/core/modules/barcode/modules_barcode.class.php 64 PHPDoc type int of property ModeleNumRefBarCode::$code_auto is not covariant with PHPDoc type int<0, 1> of overridden property CommonNumRefGenerator::$code_auto.
* Update modules_barcode.class.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr >
2024-02-18 15:02:20 +01:00
Laurent Destailleur
ff2d609814
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
...
Conflicts:
htdocs/core/class/commonobject.class.php
htdocs/mrp/mo_production.php
2024-02-12 03:35:39 +01:00
Laurent Destailleur
65533360a2
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
...
Conflicts:
htdocs/main.inc.php
2024-02-12 03:32:58 +01:00
Laurent Destailleur
e0d8bf04b5
Merge branch '19.0' of git@github.com:Dolibarr/dolibarr.git into develop
2024-02-09 19:07:24 +01:00
Laurent Destailleur
c261b84667
Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into 19.0
2024-02-09 19:06:52 +01:00
Laurent Destailleur
d07b7dc72e
Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0
2024-02-09 19:05:41 +01:00
Laurent Destailleur
2f1eecd709
Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0
2024-02-09 19:04:06 +01:00
noec764
2c07bd764d
FIX: Bar code verification should be done by entity because generation does ( #28087 )
...
* FIX: Bar code verification should be done by entity because generation does
* FIX: handle Entities shared tables
* FIX: Remove unused global
---------
Co-authored-by: Noé <noe@scopen.fr >
2024-02-09 14:07:04 +01:00
MDW
89004f7e03
Qual: Spelling htdocs/core ( #27491 )
...
Highlights:
- initialY in pdf_standard.modules.php was unused
- remove (otherwise -> initially) (+same in other file)
2024-01-13 19:48:20 +01:00
