Commit Graph

147 Commits

Author SHA1 Message Date
Frédéric FRANCE
763405a34c fix phpstan (#30985)
* fix phpstan

* fix phpstan
2024-09-17 00:23:25 +02:00
Frédéric FRANCE
e43789a3d7 fix phpstan (#30984)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-17 00:22:47 +02:00
MDW
320f0590d2 Qual: More specific phpstan exceptions (#30967)
* Qual: 🛟 Fix typing

Qual: Fix typing

Fix some typing currently failing ci in develop.

* Fix typing for grabimages

* Qual: More specific phpstan exceptions

# Qual: More specific phpstan exceptions

Avoid ignoring new types of code errors
2024-09-16 01:46:20 +02:00
Frédéric FRANCE
2a6bbf88df fix phpstan (#30944)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-13 17:40:03 +02:00
Frédéric FRANCE
ef0a3329a1 fix phpstan (#30914)
* fix phpstan

* fix phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-09-13 03:11:43 +02:00
MDW
f89245b354 Qual: Fix some CommonIncoterm/DocGenerator/People typings (#30940)
* Fix extraparams property typing

* Fix argument typing

* Fix 'status' argument type in calls to dolGetButtonTitle

* Fix argument2 for price to 1 (was 2)

* Fix deliveryreceipt argument

* Fix PHPDoc dol_sort_array

* Fix range for int argument

* Fix arg type for str_pad and add some PHPDoc

* Fix natsort value for dol_sort_array

* Fix arguments on calls to dol_sort_array

* Reduce phpstan exceptions

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Typing, initialisation

* Qual: Fix undeclared variables

* Update phan baseline

* Update baseline

* Qual: Add type hints for Stripe objects

# Qual: Add type hints for Stripe objects

Suggest the more specific implementation of the StripObject.

* Add PHPDoc for host class properties

* Ignore false positive (phan) for deprecated property

* Improve typing

* Update baseline
2024-09-13 03:09:23 +02:00
MDW
76eaf8bd8d Qual: Fix phan notices in classes related to class using getNextValue. (#30925)
* FIX 🛟 phan

* getToolTip() can take null for $coc

* Fix uninitialized vars & arg types

* PHPDoc typing, argument fixes

* PHPDoc typing, argument fixes for AdherentType

* PHPDoc typing, argument fixes for AdherentStats

* Update baseline to enable adherent notices

* Fix PHPDoc typing in api_members

* Minor bug fixes, typing

* PHPDoc api_subscriptions

* PHPDoc Societe

* Ignore empty foreach notice

* Add initialiser

* Categorie is string, old int mode is deprecated

* Fix missing initialisations

* Fix missing initialisations adherents/note

* Fix typing (cast), initialisation of var

* Fix initialisations

* Fix argument types

* Improve array PHPDoc type

* PHPDoc array type

* PHPDoc: Improve typing

* Correct argument type to getNomUrl

* Improve typing for timespent

* Fix typing for getNextValue args

* Improve typing

* Fix typing hints contrat/card

* Update baseline

* Fix typing

* Fix extraparams property typing

* Fix argument typing

* Qual: Correct covariant type

* Impove typing for timespent

* Remove exclusion no longer matched (level 6)

---------

Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
2024-09-12 21:16:42 +02:00
Frédéric FRANCE
97b97c6665 fix phpstan (#30912)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-10 14:58:36 +02:00
Frédéric FRANCE
03ca17ee40 fix phpstan (#30911)
* fix phpstan

* fix phpstan
2024-09-10 14:54:54 +02:00
Frédéric FRANCE
fba71ab043 fix phpstan (#30893)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-10 01:02:56 +02:00
Frédéric FRANCE
2d02bec9ba fix phpstan (#30882)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-09 03:13:43 +02:00
Frédéric FRANCE
6aac956b7a fix phpstan (#30868)
* fix phpstan

* fix phpstan

* fix phpstan
2024-09-09 02:29:23 +02:00
Frédéric FRANCE
797bfb27e0 fix phpstan (#30881)
* fix phpstan

* fix phpstan
2024-09-09 02:28:35 +02:00
Frédéric FRANCE
f29e9e760f fix phpstan (#30861)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 14:02:53 +02:00
Frédéric FRANCE
d12fd8d175 fix phpstan (#30869)
* fix phpstan

* fix phpstan
2024-09-06 13:50:27 +02:00
Frédéric FRANCE
80999f9a61 fix phpstan (#30871)
* fix phpstan

* fix phpstan
2024-09-06 13:47:24 +02:00
Frédéric FRANCE
eb04c5c427 fix phpstan (#30860)
* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-06 13:44:29 +02:00
Frédéric FRANCE
80d1f47d4d fix ignored phpstan (most of expects string, int given) (#30649)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* more ignore

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan
2024-09-05 16:05:37 +02:00
Frédéric FRANCE
97392965e1 fix ignored phpstan (#30645)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-16 20:13:02 +02:00
Frédéric FRANCE
2bc320bdaa fix ignored phpstan (#30643)
* fix ignored phpstan

* fix ignored phpstan

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-15 16:57:15 +02:00
Frédéric FRANCE
4c51d61fc5 fix ignored phpstan (#30644)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-15 16:55:13 +02:00
Frédéric FRANCE
fbabd1e696 fix ignored phpstan (#30642)
* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan

* fix ignored phpstan
2024-08-15 16:42:54 +02:00
Frédéric FRANCE
4df9e44663 fix expects string, bool given (#30636)
* fix expects string, bool given

* fix expects string, bool given

* fix expects string, bool given
2024-08-14 13:58:17 +02:00
Frédéric FRANCE
32839b138b fix phpstan level 5 (#30565)
* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phpstan level 5

* fix phan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

* fix phpstan

fix phpstan

fix phpstan

fix phpstan

* increase level for apstat
2024-08-13 23:16:09 +02:00
Frédéric FRANCE
803c3c2f30 fix phpstan sendXXX expects int (#30519)
* fix sendXXX expects int

* fix sendEmailTo expects int

* fix regression

* fix loadxxx expects int

* fix loadxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int

* fix getxxx expects int
2024-08-13 20:39:40 +02:00
Frédéric FRANCE
173dc1a70e fix constructor expects int (#30512)
* constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

* fix constructor expects int

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2024-08-01 10:52:53 +02:00
MDW
5da6995a56 Qual: Update Phan baseline - Fix phpstan regex (#30504)
* Add missing escapes in regex

* Qual: Fix phpstan regex
2024-07-31 18:39:02 +02:00
Frédéric FRANCE
2cf5b9bc42 Update phpstan.neon.dist (#30489) 2024-07-31 15:41:14 +02:00
Laurent Destailleur
700edf8768 Fix warnings 2024-07-31 14:19:08 +02:00
Frédéric FRANCE
6a77028b02 fix syntax error, fix phan (#30372)
* fix syntax error

* fix phpstan
2024-07-15 20:52:09 +02:00
Frédéric FRANCE
94feb2cfa7 fix phpstan expects values (#30324)
* fix phpstan expects values

* fix phpstan expects values
2024-07-09 19:28:59 +02:00
Frédéric FRANCE
6601503edc Fix phpstan llxheader (#30328)
* fix phpstan for llxHeader

* fix phpstan for llxHeader

* fix phpstan for llxFooter
2024-07-09 19:28:09 +02:00
Frédéric FRANCE
2874e85728 fix phpdoc of tva_by_rate (#30308)
* fix phpdoc of tva_by_rate

* fix phpdoc of tva_by_thirdparty
2024-07-08 21:51:27 +02:00
Frédéric FRANCE
2707475a12 fix phpstan (#30319)
* fix phpstan

* fix phpstan expects int, false given ...

* fix phpstan expects int, true given ...
2024-07-08 21:45:35 +02:00
Frédéric FRANCE
f99beb9023 fix expects int (#30304) 2024-07-06 14:30:13 +02:00
Frédéric FRANCE
29f223fd3c fix checkFunctionArgumentTypes (#30249)
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
2024-07-04 17:47:31 +02:00
Frédéric FRANCE
2f5647e4e3 fix checkFunctionArgumentTypes (#30234)
* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* add ignore

* add ignore

add ignore

add ignore

add ignore

add ignore

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes

* fix checkFunctionArgumentTypes
2024-07-03 02:30:53 +02:00
Frédéric FRANCE
3e750c2f0b ignore more phan lines with phpstan (#30135)
* ignore more phan lines with phpstan

* fix
2024-06-23 17:46:34 +02:00
Frédéric FRANCE
6cfd7d16e6 fix phpstan check class case (#30058) 2024-06-18 15:48:18 +02:00
Laurent Destailleur
baf3ec75c2 Ignore non usefull phpstan error 2024-05-13 12:42:26 +02:00
Laurent Destailleur
22aeb4ef9f Ignore warning 2024-05-01 17:49:38 +02:00
Laurent Destailleur
826f3063e2 Fix phpstan conf 2024-04-30 18:56:36 +02:00
Laurent Destailleur
b5cd856bbe Eclude some phpstan warnings 2024-04-30 13:41:27 +02:00
Frédéric FRANCE
86eda8ede5 add filters for level 4 (#29532) 2024-04-29 20:02:09 +02:00
Frédéric FRANCE
52c414d931 How many errors remain before reaching the next phpstan analysis level? (#29509) 2024-04-27 17:19:40 +02:00
Frédéric France
6c5853528e Merge remote-tracking branch 'upstream/develop' into patch-11 2024-03-11 17:46:37 +01:00
MDW
ec0fd31386 Fix phpstan workflow file (#28741)
* Fix phpstan workflow file

# Fix phpstan workflow file

Line was split in two, joined

* qual: set memory limit to 'unlimited' (-1)

* Remove some stubs to check impact

* Fix: Verify execution time limit

* Remove stub files to reuse cache

* Qual: Rename distribution phpstan.neon to phpstan.neon.dist

# Qual: Rename distribution phpstan.neon to phpstan.neon.dist

This allows the developer to override some settings locally

Also update the .gitignore file with phpstan.neon and some other other
ignores (cache, local log files, temporary edit files).

* Enable debug on phpstan

* Re-enable stubs

* Fix: Change parallel settings to defaults, remove buffer

'buffer' is not a documented parameter, removing it.
Removing some configuration settings as the defaults are higher and
should adapt better to the target machine
2024-03-11 14:04:02 +01:00