Commit Graph

608 Commits

Author SHA1 Message Date
Laurent Destailleur
3ecfc1b55f Fix css 2023-12-02 20:27:09 +01:00
Frédéric FRANCE
53c8a3acf8 clean phpdoc for phpstan (#26905) 2023-12-01 19:51:32 +01:00
Laurent Destailleur
1d589fd74e Fix warnings 2023-11-27 13:26:44 +01:00
Laurent Destailleur
e8dc651877 Fix php8.2 warnings 2023-11-27 11:56:32 +01:00
moreauftheobald
1e36013e34 fix phpstan reception class (#26729)
* fix PHP STAN error on MO class

* fix PHP STAN error on MO class

* Update mo.class.php

---------

Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
2023-11-18 23:25:16 +01:00
Laurent Destailleur
e57517d06d Clean code 2023-11-17 11:19:51 +01:00
moreauftheobald
e3ed9946c3 Correction On reception class files "Access to an undefined property" (#26661) 2023-11-17 10:58:25 +01:00
Laurent Destailleur
d9df238ac4 Clean code and prepare database for reception from any source 2023-11-14 17:33:50 +01:00
Laurent Destailleur
74e1ec4099 FIX On object validation, ecm index are not updated for uploaded files 2023-10-31 19:28:11 +01:00
Laurent Destailleur
ca3c7f0a37 Merge branch 'develop' of git@github.com:Dolibarr/dolibarr.git into
develop
2023-10-26 13:52:22 +02:00
Laurent Destailleur
35906c0af6 Fix bad test 2023-10-26 12:43:29 +02:00
thomas-Ngr
00a936bffa fix #18654 : orders are partially received even if all products have been received (#26358) 2023-10-26 12:42:07 +02:00
Alexandre Janniaux
9fe9eee18a FIX|Fix some minor issues on Reception and add a new test for it (#26310)
* reception: reOpen: mirror $this->statut in $this->status

$this->statut is the deprecated variable, $this->status should also get
the correct value.

* reception: setDraft: mirror $this->statut in $this->status

$this->statut is the deprecated variable, $this->status should also get
the correct value.

* reception: add missing $weight field

Fix warning:

    Undefined property: Reception::$weight

* societe: add country_id field

* reception: use getDolGlobalInt when suitable

Using empty() implies that the value actually exists on the stdClass at
$conf->global, but it's not always the case. getDolGlobalInt will handle
this smoothly by checking first, which solves warnings like those:

    Undefined property: stdClass::$STOCK_CALCULATE_ON_RECEPTION

* ReceptionTest: add new test

The test checks the usual workflow of the Reception class, with, on the
one hand, the common CRUD operations:
 - create
 - fetch
 - update
 - delete

And on the other hand, the status handling for Reception:
 - valid: STATUS_DRAFT -> STATUS_VALID
 - setClosed: STATUS_VALID -> STATUS_CLOSED
 - reOpen: STATUS_CLOSED -> STATUS_VALID
 - setDraft: STATUS_VALID -> STATUS_DRAFT

The stocks lines are not tested yet, and the error cases, like any other
transition not described above, are not tested either. The permissions
for some of the operations are hardcoded for the test and there is no
failure check when the permission is not set yet.
2023-10-21 16:28:30 +02:00
Laurent Destailleur
e1bf377f20 QUAL: Removed deprecated field remise, remise_percent, remise_absolute 2023-10-20 10:47:08 +02:00
Laurent Destailleur
c49a044490 Clean code 2023-10-20 02:35:18 +02:00
Laurent Destailleur
c61e9f47c8 Fix reception 2023-10-18 03:44:07 +02:00
Laurent Destailleur
ec3cc1c376 css 2023-10-18 03:39:22 +02:00
Laurent Destailleur
266b7ac61b Clean code (standardize reception with shipment) 2023-10-14 15:25:52 +02:00
Laurent Destailleur
c32fe8dc5f QUAL: Use dol_clone with parameter 2 for ->oldcopy 2023-10-11 19:10:24 +02:00
Laurent Destailleur
df454003da FIX php8.2 2023-10-09 15:44:57 +02:00
Laurent Destailleur
d3dc6615db Remove deprecated use of ->modelpdf (good is ->model_pdf) 2023-10-02 21:49:08 +02:00
Laurent Destailleur
f5bf4a6ec4 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-09-30 11:54:12 +02:00
Francis Appels
ae3112a828 HAR-132 Fix double closing Reception when classified billed. 2023-09-28 15:41:23 +02:00
Laurent Destailleur
b9336c024a Merge pull request #25566 from hansemschnokeloch/rest-extra
Add filter to restrict the data returned
2023-09-27 00:56:51 +02:00
Laurent Destailleur
cc0a07d433 Better cyclomatic complexity 2023-09-27 00:42:54 +02:00
pascal
80f060c771 fix tab indentation 2023-09-26 18:43:25 +02:00
pascal
871f896962 implementation of properties filter 2023-09-26 18:04:48 +02:00
Laurent Destailleur
0c3e516e57 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-09-13 03:08:46 +02:00
Laurent Destailleur
ec8c2a7d62 Debug dispatch tab 2023-09-13 03:01:18 +02:00
Laurent Destailleur
e31cdbe297 Fix dispatch tab on reception (no way to change batch number once set) 2023-09-12 19:47:45 +02:00
Laurent Destailleur
924da777bf Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-09-04 23:26:35 +02:00
Laurent Destailleur
55d93b3126 Fix help messages 2023-09-03 22:45:47 +02:00
Laurent Destailleur
b6b1d8acbc Fix error message 2023-09-03 22:34:14 +02:00
Laurent Destailleur
4cb97704cc Fix look and feel on shipment/reception 2023-09-03 22:12:34 +02:00
Laurent Destailleur
3343a47244 NEW billing on shipment+reception. Can be done before or after delivery. 2023-09-03 21:38:11 +02:00
Frédéric FRANCE
eaf63b60c5 phpstan 2023-09-01 14:54:35 +02:00
Laurent Destailleur
552a079379 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-08-27 16:05:46 +02:00
Laurent Destailleur
45d323a6f8 Merge branch '17.0' of git@github.com:Dolibarr/dolibarr.git into 18.0 2023-08-27 16:02:57 +02:00
Laurent Destailleur
cd960d30df Merge branch '16.0' of git@github.com:Dolibarr/dolibarr.git into 17.0 2023-08-27 16:01:05 +02:00
Laurent Destailleur
5c03db3b05 Merge branch '15.0' of git@github.com:Dolibarr/dolibarr.git into 16.0 2023-08-27 15:58:48 +02:00
Laurent Destailleur
3b6b9661fa Merge branch '14.0' of git@github.com:Dolibarr/dolibarr.git into 15.0 2023-08-27 15:57:45 +02:00
Frédéric FRANCE
a142d48d26 phpstan 2023-08-27 09:19:58 +02:00
Laurent Destailleur
bf1549e6e0 Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-08-24 00:14:55 +02:00
VESSILLER
ebed2211b6 FIX reception odt dir output path 2023-08-23 11:24:09 +02:00
Francis Appels
71e145d852 Merge remote-tracking branch 'Dolibarr/18.0' into 18_fix_mass_bill_reception 2023-08-22 10:18:44 +02:00
Francis Appels
c06282358c Fix validate supplier invoice should also set closed reception billed. Related to #25530 2023-08-22 10:16:12 +02:00
Laurent Destailleur
e4eafcc52e Merge branch '18.0' of git@github.com:Dolibarr/dolibarr.git into develop 2023-08-11 18:31:27 +02:00
Frédéric FRANCE
10abaf9dd1 add missing error info 2023-08-11 14:05:20 +02:00
Laurent Destailleur
f21c168a84 Removed $brouillon property 2023-08-06 01:16:12 +02:00
Laurent Destailleur
0076ec69b8 The property ->brouillon has been removed from all classes. It was not
reliable and was a duplicate of ->status == self::STATUS_DRAFT.
2023-08-06 00:16:25 +02:00