* CSS
* CSS
* Fix phpunit
* More legal info
* CI
* Fix CI
* Fix: IRPF tax not applied when creating invoice from project times (#37077)
* Remove 'supplier_invoice' from old path array
* Update module path in arrayforoldpath
Sorry Eldy, I was confused. You are absolutely right, it is already corrected.
* Replace localtax2 assignment with get_localtax function
Error when creating an invoice with personal income tax from project times. The rate does not apply
* Refactor localtax1 calculation using get_localtax
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix: IRPF tax not applied when creating invoice from project times (#37077)
* Remove 'supplier_invoice' from old path array
* Update module path in arrayforoldpath
Sorry Eldy, I was confused. You are absolutely right, it is already corrected.
* Replace localtax2 assignment with get_localtax function
Error when creating an invoice with personal income tax from project times. The rate does not apply
* Refactor localtax1 calculation using get_localtax
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Protect module
* Add currency
* CSS
* WIP LNE
* Fix navigation
* cs
* Debug registration process
* Debug setup navigation
* CI
* CI
* Factorize code
* Fix CI
* Fix CI
* Fix CI
* CI
* CI
* CI
* CI
* Disable phan on v23
* CI
* CI
* FIX: missing include for blockedlog lib (#37165)
* Debug CI
* fix ternary always true (#37161)
* fix ternary always true
* Update requests.php
* Update registration.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* CI
* FIX: missing include for blockedlog lib (#37165)
* FIX#37134 Use json_encode for IMAP search logging in EmailCollector (#37135)
var_export() produces multiline output that breaks log aggregators
(Loki, Splunk, Elasticsearch) as each line becomes a separate log entry.
Using json_encode() produces single-line structured output that works
correctly with all log aggregation tools.
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Populate syslog with placeholder (#37163)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Doc
* datamodel for user change password next time (#37155)
* Qual: Update phan baseline (#37172)
* Fix typo in file path (#37160)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix phpunit
* Complete call to setStatus so we have a trigy as 4th parameter (help to
fix the #37129)
* FIX Product - Warning on admin (#37157)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* FIX Product - Warning on admin + CSS (#37158)
* FIX Product - Warning on admin
* CSS
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* CI
* CI
* CI
* Avoid error if include fails
* More functions in blacklist (even if nw we use the whitelist by default)
* #37166 [SQL] add: email template for ticket admin creation (#37182)
* Replace var_export with new function formatLogObject (#37178)
* FIX BOM - Class product missing, column offset and information recording (form/input overlap) in admin (#37177)
* FIX BOM - Class product missing in admin
* Fix column offset and information recording (form/input overlap)
* ci
* ci
* FIX Intracommreport - Warning & link problem on tab (#37176)
* FIX Bank transfer admin - Warning & save 0 on constant PAYMENTBYBANKTRANSFER_ADDDAYS (#37175)
* Look and feel v24
* Update default time handling in index.php (#37150)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix file path comment in supplier invoice module (#37133)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix file path comment in supplier invoice module (#37133)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix CI
* Add template in migration
* fix phpdoc comment (#37184)
* fix phpdoc comment
* fix phpdoc comment
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* CI
* Fix phpstan
* Replace var_export by formatLogObject (continued) (#37188)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Debug amount suggested on membership public form
* Issue 36923 Fix session title handling in survey creation (#37105)
* Issue 36923 Fix session title handling in survey creation
* Change input field to use id attribute for title
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* fix phpstan errors blocking action baseline (#37189)
* fix phpstan errors blocking action baseline
* fix phpstan errors blocking action baseline
* fix phpstan errors blocking action baseline
* fix phpstan errors blocking action baseline
* fix phpstan errors blocking action baseline
* refresh baseline
* QUAL Replace var_export() with json_encode() in dol_syslog() calls (#37138)
var_export() produces multiline output that breaks log aggregators
(Loki, Splunk, Elasticsearch, Graylog) as each line becomes a separate
log entry.
json_encode() produces single-line structured output that works correctly
with all log aggregation tools. This pattern is already used elsewhere
in Dolibarr (accountancy, install modules).
Files changed:
- core/class/commoninvoice.class.php (payment intent logging)
- core/class/commonobject.class.php (payment terms logging)
- core/modules/mailings/advthirdparties.modules.php (mailing targets)
- core/modules/oauth/google_oauthcallback.php (userinfo logging)
- core/modules/oauth/generic_oauthcallback.php (userinfo logging)
- public/payment/newpayment.php (GET/POST debug logging)
- public/payment/paymentok.php (payment tag logging)
- public/stripe/ipn.php (Stripe event data logging)
- paypal/lib/paypal.lib.php (PayPal response logging)
- api/index.php (API debug logging)
- stripe/class/stripe.class.php (payment/setup intent logging)
Co-authored-by: f-hoedl <hoefla14@htl-kaindorf.ac.at>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix CI
* CI
* Check if upload_max_filesize is not empty
* clean code
* Debug v23
* CI
* Fix#33521 VAT total false (#36990)
* - Fix#33521 VAT total false
- Fix some warnings
- Fix : delete $this->vat_rate
* - Fix#33521 VAT total false
- Fix some warnings
- Fix :delete $this->tva array (replaced by $this->tva_array)
* - Fix#33521 VAT total false
- Fix some warnings
- Fix :delete $this->tva array (replaced by $this->tva_array)
* Update pdf_octopus.modules.php
* Update pdf_octopus.modules.php
* Update pdf_octopus.modules.php
* Update pdf_octopus.modules.php
* Update pdf_octopus.modules.php
---------
Co-authored-by: vmaury <vmaury@vmaury-Lafite-Pro-16-AMD>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* NEW #25829 Automatically send the invoice generated from a template (#36967)
* Update DB
* ADD email template
* Ajout d'une clé de trad
* Ajout des traductions
* Suppression des traductions, sauf en_US
* Add flag auto send
* Modif form + cron auto send
* Suppression auto_send
* correction loopError
* ajout du selected au model de mail
* Prise en compte default model
* Fix pre-commit
* ménage
* precommit
* Correction Phan
* Correction Phan
* Correction, double cal du trigger
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Develop force user change pass userclass (#37174)
* datamodel for user change password next time
* add force_pass_change in user object
* Initialize force_pass_change to 0
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Another step for #37171
* Qual: Partial phan run on PR's, complete run on integration branches (#37186)
* Qual: Partial phan run on PR's, complete on main
# Qual: Partial phan run on PR's, complete on main
The selection is based on the branch name.
To run a complete phan run in a PR, the branch name of the PR must include phan_full.
This can help to fix remaining phan issue before re-integrating to the develop branch.
* qual: Update workflow and pre-commit configurations
- Enable phan workflow by uncommenting the relevant lines
- Update actionlint version to v1.7.10
- Add manual stage to actionlint hook in pre-commit-config.yaml
* qual: Update Phan analysis conditions
The conditions for running Phan analysis have been updated to include an additional check for branches containing 'phan_full'.
* qual: Update Phan workflow
- Replace github.event.ref with github.ref_name
- Add FILE_CHANGE_LIST environment variable for better file handling
- Update file list creation and usage in the workflow
* qual: Update Phan workflow conditions
Fix the branch reference (head_ref in PR, ref_name otherwise)
* Add step for debug information
* Remove debug step
* Fix: Missing initialisations members/new.php
Following a suppression of assignments, the variables disabledphy and disabledmor were undefined.
* fix: Update budget selection dropdown arguments in member creation form
Correct the arguments in the member creation form.
* qual: Add cs2pr to phan workflow
- Add cs2pr to the tools list in the phan workflow
- Change the output mode of phan to checkstyle
- Add a step to add results to PR as Github notices
- Add a step to provide phan log as artifact
* qual: Update Phan workflow to use environment variable for file list
The change fixes the Phan workflow to use the environment variable `$FILE_CHANGED_LIST` to clear the file
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix phan
* Fix phan
* Merge branch '23.0' of git@github.com:Dolibarr/dolibarr.git into 23.0
* Doc
* Qual: Fix ambigious redirect error on Phan workflow (#37200)
# Qual: Fix ambigious redirect error on Phan workflow
Rewrote the shell command that is supposed to suppress a file contents
but is flagged by the environment.
* PHPStan > Update baseline (#37197)
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
* Typo fix (#37195)
* Debug v23 - filters on agenda pages
* css
* css
* css
* qual: Update PHPStan workflow to run on all files in integration (#37207)
The PHPStan workflow has been updated to run on all files in integration branches.
* Fix CI
* Add hook in isEditable()
* Debug v23
* CLOSE#37190 ODT Templates for thirdparties - Birthday is returned in epoch format (#37198)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* fix: Remove HTML from accounting menu tooltips in eldy theme (#37203)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Qual: Update spelling (#37199)
* Qual: Update spelling for pre-select variants
# Qual: Update spelling for pre-select variants
In English, preselect is without the hyphen. Update text and made some translations
related to preselect.
* Qual: Update composant to component and/or adequate translation.
# Qual: Update composant to component and/or adequate translation.
"Composant(s)" was mostly referenced in french file/class comments.
Updated
* Qual: Fix misspellings related to "criteria"
# Qual: Fix misspellings related to "criteria"
* Qual: Fix produt misspellings
# Qual: Fix produt misspellings
Change 'produt' to 'product'.
* Qual: Update French comments with "composants"
#Qual: Update French comments with "composants"
- Translating French comments to English (avoid codespell notice)
* Qual: Fixed typo 'bad practive' to 'bad practice'
# Qual: Fixed typo 'bad practive' to 'bad practice'
* Qual: Update phan.yml to exclude specific files from analysis
- Added file exclusion pattern to match phan configuration
- Added check for empty file list to avoid unnecessary phan execution
* Qual: Update file filtering in phan.yml workflow
The change updates the file filtering process in the phan.yml workflow to correctly redirect the output of the grep command to a temporary file.
* Qual: Ignore $systemfunction always exists
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Error handling methods for commonobject (#37201)
* Error handling methods for commonobject (#37201)
* NEW Can request and force user to change its password (#37196)
* force user to change password : redirect to user card on login
* force user to change password : redirect to user card on login
* redirect to a dedicated page
* bad old idea : self change passwd on user card + edit mode and rights: it makes a hole on security check
* only apply on dolibarr auth mode context
* only on dolibarr auth mode context
* Fix force_pass_change SQL assignment logic
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Doc
* Setup easier to understand between INVOICE_CHECK_POSTERIOR_DATE and
FAC_FORCE_DATE_VALIDATION
* Setup easier to understand between INVOICE_CHECK_POSTERIOR_DATE and
FAC_FORCE_DATE_VALIDATION
* Prepare 23.0
* Qual: Ignore exit code from `grep -v` in phan flow (#37213)
# Qual: Ignore exit code from `grep -v` in phan flow
`grep -v` returns 1 when the resulting filtered list is empty and would stop the execution.
This is fixed with `|| true` to have a final exit code that is 0.
* WIP LNE
* Debug v23
* Debug v23
* WIP LNE
* FIX Bad header name
* Fix CSP for ping
* Compatibility with multicompany
* Debug
* Fix include
* FIX phpdoc on createFixedAmountDiscount() (#37212)
* FIX phpdoc on createFixedAmountDiscount
* FIX phpdoc
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix in card css modal display (#36569)
* Fix display of cards in a modal
* fix php stan
* fix php stan
* Try a change to force CI
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* NEW Accountancy - Multi reports system
* Button style
* CI
* CI
* CI
* CI
* CI
* CI
* CI
* More complete data on pings.
* Debug v23
* Debug initdemo
* Debug initdemo
* Debug initdemo
* Debug v23
* Update initdemo
* Update initdemo
* Cleaner GET call
* Add id of perm in url
* Init demo for v24
* Fix translation of "various payment" (not english, not pro) with the
term used in english to mean "Opérations diverses (OD)"
* Sync transifex
* CSS
* Trans
* Doc
* Trans
* Debug v23
* Debug v23
* Trans
* Debug v24
* Debug v23
* Debug v23
* WIP
* Debug v23
* Debug v23
* Debug v24
* Work on LNE
* WIP LNE
* Debug v24
* Doc
* Translation
* Sync transifex
* Debug
* Debug
* Debug
* Responsive
* Dev control archive integrity
* Debug
* Update supplier_proposal.lang (#37238)
* add company name on dropdown contract list (#37245)
* Clean dump file
* Fix CI
* FIX#37246 Modifying resteapayer calculation for credit note (#37247)
* Add 'type' parameter to completeTabsHead hook (#37235)
* #37257 FIX for piesemicircle (#37258)
* Fix#37227Fix#37233
* Fix#37227Fix#37233
* QUAL French comment in English (#37225)
* Edit label of $fields
* QUAL French comment in English
* Bump actions/upload-artifact from 4 to 6 (#37250)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v4...v6)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: '6'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* UI/UX : Transfert feedback css from experimental to core (#37226)
* Transfert feedback css from experimental to core
* fix php phan
* Fix phan
* Fix phan
* Fix phan
* Missing label
* Debug
* Add method to chech if invoice can be replaced
* Fix return
* Debug v24
* Fix CI
* fix commoninvoice.class.php (#37267)
* fix commoninvoice.class.php
* Update commoninvoice.class.php
* CI
* CI
* Debug v23
* CI
* Fix CI
* Debug v23
* clean code pdf.lib.php (#37265)
* clean code pdf.lib.php
* Update pdf.lib.php
* Update pdf.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* FixCI
* FIX: linktoref should be able to receive more than 255 chars (#37262)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: Yamil Esteban Garcia <120027058+developmentOYR@users.noreply.github.com>
Co-authored-by: Noé Cendrier <81741011+altairis-noe@users.noreply.github.com>
Co-authored-by: Frédéric FRANCE <frederic34@users.noreply.github.com>
Co-authored-by: minimexat <minimexat@gmail.com>
Co-authored-by: hansemschnokeloch <hansemschnokeloch@users.noreply.github.com>
Co-authored-by: Eric - CAP-REL <1468823+rycks@users.noreply.github.com>
Co-authored-by: MDW <mdeweerd@users.noreply.github.com>
Co-authored-by: evarisk-kilyan <kilyan.evarisk@gmail.com>
Co-authored-by: Vanyo <vanyolai@gmail.com>
Co-authored-by: jeremydassaud <49372108+jeremydassaud@users.noreply.github.com>
Co-authored-by: f-hoedl <hoefla14@htl-kaindorf.ac.at>
Co-authored-by: Vincent Maury <artec.vm@arnac.net>
Co-authored-by: vmaury <vmaury@vmaury-Lafite-Pro-16-AMD>
Co-authored-by: Vincent Penel <vincent.penel@atm-consulting.fr>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dolibot <dolibarr-bot@users.noreply.github.com>
Co-authored-by: Joris Le Blansch <jleblansch@gmail.com>
Co-authored-by: intelliking <tyleradams93226@gmail.com>
Co-authored-by: Benjamin Falière <121813548+BenjaminFlr@users.noreply.github.com>
Co-authored-by: John BOTELLA <68917336+thersane-john@users.noreply.github.com>
Co-authored-by: Charlène Benke <1179011+defrance@users.noreply.github.com>
Co-authored-by: demiton <fabien.cisse@gmail.com>
Co-authored-by: Jyhere <jyhere@gmail.com>
Co-authored-by: Delthair <41671350+Delthair@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* New options for withdraw control
Add a new option "WITHDRAW_STRICT_CHECK_AMOUNT"
Transfer request control is based solely on the supplier invoice amount:
By default, once a request is made, even if its amount is less than the invoice amount, no additional requests can be made until the original request is validated (integrated into a transfer slip).
With this option, the control is applied to the sum of all requests, even if they are not integrated into a SEPA transfer slip.
The control verifies that the total sum of the requests never exceeds the invoice total.
By default, one or more requests exceeding the invoice amount can be entered; this option prevents this behavior.
This behavior is more logical and user-friendly, especially when transfer requests are made by technicians or buyers and the SEPA files are created by the accounting department.
* fix
* Update commoninvoice.class.php
* fichier lang
* Cast remaining amounts to float for precision
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* backport de la liste des ressources v23
* fix oauth api conexion
* fix oauth api conexion
* fix oauth api conexion
* Fix CI
* fix: in some case on create invoice when create PDF the lang is not correcly defined because ->thirdparty is not set (#37287)
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* add microsoft exchange oauth
* add microsoft exchange oauth
* add microsoft exchange oauth
* add microsoft exchange oauth
* add microsoft exchange oauth
* Revert unintended changes to resource list
* Tidy OAuth logging and consent prompt
* Fix PHPCS blank line warnings
---------
Co-authored-by: ATM-Lucas <lucas.mantegari@atm-consulting.fr>
Co-authored-by: VIAL-GOUTEYRON Quentin <quentin.vial-gouteyron@atm-consulting.fr>
Co-authored-by: Laurent Destailleur <eldy@users.sourceforge.net>
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Fix: key is never 'PAYMENT_CUSTOMER_CREATE'
* Fix: Update include path and formatting
- Update include path for versionmod.inc.php
- Apply code formatting
* Qual: Ignore phpstan notice
# Qual: Ignore phpstan notice
- Country code is already FR, but test can be useful in the future, so ignoring the notice.
- Code formatting
* Qual: Try exact match to suppress phpstan notice
# Qual: Try exact match to suppress phpstan notice
* Debug savedemo
* Fix mention
* FIX upload of files with multiple spaces via drag'n'drop flow
Currently there are two ways to upload files to products, orders, etc. via the "old" way and the document tab and the "new" flow via drag'n'drop on the main tab of the object.
Both ways triggering completely different code paths. In the end the new way uses dol_sanitzieFileName to sanitize the name of the file and the old way uses dol_string_nohtmltag (both from functions.lib.php).
One of the main difference between the two mentioned functions is that in the old way multiple spaces behind each other are replaced by a single space. E.g. "A␠␠B␠␠␠C␠␠D" is tranformed to "A␠B␠C␠D".
This is needed to make sure that the files are properly uploaded and can be later also downloaded correctly.
How to reproduce?
Upload a file like "test␠␠test.txt" via the drag'n'drop flow and try to download it from the document tab. This is not working. You can see the file but cannot download it. The same flow via the input field of the document tab is working correctly.
* typo in comment
* FIX Phan warnings (unrelated to feature)
* FIX Phan warnings (unrelated to feature)
* FIX Phan warnings (unrelated to feature)
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* fix: use ob_end_clean() instead of ob_end_flush() in readfileLowMemory() (fixes#37239)
* fix: use robust ob level cleanup loop per hregis review
---------
Co-authored-by: f-hoedl <hoefla14@htl-kaindorf.ac.at>
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* Clean filenames with double spaces
If a filename contains double spaces, it can get uploaded in Dolibarr exactly as it is.
When listing the file or trying to download it, the dolibarr functions clear double spaces in the filename. In particular the alpha parameter for GETPOST.
This results in files being uploaded (e.g. attachments for invoices) than can get listed but remain inaccessible and even cannot get deleted via UI.
We either need to fix all these places to accept double spaces or we change a single location, when we sanitize filenames.
* removed white space
* Add missing CSRF tokens in bank left menu links
* clean QUAL
* Update eldy.lib.php
---------
Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
* FIX#37147 Limit account fetch to active chart of accounts in PDF exports
When multiple chart of accounts have the same account number, the PDF
exports (balance and ledger) could retrieve the wrong account label.
* FIX#37147 Decode HTML entities in balance PDF account group labels
The balance PDF export was displaying HTML entities (like &EACUTE;) instead
of properly decoded characters (like É) in account group labels.
