Commit Graph

103 Commits

Author SHA1 Message Date
Laurent Destailleur
8971c8efac Exclude phan rule 2024-06-03 21:30:25 +02:00
Laurent Destailleur
82908a30eb Clean phan warnings 2024-05-30 13:37:17 +02:00
Laurent Destailleur
4b5b4c4e1a Clean some expected warnings 2024-05-13 12:49:14 +02:00
Laurent Destailleur
d523cb24e6 Disable useless phan warnings 2024-05-10 11:48:27 +02:00
Laurent Destailleur
2de1287afd Make CTI less paranoiac to avoid alert at any code change 2024-04-27 00:47:45 +02:00
Laurent Destailleur
ca65e9a333 QUAL the config_extended of phpstan will be kept on apstats only for the
moment: Too many CTI error not related to PR.
2024-04-24 21:44:58 +02:00
Laurent Destailleur
a669c3d3fa Disable PhanUndeclaredGlobalVariable 2024-04-24 20:56:41 +02:00
Laurent Destailleur
85b4077d0d Clean code 2024-04-24 20:35:36 +02:00
MDW
bbde552979 Qual: Enable Phan Rules and update baseline (#29255)
* Fix script generating trailing whitespace

* Add nusoap as a stub for better analysis

* Qual: Return type for fetch_name_optionals_label to fix phan message

* Qual: Enable Phan Rules and update baseline

# Qual: Enable Phan Rules and update baseline

This enables all of the rules that are currently also
enabled for cti, but sets the baseline to ignore the
exceptions already present.
This will help detect exceptions added by code modifications
if the rule is not ignored for the given file.
2024-04-07 11:55:39 +02:00
MDW
6e5841b13d Add checks on checkVal, price2num and GETPOSTFLOAT arguments 2024-03-27 10:18:41 +01:00
MDW
a703ea1092 Add checks on dol_(mktime|now|print_date) + avoid duplicate phan conf 2024-03-27 10:18:39 +01:00
Laurent Destailleur
c43bb3d52c Update config.php 2024-03-24 16:37:21 +01:00
MDW
a1ae115757 Set cache_codes global type 2024-03-24 15:40:25 +01:00
MDW
34416d9723 Qual: Enable PhanNonClassMethodCall 2024-03-24 15:06:59 +01:00
MDW
02960415cb Fix global typing of menumanager as MenuManager 2024-03-24 11:03:22 +01:00
MDW
79a8533f53 Qual: Enable PhanTypeInvalidPropertyName 2024-03-24 11:03:02 +01:00
MDW
2a13f7134c Qual: Add extra phan stubs fixing PhanUndeclaredClassMethod 2024-03-23 14:29:54 +01:00
MDW
30b7ae336f Qual: Enable dev/tools/phan/config.php 2024-03-23 13:14:35 +01:00
MDW
09b931e8fc Qual: Enable PhanUndeclaredClassProperty 2024-03-23 03:19:04 +01:00
MDW
27091da3f3 Qual: Enable lidLeftOperandOfNumericOp 2024-03-23 02:06:57 +01:00
MDW
5c073dfb6e Qual: Enable PhanTypeInvalidRightOperandOfAdd 2024-03-22 09:52:42 +01:00
MDW
b8c16af0a3 Qual: Enable PhanTypeInvalidLeftOperandOfAdd 2024-03-22 09:51:38 +01:00
MDW
3908b4df9d Qual: Enable PhanTypeInvalidLeftOperandOfBitwiseOp (all fixed) 2024-03-21 13:44:54 +01:00
MDW
a69dcc9c5a Qual: Enable PhanTypeMismatchArgumentSuperType 2024-03-20 04:09:19 +01:00
MDW
390d164f82 Qual: Ignore PhanTypeMismatchArgumentNullableInternal 2024-03-20 04:09:18 +01:00
MDW
6413341c96 Qual: Enable PhanTypeMismatchArgumentInternal 2024-03-20 04:09:17 +01:00
MDW
cd3ea72f96 Qual: Disable global variable suggestion for $website 2024-03-19 02:44:07 +01:00
MDW
3c968477cb Change type of global $website to string 2024-03-19 02:44:04 +01:00
MDW
921431dbdc Qual: Enable PhanTypeSuspiciousStringExpression 2024-03-19 02:44:03 +01:00
Laurent Destailleur
29a858aa68 Merge pull request #28924 from mdeweerd/fix/whitespace
Fix trailing whitespace + format code + minor spelling + enable checks
2024-03-19 02:14:13 +01:00
MDW
d2568a0878 Qual: Enable PhanUndeclaredVariableAssignOp 2024-03-18 13:12:53 +01:00
MDW
686facd74d Fix PhanPluginWhitespaceTrailing + format code + minor spelling 2024-03-17 21:35:08 +01:00
MDW
aa6c20bf0d Qual: Enable PhanPluginWhitespaceTrailing 2024-03-17 21:35:07 +01:00
Laurent Destailleur
bb0e18deae Merge pull request #28922 from mdeweerd/fix/printf
Fix & enable Phan printf checks
2024-03-17 21:08:26 +01:00
MDW
7a4f5ec4f8 Qual: Enable some low occurence notifications 2024-03-17 20:12:27 +01:00
MDW
aa5aa2bf26 Add one more index to the theme_datacolor 2024-03-17 19:49:10 +01:00
MDW
d73886281c Qual: Set typing for global 2024-03-17 18:56:44 +01:00
MDW
81d5f30466 Qual: Enable PhanPluginPrintfIncompatibleArgumentType 2024-03-17 18:56:43 +01:00
MDW
4232713e96 Qual: enable PhanPluginPrintfVariableFormatString 2024-03-17 18:21:35 +01:00
Laurent Destailleur
91c5868020 Merge pull request #28909 from mdeweerd/fix/PhanPluginUnknownClosureReturnType
Fix & enable PhanPluginUnknownClosureReturnType
2024-03-17 03:03:35 +01:00
MDW
551eaa115c Fix & enable PhanPluginUnknownClosureReturnType
# Fix & enable PhanPluginUnknownClosureReturnType

Fix last PhanPluginUnknownClosureReturnType & enable the notice as
all are fixed
2024-03-17 00:10:18 +01:00
MDW
ef6eea3ed2 Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname
# Qual: Fix PhanTypeExpectedObjectOrClassName by testing on classname

PhanTypeExpectedObjectOrClassName should be fixed by testing that the classname is not
empty.
2024-03-17 00:03:20 +01:00
Laurent Destailleur
75fae0f27d Merge branch 'develop' into fix/PhanTypeMismatchReturn 2024-03-16 16:08:08 +01:00
MDW
725e419a46 Qual: Enable PhanTypeMismatchReturn 2024-03-16 13:52:19 +01:00
MDW
7b53202f74 Qual: Enable detection of use of DeprecatedFunctions 2024-03-16 13:27:52 +01:00
Laurent Destailleur
a247b474d7 Merge pull request #28885 from mdeweerd/fix/phan/low_occurrence
Fix some phan notifications with low occurrence
2024-03-16 11:48:10 +01:00
MDW
8a83388905 Qual: Enable several phan notifications 2024-03-16 00:00:25 +01:00
MDW
375e4d7ccf Qual: Enable PhanTypeMismatchArgumentInternalReal 2024-03-15 23:41:17 +01:00
Laurent Destailleur
372c8445fd Merge pull request #28809 from mdeweerd/PhanPluginPrintfIncompatibleArgumentTypeWeak
Fix & enable PhanPluginPrintfIncompatibleArgumentTypeWeak occurrences
2024-03-15 16:32:40 +01:00
Laurent Destailleur
0ee6fd6bad Merge pull request #28877 from mdeweerd/PhanTypeMismatchDefault
Fix & enable PhanTypeMismatchDefault
2024-03-15 15:44:30 +01:00